Hello, There are several articles will be helpful both to reviewers and code contributors: [1],[2],[3]
[1]: http://docs.openstack.org/infra/manual/developers.html#code-review [2]: http://docs.openstack.org/infra/manual/developers.html#peer-review [3]: https://krotscheck.net/2015/07/13/code-review-in-openstack.html I think this point is quite important for reviewer: Be explicit: If you ask for a change, specify where that change needs to be made, how it needs to be made, and why it needs to be made. Provide a code example if possible. Best Regards Chaoyi Huang ( Joe Huang ) -----Original Message----- From: Shinobu Kinjo [mailto:[email protected]] Sent: Friday, June 03, 2016 7:28 PM To: OpenStack Development Mailing List (not for usage questions) Subject: [openstack-dev] [tricircle] reviewed by multiple eyes Hi Team, There are some patch sets reviewed by only myself. >From my point of view, any patch set needs to be reviewed by multiple eyes. It's because anyone is not perfect. And there should be anything missing. Please take a look, if you get notification to review. Cheers, Shinobu -- Email: [email protected] [email protected] __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
