Hi Devon, Devon Mizelle <[email protected]> writes:
> Greetings, > > I was directed here from #puppet-openstack to submit an e-mail. Well, the best way to have it done, would be to make bug in launchap[1] If you don't have the an account or the time time let me know I will do it for you, np. The patch shouldn't be a problem, but the diff here misses some bits :) Thanks, [1] https://bugs.launchpad.net/puppet-pacemaker/+bugs > Noted here, there is an 'action' parameter defined for fence_ifmib: > > https://github.com/openstack/puppet-pacemaker/blob/f62805f678f6fd8a260118279f6e0dbb05bff3d1/agent_generator/src_xml/fence_ifmib.xml#L83 > > However, in the generated manifest here, it seems that the 'action' > parameter is missing: > > https://github.com/openstack/puppet-pacemaker/blob/f62805f678f6fd8a260118279f6e0dbb05bff3d1/manifests/stonith/fence_ifmib.pp > > It looks like the 'action' parameter is missing in every fence_* > manifest (and has never existed.) I need this available to me so that > I can override the default action of fence_ifmib (which is 'reboot') > and set it to 'off'. > > It looks like that in the agent_generator.rb script, action is being > specifically ignored in addition to 'help' and 'version' parameters. > I've attached a quick plain-text patch. I don't think this is the > norm, but considering that its such a small one word change I'm hoping > it would be OK. > > Thanks for your time and for a wonderful project, > Devon > > diff --git a/agent_generator/agent_generator.rb > b/agent_generator/agent_generator.rb > index 9c1ab0a..171ca50 100755 > --- a/agent_generator/agent_generator.rb > +++ b/agent_generator/agent_generator.rb > @@ -40,7 +40,7 @@ class FencingMetadataParser > param['default'] = REXML::XPath.match(p, > 'string(./content/@default)')[0] > param['description'] = REXML::XPath.match(p, 'string(./shortdesc)')[0] > ## remove parameters that are not usable during automatic execution > - @params.push(param) unless %w(help version > action).include?(param['name']) > + @params.push(param) unless %w(help version).include?(param['name']) > } > @params > end > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: [email protected]?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Sofer Athlan-Guyot __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
