I empathize with you Erno. I think this is a case of sheer mis-understanding and probably (I think) the mention of that instance / situation in this email is only for referential purposes.
There are some critical deadlines one sub-set of people have to met and there are other priorities other sub-set have. Co-ordination across continents and low bandwidth conversations that do not necessarily communicate the /intent/ every time results into such situations. Let's /all/ move on and not regress on it. We do need improvement in the process for /sure/ and I've already communicated my intentions with rosmaita about them. You can expect something later next week as time permits. On 9/23/16 12:30 PM, Erno Kuvaja wrote: > On Fri, Sep 23, 2016 at 3:42 PM, Ian Cordasco <[email protected]> wrote: >> Hi all, >> >> A few weeks ago, there was a controversy in which a patch had been >> -2'd until other concerns were resolved and then the core who used >> their -2 powers disappeared and could not lift it after those concerns >> had been resolved. This lead to a situation where the -2'd patch was >> abandoned and then resubmitted with a new Change-Id so it could be >> approved in time for a milestone. >> >> In chatting with some folks, it's become apparent that all of us >> Glance cores need to keep a dashboard around of items that we've -2'd. >> >> The basic form of that is: >> >> https://review.openstack.org/#/q/reviewer:self+AND+label:code-review-2+AND+(project:openstack/glance+OR+project:openstack/glance_store+OR+project:openstack/python-glanceclient) >> >> Or the query in particular is: >> >> reviewer:self AND label:code-review-2 AND >> (project:openstack/glance OR project:openstack/glance_store OR >> project:openstack/python-glanceclient) >> >> That said, this will show any patch you have reviewed that has a -2 on >> it. (This also ignores specs.) >> >> To find what *you* have -2'd, the query is a little bit different: >> >> label:code-review-2,<gerrit-user-name> AND >> (project:openstack/glance OR project:openstack/glance_store OR >> project:openstack/python-glanceclient) >> >> For example, >> >> label:code-review-2,sigmavirus24 AND (project:openstack/glance OR >> project:openstack/glance_store OR >> project:openstack/python-glanceclient) >> >> is my query. >> >> I think we would all appreciate it if as cores we could keep an eye on >> our own -2's and keep them up-to-date. >> >> I suspect people here will want to ignore anything that was abandoned >> so you can also do: >> >> label:code-review-2,<gerrit-user-name> AND -status:abandoned AND >> (project:openstack/glance OR project:openstack/glance_store OR >> project:openstack/python-glanceclient) >> >> Finally, if you use Gertty, you can use this query to do the same thing: >> >> label:Code-Review=-2,<gerrit-user-name> AND -status:abandoned AND >> project:^openstack/.*glance.* >> >> Cheers, >> -- >> Ian Cordasco >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: [email protected]?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > Ok, as it's becoming clear that the one wrong assumption did not slip > from people (as I originally did not want to point it out), lets > clarify this. > > There is difference between "not being able to" as referred in the > original mailchain and "not willing to before verifying as the issues > were flagged and their corrections slipped under radar long time > before". I actually followed up that situation daily basis and got > online on my holidays to make sure those -2s were not left hanging > there without reason. That was the cause of the frustration and > initial e-mail. Yes, it's important to track -2s, it's equally > important to not assume it's not relevant just because you happen to > think someone has addressed the reason for it. > > No bad feelings, > Erno "jokke" Kuvaja > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: [email protected]?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Thanks, Nikhil __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
