Yeah, I'll 1+ the patch. The move is an easy one once the bug is resolved.

I'm quite amused by the bug, and that someone else filed the same bug a couple of hours right before me (and I missed it). Will review his fix.

Looking forward to your other two patches.

On 26/01/2017 9:37 PM, Rob Cresswell <robert.cressw...@outlook.com> wrote:
Wow, lots of replies. Thanks for the FFE. I'd request that we proceed with the panel separation now, and resolve the final location when any bug fixes have merged. I don't really want to hold up a whole chain of patches over a one line path change. API Access and Key Pairs are done, and I'll put up Security Groups and Floating IPs once they start moving (maintaining huge patch chains is a waste of time)

Rob

On 26 January 2017 at 02:09, Adrian Turjak <adri...@catalyst.net.nz> wrote:
I've posted some comments on the API Access patch.


The blueprint was saying that 'API Access' would be both at the Project level, but the way panel groups worked meant that setting the 'default' panel group didn't work when that dashboard already had panel groups, since the default panel group was annoyingly hidden away because of somewhat odd template logic.

I submitted a bug report here:
https://bugs.launchpad.net/horizon/+bug/1659456

And proposed a fix for that here:
https://review.openstack.org/#/c/425486

With that change the default group panels are not hidden, and displayed at the same level as the other panel groups. This then allows us to move API Access to the top level where the blueprint says. This makes much more sense since API Access isn't a compute only thing.


On 26/01/17 12:02, Fox, Kevin M wrote:
Big Thanks! from me too. The old UI here was very unintuitive, so I had to field a lot of questions related to it. This is great. :)

Kevin

From: Lingxian Kong [anlin.k...@gmail.com]
Sent: Wednesday, January 25, 2017 2:23 PM
To: OpenStack Development Mailing List (not for usage questions)
Subject: Re: [openstack-dev] [horizon] FFE Request

Hi, Rob,

First, thanks for your work!

What's your plan for the other two tabs (security group, floatingip)? I could see the split is very helpful no matter from performance perspective and both useful from end user's perspective.

BTW, a huge +1 for this FFE!




Cheers,
Lingxian Kong (Larry)

On Thu, Jan 26, 2017 at 9:01 AM, Adrian Turjak <adri...@catalyst.net.nz> wrote:
+1

We very much need this as the performance of that panel is awful. This solves that problem while being a fairly minor code change which also provides much better UX.


On 26/01/2017 8:07 AM, Rob Cresswell <robert.cressw...@outlook.com> wrote:
o/ 

I'd like to request an FFE on https://blueprints.launchpad.net/horizon/+spec/reorganise-access-and-security. This blueprint splits up the access and security tabs into 4 distinct panels. The first two patches are https://review.openstack.org/#/c/408247 and https://review.openstack.org/#/c/425345/ 

It's low risk; no API layer changes, mostly just moving code around.

Rob


__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to