FYI, this has implications for both Nova and Glance. Our relevant bug on Launchpad for this is here:
https://bugs.launchpad.net/glance/+bug/787296 Ta, -jay ---------- Forwarded message ---------- From: Jan Dittberner <[email protected]> Date: Thu, May 26, 2011 at 11:41 AM Subject: help wanted: porting sqlalchemy-migrate for SQLAlchemy 0.7 and sqlalchemy-migrate maintenance To: [email protected] Cc: [email protected], [email protected] Hello, I work on making sqlalchemy-migrate [1] work with SQLAlchemy 0.7. I fixed all broken unit tests except for one related to adding a new column with a foreign key to an existing table. We have a continues integration system (Jenkins CI) at [2] that provides the output of the failing test. The problem is with some changed behaviour of the SchemaVisitor API (or the Column objects). Until SQLAlchemy 0.6 it was possible to get the constraints object for the ForeignKey arguments of a column. The test at [3] creates a new Column instance and adds it to the table. Afterwards our ANSIColumnGenerator [4] is triggered to generate the necessary SQL statements. Until SQLAlchemy 0.6 the code for generating the foreign key constraints could be generated properly but now the constraint is None instead of a ForeignKeyConstraint. I tried to just ignore fk.constraint if it is None, which expectedly did not generate a statement. I also tried to construct a ForeignKeyConstraint instance and pass that to the AddConstraint constructor. This approach added a second ForeignKey instance to the Column which is not desired too. Can you please give me hints in the right direction or provide help to fix this issue? We would also like to invite interested developers to join the sqlalchemy-migrate project because it has no maintainers with enough time to keep it in a good shape. I think it would be great if the test coverage and code quality would be improved but neither me nor the other current maintainers have enough time to do these necessary prerequisites. We have a quite long list of outstanding issues [5] that need some triaging and fixes and should give a good start for interested developers. [1] http://code.google.com/p/sqlalchemy-migrate/ [2] http://jenkins.gnuviech-server.de/job/sqlalchemy-migrate-all/ [3] http://code.google.com/p/sqlalchemy-migrate/source/browse/migrate/tests/changeset/test_changeset.py#160 [4] http://code.google.com/p/sqlalchemy-migrate/source/browse/migrate/changeset/ansisql.py#87 [5] http://code.google.com/p/sqlalchemy-migrate/issues/list Regards Jan Dittberner -- You received this message because you are subscribed to the Google Groups "migrate-users" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/migrate-users?hl=en. _______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : [email protected] Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
