On Sep 7, 2011, at 10:34 AM, Sandy Walsh wrote:
> Heh. Like I mentioned at the top of the thread, it's just a hack. We're
> currently merging with Roundabout to handle the Jenkins integration and make
> roundabout's workflow strategies pluggable.
>
> So, right now only the pull request and core members are real, the votes are
> faked out.
>
> The output from jenkins would be exactly the same as what we get from Gerrit
> (a new comment added to the pull request with the test results) ... only
> easier to find ;)
>
> But yes, there is a risk that a core member could just hit "merge and close"
> and break trunk. That's perhaps the only real "con" I can think of.
Only if they actually own the branch in github. Presumably if you implement a
gated trunk with Github/roundabout/hubcap, the canonical repo is set such that
only the user the roundabout 'bot is using can actually merge a pull request.
The 'core members' are just members of a random team that the bot looks at to
determine who to listen to for votes. This is basically what gerrit and our
current LP setup do. it's just a matter of permissions.
--
Monsyne M. Dragon
OpenStack/Nova
cell 210-441-0965
work x 5014190
This email may include confidential information. If you received it in error,
please delete it.
_______________________________________________
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help : https://help.launchpad.net/ListHelp
