Thanks it seems like there should be a backlog of these types of issues. Or some talk with the libvirt people so those missing functions can be integrated. Having an interface where implementations throw NotSupported still seems odd, and getting the libvirt people to make those missing functions possible seems like a good goal.
On 9/9/11 9:06 AM, "Darrel O'Pry" <[email protected]> wrote: I might also tender a suggestion of a NotSupported error as well. I think you have two states to deal with. There is the case where someone hasn't had time to implement the feature in the driver or event review the implementation, NotImplemented. Then there is a case where the system you're building a driver for simply doesn't support a feature, NotSupported. On Fri, Sep 9, 2011 at 11:37 AM, Soren Hansen <[email protected]> wrote: 2011/9/9 Brian Lamar <[email protected]>: > Yeah, I've had the same issues you seem to be struggling with. Long story > short when you're doing what this project is doing and attempting to be > flexible with several different diverse implementations you're going to > encounter areas where some drivers just don't support things. I feel like > this should just go away and then NotImplementedError would be raised as it's > not implemented. This was also pointed out by Kei. This is what I'm doing as I'm going through the virt layer cleaning things up. I have a test that calls all the methods and records when something raises NotImplementedError. I'll use this data to automatically compile a matrix of supported features in the individual drivers, but it'll be a while before this actually happens (I need to actually call all the various drivers from this test first). -- Soren Hansen | http://linux2go.dk/ Ubuntu Developer | http://www.ubuntu.com/ OpenStack Developer | http://www.openstack.org/ _______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : [email protected] Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
_______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : [email protected] Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
