But it's metadata about the code (a particular review pattern with a particular vcs). VCS info does not belong in the code. I'll admit that I like a dotfile in the repo much better than I like rfc.sh in the repo, but I'd prefer to keep info about remotes, review processes, and other repo metadata out of the repo. If this is something for a particular VCS (as the proposed git-review is), it should use the established locations for that particular VCS. In this case, git-review should pull info from the .git directory (more specifically, the git config data).
--John On Oct 14, 2011, at 8:04 AM, Julien Danjou wrote: > On Fri, Oct 14 2011, John Dickinson wrote: > >> I'd much prefer storing data in git config rather than in a dot file. > > A dot file is commit-able. Git config is not. > So in this case, providing the dot file wins. Think about like a > .gitignore file. > > -- > Julien Danjou > // eNovance http://enovance.com > // ✉ [email protected] ☎ +33 1 49 70 99 81
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : [email protected] Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
