Hello It's very cool. I send review request to review.openstack.org this a link to it https://review.openstack.org/#/c/6775/
Thank you, Victor 2012/4/23 Doug Hellmann <doug.hellm...@dreamhost.com>: > This sounds like a good candidate to live in openstack-common, rather than > being limited to Swift. > > > On Sat, Apr 21, 2012 at 12:22 PM, John Dickinson <m...@not.mn> wrote: >> >> I like what you are trying to do here. Can you please submit this as a >> patch through gerrit so we can get the rest of the core devs to look at it? >> >> --John >> >> >> On Apr 20, 2012, at 12:14 PM, Victor Rodionov wrote: >> >> > There are many place in Swift code where used hard coded values, such >> > as response statuses (200, 201, 404, ...) which can replaced with >> > constants HTTP_OK, HTTP_CREATED, HTTP_NOT_FOUND. Also there is widlly >> > used idiom 200 <= status < 300, that can be replaced as well with >> > something like this is_success(status). I want add modules for >> > defining all required constants (Swift, HTTP). >> > >> > So I think this changes will improve Swift code readability. >> > >> > PS: this is an initial changes in github >> > >> > https://github.com/vitoordaz/swift/commit/7163d5df13ceaf8fc7b53ba812fe16bd7dd31131 >> > >> > _______________________________________________ >> > Mailing list: https://launchpad.net/~openstack >> > Post to : openstack@lists.launchpad.net >> > Unsubscribe : https://launchpad.net/~openstack >> > More help : https://help.launchpad.net/ListHelp >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~openstack >> Post to : openstack@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~openstack >> More help : https://help.launchpad.net/ListHelp >> > _______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp