Hi All, I would like to propose a minimum required code coverage level per file in Nova. Say 80%. This would mean that any new feature/file should only be accepted if it has over 80% code coverage. Exceptions to this rule would be allowed for code that is covered by skipped tests (as long as 80% is reached when the tests are not skipped).
With 193 python files in nova/tests, Nova unit tests produce 85% overall code coverage (calculated with ./run_test.sh -c [1]). But 23% of files (125 files) have lower then 80% code coverage (30 tests skipped on my machine). Getting all files to hit the 80% code coverage mark should be one of the goals for Folsom. Some files with low coverage: nova/flags 18% nova/tests/integrated/test_servers 27% nova/testing/runner 31% nova/api/ec2/faults 36% nova/network/quantum/client 36% nova/network/quantum/melange_connection 38% nova/openstack/common/iniparser 40% nova/openstack/common/cfg 41% nova/tests/db/fakes 41% nova/console/api 44% nova/image/s3 50% nova/api/ec2/__init__ 53% nova/notifier/log_notifier 56% best, Joe Gordon [1] With https://review.openstack.org/#/c/6750/
_______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
