On 04/30/2012 08:11 PM, Vishvananda Ishaya wrote: > Looking good. > > A few points: > > a) can we just do hasattr dispatch instead of isinstance. it seems more > pythonic than forcing the use of the dispatcher base class
Sounds good. > b) it seems like we should make the dispatcher pick version 1.0 instead of > failing if version is not passed in, that way a new dispatcher could handle > unversioned messages. Or did i miss some other magic way this is happening. Good point. Otherwise, *all* messages from an Essex install would be rejected from a newer version using rpc versioning even if it could handle it properly. Thanks for the feedback! -- Russell Bryant _______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp