On 05/04/2012 12:45 PM, Eric Windisch wrote: >> >> I guess another question is, why do you need to set ZeroMQ related flags >> in fake_flags? I think those should only be settings that apply for >> *all* unit tests. I would just register your flags in your unit tests. >> >> https://github.com/openstack/nova/blob/master/nova/tests/rpc/test_qpid.py#L69 > > The fake_rabbit flag doesn't, but this is otherwise a good point. For > now, I've just hard-coded the flag into the test.
Yeah, the fake_rabbit flag used to apply to a lot more than it does now. It was applicable to all tests before nova.rpc.impl_fake was added during Essex development. -- Russell Bryant _______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : [email protected] Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
