On 19.05.14 14:59, Jean Delvare wrote:
Le Monday 19 May 2014 à 14:25 +0200, Jean Delvare a écrit :
This one is fairly simple actually. You can't build exynos_dp_core into
the kernel (CONFIG_DRM_EXYNOS_DP=y) while ptn3460 is built as a module
(CONFIG_DRM_PTN3460=m) because the former depends on the latter.
The most immediate fix is to change CONFIG_DRM_PTN3460 to y. I'll do
that.
Done.
BTW, this makes me wonder why we have CONFIG_DRM_PTN3460=m in all other
kernel flavors. As far as I can see this chip is only used by Exynos at
the moment so we can safely disable it everywhere else.
The idea of the exynos flavor was to be a mere temporary solution until
exynos becomes multiarch aware. In an ideal world, the exynos flavor
really should just be default + CONFIG_EXYNOS, so that merging doesn't
become too hard.
The proper fix would be to add the proper dependency between these two
drivers, with either a "depends on" or a "select". I'll see what it more
appropriate.
I'll go with "depends on" because it's easier. The whole design is
horrible anyway, the right thing to do would be to rewrite the driver
interface completely...
Heh :). Please send the patch upstream once you have it ;)
Alex
--
To unsubscribe, e-mail: [email protected]
To contact the owner, e-mail: [email protected]
