On 28.10.14 10:11, Andreas Schwab wrote: > Alexander Graf <[email protected]> writes: > >> On 28.10.14 09:54, Andreas Schwab wrote: >>> Alexander Graf <[email protected]> writes: >>> >>>> ++ buf = kasprintf(GFP_KERNEL, "amd-xgbe-%s", pdata->netdev->name); >>> >>> You'll probably need to rename that. You'll probably also need to >>> rename all public functions to avoid conflicts. >> >> As long as it gets built as a module public functions don't hurt. The >> above can also never conflict, as there's either A0 or B0 silicon in a >> SoC - never both at the same time. > > You can still load both modules, causing two modules providing the same > symbols.
True, I've changed the debugfs string above. Kernel module symbols only conflict when they're exported - and this driver doesn't export any symbols. So there shouldn't be a conflict on symbol names ever :). Alex -- To unsubscribe, e-mail: [email protected] To contact the owner, e-mail: [email protected]
