Hi Frank,

Am 08.01.2017 um 13:35 schrieb Frank Kunz:
> [1]
> https://build.opensuse.org/package/show/home:frank_kunz:branches:openSUSE:Factory:ARM/JeOS

Please delete _multibuild until you're ready to submit, otherwise you
are wasting build power rebuilding all other images, too.

Images.kiwi.in:

firmware="ofw" sounds wrong?

dtb-sun7i is obviously copy&paste, waiting for your pull to be merged.
Better drop the line and add a to-do comment.

For the gfx command line you may want to add a second console=tty or so?

uboot-image-setup.in:

Please don't set so many U-Boot variables for a new board. You should
probably set use_fdt_addr_r and not duplicate the variables that modern
U-Boot should already be providing for you, including fdtfile. Compare
my in-progress nanopineo with just three lines:

https://build.opensuse.org/package/show/home:a_faerber:branches:openSUSE:Factory:ARM/JeOS-nanopineo

Does EFI not work yet or have you not tried?

uboot-image-install.in:

Better check for file presence than for image name (think "sockit").

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
-- 
To unsubscribe, e-mail: [email protected]
To contact the owner, e-mail: [email protected]

Reply via email to