Hello community, here is the log from the commit of package rpmlint for openSUSE:Factory checked in at Wed Jun 8 09:11:30 CEST 2011.
-------- --- rpmlint/rpmlint.changes 2011-05-31 13:31:04.000000000 +0200 +++ /mounts/work_src_done/STABLE/rpmlint/rpmlint.changes 2011-06-07 17:14:42.000000000 +0200 @@ -1,0 +2,12 @@ +Tue Jun 7 15:14:20 UTC 2011 - lnus...@suse.de + +- add colord to dbus whitelist (bnc#698250) + +------------------------------------------------------------------- +Tue Jun 7 15:03:54 UTC 2011 - lnus...@suse.de + +- CheckPolkitPrivs.py: use different tag for non-fatal issues +- CheckBuildDate.py: print either file-contains-current-date or + file-contains-current-date but not both + +------------------------------------------------------------------- calling whatdependson for head-i586 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rpmlint.spec ++++++ --- /var/tmp/diff_new_pack.z0BpNY/_old 2011-06-08 09:09:00.000000000 +0200 +++ /var/tmp/diff_new_pack.z0BpNY/_new 2011-06-08 09:09:00.000000000 +0200 @@ -23,7 +23,7 @@ BuildRequires: rpm-python xz Summary: Rpm correctness checker Version: 1.2 -Release: 7 +Release: 9 Source0: http://rpmlint.zarb.org/download/rpmlint-%{version}.tar.xz Source1: config Source1001: config.in ++++++ CheckBuildDate.py ++++++ --- /var/tmp/diff_new_pack.z0BpNY/_old 2011-06-08 09:09:00.000000000 +0200 +++ /var/tmp/diff_new_pack.z0BpNY/_new 2011-06-08 09:09:00.000000000 +0200 @@ -30,13 +30,13 @@ grep_date = pkg.grep(self.istoday, filename) - if len(grep_date): - printWarning(pkg, "file-contains-current-date", filename) - grep_time = pkg.grep(self.looksliketime, filename) - if len(grep_date) and len(grep_time): - printError(pkg, "file-contains-date-and-time", filename) + if len(grep_date): + if len(grep_time): + printError(pkg, "file-contains-date-and-time", filename) + else: + printWarning(pkg, "file-contains-current-date", filename) check=BuildDateCheck() ++++++ CheckPolkitPrivs.py ++++++ --- /var/tmp/diff_new_pack.z0BpNY/_old 2011-06-08 09:09:00.000000000 +0200 +++ /var/tmp/diff_new_pack.z0BpNY/_new 2011-06-08 09:09:00.000000000 +0200 @@ -77,37 +77,50 @@ try: if f.startswith("/usr/share/PolicyKit/policy/")\ or f.startswith("/usr/share/polkit-1/actions/"): - f = pkg.dirName() + f - xml = parse(f) + xml = parse(pkg.dirName() + f) for a in xml.getElementsByTagName("action"): action = a.getAttribute('id') if not action in self.privs: iserr = 0 foundno = 0 - anyseen = 0 + foundundef = 0 + settings = {} try: defaults = a.getElementsByTagName("defaults")[0] for i in defaults.childNodes: if not i.nodeType == i.ELEMENT_NODE: continue - if i.nodeName == 'allow_any': - anyseen = 1 - if i.firstChild.data.find("auth_admin") != 0: - if i.firstChild.data == 'no': - foundno = 1 - else: - iserr = 1 + + if i.nodeName in ('allow_any', 'allow_inactive', 'allow_active'): + settings[i.nodeName] = i.firstChild.data + except: iserr = 1 + for i in ('allow_any', 'allow_inactive', 'allow_active'): + if not i in settings: + foundundef = 1 + settings[i] = '??' + elif settings[i].find("auth_admin") != 0: + if settings[i] == 'no': + foundno = 1 + else: + iserr = 1 + if iserr: - printError(pkg, 'polkit-unauthorized-privilege', action) + printError(pkg, 'polkit-unauthorized-privilege', '%s (%s:%s:%s)' % (action, \ + settings['allow_any'], settings['allow_inactive'], settings['allow_active'])) else: - printInfo(pkg, 'polkit-unauthorized-privilege', action) + printInfo(pkg, 'polkit-untracked-privilege', '%s (%s:%s:%s)' % (action, \ + settings['allow_any'], settings['allow_inactive'], settings['allow_active'])) + + if foundno or foundundef: + printInfo(pkg, + 'polkit-cant-acquire-privilege', '%s (%s:%s:%s)' % (action, \ + settings['allow_any'], settings['allow_inactive'], settings['allow_active'])) - if foundno or not anyseen: - printWarning(pkg, 'polkit-cant-acquire-privilege', action) - except: + except Exception, x: + printError(pkg, 'rpmlint-exception', "%(file)s raised an exception: %(x)s" % {'file':f, 'x':x}) continue check=PolkitCheck() @@ -119,10 +132,18 @@ please open a bug report to request review of the package by the security team""", 'polkit-unauthorized-privilege', -"""If the package is intended for inclusion in any SUSE product -please open a bug report to request review of the package by the -security team""", +"""The package allows unprivileged users to carry out privileged +operations without authentication. This could cause security +problems if not done carefully. If the package is intended for +inclusion in any SUSE product please open a bug report to request +review of the package by the security team""", +'polkit-untracked-privilege', +"""The privilege is not listed in /etc/polkit-default-privs.* +which makes it harder for admins to find. If the package is intended +for inclusion in any SUSE product please open a bug report to +request review of the package by the security team""", 'polkit-cant-acquire-privilege', """Usability can be improved by allowing users to acquire privileges via authentication. Use e.g. 'auth_admin' instead of 'no' and make -sure to define 'allow_any'.""") +sure to define 'allow_any'. This is an issue only if the privilege +is not listed in /etc/polkit-default-privs.*""") ++++++ config ++++++ --- /var/tmp/diff_new_pack.z0BpNY/_old 2011-06-08 09:09:00.000000000 +0200 +++ /var/tmp/diff_new_pack.z0BpNY/_new 2011-06-08 09:09:00.000000000 +0200 @@ -425,6 +425,9 @@ # synche-connector (bnc#683956) "org.synce.dccm.service", "org.synce.dccm.conf", + # colord (bnc#698250) + "org.freedesktop.ColorManager.service", + "org.freedesktop.ColorManager.conf", )) # Output filters ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org For additional commands, e-mail: opensuse-commit+h...@opensuse.org
