Hello community,

here is the log from the commit of package alpine for openSUSE:Factory
checked in at Tue Oct 18 13:56:33 CEST 2011.



--------
--- openSUSE:Factory/alpine/alpine.changes      2011-10-11 18:20:45.000000000 
+0200
+++ /mounts/work_src_done/STABLE/alpine/alpine.changes  2011-10-17 
10:48:47.000000000 +0200
@@ -1,0 +2,6 @@
+Mon Oct 17 08:45:32 UTC 2011 - m...@suse.com
+
+- Fix two instances of premature closedir() and a potential buffer
+  overflow in the maildir handler (alpine-maildir-closedir.patch).
+
+-------------------------------------------------------------------

calling whatdependson for head-i586


New:
----
  alpine-maildir-closedir.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ alpine.spec ++++++
--- /var/tmp/diff_new_pack.YFjYE5/_old  2011-10-18 13:56:29.000000000 +0200
+++ /var/tmp/diff_new_pack.YFjYE5/_new  2011-10-18 13:56:29.000000000 +0200
@@ -66,6 +66,7 @@
 Patch5:         alpine-gcc44.diff
 Patch6:         alpine-2.00-as_needed.patch
 Patch7:         alpine-month_name-utf8.patch
+Patch8:         alpine-maildir-closedir.patch
 Patch10:        pico-fix-spurious-undef-warnings.diff
 Patch20:        pine-expression-warnings.diff
 Patch40:        pico-stripwhitespace.diff
@@ -164,6 +165,7 @@
 %patch5 -p0
 %patch6 -p0
 %patch7
+%patch8
 %patch10 -p1
 %patch20 -p1
 %patch40 -p1

++++++ alpine-maildir-closedir.patch ++++++
--- imap/src/osdep/unix/maildir.c       2011-10-17 10:11:55.000000000 +0200
+++ imap/src/osdep/unix/maildir.c       2011-10-17 10:39:31.000000000 +0200
@@ -2396,7 +2396,6 @@
        || !strncmp(d->d_name, MDUIDTEMP, strlen(MDUIDTEMP)))
        break;
   }
-  closedir(dir);
   rv = d ? !strncmp(d->d_name, tmp, strlen(tmp)) : 1;
   createtemp = d ? 0 : 1;
   if (d && rv == 0){   /* is there a temp file that is not ours? */
@@ -2410,6 +2409,7 @@
        unlink(tmp);
      }
   }
+  closedir(dir);
   if(createtemp){
     FILE *fp;
     sprintf(tmp,"%s/%s.%d.%lu", LOCAL->dir, MDUIDTEMP, getpid(), time(0));
@@ -2442,7 +2442,6 @@
       if(!strncmp(d->d_name, MDUIDLAST, strlen(MDUIDLAST)))
        break;
   }
-  closedir(dir);
   createuid = d == NULL ? 1 : 0;
   if(uid_last == NULL)
     deleteuid++;
@@ -2473,9 +2472,10 @@
      }
   }
   if(deleteuid){
-     sprintf(tmp,"%s/%s", LOCAL->dir, d->d_name);
+     snprintf(tmp, sizeof(tmp), "%s/%s", LOCAL->dir, d->d_name);
      unlink(tmp);
   }
+  closedir(dir);
   if(createuid)
      maildir_write_uid(stream, (uid_last ? *uid_last : stream->uid_last), 
                uid_validity ? *uid_validity : time(0));
Nur in alpine-2.00/imap/src/osdep/unix: maildir.c~.

continue with "q"...



Remember to have fun...

-- 
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org

Reply via email to