Hello community,

here is the log from the commit of package perl-Moo for openSUSE:Factory 
checked in at 2016-11-24 21:23:58
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-Moo (Old)
 and      /work/SRC/openSUSE:Factory/.perl-Moo.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "perl-Moo"

Changes:
--------
--- /work/SRC/openSUSE:Factory/perl-Moo/perl-Moo.changes        2016-07-12 
23:51:19.000000000 +0200
+++ /work/SRC/openSUSE:Factory/.perl-Moo.new/perl-Moo.changes   2016-11-24 
21:24:00.000000000 +0100
@@ -1,0 +2,17 @@
+Tue Nov  1 06:52:46 UTC 2016 - co...@suse.com
+
+- updated to 2.002005
+   see /usr/share/doc/packages/perl-Moo/Changes
+
+  2.002005 - 2016-10-31
+    - fix accessor extensions that need captured variables for clearers and
+      predicates. (RT#118453)
+    - avoid relying on '.' being in @INC in tests
+    - fix Sub::Quote test when run with perl -C or PERL_UNICODE on perl 5.10
+      (RT#117844)
+    - improved error messages for invalid sub names in Sub::Quote (RT#116416,
+      RT#117711)
+    - clarify meta method documentation
+    - bump Role::Tiny prereq version to get stub in role fix (RT#116674)
+
+-------------------------------------------------------------------

Old:
----
  Moo-2.002004.tar.gz

New:
----
  Moo-2.002005.tar.gz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ perl-Moo.spec ++++++
--- /var/tmp/diff_new_pack.4mrNML/_old  2016-11-24 21:24:01.000000000 +0100
+++ /var/tmp/diff_new_pack.4mrNML/_new  2016-11-24 21:24:01.000000000 +0100
@@ -17,7 +17,7 @@
 
 
 Name:           perl-Moo
-Version:        2.002004
+Version:        2.002005
 Release:        0
 %define cpan_name Moo
 Summary:        Minimalist Object Orientation (with Moose compatibility)
@@ -33,13 +33,13 @@
 BuildRequires:  perl(Class::Method::Modifiers) >= 1.1
 BuildRequires:  perl(Devel::GlobalDestruction) >= 0.11
 BuildRequires:  perl(Module::Runtime) >= 0.014
-BuildRequires:  perl(Role::Tiny) >= 2.000002
+BuildRequires:  perl(Role::Tiny) >= 2.000004
 BuildRequires:  perl(Test::Fatal) >= 0.003
 BuildRequires:  perl(Test::More) >= 0.94
 Requires:       perl(Class::Method::Modifiers) >= 1.1
 Requires:       perl(Devel::GlobalDestruction) >= 0.11
 Requires:       perl(Module::Runtime) >= 0.014
-Requires:       perl(Role::Tiny) >= 2.000002
+Requires:       perl(Role::Tiny) >= 2.000004
 Recommends:     perl(Class::XSAccessor) >= 1.18
 Recommends:     perl(strictures) >= 2
 Recommends:     perl(Sub::Name) >= 0.08

++++++ Moo-2.002004.tar.gz -> Moo-2.002005.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/Changes new/Moo-2.002005/Changes
--- old/Moo-2.002004/Changes    2016-06-28 04:33:55.000000000 +0200
+++ new/Moo-2.002005/Changes    2016-10-31 22:57:53.000000000 +0100
@@ -1,5 +1,16 @@
 Revision history for Moo
 
+2.002005 - 2016-10-31
+  - fix accessor extensions that need captured variables for clearers and
+    predicates. (RT#118453)
+  - avoid relying on '.' being in @INC in tests
+  - fix Sub::Quote test when run with perl -C or PERL_UNICODE on perl 5.10
+    (RT#117844)
+  - improved error messages for invalid sub names in Sub::Quote (RT#116416,
+    RT#117711)
+  - clarify meta method documentation
+  - bump Role::Tiny prereq version to get stub in role fix (RT#116674)
+
 2.002004 - 2016-06-28
   - fixed another case of local functions interfering with generated code.
     (RT#115655)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/META.json new/Moo-2.002005/META.json
--- old/Moo-2.002004/META.json  2016-06-28 04:34:30.000000000 +0200
+++ new/Moo-2.002005/META.json  2016-10-31 22:58:30.000000000 +0100
@@ -4,7 +4,7 @@
       "mst - Matt S. Trout (cpan:MSTROUT) <m...@shadowcat.co.uk>"
    ],
    "dynamic_config" : 1,
-   "generated_by" : "ExtUtils::MakeMaker version 7.16, CPAN::Meta::Converter 
version 2.150005",
+   "generated_by" : "ExtUtils::MakeMaker version 7.24, CPAN::Meta::Converter 
version 2.150005",
    "license" : [
       "perl_5"
    ],
@@ -54,7 +54,7 @@
             "Devel::GlobalDestruction" : "0.11",
             "Exporter" : "5.57",
             "Module::Runtime" : "0.014",
-            "Role::Tiny" : "2.000002",
+            "Role::Tiny" : "2.000004",
             "Scalar::Util" : "0",
             "perl" : "5.006"
          }
@@ -86,7 +86,7 @@
       },
       "x_IRC" : "irc://irc.perl.org/#moose"
    },
-   "version" : "2.002004",
+   "version" : "2.002005",
    "x_authority" : "cpan:MSTROUT",
    "x_breaks" : {
       "App::Commando" : "<= 0.012",
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/META.yml new/Moo-2.002005/META.yml
--- old/Moo-2.002004/META.yml   2016-06-28 04:34:30.000000000 +0200
+++ new/Moo-2.002005/META.yml   2016-10-31 22:58:30.000000000 +0100
@@ -8,7 +8,7 @@
 configure_requires:
   ExtUtils::MakeMaker: '0'
 dynamic_config: 1
-generated_by: 'ExtUtils::MakeMaker version 7.16, CPAN::Meta::Converter version 
2.150005'
+generated_by: 'ExtUtils::MakeMaker version 7.24, CPAN::Meta::Converter version 
2.150005'
 license: perl
 meta-spec:
   url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -27,7 +27,7 @@
   Devel::GlobalDestruction: '0.11'
   Exporter: '5.57'
   Module::Runtime: '0.014'
-  Role::Tiny: '2.000002'
+  Role::Tiny: '2.000004'
   Scalar::Util: '0'
   perl: '5.006'
 resources:
@@ -35,7 +35,7 @@
   bugtracker: https://rt.cpan.org/Public/Dist/Display.html?Name=Moo
   license: http://dev.perl.org/licenses/
   repository: https://github.com/moose/Moo.git
-version: '2.002004'
+version: '2.002005'
 x_authority: cpan:MSTROUT
 x_breaks:
   App::Commando: '<= 0.012'
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/Makefile.PL new/Moo-2.002005/Makefile.PL
--- old/Moo-2.002004/Makefile.PL        2016-06-23 07:57:07.000000000 +0200
+++ new/Moo-2.002005/Makefile.PL        2016-10-31 22:32:00.000000000 +0100
@@ -25,7 +25,7 @@
       requires => {
         'Class::Method::Modifiers'  => 1.10,  # for RT#80194
         'Module::Runtime'           => 0.014, # for RT#86394
-        'Role::Tiny'                => 2.000002,
+        'Role::Tiny'                => 2.000004,
         'Devel::GlobalDestruction'  => 0.11,  # for RT#78617
         'Scalar::Util'              => 0,
         'perl'                      => 5.006,
@@ -113,7 +113,7 @@
 
 ## BOILERPLATE ###############################################################
 require ExtUtils::MakeMaker;
-(do 'maint/Makefile.PL.include' or die $@) unless -f 'META.yml';
+(do './maint/Makefile.PL.include' or die $@) unless -f 'META.yml';
 
 # have to do this since old EUMM dev releases miss the eval $VERSION line
 my $eumm_version  = eval $ExtUtils::MakeMaker::VERSION;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/README new/Moo-2.002005/README
--- old/Moo-2.002004/README     2016-06-28 04:34:30.000000000 +0200
+++ new/Moo-2.002005/README     2016-10-31 22:58:31.000000000 +0100
@@ -172,8 +172,13 @@
       my $meta = Foo::Bar->meta;
       my @methods = $meta->get_method_list;
 
-    Returns a Moose metaclass object for the class. The metaclass will only
-    be built on demand, loading Moose in the process.
+    Returns an object that will behave as if it is a Moose metaclass object
+    for the class. If you call anything other than "make_immutable" on it,
+    the object will be transparently upgraded to a genuine
+    Moose::Meta::Class instance, loading Moose in the process if required.
+    "make_immutable" itself is a no-op, since we generate metaclasses that
+    are already immutable, and users converting from Moose had an
+    unfortunate tendency to accidentally load Moose by calling it.
 
 LIFECYCLE METHODS
     There are several methods that you can define in your class to control
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/lib/Method/Generate/Accessor.pm 
new/Moo-2.002005/lib/Method/Generate/Accessor.pm
--- old/Moo-2.002004/lib/Method/Generate/Accessor.pm    2016-06-23 
09:35:27.000000000 +0200
+++ new/Moo-2.002005/lib/Method/Generate/Accessor.pm    2016-10-31 
01:07:53.000000000 +0100
@@ -185,10 +185,11 @@
         exists_predicates => $into, $pred, $name, $spec
       );
     } else {
+      $self->{captures} = {};
       $methods{$pred} =
         quote_sub "${into}::${pred}"
           => $self->_generate_simple_has('$_[0]', $name, $spec)."\n"
-          => {}
+          => delete $self->{captures}
           => $quote_opts
         ;
     }
@@ -199,10 +200,11 @@
   if (my $cl = $spec->{clearer}) {
     _die_overwrite($into, $cl, 'a clearer')
       if !$spec->{allow_overwrite} && defined &{"${into}::${cl}"};
+    $self->{captures} = {};
     $methods{$cl} =
       quote_sub "${into}::${cl}"
         => $self->_generate_simple_clear('$_[0]', $name, $spec)."\n"
-        => {}
+        => delete $self->{captures}
         => $quote_opts
       ;
   }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/lib/Moo/HandleMoose.pm 
new/Moo-2.002005/lib/Moo/HandleMoose.pm
--- old/Moo-2.002004/lib/Moo/HandleMoose.pm     2016-06-28 04:22:29.000000000 
+0200
+++ new/Moo-2.002005/lib/Moo/HandleMoose.pm     2016-10-31 01:06:02.000000000 
+0100
@@ -1,6 +1,5 @@
 package Moo::HandleMoose;
 use Moo::_strictures;
-no warnings 'once';
 use Moo::_Utils qw(_getstash);
 use Sub::Quote qw(quotify);
 use Carp qw(croak);
@@ -16,7 +15,7 @@
     if $Moo::sification::disabled;
   require Class::MOP;
   inject_fake_metaclass_for($_)
-    for grep $_ ne 'Moo::Object', do { no warnings 'once'; keys %Moo::MAKERS };
+    for grep $_ ne 'Moo::Object', keys %Moo::MAKERS;
   inject_fake_metaclass_for($_) for keys %Moo::Role::INFO;
   require Moose::Meta::Method::Constructor;
   @Moo::HandleMoose::FakeConstructor::ISA = 'Moose::Meta::Method::Constructor';
@@ -219,7 +218,7 @@
     }
     $meta->add_role(Class::MOP::class_of($_))
       for grep !/\|/ && $_ ne $name, # reject Foo|Bar and same-role-as-self
-        do { no warnings 'once'; keys %{$Moo::Role::APPLIED_TO{$name}} };
+        keys %{$Moo::Role::APPLIED_TO{$name}}
   }
   $DID_INJECT{$name} = 1;
   $meta;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/lib/Moo/Role.pm 
new/Moo-2.002005/lib/Moo/Role.pm
--- old/Moo-2.002004/lib/Moo/Role.pm    2016-06-28 04:33:43.000000000 +0200
+++ new/Moo-2.002005/lib/Moo/Role.pm    2016-10-31 22:57:03.000000000 +0100
@@ -25,7 +25,7 @@
   );
 }
 
-our $VERSION = '2.002004';
+our $VERSION = '2.002005';
 $VERSION = eval $VERSION;
 
 require Moo::sification;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/lib/Moo/_Utils.pm 
new/Moo-2.002005/lib/Moo/_Utils.pm
--- old/Moo-2.002004/lib/Moo/_Utils.pm  2016-06-14 21:53:26.000000000 +0200
+++ new/Moo-2.002005/lib/Moo/_Utils.pm  2016-10-31 01:06:02.000000000 +0100
@@ -1,12 +1,12 @@
 package Moo::_Utils;
-
-no warnings 'once'; # guard against -w
-
-sub _getglob { \*{$_[0]} }
-sub _getstash { \%{"$_[0]::"} }
-
 use Moo::_strictures;
 
+{
+  no strict 'refs';
+  sub _getglob { \*{$_[0]} }
+  sub _getstash { \%{"$_[0]::"} }
+}
+
 BEGIN {
   my ($su, $sn);
   $su = $INC{'Sub/Util.pm'} && defined &Sub::Util::set_subname
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/lib/Moo/_strictures.pm 
new/Moo-2.002005/lib/Moo/_strictures.pm
--- old/Moo-2.002004/lib/Moo/_strictures.pm     2016-05-17 05:18:15.000000000 
+0200
+++ new/Moo-2.002005/lib/Moo/_strictures.pm     2016-10-31 01:06:02.000000000 
+0100
@@ -12,6 +12,7 @@
   else {
     strict->import;
     warnings->import;
+    warnings->unimport('once');
   }
 }
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/lib/Moo.pm new/Moo-2.002005/lib/Moo.pm
--- old/Moo-2.002004/lib/Moo.pm 2016-06-28 04:33:43.000000000 +0200
+++ new/Moo-2.002005/lib/Moo.pm 2016-10-31 22:57:03.000000000 +0100
@@ -22,7 +22,7 @@
   );
 }
 
-our $VERSION = '2.002004';
+our $VERSION = '2.002005';
 $VERSION = eval $VERSION;
 
 require Moo::sification;
@@ -125,7 +125,6 @@
   elsif (!$target->isa('Moo::Object')) {
     Moo->_constructor_maker_for($target);
   }
-  no warnings 'once'; # piss off. -- mst
   $Moo::HandleMoose::MOUSE{$target} = [
     grep defined, map Mouse::Util::find_meta($_), @_
   ] if Mouse::Util->can('find_meta');
@@ -443,8 +442,13 @@
   my $meta = Foo::Bar->meta;
   my @methods = $meta->get_method_list;
 
-Returns a L<Moose metaclass|Moose::Meta::Class> object for the class.  The
-metaclass will only be built on demand, loading Moose in the process.
+Returns an object that will behave as if it is a
+L<Moose metaclass|Moose::Meta::Class> object for the class. If you call
+anything other than C<make_immutable> on it, the object will be transparently
+upgraded to a genuine L<Moose::Meta::Class> instance, loading Moose in the
+process if required. C<make_immutable> itself is a no-op, since we generate
+metaclasses that are already immutable, and users converting from Moose had
+an unfortunate tendency to accidentally load Moose by calling it.
 
 =head1 LIFECYCLE METHODS
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/lib/Sub/Defer.pm 
new/Moo-2.002005/lib/Sub/Defer.pm
--- old/Moo-2.002004/lib/Sub/Defer.pm   2016-06-28 04:33:43.000000000 +0200
+++ new/Moo-2.002005/lib/Sub/Defer.pm   2016-10-31 22:57:03.000000000 +0100
@@ -6,7 +6,7 @@
 use Scalar::Util qw(weaken);
 use Carp qw(croak);
 
-our $VERSION = '2.002004';
+our $VERSION = '2.002005';
 $VERSION = eval $VERSION;
 
 our @EXPORT = qw(defer_sub undefer_sub undefer_all);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/lib/Sub/Quote.pm 
new/Moo-2.002005/lib/Sub/Quote.pm
--- old/Moo-2.002004/lib/Sub/Quote.pm   2016-06-28 04:33:43.000000000 +0200
+++ new/Moo-2.002005/lib/Sub/Quote.pm   2016-10-31 22:57:03.000000000 +0100
@@ -15,7 +15,7 @@
   *_HAVE_PERLSTRING = defined &B::perlstring ? sub(){1} : sub(){0};
 }
 
-our $VERSION = '2.002004';
+our $VERSION = '2.002005';
 $VERSION = eval $VERSION;
 
 our @EXPORT = qw(quote_sub unquote_sub quoted_from_sub qsub);
@@ -94,10 +94,14 @@
     my $subname = $name;
     my $package = $subname =~ s/(.*)::// ? $1 : caller;
     $name = join '::', $package, $subname;
-    croak "package name $package too long!"
+    croak qq{package name "$package" too long!}
       if length $package > 252;
-    croak "sub name $subname too long!"
+    croak qq{package name "$package" is not valid!}
+      unless $package =~ /^[^\d\W]\w*(?:::\w+)*$/;
+    croak qq{sub name "$subname" too long!}
       if length $subname > 252;
+    croak qq{sub name "$subname" is not valid!}
+      unless $subname =~ /^[^\d\W]\w*$/;
   }
   my @caller = caller(0);
   my $attributes = $options->{attributes};
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/t/accessor-weaken-pre-5_8_3.t 
new/Moo-2.002005/t/accessor-weaken-pre-5_8_3.t
--- old/Moo-2.002004/t/accessor-weaken-pre-5_8_3.t      2016-04-14 
13:24:25.000000000 +0200
+++ new/Moo-2.002005/t/accessor-weaken-pre-5_8_3.t      2016-10-31 
01:06:02.000000000 +0100
@@ -1,10 +1,10 @@
 use Moo::_strictures;
-
+use File::Spec;
 BEGIN {
   $ENV{MOO_TEST_PRE_583} = 1;
 }
 
-(my $real_test = __FILE__) =~ s/-pre-5_8_3//;
+(my $real_test = File::Spec->rel2abs(__FILE__)) =~ s/-pre-5_8_3//;
 
 unless (defined do $real_test) {
     die "$real_test: $@" if $@;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/t/constructor-modify.t 
new/Moo-2.002005/t/constructor-modify.t
--- old/Moo-2.002004/t/constructor-modify.t     2016-04-14 13:24:25.000000000 
+0200
+++ new/Moo-2.002005/t/constructor-modify.t     2016-10-31 01:06:02.000000000 
+0100
@@ -1,5 +1,4 @@
 use Moo::_strictures;
-no warnings 'once';
 use Test::More;
 use Test::Fatal;
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/t/lib/InlineModule.pm 
new/Moo-2.002005/t/lib/InlineModule.pm
--- old/Moo-2.002004/t/lib/InlineModule.pm      2016-06-14 21:53:26.000000000 
+0200
+++ new/Moo-2.002005/t/lib/InlineModule.pm      2016-10-31 01:06:02.000000000 
+0100
@@ -36,12 +36,15 @@
     return $fh;
   }
   else {
-    return sub {
-      return 0 unless length $code;
-      $code =~ s/^([^\n]*\n?)//;
-      $_ = $1;
+    my $pos = 0;
+    my $last = length $code;
+    return (sub {
+      return 0 if $pos == $last;
+      my $next = (1 + index $code, "\n", $pos) || $last;
+      $_ .= substr $code, $pos, $next - $pos;
+      $pos = $next;
       return 1;
-    };
+    });
   }
 }
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/t/moo-object.t 
new/Moo-2.002005/t/moo-object.t
--- old/Moo-2.002004/t/moo-object.t     2016-06-14 21:53:26.000000000 +0200
+++ new/Moo-2.002005/t/moo-object.t     2016-10-31 01:06:02.000000000 +0100
@@ -2,8 +2,6 @@
 use Test::More;
 use Test::Fatal;
 
-no warnings 'once';
-
 {
   package MyClass;
   use base 'Moo::Object';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/t/no-moo.t new/Moo-2.002005/t/no-moo.t
--- old/Moo-2.002004/t/no-moo.t 2016-04-14 13:24:25.000000000 +0200
+++ new/Moo-2.002005/t/no-moo.t 2016-10-31 01:06:02.000000000 +0100
@@ -92,19 +92,15 @@
 
 ok(!GlobalConflict->can('extends'), 'extends cleaned');
 is(GlobalConflict->has, "has!", 'has left alone');
-{
-  no warnings 'once';
-  is($GlobalConflict::around, "has!", 'package global left alone');
-}
+
+is($GlobalConflict::around, "has!", 'package global left alone');
 
 ok(RollerTiny->can('around'), 'around left alone');
 is(RollerTiny->with, "with!", 'with left alone');
 
 ok(!GlobalConflict2->can('extends'), 'extends cleaned');
 is(GlobalConflict2->has, "has!", 'has left alone');
-{
-  no warnings 'once';
-  is($GlobalConflict2::after, "has!", 'package global left alone');
-}
+
+is($GlobalConflict2::after, "has!", 'package global left alone');
 
 done_testing;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/t/sub-defer-no-subname.t 
new/Moo-2.002005/t/sub-defer-no-subname.t
--- old/Moo-2.002004/t/sub-defer-no-subname.t   2016-06-14 21:53:26.000000000 
+0200
+++ new/Moo-2.002005/t/sub-defer-no-subname.t   2016-10-31 01:06:02.000000000 
+0100
@@ -4,6 +4,6 @@
   'Sub::Name' => undef,
   'Sub::Util' => undef,
 ;
-do 't/sub-defer.t';
+do './t/sub-defer.t';
 die $@
   if $@;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/t/sub-quote.t 
new/Moo-2.002005/t/sub-quote.t
--- old/Moo-2.002004/t/sub-quote.t      2016-06-21 19:41:21.000000000 +0200
+++ new/Moo-2.002005/t/sub-quote.t      2016-10-31 01:06:02.000000000 +0100
@@ -1,3 +1,15 @@
+BEGIN {
+  %^H = ();
+  my %clear_hints = sub { %{(caller(0))[10]||{}} }->();
+  $INC{'ClearHintsHash.pm'} = __FILE__;
+  package ClearHintsHash;
+  sub hints { %clear_hints }
+  sub import {
+    $^H |= 0x020000;
+    %^H = hints;
+  }
+}
+
 use Moo::_strictures;
 use Test::More;
 use Test::Fatal;
@@ -86,14 +98,34 @@
 
 like exception {
   quote_sub "${long}${long}::${long}", q{ return 1; };
-}, qr/^package name $long$long too long/,
+}, qr/^package name "$long$long" too long/,
   'over long package names error';
 
 like exception {
   quote_sub "${long}::${long}${long}", q{ return 1; };
-}, qr/^sub name $long$long too long/,
+}, qr/^sub name "$long$long" too long/,
   'over long sub names error';
 
+like exception {
+  quote_sub "got a space::gorp", q{ return 1; };
+}, qr/^package name "got a space" is not valid!/,
+  'packages with spaces are invalid';
+
+like exception {
+  quote_sub "Gorp::got a space", q{ return 1; };
+}, qr/^sub name "got a space" is not valid!/,
+  'sub names with spaces are invalid';
+
+like exception {
+  quote_sub "0welp::gorp", q{ return 1; };
+}, qr/^package name "0welp" is not valid!/,
+  'package names starting with numbers are not valid';
+
+like exception {
+  quote_sub "Gorp::0welp", q{ return 1; };
+}, qr/^sub name "0welp" is not valid!/,
+  'sub names starting with numbers are not valid';
+
 my $broken_quoted = quote_sub q{
   return 5<;
 };
@@ -189,10 +221,7 @@
 {
   my %hints;
   {
-    BEGIN {
-      $^H |= 0x020000;
-      %^H = ();
-    }
+    use ClearHintsHash;
     use UseHintHash;
     BEGIN { %hints = %^H }
   }
@@ -201,10 +230,7 @@
     local $TODO = 'hints hash from context not available on perl 5.8'
       if "$]" < 5.010_000;
 
-    BEGIN {
-      $^H |= 0x020000;
-      %^H = ();
-    }
+    use ClearHintsHash;
     use UseHintHash;
     is_deeply quote_sub(q{
       our %temp_hints_hash;
@@ -223,7 +249,7 @@
 }
 
 {
-  BEGIN { %^H = () }
+  use ClearHintsHash;
   my $sub = quote_sub(q{
     our %temp_hints_hash;
     BEGIN { %temp_hints_hash = %^H }
@@ -234,7 +260,8 @@
     my (undef, $code, $cap) = @{quoted_from_sub($sub)};
     quote_sub $code, $cap||();
   };
-  is_deeply $wrap_sub->(), {}, 'empty hints maintained when inlined';
+  is_deeply $wrap_sub->(), { ClearHintsHash::hints },
+    'empty hints maintained when inlined';
 }
 
 BEGIN {
@@ -254,7 +281,7 @@
   }
 }
 
-{
+TODO: {
   my ($options, $context_sub, $direct_val);
   {
     use BetterNumbers;
@@ -267,7 +294,7 @@
   is $direct_val, 11,
     'integer overload is working';
 
-  local $TODO = "refs in hints hash not yet implemented";
+  todo_skip "refs in hints hash not yet implemented", 4;
   {
     my $context_val;
     is exception { $context_val = $context_sub->() }, undef,
@@ -287,7 +314,7 @@
   }
 }
 
-{
+TODO: {
   my ($options, $context_sub, $direct_val);
   {
     use BetterNumbers +2;
@@ -300,7 +327,7 @@
   is $direct_val, 12,
     'closure integer overload is working';
 
-  local $TODO = "refs in hints hash not yet implemented";
+  todo_skip "refs in hints hash not yet implemented", 4;
 
   {
     my $context_val;
@@ -463,7 +490,6 @@
 }
 
 {
-  no warnings 'once';
   $Bar::baz = 3;
   my $inlined_code = inlinify q{
     package Bar;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/xt/handle_moose.t 
new/Moo-2.002005/xt/handle_moose.t
--- old/Moo-2.002004/xt/handle_moose.t  2016-04-14 13:24:06.000000000 +0200
+++ new/Moo-2.002005/xt/handle_moose.t  2016-10-31 01:06:02.000000000 +0100
@@ -1,7 +1,7 @@
 use Moo::_strictures;
 use Test::Fatal;
 
-BEGIN { require "t/moo-accessors.t"; }
+BEGIN { require "./t/moo-accessors.t"; }
 
 require Moose;
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/Moo-2.002004/xt/type-inflate-threads.t 
new/Moo-2.002005/xt/type-inflate-threads.t
--- old/Moo-2.002004/xt/type-inflate-threads.t  2016-04-14 13:24:06.000000000 
+0200
+++ new/Moo-2.002005/xt/type-inflate-threads.t  2016-10-31 01:06:02.000000000 
+0100
@@ -13,7 +13,6 @@
 my $str = sub {
   die unless defined $_[0] && !ref $_[0];
 };
-no warnings 'once';
 $Moo::HandleMoose::TYPE_MAP{$str} = sub {
   require Moose::Util::TypeConstraints;
   Moose::Util::TypeConstraints::find_type_constraint("Str");


Reply via email to