Hello community, here is the log from the commit of package libkolabxml for openSUSE:Factory checked in at 2016-12-01 10:24:38 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libkolabxml (Old) and /work/SRC/openSUSE:Factory/.libkolabxml.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libkolabxml" Changes: -------- --- /work/SRC/openSUSE:Factory/libkolabxml/libkolabxml.changes 2016-08-08 13:50:52.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.libkolabxml.new/libkolabxml.changes 2016-12-01 10:24:39.000000000 +0100 @@ -1,0 +2,20 @@ +Wed Nov 23 17:57:39 UTC 2016 - wba...@tmo.at + +- disable parallel build to hopefully fix random build failures + +------------------------------------------------------------------- +Wed Nov 16 14:31:32 UTC 2016 - a...@ajaissle.de + +- New upstream release 1.1.6 + + The created date is optional + +- New upstream release 1.1.5 + + Support audio alarms without an attachment + +- New upstream release 1.1.4 + + The tests require valid created dates + +- New upstream release 1.1.3 + + The "created" property must be a UTC date-time + +------------------------------------------------------------------- Old: ---- libkolabxml-1.1.2.tar.gz New: ---- libkolabxml-1.1.6.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libkolabxml.spec ++++++ --- /var/tmp/diff_new_pack.2THVZ2/_old 2016-12-01 10:24:40.000000000 +0100 +++ /var/tmp/diff_new_pack.2THVZ2/_new 2016-12-01 10:24:40.000000000 +0100 @@ -27,7 +27,7 @@ %global php_confdir %{_sysconfdir}/php5/conf.d %define libname %{name}1 Name: libkolabxml -Version: 1.1.2 +Version: 1.1.6 Release: 0 Summary: Kolab XML Format Schema Definitions Library License: LGPL-3.0+ @@ -244,7 +244,9 @@ .. %endif -make %{?_smp_mflags} +# parallel build is too unstable currently +#make %{?_smp_mflags} +make -j1 %install # cmake: with earlier releases, we have to change dir manually, as %%cmake_install is not available ++++++ libkolabxml-1.1.2.tar.gz -> libkolabxml-1.1.6.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libkolabxml-1.1.2/.arcconfig new/libkolabxml-1.1.6/.arcconfig --- old/libkolabxml-1.1.2/.arcconfig 1970-01-01 01:00:00.000000000 +0100 +++ new/libkolabxml-1.1.6/.arcconfig 2016-09-02 10:50:26.000000000 +0200 @@ -0,0 +1,3 @@ +{ + "phabricator.uri" : "https://git.kolab.org" +} diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libkolabxml-1.1.2/CMakeLists.txt new/libkolabxml-1.1.6/CMakeLists.txt --- old/libkolabxml-1.1.2/CMakeLists.txt 2015-11-25 12:36:44.000000000 +0100 +++ new/libkolabxml-1.1.6/CMakeLists.txt 2016-09-02 10:50:26.000000000 +0200 @@ -45,7 +45,7 @@ set (Libkolabxml_VERSION_MAJOR 1) set (Libkolabxml_VERSION_MINOR 1) # Enable the full x.y.z version only for release versions -set (Libkolabxml_VERSION_PATCH 2) +set (Libkolabxml_VERSION_PATCH 6) set (Libkolabxml_VERSION "${Libkolabxml_VERSION_MAJOR}.${Libkolabxml_VERSION_MINOR}.${Libkolabxml_VERSION_PATCH}" ) #set (Libkolabxml_VERSION "${Libkolabxml_VERSION_MAJOR}.${Libkolabxml_VERSION_MINOR}" ) @@ -66,7 +66,7 @@ COMMAND git archive --prefix=${SNAPSHOTARCHIVE_NAME}/ HEAD | bzip2 > ${CMAKE_BINARY_DIR}/${SNAPSHOTARCHIVE_NAME}.tar.bz2 WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}) - + #It's possible to make dist targets only using: #cmake -DDIST_ONLY=TRUE .. if (DIST_ONLY) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libkolabxml-1.1.2/src/containers/kolabcontainers.cpp new/libkolabxml-1.1.6/src/containers/kolabcontainers.cpp --- old/libkolabxml-1.1.2/src/containers/kolabcontainers.cpp 2015-11-25 12:36:44.000000000 +0100 +++ new/libkolabxml-1.1.6/src/containers/kolabcontainers.cpp 2016-09-02 10:50:26.000000000 +0200 @@ -637,6 +637,12 @@ { } +Alarm::Alarm(Alarm::Type type) +: d(new Alarm::Private) +{ + d->type = AudioAlarm; +} + Alarm::Alarm(const std::string &text) : d(new Alarm::Private) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libkolabxml-1.1.2/src/containers/kolabcontainers.h new/libkolabxml-1.1.6/src/containers/kolabcontainers.h --- old/libkolabxml-1.1.2/src/containers/kolabcontainers.h 2015-11-25 12:36:44.000000000 +0100 +++ new/libkolabxml-1.1.6/src/containers/kolabcontainers.h 2016-09-02 10:50:26.000000000 +0200 @@ -224,6 +224,7 @@ }; Alarm(); + Alarm(Type); Alarm(const Alarm &); ~Alarm(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libkolabxml-1.1.2/src/objectvalidation.cpp new/libkolabxml-1.1.6/src/objectvalidation.cpp --- old/libkolabxml-1.1.2/src/objectvalidation.cpp 2015-11-25 12:36:44.000000000 +0100 +++ new/libkolabxml-1.1.6/src/objectvalidation.cpp 2016-09-02 10:50:26.000000000 +0200 @@ -88,6 +88,11 @@ void validate(const Event &event) { + ASSERTVALID(event.created()); + if (event.created().isValid()) { + ASSERT(event.created().isUTC()); + ASSERT(!event.created().isDateOnly()); + } ASSERTEXISTING(event.start()); ASSERTVALID(event.start()); ASSERTVALID(event.end()); @@ -98,6 +103,11 @@ void validate(const Todo& todo) { + ASSERTVALID(todo.created()); + if (todo.created().isValid()) { + ASSERT(todo.created().isUTC()); + ASSERT(!todo.created().isDateOnly()); + } ASSERTVALID(todo.start()); ASSERTVALID(todo.due()); if (todo.start().isValid() && todo.due().isValid()) { @@ -107,6 +117,11 @@ void validate(const Journal& journal) { + ASSERTVALID(journal.created()); + if (journal.created().isValid()) { + ASSERT(journal.created().isUTC()); + ASSERT(!journal.created().isDateOnly()); + } ASSERTVALID(journal.start()); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libkolabxml-1.1.2/src/xcalconversions.h new/libkolabxml-1.1.6/src/xcalconversions.h --- old/libkolabxml-1.1.2/src/xcalconversions.h 2015-11-25 12:36:44.000000000 +0100 +++ new/libkolabxml-1.1.6/src/xcalconversions.h 2016-09-02 10:50:26.000000000 +0200 @@ -1353,7 +1353,9 @@ case Kolab::Alarm::AudioAlarm: p = std::auto_ptr<PropType>(new PropType(PropType::action_type(AUDIOALARM), trigger)); p->description(PropType::description_type(alarm.description())); - p->attach(fromAttachment(alarm.audioFile())); + if (alarm.audioFile().isValid()) { + p->attach(fromAttachment(alarm.audioFile())); + } break; default: ERROR("invalid alarm"); @@ -1401,16 +1403,17 @@ } alarm = Kolab::Alarm((*prop.summary()).text(), (*prop.description()).text(), attendees); } else if (prop.action().text() == AUDIOALARM) { - if (!prop.attach()) { - ERROR("audio file is missing"); - continue; - } - const Kolab::Attachment &attach = toAttachment<icalendar_2_0::properties::attach_type>(*prop.attach()); - if (!attach.isValid()) { - ERROR("audio file is invalid"); - continue; + if (prop.attach()) { + const Kolab::Attachment &attach = toAttachment<icalendar_2_0::properties::attach_type>(*prop.attach()); + if (!attach.isValid()) { + ERROR("audio file is invalid"); + continue; + } + alarm = Kolab::Alarm(attach); + } else { + //An audio alarm without an audio file is valid according to spec + alarm = Kolab::Alarm(Kolab::Alarm::AudioAlarm); } - alarm = Kolab::Alarm(attach); } else { ERROR("unknown alarm type " + prop.action().text()); continue; @@ -1877,7 +1880,7 @@ } typename KolabType::properties_type::created_type created; - if (incidence.created().isValid()) { + if (incidence.created().isValid() && !incidence.created().isDateOnly()) { created.date_time(fromDateTime(incidence.created())); } else { created.date_time(fromDateTime(timestamp())); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libkolabxml-1.1.2/tests/bindingstest.cpp new/libkolabxml-1.1.6/tests/bindingstest.cpp --- old/libkolabxml-1.1.2/tests/bindingstest.cpp 2015-11-25 12:36:44.000000000 +0100 +++ new/libkolabxml-1.1.6/tests/bindingstest.cpp 2016-09-02 10:50:26.000000000 +0200 @@ -334,11 +334,9 @@ Kolab::Alarm emailAlarm("ident", "value", att); emailAlarm.setStart(Kolab::cDateTime(2003,2,3,2,3,4, true)); alarms.push_back(emailAlarm); -// Kolab::Attachment audiofile; -// audiofile.setUri("ksdjlksdflj", "sdkljdfl"); -// Kolab::Alarm audio(audiofile); -// audio.setStart(Kolab::cDateTime(2003,2,3,2,3,4, true)); -// alarms.push_back(audio); + Kolab::Alarm audio(Kolab::Alarm::AudioAlarm); + audio.setStart(Kolab::cDateTime(2003,2,3,2,3,4, true)); + alarms.push_back(audio); ev.setAlarms(alarms); } @@ -415,6 +413,7 @@ void BindingsTest::eventDuration() { Kolab::Event ev; + ev.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC ev.setStart(Kolab::cDateTime("Europe/Zurich", 2006,1,8,12,0,0)); ev.setDuration(Kolab::Duration(11,22,33,44, true)); @@ -431,6 +430,7 @@ { Kolab::Event ev; ev.setUid("uid1"); + ev.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC ev.setStart(Kolab::cDateTime("Europe/Zurich", 2006,1,8,12,0,0)); std::vector<Kolab::Event> exceptions; Kolab::Event ex1; @@ -481,6 +481,7 @@ void BindingsTest::dueDateDateOnly() { Kolab::Todo ev; + ev.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC ev.setDue(Kolab::cDateTime(2006,1,8)); std::string result = Kolab::writeTodo(ev); QVERIFY(Kolab::error() == Kolab::NoError); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libkolabxml-1.1.2/tests/validationtest.cpp new/libkolabxml-1.1.6/tests/validationtest.cpp --- old/libkolabxml-1.1.2/tests/validationtest.cpp 2015-11-25 12:36:44.000000000 +0100 +++ new/libkolabxml-1.1.6/tests/validationtest.cpp 2016-09-02 10:50:26.000000000 +0200 @@ -34,6 +34,7 @@ void ValidationTest::testNoErrorOnValidEvent() { Event event; + event.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC event.setStart(cDateTime(2013,1,1,1,1,1)); writeEvent(event); QCOMPARE(Kolab::error(), Kolab::NoError); @@ -43,18 +44,21 @@ { { Todo todo; + todo.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC todo.setStart(cDateTime("Europe/Zurich", 2013,1,1,1,1,1)); writeTodo(todo); QCOMPARE(Kolab::error(), Kolab::NoError); } { Todo todo; + todo.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC todo.setDue(cDateTime("Europe/Zurich", 2013,1,1,1,1,1)); writeTodo(todo); QCOMPARE(Kolab::error(), Kolab::NoError); } { Todo todo; + todo.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC todo.setStart(cDateTime("Europe/Zurich", 2013,1,1,1,1,1)); todo.setDue(cDateTime("Europe/Zurich", 2013,1,1,1,1,1)); writeTodo(todo); @@ -65,6 +69,7 @@ void ValidationTest::testOlsonTimezone() { Event event; + event.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC event.setStart(cDateTime("Europe/Zurich",2013,1,1,1,1,1)); writeEvent(event); QCOMPARE(Kolab::error(), Kolab::NoError); @@ -73,12 +78,14 @@ void ValidationTest::testDifferentTimezones() { Event event; + event.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC event.setStart(cDateTime("Europe/Zurich",2013,1,1,1,1,1)); event.setEnd(cDateTime("Europe/London",2013,1,1,1,1,1)); writeEvent(event); QCOMPARE(Kolab::error(), Kolab::NoError); Todo todo; + todo.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC todo.setStart(cDateTime("Europe/Zurich",2013,1,1,1,1,1)); todo.setDue(cDateTime("Europe/London",2013,1,1,1,1,1)); writeTodo(todo); @@ -88,6 +95,7 @@ void ValidationTest::testUTCwithTimezone() { Event event; + event.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC cDateTime dt("Europe/Zurich",2013,1,1,1,1,1); dt.setUTC(true); event.setStart(dt); @@ -98,6 +106,7 @@ void ValidationTest::testTimezoneZ() { Event event; + event.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC event.setStart(cDateTime("Z",2013,1,1,1,1,1)); writeEvent(event); QCOMPARE(Kolab::error(), Kolab::Error); @@ -106,6 +115,7 @@ void ValidationTest::testWindowsTimezone() { Event event; + event.setCreated(Kolab::cDateTime(2006,1,6,12,0,0,true)); //UTC event.setStart(cDateTime("Central European Standard Time",2013,1,1,1,1,1)); writeEvent(event); QCOMPARE(Kolab::error(), Kolab::Error);