Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2017-01-29 10:40:27 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virt-manager" Changes: -------- --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2016-09-13 22:25:21.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new/virt-manager.changes 2017-02-03 20:04:29.355582577 +0100 @@ -1,0 +2,41 @@ +Thu Jan 26 16:41:16 MST 2017 - [email protected] + +- bsc#1022173 - virt-manager: unknown input device type + 'virtio1.0-input' + 1d2cd306-Fix-incorrect-usage-of-virtio-input.patch +- bsc#1005848 - KVM: guest can not be started on top of SLES12SP1 + KVM host ppc64 + 5a11cf07-virt-manager-generates-invalid-guest-XML.patch +- Upstream bug fixes + 617b9271-dont-return-virtio1.0-net-as-valid-device-name.patch + 7962672c-fix-error-checking-extra_args.patch + b4858842-fix-bad-version-check-regression.patch + f07a3021-fix-wait-to-behave-like-noautoconsole.patch + +------------------------------------------------------------------- +Wed Jan 18 15:36:46 MST 2017 - [email protected] + +- bsc#1005861 - virt-manager create new machine dialog box too + small to display system type + virtinst-expand-combobox.patch + +------------------------------------------------------------------- +Wed Jan 18 10:54:58 MST 2017 - [email protected] + +- bsc#976796 - Virt-manager does not show up in application menu + virtman-desktop.patch + virt-install.desktop + +------------------------------------------------------------------- +Fri Jan 13 11:38:11 MST 2017 - [email protected] + +- bsc#1010060 - virt-install won't start CASP installation + virtinst-add-casp-support.patch + +------------------------------------------------------------------- +Fri Jan 6 15:54:59 MST 2017 - [email protected] + +- bsc#1018645 - virt-manager is using pygrub for booting PV domU + virtinst-pvgrub2-bootloader.patch + +------------------------------------------------------------------- @@ -1514 +1555 @@ -- fate##314135: Support PVSCSI on XEN and VirtioSCSI on KVM - +- fate#314135: Support PVSCSI on XEN and VirtioSCSI on KVM - @@ -1516 +1557 @@ -- fate##313076: HBA passthrough for kvm +- fate#313076: HBA passthrough for kvm New: ---- 1d2cd306-Fix-incorrect-usage-of-virtio-input.patch 5a11cf07-virt-manager-generates-invalid-guest-XML.patch 617b9271-dont-return-virtio1.0-net-as-valid-device-name.patch 7962672c-fix-error-checking-extra_args.patch b4858842-fix-bad-version-check-regression.patch f07a3021-fix-wait-to-behave-like-noautoconsole.patch virtinst-add-casp-support.patch virtinst-expand-combobox.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ virt-manager.spec ++++++ --- /var/tmp/diff_new_pack.HmvZI7/_old 2017-02-03 20:04:31.043345014 +0100 +++ /var/tmp/diff_new_pack.HmvZI7/_new 2017-02-03 20:04:31.047344451 +0100 @@ -1,7 +1,7 @@ # # spec file for package virt-manager # -# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -21,7 +21,7 @@ %define qemu_user "qemu" %define libvirt_kvm_packages "" %define libvirt_xen_packages "" -%define preferred_distros "sles12sp2,opensuse42.2" +%define preferred_distros "sles12sp3,opensuse42.3" %define kvm_packages "" %define _version 1.4.0 %define _release 0 @@ -50,6 +50,12 @@ Patch11: 63784f4d-document-new-sysinfo-option.patch Patch12: 0425975f-use-virDomainMigrate3-API.patch Patch13: 561f5cd3-drop-xenmigr-scheme-from-Xen-migration-URI.patch +Patch14: 1d2cd306-Fix-incorrect-usage-of-virtio-input.patch +Patch15: 7962672c-fix-error-checking-extra_args.patch +Patch16: b4858842-fix-bad-version-check-regression.patch +Patch17: 5a11cf07-virt-manager-generates-invalid-guest-XML.patch +Patch18: 617b9271-dont-return-virtio1.0-net-as-valid-device-name.patch +Patch19: f07a3021-fix-wait-to-behave-like-noautoconsole.patch # SUSE Only Patch70: virtman-desktop.patch Patch71: virtman-kvm.patch @@ -75,6 +81,8 @@ Patch127: virtinst-set-qemu-emulator.patch Patch128: virtinst-add-ppc64-arch-support.patch Patch129: virtinst-s390x-disable-graphics.patch +Patch130: virtinst-add-casp-support.patch +Patch131: virtinst-expand-combobox.patch # Bug Fixes Patch150: virtman-prevent-double-click-starting-vm-twice.patch Patch151: virtman-increase-setKeepAlive-count.patch @@ -180,6 +188,12 @@ %patch11 -p1 %patch12 -p1 %patch13 -p1 +%patch14 -p1 +%patch15 -p1 +%patch16 -p1 +%patch17 -p1 +%patch18 -p1 +%patch19 -p1 # SUSE Only %patch70 -p1 %patch71 -p1 @@ -205,6 +219,8 @@ %patch127 -p1 %patch128 -p1 %patch129 -p1 +%patch130 -p1 +%patch131 -p1 # Bug Fixes %patch150 -p1 %patch151 -p1 ++++++ 1d2cd306-Fix-incorrect-usage-of-virtio-input.patch ++++++ Subject: osdict: Fix incorrect usage of virtio input From: Cole Robinson [email protected] Fri Jul 29 13:17:36 2016 -0400 Date: Fri Jul 29 13:17:36 2016 -0400: Git: 1d2cd306773064258f5d02c980b09a683ae77798 Regression reported with latest libosinfo, when the OS reports virtio-input support: http://www.redhat.com/archives/virt-tools-list/2016-July/msg00109.html Really our code presently only cares about the USB tablet, so adjust our libosinfo lookup to explicitly check for it Index: virt-manager-1.4.0/virtinst/guest.py =================================================================== --- virt-manager-1.4.0.orig/virtinst/guest.py +++ virt-manager-1.4.0/virtinst/guest.py @@ -1033,15 +1033,14 @@ class Guest(XMLBuilder): return False return all([c.model == "none" for c in controllers]) - input_type = self._os_object.default_inputtype() - input_bus = self._os_object.default_inputbus() + input_type = "mouse" + input_bus = "ps2" if self.os.is_xenpv(): input_type = VirtualInputDevice.TYPE_MOUSE input_bus = VirtualInputDevice.BUS_XEN - elif _usb_disabled() and input_bus == "usb": - input_bus = "ps2" - if input_type == "tablet": - input_type = "mouse" + elif self._os_object.supports_usbtablet() and not _usb_disabled(): + input_type = "tablet" + input_bus = "usb" for inp in self.get_devices("input"): if (inp.type == inp.TYPE_DEFAULT and Index: virt-manager-1.4.0/virtinst/osdict.py =================================================================== --- virt-manager-1.4.0.orig/virtinst/osdict.py +++ virt-manager-1.4.0/virtinst/osdict.py @@ -457,23 +457,19 @@ class _OsVariant(object): return devname return None - def default_inputtype(self): - if self._os: - fltr = libosinfo.Filter() - fltr.add_constraint("class", "input") - devs = self._os.get_all_devices(fltr) - if devs.get_length(): - return devs.get_nth(0).get_name() - return "mouse" + def supports_usbtablet(self): + if not self._os: + return False - def default_inputbus(self): - if self._os: - fltr = libosinfo.Filter() - fltr.add_constraint("class", "input") - devs = self._os.get_all_devices(fltr) - if devs.get_length(): - return devs.get_nth(0).get_bus_type() - return "ps2" + fltr = libosinfo.Filter() + fltr.add_constraint("class", "input") + fltr.add_constraint("name", "tablet") + devs = self._os.get_all_devices(fltr) + for idx in range(devs.get_length()): + dev = devs.get_nth(idx) + if devs.get_nth(idx).get_bus_type() == "usb": + return True + return False def supports_virtiodisk(self): if self._os: ++++++ 5a11cf07-virt-manager-generates-invalid-guest-XML.patch ++++++ Subject: virt-manager generates invalid guest XML From: Seeteena Thoufeek [email protected] Mon Dec 12 17:48:50 2016 +0530 Date: Mon Dec 12 21:12:09 2016 -0500: Git: 5a11cf0782998a36eef42718231bcb4c2de8ebba The virt-manager application generates invalid guest XML when a spapr-vio SCSI model controller is changed to a virtio-scsi model controller. 1. Create a guest 2. Add an spapr-vio controller to the guest via this gui path: ->Add Hardware ->Controller ->Type SCSI ->Model Hypervisor default At this point, there will be a valid spapr-vio SCSI controller defined: <controller type='scsi' index='0'> <address type='spapr-vio' reg='0x2000'/> </controller> 3.Now modify the above SCSI controller using this gui path: ->Choose "Controller sPAPR SCSI" on left pane ->Choose "VirtIO SCSI" for the Model on the right pane ->Apply At this point, there will be a SCSI controller definition which is invalid due to an incorrect address type: ~# virsh dumpxml dotg2|grep -A2 -i scsi <controller type='scsi' index='0' model='virtio-scsi'> <address type='spapr-vio' reg='0x2000'/> </controller> Any attempt to start the guest will throw this error: error: Failed to start domain dotg2 error: internal error: process exited while connecting to monitor: 2016-12-02T17:45:12.989165Z qemu-system-ppc64le: -device virtio-scsi-pci,id=scsi0,reg=0x2000: Property '.reg' not found virt-manager fails to realize that the address type needs to be changed to a PCI address for a virtio-scsi controller. If you change the model, you are supposed to leave the address field empty, so that libvirt sets it correctly. Or change the address field also appropriately. Note that this bug can be reproduced entirely within virt-manager. No manual editing of guest XML is being done here. So, fix is to make virt-manager delete the address field when the SCSI controller model is changed, allowing libvirt to automatically assign a new address with the correct type. Signed-off-by: Seeteena Thoufeek <[email protected]> Index: virt-manager-1.4.0/virtManager/domain.py =================================================================== --- virt-manager-1.4.0.orig/virtManager/domain.py +++ virt-manager-1.4.0/virtManager/domain.py @@ -949,6 +949,7 @@ class vmmDomain(vmmLibvirtObject): else: editdev.model = model + editdev.address.clear() self.hotplug(device=editdev) if model != _SENTINEL: ++++++ 617b9271-dont-return-virtio1.0-net-as-valid-device-name.patch ++++++ Subject: osdict: Don't return virtio1.0-net as a valid device name (bug 1399083) From: Cole Robinson [email protected] Tue Dec 13 12:58:14 2016 -0500 Date: Tue Dec 13 12:58:14 2016 -0500: Git: 617b92710f50015c5df5f9db15d25de18867957d We can't depend on libosinfo device names being valid libvirt network model names, so use a whitelist https://bugzilla.redhat.com/show_bug.cgi?id=1399083 Index: virt-manager-1.4.0/virtinst/osdict.py =================================================================== --- virt-manager-1.4.0.orig/virtinst/osdict.py +++ virt-manager-1.4.0/virtinst/osdict.py @@ -453,7 +453,7 @@ class _OsVariant(object): devs = self._os.get_all_devices(fltr) for idx in range(devs.get_length()): devname = devs.get_nth(idx).get_name() - if devname != "virtio-net": + if devname in ["pcnet", "ne2k_pci", "rtl8139", "e1000"]: return devname return None ++++++ 7962672c-fix-error-checking-extra_args.patch ++++++ Subject: virt-install: Fix error checking extra_args From: Cole Robinson [email protected] Wed Nov 2 10:27:14 2016 -0400 Date: Wed Nov 2 10:27:14 2016 -0400: Git: 7962672c713cf6d35e770f0d00068dee707b6ec9 Later bits in the code that want to warn based on extra_args content don't handle the None case. Be consistent and convert it to a list everywhere. Mentioned at https://bugzilla.redhat.com/show_bug.cgi?id=1376547#c9 Index: virt-manager-1.4.0/virt-install =================================================================== --- virt-manager-1.4.0.orig/virt-install +++ virt-manager-1.4.0/virt-install @@ -595,7 +595,8 @@ def build_guest_instance(conn, options): convert_old_os_options(options) # non-xml install options - guest.installer.extraargs = options.extra_args or [] + options.extra_args = options.extra_args or [] + guest.installer.extraargs = options.extra_args guest.installer.initrd_injections = options.initrd_inject guest.autostart = options.autostart ++++++ b4858842-fix-bad-version-check-regression.patch ++++++ Subject: virtinst: fix bad version check regression from 55327c81b7 From: Marc-André Lureau [email protected] Wed Nov 9 11:21:32 2016 +0400 Date: Mon Nov 14 09:03:30 2016 +0100: Git: b4858842f9e2f4f39ca81ad596fb777d11537a0f Signed-off-by: Marc-André Lureau <[email protected]> Index: virt-manager-1.4.0/virtinst/support.py =================================================================== --- virt-manager-1.4.0.orig/virtinst/support.py +++ virt-manager-1.4.0/virtinst/support.py @@ -312,9 +312,9 @@ SUPPORT_CONN_MEM_STATS_PERIOD = _make( function="virDomain.setMemoryStatsPeriod", version="1.1.1", hv_version={"qemu": 0}) SUPPORT_CONN_SPICE_GL = _make(version="1.3.3", - hv_version={"qemu": "2.7.92", "test": 0}) + hv_version={"qemu": "2.6.0", "test": 0}) SUPPORT_CONN_VIDEO_VIRTIO_ACCEL3D = _make(version="1.3.0", - hv_version={"qemu": "2.7.0", "test": 0}) + hv_version={"qemu": "2.5.0", "test": 0}) SUPPORT_CONN_GRAPHICS_LISTEN_NONE = _make(version="2.0.0") ++++++ f07a3021-fix-wait-to-behave-like-noautoconsole.patch ++++++ Subject: virt-install: fix --wait=0 to behave like --noautoconsole From: Pavel Hrdina [email protected] Wed Jan 18 13:11:43 2017 +0100 Date: Wed Jan 18 13:11:43 2017 +0100: Git: f07a3021d99298e3b157f6c18b880dcb3ac19b62 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1371781 Signed-off-by: Pavel Hrdina <[email protected]> Index: virt-manager-1.4.0/virt-install =================================================================== --- virt-manager-1.4.0.orig/virt-install +++ virt-manager-1.4.0/virt-install @@ -647,7 +647,7 @@ def build_guest_instance(conn, options): ########################### def start_install(guest, options): - if options.wait: + if options.wait is not None: wait_on_install = True wait_time = options.wait * 60 if "VIRTINST_TEST_SUITE" in os.environ and wait_time: ++++++ virt-install.desktop ++++++ --- /var/tmp/diff_new_pack.HmvZI7/_old 2017-02-03 20:04:31.239317430 +0100 +++ /var/tmp/diff_new_pack.HmvZI7/_new 2017-02-03 20:04:31.243316867 +0100 @@ -2,7 +2,7 @@ X-SuSE-translate=true X-SuSE-DocTeamID=ycc_xen Type=Application -Categories=Qt;X-SuSE-YaST;X-SuSE-YaST-Virtualization; +Categories=GTK;GNOME;System;Monitor;X-SuSE-YaST;X-SuSE-YaST-Virtualization; X-KDE-ModuleType=Library X-KDE-RootOnly=true ++++++ virtinst-add-casp-support.patch ++++++ References: bsc#1010060 Notes: SUSE Containers as a Service Platform and 'CASP' are not names set in stone yet and could change before the product ships. Index: virt-manager-1.4.0/virtinst/urlfetcher.py =================================================================== --- virt-manager-1.4.0.orig/virtinst/urlfetcher.py +++ virt-manager-1.4.0/virtinst/urlfetcher.py @@ -464,6 +464,10 @@ def _distroFromSUSEContent(fetcher, arch dclass = SLESDistro if distro_version is None: distro_version = ['VERSION', distribution[1].strip().rsplit(' ')[4]] + elif re.match(".*SUSE Containers as a Service Platform*", distribution[1]): + dclass = CASPDistro + if distro_version is None: + distro_version = ['VERSION', distribution[1].strip().rsplit(' ')[6]] elif re.match(".*openSUSE.*", distribution[1]): dclass = OpensuseDistro if distro_version is None: @@ -1019,7 +1023,8 @@ class SuseDistro(Distro): distro_version = self.version_from_content[1].strip() version = distro_version.split('.', 1)[0].strip() self.os_variant = self.urldistro - if int(version) >= 10: + version_int = int(version) + if version_int >= 10: if self.os_variant.startswith(("sles", "sled")): sp_version = None if len(distro_version.split('.', 1)) == 2: @@ -1033,6 +1038,8 @@ class SuseDistro(Distro): self.os_variant += "tumbleweed" else: self.os_variant += distro_version + elif version_int == 1 and self.os_variant.startswith("casp"): + self.os_variant = "casp" else: self.os_variant += "9" @@ -1079,6 +1086,9 @@ class SLESDistro(SuseDistro): class SLEDDistro(SuseDistro): urldistro = "sled" +class CASPDistro(SuseDistro): + urldistro = "casp" + # Suse image store is harder - we fetch the kernel RPM and a helper # RPM and then munge bits together to generate a initrd ++++++ virtinst-expand-combobox.patch ++++++ References: bsc#1005861 Notes: Just allow the GtkComboBox to be the width of the dialog so you can see more of the operating system name. Index: virt-manager-1.4.0/ui/create.ui =================================================================== --- virt-manager-1.4.0.orig/ui/create.ui +++ virt-manager-1.4.0/ui/create.ui @@ -1741,7 +1741,6 @@ is not yet supported.</small></pro <packing> <property name="left_attach">1</property> <property name="right_attach">2</property> - <property name="x_options">GTK_FILL</property> <property name="y_options"/> </packing> </child> ++++++ virtinst-pvgrub2-bootloader.patch ++++++ --- /var/tmp/diff_new_pack.HmvZI7/_old 2017-02-03 20:04:31.315306734 +0100 +++ /var/tmp/diff_new_pack.HmvZI7/_new 2017-02-03 20:04:31.315306734 +0100 @@ -13,9 +13,12 @@ - self.bootloader = "/usr/bin/pygrub" - self.os.clear() + os_ver = self._get_os_variant() -+ if os_ver.startswith("sles12") or os_ver.startswith("sled12") or \ -+ os_ver.startswith("opensuse13") or os_ver.startswith("opensuse42") or \ -+ os_ver.startswith("opensuse-tumbleweed"): ++ if os_ver.startswith("sles9") or \ ++ os_ver.startswith("sles10") or os_ver.startswith("sled10") or \ ++ os_ver.startswith("opensuse10") or os_ver.startswith("opensuse11"): ++ self.bootloader = "/usr/bin/pygrub" ++ self.os.clear() ++ else: + self.installer._install_kernel = "/usr/lib/grub2/x86_64-xen/grub.xen" + self.installer._install_initrd = None + self.installer.extraargs = None @@ -23,9 +26,6 @@ + # we are in an install phase. Add force_update param to call + self.installer.alter_bootconfig(self, True, True) + logging.info("Using grub.xen to boot guest") -+ else: -+ self.bootloader = "/usr/bin/pygrub" -+ self.os.clear() return self.get_xml_config() ++++++ virtinst-set-cache-mode-unsafe-for-install.patch ++++++ --- /var/tmp/diff_new_pack.HmvZI7/_old 2017-02-03 20:04:31.339303356 +0100 +++ /var/tmp/diff_new_pack.HmvZI7/_new 2017-02-03 20:04:31.339303356 +0100 @@ -23,8 +23,8 @@ if (not install and self.os.is_xenpv() and @@ -379,7 +390,10 @@ class Guest(XMLBuilder): - self.bootloader = "/usr/bin/pygrub" - self.os.clear() + self.installer.alter_bootconfig(self, True, True) + logging.info("Using grub.xen to boot guest") - return self.get_xml_config() + xml_config = self.get_xml_config() ++++++ virtinst-use-xenpae-kernel-for-32bit.patch ++++++ --- /var/tmp/diff_new_pack.HmvZI7/_old 2017-02-03 20:04:31.359300541 +0100 +++ /var/tmp/diff_new_pack.HmvZI7/_new 2017-02-03 20:04:31.359300541 +0100 @@ -8,7 +8,7 @@ =================================================================== --- virt-manager-1.4.0.orig/virtinst/urlfetcher.py +++ virt-manager-1.4.0/virtinst/urlfetcher.py -@@ -1012,8 +1012,12 @@ class SuseDistro(Distro): +@@ -1016,8 +1016,12 @@ class SuseDistro(Distro): "boot/%s/initrd" % self.arch)) # Matches Opensuse > 10.2 and sles 10 ++++++ virtinst-vol-default-nocow.patch ++++++ --- /var/tmp/diff_new_pack.HmvZI7/_old 2017-02-03 20:04:31.371298853 +0100 +++ /var/tmp/diff_new_pack.HmvZI7/_new 2017-02-03 20:04:31.371298853 +0100 @@ -27,7 +27,7 @@ +++ virt-manager-1.4.0/virtinst/support.py @@ -316,6 +316,8 @@ SUPPORT_CONN_SPICE_GL = _make(version="1 SUPPORT_CONN_VIDEO_VIRTIO_ACCEL3D = _make(version="1.3.0", - hv_version={"qemu": "2.7.0", "test": 0}) + hv_version={"qemu": "2.5.0", "test": 0}) SUPPORT_CONN_GRAPHICS_LISTEN_NONE = _make(version="2.0.0") +SUPPORT_CONN_NOCOW = _make( + version="1.2.18", hv_version={"qemu": "2.2.0", "test": 0}) ++++++ virtman-desktop.patch ++++++ --- /var/tmp/diff_new_pack.HmvZI7/_old 2017-02-03 20:04:31.407293786 +0100 +++ /var/tmp/diff_new_pack.HmvZI7/_new 2017-02-03 20:04:31.411293223 +0100 @@ -16,7 +16,7 @@ Terminal=false -Categories=System; +Encoding=UTF-8 -+Categories=GTK;GNOME;System;Monitor;Qt;X-SuSE-YaST;X-SuSE-YaST-Virtualization; ++Categories=GTK;GNOME;System;Monitor;X-SuSE-YaST;X-SuSE-YaST-Virtualization; +X-KDE-ModuleType=Library +X-KDE-RootOnly=true +X-KDE-HasReadOnlyMode=false
