Hello community,
here is the log from the commit of package perl-Log-Dispatch-FileRotate for
openSUSE:Factory checked in at 2017-02-16 17:07:34
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-Log-Dispatch-FileRotate (Old)
and /work/SRC/openSUSE:Factory/.perl-Log-Dispatch-FileRotate.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Log-Dispatch-FileRotate"
Changes:
--------
---
/work/SRC/openSUSE:Factory/perl-Log-Dispatch-FileRotate/perl-Log-Dispatch-FileRotate.changes
2017-01-22 00:21:17.153843092 +0100
+++
/work/SRC/openSUSE:Factory/.perl-Log-Dispatch-FileRotate.new/perl-Log-Dispatch-FileRotate.changes
2017-02-16 17:07:35.418289082 +0100
@@ -1,0 +2,22 @@
+Wed Feb 15 06:57:18 UTC 2017 - [email protected]
+
+- updated to 1.24
+ see /usr/share/doc/packages/perl-Log-Dispatch-FileRotate/Changes
+
+ 1.24 Tue Feb 14 2017
+ - fix test failure on file-open-failure.t related to current locale
+ setting.
+ - improve fix to Date::Manip TZ deprecation warnings.
+
+-------------------------------------------------------------------
+Mon Feb 13 12:21:18 UTC 2017 - [email protected]
+
+- updated to 1.23
+ see /usr/share/doc/packages/perl-Log-Dispatch-FileRotate/Changes
+
+ 1.23 Thu Feb 09 2017
+ - Issue a warning if the lockfile cannot be opened (Thanks KGOESS)
+ [#63544]
+ - Fix POD typo (Thanks Anirvan Chatterjee)
+
+-------------------------------------------------------------------
Old:
----
Log-Dispatch-FileRotate-1.22.tar.gz
New:
----
Log-Dispatch-FileRotate-1.24.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ perl-Log-Dispatch-FileRotate.spec ++++++
--- /var/tmp/diff_new_pack.IkMRHN/_old 2017-02-16 17:07:35.986208722 +0100
+++ /var/tmp/diff_new_pack.IkMRHN/_new 2017-02-16 17:07:35.994207590 +0100
@@ -1,7 +1,7 @@
#
# spec file for package perl-Log-Dispatch-FileRotate
#
-# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,14 +17,14 @@
Name: perl-Log-Dispatch-FileRotate
-Version: 1.22
+Version: 1.24
Release: 0
%define cpan_name Log-Dispatch-FileRotate
Summary: Log to Files that Archive/Rotate Themselves
License: Artistic-1.0 or GPL-1.0+
Group: Development/Libraries/Perl
Url: http://search.cpan.org/dist/Log-Dispatch-FileRotate/
-Source0:
http://www.cpan.org/authors/id/M/MS/MSCHOUT/%{cpan_name}-%{version}.tar.gz
+Source0:
https://cpan.metacpan.org/authors/id/M/MS/MSCHOUT/%{cpan_name}-%{version}.tar.gz
Source1: cpanspec.yml
BuildArch: noarch
BuildRoot: %{_tmppath}/%{name}-%{version}-build
@@ -36,6 +36,7 @@
BuildRequires: perl(Params::Validate)
BuildRequires: perl(Path::Tiny) >= 0.018
BuildRequires: perl(Test::More) >= 0.88
+BuildRequires: perl(Test::Warn)
BuildRequires: perl(version)
Requires: perl(Date::Manip)
Requires: perl(Log::Dispatch::File)
@@ -84,7 +85,7 @@
to the same time, and if your recurrences aren't too close together all
should sync up just nicely.
-I initially aasumed a long runinng process but it seems people are using
+I initially assumed a long running process but it seems people are using
this module as part of short running CGI programs. So, now we look at the
last modified time stamp of the log file and compare it to a previous
occurance of a DatePattern, on startup only. If the file stat shows the
@@ -111,6 +112,7 @@
%files -f %{name}.files
%defattr(-,root,root,755)
-%doc Changes LICENSE README
+%doc Changes README
+%license LICENSE
%changelog
++++++ Log-Dispatch-FileRotate-1.22.tar.gz ->
Log-Dispatch-FileRotate-1.24.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.22/Changes
new/Log-Dispatch-FileRotate-1.24/Changes
--- old/Log-Dispatch-FileRotate-1.22/Changes 2016-10-06 14:54:46.000000000
+0200
+++ new/Log-Dispatch-FileRotate-1.24/Changes 2017-02-14 18:10:50.000000000
+0100
@@ -1,5 +1,15 @@
Revision history for Perl extension Log::Dispatch::FileRotate.
+1.24 Tue Feb 14 2017
+ - fix test failure on file-open-failure.t related to current locale
+ setting.
+ - improve fix to Date::Manip TZ deprecation warnings.
+
+1.23 Thu Feb 09 2017
+ - Issue a warning if the lockfile cannot be opened (Thanks KGOESS)
+ [#63544]
+ - Fix POD typo (Thanks Anirvan Chatterjee)
+
1.22 Thu Oct 06 2016
- Fix minor POD error (Thanks Matthias Schmitz) [#47665]
- Remove Log::Log4perl dependency. The tests now use Log::Dispatch
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.22/MANIFEST
new/Log-Dispatch-FileRotate-1.24/MANIFEST
--- old/Log-Dispatch-FileRotate-1.22/MANIFEST 2016-10-06 14:54:46.000000000
+0200
+++ new/Log-Dispatch-FileRotate-1.24/MANIFEST 2017-02-14 18:10:50.000000000
+0100
@@ -11,6 +11,8 @@
lib/Log/Dispatch/FileRotate.pm
t/author-pod-syntax.t
t/basic.t
+t/file-open-failure.t
+t/lockfile-open-failure.t
t/no-activity-bug.t
t/signature.t
t/size-with-underscore.t
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.22/META.json
new/Log-Dispatch-FileRotate-1.24/META.json
--- old/Log-Dispatch-FileRotate-1.22/META.json 2016-10-06 14:54:46.000000000
+0200
+++ new/Log-Dispatch-FileRotate-1.24/META.json 2017-02-14 18:10:50.000000000
+0100
@@ -40,9 +40,11 @@
},
"test" : {
"requires" : {
+ "POSIX" : "0",
"Path::Tiny" : "0.018",
"Socket" : "0",
"Test::More" : "0.88",
+ "Test::Warn" : "0",
"warnings" : "0"
}
}
@@ -60,6 +62,6 @@
"web" : "https://github.com/mschout/perl-log-dispatch-filerotate";
}
},
- "version" : "1.22"
+ "version" : "1.24"
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.22/META.yml
new/Log-Dispatch-FileRotate-1.24/META.yml
--- old/Log-Dispatch-FileRotate-1.22/META.yml 2016-10-06 14:54:46.000000000
+0200
+++ new/Log-Dispatch-FileRotate-1.24/META.yml 2017-02-14 18:10:50.000000000
+0100
@@ -3,9 +3,11 @@
author:
- 'Michael Schout <[email protected]>'
build_requires:
+ POSIX: '0'
Path::Tiny: '0.018'
Socket: '0'
Test::More: '0.88'
+ Test::Warn: '0'
warnings: '0'
configure_requires:
ExtUtils::MakeMaker: '0'
@@ -31,4 +33,4 @@
bugtracker:
http://rt.cpan.org/Public/Dist/Display.html?Name=Log-Dispatch-FileRotate
homepage: http://search.cpan.org/dist/Log-Dispatch-FileRotate/
repository: git://github.com/mschout/perl-log-dispatch-filerotate.git
-version: '1.22'
+version: '1.24'
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.22/Makefile.PL
new/Log-Dispatch-FileRotate-1.24/Makefile.PL
--- old/Log-Dispatch-FileRotate-1.22/Makefile.PL 2016-10-06
14:54:46.000000000 +0200
+++ new/Log-Dispatch-FileRotate-1.24/Makefile.PL 2017-02-14
18:10:50.000000000 +0100
@@ -28,12 +28,14 @@
"version" => 0
},
"TEST_REQUIRES" => {
+ "POSIX" => 0,
"Path::Tiny" => "0.018",
"Socket" => 0,
"Test::More" => "0.88",
+ "Test::Warn" => 0,
"warnings" => 0
},
- "VERSION" => "1.22",
+ "VERSION" => "1.24",
"test" => {
"TESTS" => "t/*.t"
}
@@ -46,10 +48,12 @@
"File::Spec" => 0,
"Log::Dispatch::File" => 0,
"Log::Dispatch::Output" => 0,
+ "POSIX" => 0,
"Params::Validate" => 0,
"Path::Tiny" => "0.018",
"Socket" => 0,
"Test::More" => "0.88",
+ "Test::Warn" => 0,
"base" => 0,
"strict" => 0,
"version" => 0,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.22/README
new/Log-Dispatch-FileRotate-1.24/README
--- old/Log-Dispatch-FileRotate-1.22/README 2016-10-06 14:54:46.000000000
+0200
+++ new/Log-Dispatch-FileRotate-1.24/README 2017-02-14 18:10:50.000000000
+0100
@@ -1,7 +1,7 @@
This archive contains the distribution Log-Dispatch-FileRotate,
-version 1.22:
+version 1.24:
Log to Files that Archive/Rotate Themselves
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.22/SIGNATURE
new/Log-Dispatch-FileRotate-1.24/SIGNATURE
--- old/Log-Dispatch-FileRotate-1.22/SIGNATURE 2016-10-06 14:54:46.000000000
+0200
+++ new/Log-Dispatch-FileRotate-1.24/SIGNATURE 2017-02-14 18:10:50.000000000
+0100
@@ -12,26 +12,38 @@
not run its Makefile.PL or Build.PL.
-----BEGIN PGP SIGNED MESSAGE-----
-Hash: SHA1
+Hash: SHA256
-SHA1 94877fd1e4cf9461845bf1dce8e5cb2920172650 Changes
+SHA1 05a324815725beaf4ce0b9dbd64b40def50d66a0 Changes
SHA1 bab88f54ea8c7c2588e407bd69fad8bf7cb47c1b LICENSE
-SHA1 064231404ee56e6ea6db4c85b43301b53e82e506 MANIFEST
+SHA1 3381e008362a610e8ef87a3c844e6d80d448786d MANIFEST
SHA1 57044ee7c79261d69db3e0748bb9fb2470a6a0cb MANIFEST.SKIP
-SHA1 f813190c0783f47bfacbfc1021a22f0fe95924ac META.json
-SHA1 15e9bc50e45ce487ca16555c1106471c496731bf META.yml
-SHA1 55b91314cf3490ef9e40f56f8cb9e605d26e0c90 Makefile.PL
-SHA1 486e888c2eb75d877155881f3f177d66864457ae README
-SHA1 6d0e2d6b0582ce4a07bd6b34010eb077506ca551 lib/Log/Dispatch/FileRotate.pm
+SHA1 55266412c5bbda5acaf00b2005582074aca1c55a META.json
+SHA1 c63d530dd31d04b3172433207e81c5fd6e46d5ca META.yml
+SHA1 614d33ae96c61e587b21ecc13868d9e500c1e735 Makefile.PL
+SHA1 b5ebbd8be0cfed0d6db558e05cfbc971d7c3a837 README
+SHA1 20142ca41ebcf6af4ff3e068a3c3849233e721a4 lib/Log/Dispatch/FileRotate.pm
SHA1 d2eebabfd34d330bd59043a4b6879faf4de7229d t/author-pod-syntax.t
SHA1 1b0ff3264a10a8bbb678cc7cbec943d838fc7677 t/basic.t
+SHA1 adabd981c505aa6cc53905317f745cf8bbbd24f0 t/file-open-failure.t
+SHA1 42bc20584eda94b456d93d255375b8f30a00d10a t/lockfile-open-failure.t
SHA1 ebfd5c0be8646d1e8c43515c5b745a63d3815955 t/no-activity-bug.t
SHA1 f0c37746e0277de1ddb62c9227628a5ebe5a777a t/signature.t
SHA1 11e859568dfce86bbb2d75c0eb902199aa23fa7e t/size-with-underscore.t
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
-iD8DBQFX9kmW+CqvSzp9LOwRAqhEAJ44CS38D+sFzb6Gj0A+/oYiDSXTVgCePWHa
-LuqGwlXPcf4TEiBReecsi+Y=
-=u/Qu
+iQIVAwUBWKM6GqQl27WkM10aAQg4yg//UrwJ5mqIVcUWIUujrIMbu1e/vjRccGPG
+VVvuDi/1k7HLWl8HilQGy+v9rgoLcEbrk2Y6YYGCaGqXs8XCRF0ip5/M2fAhqLp/
+Vtk4ZFOb12rlDiO9XPw2kOOvCQ1NXTN5sEVd5MddxnplnfZE6CkLRvY7GHIzGPjq
+2kwtJtVe9U9CCo3H38O6Ipg9gLxBpjUQg37CNyJlG4cpPKyNPq+85dYY4PLOsuyk
+3YYYfLQQdZboVTwZCeC1fGK+RlnY+Q4rB6owYjFt/79JsbMBNxuv1Bs4J6IBty70
+zSU653giVwkYtgGP1ki04S/JcIJpvczjbXZpsWyUxTmLmtt1hfhjaOTN3jo3Zltr
+PgMwWGeES6VYVLBEp9sqKOL/n5UzIhgBSh7X6vTMhCtAykavabljiArQmtQdYr42
+9I0mHqpw5+wByCxEqN/BtsiPvcMl4/BVs24IbTlkJ9lIqe4Holt78NEu+HjQJeQA
++LUCvBHjdDCG5qC8v/cwoR+LLPqx9wsGIySvXn3EJxMY2dwUxuZW/VPwkMxrgGPS
+lfqH6jN202t9JkD7WTm5nMdoaLZv2lfv0iwxD37dNEfNdOOnJRG7lRdM9bMfAx2Z
+3kBYsuINk5sJEFVg2bQ+EaS5YvDt8Pzg2GF27x/breJ6be7roYtmE8B5Oa1RTKMa
+Nv3N0aLvrbM=
+=WGvZ
-----END PGP SIGNATURE-----
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Log-Dispatch-FileRotate-1.22/lib/Log/Dispatch/FileRotate.pm
new/Log-Dispatch-FileRotate-1.24/lib/Log/Dispatch/FileRotate.pm
--- old/Log-Dispatch-FileRotate-1.22/lib/Log/Dispatch/FileRotate.pm
2016-10-06 14:54:46.000000000 +0200
+++ new/Log-Dispatch-FileRotate-1.24/lib/Log/Dispatch/FileRotate.pm
2017-02-14 18:10:50.000000000 +0100
@@ -1,5 +1,5 @@
package Log::Dispatch::FileRotate;
-$Log::Dispatch::FileRotate::VERSION = '1.22';
+$Log::Dispatch::FileRotate::VERSION = '1.24';
# ABSTRACT: Log to Files that Archive/Rotate Themselves
require 5.005;
@@ -74,7 +74,7 @@
# compat with 5.8, we use TZ if setdate is not avilable.
Otherwise we
# use setdate.
require version;
- if (version->parse($Date::Manip::VERSION) <
version->parse('6.0'))
+ if (version->parse(DateManipVersion()) < version->parse('6.0'))
{
Date_Init("TZ=".$p{'TZ'});
}
@@ -207,7 +207,7 @@
warn "$$ waiting on lock\n" if $self->{debug};
unless($self->lfhlock())
{
- warn "$$ failed to get lock. returning\n" if
$self->{debug};
+ warn "$$ Log::Dispatch::FileRotate failed to get lock:
", $self->{_lfhlock_test_err}, ". Not logging.\n";
return;
}
warn "$$ got lock after wait\n" if $self->{debug};
@@ -293,7 +293,7 @@
# Clean up locks
close $self->{lfh} if $self->{lfh};
- unlink $self->{lf} if -f $self->{lf};
+ unlink $self->{lf} if $self->{lf} && -f $self->{lf};
}
sub logit
@@ -627,6 +627,7 @@
}
else
{
+ $self->{_lfhlock_test_err} = "couldn't lock $self->{lf}: $!";
$self->{lfh} = 0;
warn "$$ couldn't get lock on Lock File\n" if $self->{debug};
return 0;
@@ -676,7 +677,7 @@
=head1 VERSION
-version 1.22
+version 1.24
=head1 SYNOPSIS
@@ -743,7 +744,7 @@
close to the same time, and if your recurrences aren't too close together
all should sync up just nicely.
-I initially aasumed a long runinng process but it seems people are using
+I initially assumed a long running process but it seems people are using
this module as part of short running CGI programs. So, now we look at the
last modified time stamp of the log file and compare it to a previous
occurance of a DatePattern, on startup only. If the file stat shows
@@ -767,11 +768,11 @@
=item -- size ($)
-The maxium (or close to) size the log file can grow too.
+The maximum (or close to) size the log file can grow too.
=item -- max ($)
-The maxium number of log files to create.
+The maximum number of log files to create.
=item -- TZ ($)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Log-Dispatch-FileRotate-1.22/t/file-open-failure.t
new/Log-Dispatch-FileRotate-1.24/t/file-open-failure.t
--- old/Log-Dispatch-FileRotate-1.22/t/file-open-failure.t 1970-01-01
01:00:00.000000000 +0100
+++ new/Log-Dispatch-FileRotate-1.24/t/file-open-failure.t 2017-02-14
18:10:50.000000000 +0100
@@ -0,0 +1,57 @@
+#!/usr/bin/env perl -w
+#
+# Test case for what happens when filename cannot be written to
+#
+
+use strict;
+use warnings;
+use Test::More 0.88;
+use Path::Tiny 0.018;
+use Test::Warn;
+
+# we need to make sure we are in the correct locale so that we get "Permission
+# denied" as the error message, not a translation of that into another locale
+
+unless (eval { require POSIX; 1 }) {
+ plan skip_all => 'POSIX module is required for this test';
+}
+
+my $locale = 'en_US.UTF-8';
+my $curloc = POSIX::setlocale(&POSIX::LC_ALL, $locale) || '';
+unless ($curloc eq $locale) {
+ plan skip_all => "locale $locale is not available on this system";
+}
+
+use_ok 'Log::Dispatch::FileRotate';
+
+my $tempdir = Path::Tiny->tempdir;
+
+# Create a file that isn't writable
+my $filename = $tempdir->child('myerrs.log')->stringify;
+open my $o, '>', $filename;
+close $o;
+chmod 0, $filename;
+
+warning_is(
+ sub {
+ my $file_logger = eval {
+ Log::Dispatch::FileRotate->new(
+ filename => $filename,
+ min_level => 'debug',
+ mode => 'append',
+ max => 5,
+ newline => 0,
+ DatePattern => 'YYYY-dd-HH');
+ };
+
+ like(
+ $@,
+ qr/Cannot write to '.*myerrs.log': Permission denied/,
+ 'Expect a "Permission denied" error'
+ );
+ },
+ undef,
+ 'No warnings from using an unwritable filename'
+);
+
+done_testing;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Log-Dispatch-FileRotate-1.22/t/lockfile-open-failure.t
new/Log-Dispatch-FileRotate-1.24/t/lockfile-open-failure.t
--- old/Log-Dispatch-FileRotate-1.22/t/lockfile-open-failure.t 1970-01-01
01:00:00.000000000 +0100
+++ new/Log-Dispatch-FileRotate-1.24/t/lockfile-open-failure.t 2017-02-14
18:10:50.000000000 +0100
@@ -0,0 +1,49 @@
+#!/usr/bin/env perl
+#
+# Test case for what happens when lockfile cannot be opened
+#
+
+use strict;
+use warnings;
+use Test::More 0.88;
+use Path::Tiny 0.018;
+use Test::Warn;
+
+use_ok 'Log::Dispatch';
+use_ok 'Log::Dispatch::FileRotate';
+
+my $tempdir = Path::Tiny->tempdir;
+
+my $dispatcher = Log::Dispatch->new;
+isa_ok $dispatcher, 'Log::Dispatch';
+
+my $file_logger = Log::Dispatch::FileRotate->new(
+ filename => $tempdir->child('myerrs.log')->stringify,
+ min_level => 'debug',
+ mode => 'append',
+ max => 5,
+ newline => 0,
+ DatePattern => 'YYYY-dd-HH');
+
+isa_ok $file_logger, 'Log::Dispatch::FileRotate';
+
+$dispatcher->add($file_logger);
+
+$dispatcher->info('write with successful lock');
+
+my $lockfile = $file_logger->{lf};
+
+# make the lockfile unwriteable
+chmod 0, $lockfile;
+
+warning_like {
+ $dispatcher->info('Write with unsuccessful lock');
+} qr/\d+ Log::Dispatch::FileRotate failed to get lock/;
+
+open my $fh, '<', $tempdir->child('myerrs.log')->stringify or die "can't open
logfile: $!";
+my $content = do { local $/ = undef; <$fh> };
+is $content, 'write with successful lock';
+
+chmod 0644, $lockfile;
+
+done_testing;
