Hello community,
here is the log from the commit of package yast2-iscsi-client for
openSUSE:Factory checked in at 2017-03-03 17:33:56
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-iscsi-client (Old)
and /work/SRC/openSUSE:Factory/.yast2-iscsi-client.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-iscsi-client"
Fri Mar 3 17:33:56 2017 rev:114 rq:461281 version:3.1.30
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-iscsi-client/yast2-iscsi-client.changes
2016-07-12 23:44:59.000000000 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-iscsi-client.new/yast2-iscsi-client.changes
2017-03-03 17:33:57.310831027 +0100
@@ -1,0 +2,6 @@
+Thu Feb 22 17:25:23 CEST 2017 - [email protected]
+
+- Fate#318832, redesign authentication UI and online help.
+- 3.1.30
+
+-------------------------------------------------------------------
Old:
----
yast2-iscsi-client-3.1.29.tar.bz2
New:
----
yast2-iscsi-client-3.1.30.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-iscsi-client.spec ++++++
--- /var/tmp/diff_new_pack.iWNcYN/_old 2017-03-03 17:33:58.154711790 +0100
+++ /var/tmp/diff_new_pack.iWNcYN/_new 2017-03-03 17:33:58.154711790 +0100
@@ -1,7 +1,7 @@
#
# spec file for package yast2-iscsi-client
#
-# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
Name: yast2-iscsi-client
-Version: 3.1.29
+Version: 3.1.30
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
++++++ yast2-iscsi-client-3.1.29.tar.bz2 -> yast2-iscsi-client-3.1.30.tar.bz2
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-iscsi-client-3.1.29/.travis.yml
new/yast2-iscsi-client-3.1.30/.travis.yml
--- old/yast2-iscsi-client-3.1.29/.travis.yml 2016-07-05 14:01:20.885198991
+0200
+++ new/yast2-iscsi-client-3.1.30/.travis.yml 2017-02-28 11:34:51.090707588
+0100
@@ -1,16 +1,11 @@
-language: cpp
-compiler:
- - gcc
+sudo: required
+language: bash
+services:
+ - docker
+
before_install:
- # disable rvm, use system Ruby
- - rvm reset
- - wget
https://raw.githubusercontent.com/yast/yast-devtools/master/travis-tools/travis_setup.sh
- - sh ./travis_setup.sh -p "rake yast2-devtools yast2-testsuite yast2" -g
"rspec:3.3.0 yast-rake gettext"
+ - docker build -t yast-iscsi-client-image .
script:
- - rake check:syntax
- - rake check:pot
- - make -f Makefile.cvs
- - make
- - sudo make install
- - make check
-
+ # the "yast-travis-ruby" script is included in the base yastdevel/ruby image
+ # see https://github.com/yast/docker-yast-ruby/blob/master/yast-travis-ruby
+ - docker run -it -e TRAVIS=1 -e TRAVIS_JOB_ID="$TRAVIS_JOB_ID"
yast-iscsi-client-image yast-travis-ruby
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-iscsi-client-3.1.29/CONTRIBUTING.md
new/yast2-iscsi-client-3.1.30/CONTRIBUTING.md
--- old/yast2-iscsi-client-3.1.29/CONTRIBUTING.md 2016-07-05
14:01:20.897198991 +0200
+++ new/yast2-iscsi-client-3.1.30/CONTRIBUTING.md 2017-02-28
11:34:51.090707588 +0100
@@ -3,7 +3,7 @@
YaST is an open source project and as such it welcomes all kinds of
contributions. If you decide to contribute, please follow these guidelines to
-ensure the process is effective and pleasant both for you and YaST maintainers.
+ensure the process is effective and pleasant both for you and the YaST
maintainers.
There are two main forms of contribution: reporting bugs and performing code
changes.
@@ -17,13 +17,11 @@
registration](https://secure-www.novell.com/selfreg/jsp/createSimpleAccount.jsp)
if you don't have an account yet.)
-If you find a problem, please report it either using
-[Bugzilla](https://bugzilla.suse.com/) or GitHub issues. We can't guarantee
-that every bug will be fixed, but we'll try.
-
When creating a bug report, please follow our [bug reporting
guidelines](http://en.opensuse.org/openSUSE:Report_a_YaST_bug).
+We can't guarantee that every bug will be fixed, but we'll try.
+
Code Changes
------------
@@ -44,15 +42,22 @@
to the [Ruby style
guide](https://github.com/SUSE/style-guides/blob/master/Ruby.md).
- 4. Make sure your change didn't break anything by building the RPM package
+ 4. Update the package version (in `packages/*.spec`, usually by
+ `rake version:bump`) and add a new entry to the `package/*.changes` file
+ (by `osc vc package`).
+ For bigger changes or changes which need longer discussion it is advised
to
+ add this as a separate last commit so it can be easily updated when
another
+ change is merged in the meantime.
+
+ 5. Make sure your change didn't break anything by building the RPM package
(`rake osc:build`). The build process includes running the full testsuite.
- 5. Publish the branch and create a pull request.
+ 6. Publish the branch and create a pull request.
- 6. YaST developers will review your change and possibly point out issues.
+ 7. YaST developers will review your change and possibly point out issues.
Adapt the code under their guidance until they are all resolved.
- 7. Finally, the pull request will get merged or rejected.
+ 8. Finally, the pull request will get merged or rejected.
See also [GitHub's guide on
contributing](https://help.github.com/articles/fork-a-repo).
@@ -60,9 +65,6 @@
If you want to do multiple unrelated changes, use separate branches and pull
requests.
-Do not change the `VERSION` and `*.changes` files as this could lead to
-conflicts.
-
### Commits
Each commit in the pull request should do only one thing, which is clearly
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-iscsi-client-3.1.29/Dockerfile
new/yast2-iscsi-client-3.1.30/Dockerfile
--- old/yast2-iscsi-client-3.1.29/Dockerfile 1970-01-01 01:00:00.000000000
+0100
+++ new/yast2-iscsi-client-3.1.30/Dockerfile 2017-02-28 11:34:51.110707588
+0100
@@ -0,0 +1,3 @@
+FROM yastdevel/ruby
+COPY . /usr/src/app
+
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-client-3.1.29/package/yast2-iscsi-client.changes
new/yast2-iscsi-client-3.1.30/package/yast2-iscsi-client.changes
--- old/yast2-iscsi-client-3.1.29/package/yast2-iscsi-client.changes
2016-07-05 14:01:20.937198991 +0200
+++ new/yast2-iscsi-client-3.1.30/package/yast2-iscsi-client.changes
2017-02-28 11:34:51.150707588 +0100
@@ -1,4 +1,10 @@
-------------------------------------------------------------------
+Thu Feb 22 17:25:23 CEST 2017 - [email protected]
+
+- Fate#318832, redesign authentication UI and online help.
+- 3.1.30
+
+-------------------------------------------------------------------
Thu Jun 23 11:46:46 CEST 2016 - [email protected]
- don't treat the attempt to login twice to a target as an error,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-client-3.1.29/package/yast2-iscsi-client.spec
new/yast2-iscsi-client-3.1.30/package/yast2-iscsi-client.spec
--- old/yast2-iscsi-client-3.1.29/package/yast2-iscsi-client.spec
2016-07-05 14:01:20.937198991 +0200
+++ new/yast2-iscsi-client-3.1.30/package/yast2-iscsi-client.spec
2017-02-28 11:34:51.150707588 +0100
@@ -17,7 +17,7 @@
Name: yast2-iscsi-client
-Version: 3.1.29
+Version: 3.1.30
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-client-3.1.29/src/include/iscsi-client/dialogs.rb
new/yast2-iscsi-client-3.1.30/src/include/iscsi-client/dialogs.rb
--- old/yast2-iscsi-client-3.1.29/src/include/iscsi-client/dialogs.rb
2016-07-05 14:01:20.977198991 +0200
+++ new/yast2-iscsi-client-3.1.30/src/include/iscsi-client/dialogs.rb
2017-02-28 11:34:51.162707588 +0100
@@ -235,16 +235,16 @@
CheckBoxFrame(
Id(:auth_none),
Opt(:invertAutoEnable),
- _("No Authentication"),
+ _("No Discovery Authentication"),
true,
VBox(
- Left(Label(_("Incoming Authentication"))),
+ Left(Label(_("Authentication by Initiator"))),
HBox(
HWeight(2, TextEntry(Id(:user_in), _("Username"))),
HWeight(1, Password(Id(:pass_in), _("Password")))
),
VSpacing(2),
- Left(Label(_("Outgoing Authentication"))),
+ Left(Label(_("Authentication by Targets"))),
HBox(
HWeight(2, TextEntry(Id(:user_out), _("Username"))),
HWeight(1, Password(Id(:pass_out), _("Password")))
@@ -269,16 +269,16 @@
CheckBoxFrame(
Id(:auth_none),
Opt(:invertAutoEnable),
- _("No Authentication"),
+ _("No Login Authentication"),
true,
VBox(
- Left(Label(_("Incoming Authentication"))),
+ Left(Label(_("Authentication by Initiator"))),
HBox(
HWeight(2, TextEntry(Id(:user_in), _("Username"))),
HWeight(1, Password(Id(:pass_in), _("Password")))
),
VSpacing(2),
- Left(Label(_("Outgoing Authentication"))),
+ Left(Label(_("Authentication by Targets"))),
HBox(
HWeight(2, TextEntry(Id(:user_out), _("Username"))),
HWeight(1, Password(Id(:pass_out), _("Password")))
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-client-3.1.29/src/include/iscsi-client/helps.rb
new/yast2-iscsi-client-3.1.30/src/include/iscsi-client/helps.rb
--- old/yast2-iscsi-client-3.1.29/src/include/iscsi-client/helps.rb
2016-07-05 14:01:20.989198991 +0200
+++ new/yast2-iscsi-client-3.1.30/src/include/iscsi-client/helps.rb
2017-02-28 11:34:51.162707588 +0100
@@ -32,6 +32,8 @@
def initialize_iscsi_client_helps(include_target)
textdomain "iscsi-client"
+ use_bidirectional_auth = _("If authentication is needed for secure
access, please use <b>Authentication by Initiator</b> and <b>Authentication by
Targets</b> " \
+ "together. Please do not only use one of them for security reasons.\n")
# All helps are here
@HELPS = {
# Read dialog help 1/2
@@ -110,9 +112,8 @@
"discovery" => _("<h1>iSCSI Initiator</h1>") +
_(
"Enter the <b>IP Address</b> of the iSCSI target server.\n" +
- "Only change <b>Port</b> if needed. For authentication, use
<b>Username</b> and <b>Password</b>. If you do not need authentication,\n" +
- "select <b>No Authentication</b>.\n"
- ) +
+ "Only change <b>Port</b>. If you do not need authentication,\n" +
+ "select <b>No Discovery Authentication</b>. ") +
use_bidirectional_auth +
# Warning
_("<h1>Warning</h1>") +
_(
@@ -141,12 +142,8 @@
_("<h1>Authentication</h1>") +
_(
"<p>The default setting here is <i>No Authentication</i>. Uncheck
the checkbox if " \
- "authentication is needed for security reasons. Enter
<b>Username</b> and <b>Password</b> " \
- "for 'Incoming Authentication', 'Outgoing Authentication' or for
both.</p>" \
- "<p><b>Please note:</b><br>" \
- "'Incoming Authentication' here correlates to 'Outgoing
Authentication' "\
- "on iSCSI target server side and the other way round.</p>"
- ),
+ "authentication is needed for security reasons." \
+ ) + use_bidirectional_auth + "</p>",
# list of discovered targets
"discovered" => _(
"<p>This screen shows the list of discovered targets.</p>" \
