Hello community, here is the log from the commit of package at-spi2-atk for openSUSE:Factory checked in at 2017-05-31 12:12:48 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/at-spi2-atk (Old) and /work/SRC/openSUSE:Factory/.at-spi2-atk.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "at-spi2-atk" Wed May 31 12:12:48 2017 rev:72 rq:496380 version:2.24.1 Changes: -------- --- /work/SRC/openSUSE:Factory/at-spi2-atk/at-spi2-atk.changes 2017-03-22 23:12:49.094203577 +0100 +++ /work/SRC/openSUSE:Factory/.at-spi2-atk.new/at-spi2-atk.changes 2017-05-31 12:12:52.242599256 +0200 @@ -1,0 +2,10 @@ +Wed May 10 20:58:14 UTC 2017 - [email protected] + +- Update to version 2.24.1: + + Fix position getter for table cells. + + atk-adaptor/bridge: Fix GList handling resulting in memory + corruption (bgo#781658). + + Fix use after free when returned objects hold only one ref + (bgo#781716). + +------------------------------------------------------------------- Old: ---- at-spi2-atk-2.24.0.tar.xz New: ---- at-spi2-atk-2.24.1.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ at-spi2-atk.spec ++++++ --- /var/tmp/diff_new_pack.q0lihz/_old 2017-05-31 12:12:53.378438925 +0200 +++ /var/tmp/diff_new_pack.q0lihz/_new 2017-05-31 12:12:53.378438925 +0200 @@ -17,7 +17,7 @@ Name: at-spi2-atk -Version: 2.24.0 +Version: 2.24.1 Release: 0 Summary: Assistive Technology Service Provider Interface - GTK+ module License: LGPL-2.0+ ++++++ at-spi2-atk-2.24.0.tar.xz -> at-spi2-atk-2.24.1.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-atk-2.24.0/NEWS new/at-spi2-atk-2.24.1/NEWS --- old/at-spi2-atk-2.24.0/NEWS 2017-03-20 23:44:50.000000000 +0100 +++ new/at-spi2-atk-2.24.1/NEWS 2017-05-09 00:29:06.000000000 +0200 @@ -1,3 +1,11 @@ +What's new in at-spi2-atk 2.24.1: + +* Fix position getter for table cells. + +* atk-adaptor/bridge: Fix GList handling resulting in memory corruption (bgo#781658). + +* Fix use after free when returned objects hold only one ref (bgo#781716). + What's new in at-spi2-atk 2.24.0: * test: remove atk_table_cell_get_column_index test, as the diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-atk-2.24.0/aclocal.m4 new/at-spi2-atk-2.24.1/aclocal.m4 --- old/at-spi2-atk-2.24.0/aclocal.m4 2017-03-20 23:44:55.000000000 +0100 +++ new/at-spi2-atk-2.24.1/aclocal.m4 2017-05-09 00:29:13.000000000 +0200 @@ -20,6 +20,90 @@ If you have problems, you may need to regenerate the build system entirely. To do so, use the procedure documented by the package, typically 'autoreconf'.])]) +dnl GLIB_GSETTINGS +dnl Defines GSETTINGS_SCHEMAS_INSTALL which controls whether +dnl the schema should be compiled +dnl + +AC_DEFUN([GLIB_GSETTINGS], +[ + m4_pattern_allow([AM_V_GEN]) + AC_ARG_ENABLE(schemas-compile, + AS_HELP_STRING([--disable-schemas-compile], + [Disable regeneration of gschemas.compiled on install]), + [case ${enableval} in + yes) GSETTINGS_DISABLE_SCHEMAS_COMPILE="" ;; + no) GSETTINGS_DISABLE_SCHEMAS_COMPILE="1" ;; + *) AC_MSG_ERROR([bad value ${enableval} for --enable-schemas-compile]) ;; + esac]) + AC_SUBST([GSETTINGS_DISABLE_SCHEMAS_COMPILE]) + PKG_PROG_PKG_CONFIG([0.16]) + AC_SUBST(gsettingsschemadir, [${datadir}/glib-2.0/schemas]) + if test x$cross_compiling != xyes; then + GLIB_COMPILE_SCHEMAS=`$PKG_CONFIG --variable glib_compile_schemas gio-2.0` + else + AC_PATH_PROG(GLIB_COMPILE_SCHEMAS, glib-compile-schemas) + fi + AC_SUBST(GLIB_COMPILE_SCHEMAS) + if test "x$GLIB_COMPILE_SCHEMAS" = "x"; then + ifelse([$2],,[AC_MSG_ERROR([glib-compile-schemas not found.])],[$2]) + else + ifelse([$1],,[:],[$1]) + fi + + GSETTINGS_RULES=' +.PHONY : uninstall-gsettings-schemas install-gsettings-schemas clean-gsettings-schemas + +mostlyclean-am: clean-gsettings-schemas + +gsettings__enum_file = $(addsuffix .enums.xml,$(gsettings_ENUM_NAMESPACE)) + +%.gschema.valid: %.gschema.xml $(gsettings__enum_file) + $(AM_V_GEN) $(GLIB_COMPILE_SCHEMAS) --strict --dry-run $(addprefix --schema-file=,$(gsettings__enum_file)) --schema-file=$< && mkdir -p [$](@D) && touch [$]@ + +all-am: $(gsettings_SCHEMAS:.xml=.valid) +uninstall-am: uninstall-gsettings-schemas +install-data-am: install-gsettings-schemas + +.SECONDARY: $(gsettings_SCHEMAS) + +install-gsettings-schemas: $(gsettings_SCHEMAS) $(gsettings__enum_file) + @$(NORMAL_INSTALL) + if test -n "$^"; then \ + test -z "$(gsettingsschemadir)" || $(MKDIR_P) "$(DESTDIR)$(gsettingsschemadir)"; \ + $(INSTALL_DATA) $^ "$(DESTDIR)$(gsettingsschemadir)"; \ + test -n "$(GSETTINGS_DISABLE_SCHEMAS_COMPILE)$(DESTDIR)" || $(GLIB_COMPILE_SCHEMAS) $(gsettingsschemadir); \ + fi + +uninstall-gsettings-schemas: + @$(NORMAL_UNINSTALL) + @list='\''$(gsettings_SCHEMAS) $(gsettings__enum_file)'\''; test -n "$(gsettingsschemadir)" || list=; \ + files=`for p in $$list; do echo $$p; done | sed -e '\''s|^.*/||'\''`; \ + test -n "$$files" || exit 0; \ + echo " ( cd '\''$(DESTDIR)$(gsettingsschemadir)'\'' && rm -f" $$files ")"; \ + cd "$(DESTDIR)$(gsettingsschemadir)" && rm -f $$files + test -n "$(GSETTINGS_DISABLE_SCHEMAS_COMPILE)$(DESTDIR)" || $(GLIB_COMPILE_SCHEMAS) $(gsettingsschemadir) + +clean-gsettings-schemas: + rm -f $(gsettings_SCHEMAS:.xml=.valid) $(gsettings__enum_file) + +ifdef gsettings_ENUM_NAMESPACE +$(gsettings__enum_file): $(gsettings_ENUM_FILES) + $(AM_V_GEN) glib-mkenums --comments '\''<!-- @comment@ -->'\'' --fhead "<schemalist>" --vhead " <@type@ id='\''$(gsettings_ENUM_NAMESPACE).@EnumName@'\''>" --vprod " <value nick='\''@valuenick@'\'' value='\''@valuenum@'\''/>" --vtail " </@type@>" --ftail "</schemalist>" [$]^ > [$]@.tmp && mv [$]@.tmp [$]@ +endif +' + _GSETTINGS_SUBST(GSETTINGS_RULES) +]) + +dnl _GSETTINGS_SUBST(VARIABLE) +dnl Abstract macro to do either _AM_SUBST_NOTMAKE or AC_SUBST +AC_DEFUN([_GSETTINGS_SUBST], +[ +AC_SUBST([$1]) +m4_ifdef([_AM_SUBST_NOTMAKE], [_AM_SUBST_NOTMAKE([$1])]) +] +) + # libtool.m4 - Configure libtool for the host system. -*-Autoconf-*- # # Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2003, 2004, 2005, @@ -8828,90 +8912,6 @@ AS_VAR_IF([$1], [""], [$5], [$4])dnl ])# PKG_CHECK_VAR -dnl GLIB_GSETTINGS -dnl Defines GSETTINGS_SCHEMAS_INSTALL which controls whether -dnl the schema should be compiled -dnl - -AC_DEFUN([GLIB_GSETTINGS], -[ - m4_pattern_allow([AM_V_GEN]) - AC_ARG_ENABLE(schemas-compile, - AS_HELP_STRING([--disable-schemas-compile], - [Disable regeneration of gschemas.compiled on install]), - [case ${enableval} in - yes) GSETTINGS_DISABLE_SCHEMAS_COMPILE="" ;; - no) GSETTINGS_DISABLE_SCHEMAS_COMPILE="1" ;; - *) AC_MSG_ERROR([bad value ${enableval} for --enable-schemas-compile]) ;; - esac]) - AC_SUBST([GSETTINGS_DISABLE_SCHEMAS_COMPILE]) - PKG_PROG_PKG_CONFIG([0.16]) - AC_SUBST(gsettingsschemadir, [${datadir}/glib-2.0/schemas]) - if test x$cross_compiling != xyes; then - GLIB_COMPILE_SCHEMAS=`$PKG_CONFIG --variable glib_compile_schemas gio-2.0` - else - AC_PATH_PROG(GLIB_COMPILE_SCHEMAS, glib-compile-schemas) - fi - AC_SUBST(GLIB_COMPILE_SCHEMAS) - if test "x$GLIB_COMPILE_SCHEMAS" = "x"; then - ifelse([$2],,[AC_MSG_ERROR([glib-compile-schemas not found.])],[$2]) - else - ifelse([$1],,[:],[$1]) - fi - - GSETTINGS_RULES=' -.PHONY : uninstall-gsettings-schemas install-gsettings-schemas clean-gsettings-schemas - -mostlyclean-am: clean-gsettings-schemas - -gsettings__enum_file = $(addsuffix .enums.xml,$(gsettings_ENUM_NAMESPACE)) - -%.gschema.valid: %.gschema.xml $(gsettings__enum_file) - $(AM_V_GEN) $(GLIB_COMPILE_SCHEMAS) --strict --dry-run $(addprefix --schema-file=,$(gsettings__enum_file)) --schema-file=$< && mkdir -p [$](@D) && touch [$]@ - -all-am: $(gsettings_SCHEMAS:.xml=.valid) -uninstall-am: uninstall-gsettings-schemas -install-data-am: install-gsettings-schemas - -.SECONDARY: $(gsettings_SCHEMAS) - -install-gsettings-schemas: $(gsettings_SCHEMAS) $(gsettings__enum_file) - @$(NORMAL_INSTALL) - if test -n "$^"; then \ - test -z "$(gsettingsschemadir)" || $(MKDIR_P) "$(DESTDIR)$(gsettingsschemadir)"; \ - $(INSTALL_DATA) $^ "$(DESTDIR)$(gsettingsschemadir)"; \ - test -n "$(GSETTINGS_DISABLE_SCHEMAS_COMPILE)$(DESTDIR)" || $(GLIB_COMPILE_SCHEMAS) $(gsettingsschemadir); \ - fi - -uninstall-gsettings-schemas: - @$(NORMAL_UNINSTALL) - @list='\''$(gsettings_SCHEMAS) $(gsettings__enum_file)'\''; test -n "$(gsettingsschemadir)" || list=; \ - files=`for p in $$list; do echo $$p; done | sed -e '\''s|^.*/||'\''`; \ - test -n "$$files" || exit 0; \ - echo " ( cd '\''$(DESTDIR)$(gsettingsschemadir)'\'' && rm -f" $$files ")"; \ - cd "$(DESTDIR)$(gsettingsschemadir)" && rm -f $$files - test -n "$(GSETTINGS_DISABLE_SCHEMAS_COMPILE)$(DESTDIR)" || $(GLIB_COMPILE_SCHEMAS) $(gsettingsschemadir) - -clean-gsettings-schemas: - rm -f $(gsettings_SCHEMAS:.xml=.valid) $(gsettings__enum_file) - -ifdef gsettings_ENUM_NAMESPACE -$(gsettings__enum_file): $(gsettings_ENUM_FILES) - $(AM_V_GEN) glib-mkenums --comments '\''<!-- @comment@ -->'\'' --fhead "<schemalist>" --vhead " <@type@ id='\''$(gsettings_ENUM_NAMESPACE).@EnumName@'\''>" --vprod " <value nick='\''@valuenick@'\'' value='\''@valuenum@'\''/>" --vtail " </@type@>" --ftail "</schemalist>" [$]^ > [$]@.tmp && mv [$]@.tmp [$]@ -endif -' - _GSETTINGS_SUBST(GSETTINGS_RULES) -]) - -dnl _GSETTINGS_SUBST(VARIABLE) -dnl Abstract macro to do either _AM_SUBST_NOTMAKE or AC_SUBST -AC_DEFUN([_GSETTINGS_SUBST], -[ -AC_SUBST([$1]) -m4_ifdef([_AM_SUBST_NOTMAKE], [_AM_SUBST_NOTMAKE([$1])]) -] -) - # Copyright (C) 2002-2014 Free Software Foundation, Inc. # # This file is free software; the Free Software Foundation diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-atk-2.24.0/atk-adaptor/adaptors/accessible-adaptor.c new/at-spi2-atk-2.24.1/atk-adaptor/adaptors/accessible-adaptor.c --- old/at-spi2-atk-2.24.0/atk-adaptor/adaptors/accessible-adaptor.c 2016-10-26 23:36:37.000000000 +0200 +++ new/at-spi2-atk-2.24.1/atk-adaptor/adaptors/accessible-adaptor.c 2017-05-09 00:29:06.000000000 +0200 @@ -182,7 +182,8 @@ } child = atk_object_ref_accessible_child (object, i); reply = spi_object_return_reference (message, child); - g_object_unref (child); + if (child) + g_object_unref (child); return reply; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-atk-2.24.0/atk-adaptor/adaptors/collection-adaptor.c new/at-spi2-atk-2.24.1/atk-adaptor/adaptors/collection-adaptor.c --- old/at-spi2-atk-2.24.0/atk-adaptor/adaptors/collection-adaptor.c 2016-04-14 13:26:54.000000000 +0200 +++ new/at-spi2-atk-2.24.1/atk-adaptor/adaptors/collection-adaptor.c 2017-05-09 00:29:06.000000000 +0200 @@ -494,9 +494,12 @@ { AtkObject *child = atk_object_ref_accessible_child (obj, i); - g_object_unref (child); + if (!child) + continue; + if (prev && child == pobj) { + g_object_unref (child); return kount; } @@ -517,6 +520,7 @@ kount = sort_order_canonical (mrp, ls, kount, max, child, 0, TRUE, pobj, recurse, traverse); + g_object_unref (child); } return kount; } @@ -559,19 +563,23 @@ and get it's last descendant. First, get the previous sibling */ nextobj = atk_object_ref_accessible_child (parent, indexinparent - 1); - g_object_unref (nextobj); /* Now, drill down the right side to the last descendant */ - while (atk_object_get_n_accessible_children (nextobj) > 0) + while (nextobj && atk_object_get_n_accessible_children (nextobj) > 0) { - nextobj = atk_object_ref_accessible_child (nextobj, + AtkObject *follow; + + follow = atk_object_ref_accessible_child (nextobj, atk_object_get_n_accessible_children (nextobj) - 1); g_object_unref (nextobj); + nextobj = follow; } /* recurse with the last descendant */ kount = sort_order_rev_canonical (mrp, ls, kount, max, nextobj, TRUE, pobj); + if (nextobj) + g_object_unref (nextobj); } else if (max == 0 || kount < max) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-atk-2.24.0/atk-adaptor/adaptors/table-cell-adaptor.c new/at-spi2-atk-2.24.1/atk-adaptor/adaptors/table-cell-adaptor.c --- old/at-spi2-atk-2.24.0/atk-adaptor/adaptors/table-cell-adaptor.c 2015-10-12 23:41:04.000000000 +0200 +++ new/at-spi2-atk-2.24.1/atk-adaptor/adaptors/table-cell-adaptor.c 2017-04-25 00:43:15.000000000 +0200 @@ -114,8 +114,8 @@ d_row = row; d_column = column; - dbus_message_iter_open_container (iter, DBUS_TYPE_STRUCT, "(ii)", &iter_variant); - dbus_message_iter_open_container (&iter_struct, DBUS_TYPE_STRUCT, NULL, &iter_struct); + dbus_message_iter_open_container (iter, DBUS_TYPE_VARIANT, "(ii)", &iter_variant); + dbus_message_iter_open_container (&iter_variant, DBUS_TYPE_STRUCT, NULL, &iter_struct); dbus_message_iter_append_basic (&iter_struct, DBUS_TYPE_INT32, &row); dbus_message_iter_append_basic (&iter_struct, DBUS_TYPE_INT32, &column); dbus_message_iter_close_container (&iter_variant, &iter_struct); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-atk-2.24.0/atk-adaptor/bridge.c new/at-spi2-atk-2.24.1/atk-adaptor/bridge.c --- old/at-spi2-atk-2.24.0/atk-adaptor/bridge.c 2017-01-20 21:49:02.000000000 +0100 +++ new/at-spi2-atk-2.24.1/atk-adaptor/bridge.c 2017-04-25 00:43:15.000000000 +0200 @@ -748,22 +748,17 @@ if (!g_strcmp0 (evdata->bus_name, bus_name) && spi_event_is_subtype (evdata->data, remove_data)) { + GList *next; GList *events = spi_global_app_data->events; + g_strfreev (evdata->data); g_free (evdata->bus_name); g_slist_free_full (evdata->properties, free_property_definition); g_free (evdata); - if (list->prev) - { - GList *next = list->next; - list->prev = g_list_remove (list->prev, evdata); - list = next; - } - else - { - spi_global_app_data->events = g_list_remove (events, evdata); - list = spi_global_app_data->events; - } + + next = list->next; + spi_global_app_data->events = g_list_delete_link (events, list); + list = next; } else { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-atk-2.24.0/config/config.guess new/at-spi2-atk-2.24.1/config/config.guess --- old/at-spi2-atk-2.24.0/config/config.guess 2017-03-20 23:44:56.000000000 +0100 +++ new/at-spi2-atk-2.24.1/config/config.guess 2017-04-25 00:48:11.000000000 +0200 @@ -1013,7 +1013,7 @@ echo powerpcle-${VENDOR}-linux-${LIBC} exit ;; s390:Linux:*:* | s390x:Linux:*:*) - echo ${UNAME_MACHINE}-ibm-linux-${LIBC} + echo ${UNAME_MACHINE}-${VENDOR}-linux-${LIBC} exit ;; sh64*:Linux:*:*) echo ${UNAME_MACHINE}-${VENDOR}-linux-${LIBC} diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-atk-2.24.0/config/config.sub new/at-spi2-atk-2.24.1/config/config.sub --- old/at-spi2-atk-2.24.0/config/config.sub 2017-03-20 23:44:56.000000000 +0100 +++ new/at-spi2-atk-2.24.1/config/config.sub 2017-04-25 00:48:11.000000000 +0200 @@ -1058,12 +1058,18 @@ rtpc | rtpc-*) basic_machine=romp-ibm ;; - s390 | s390-*) + s390) basic_machine=s390-ibm ;; - s390x | s390x-*) + s390-*) + basic_machine=s390-`echo $basic_machine | sed 's/^[^-]*-//'` + ;; + s390x) basic_machine=s390x-ibm ;; + s390x-*) + basic_machine=s390x-`echo $basic_machine | sed 's/^[^-]*-//'` + ;; sa29200) basic_machine=a29k-amd os=-udi diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-atk-2.24.0/configure new/at-spi2-atk-2.24.1/configure --- old/at-spi2-atk-2.24.0/configure 2017-03-20 23:44:55.000000000 +0100 +++ new/at-spi2-atk-2.24.1/configure 2017-05-09 00:29:14.000000000 +0200 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for at-spi2-atk 2.24.0. +# Generated by GNU Autoconf 2.69 for at-spi2-atk 2.24.1. # # Report bugs to <[email protected]>. # @@ -590,8 +590,8 @@ # Identity of this package. PACKAGE_NAME='at-spi2-atk' PACKAGE_TARNAME='at-spi2-atk' -PACKAGE_VERSION='2.24.0' -PACKAGE_STRING='at-spi2-atk 2.24.0' +PACKAGE_VERSION='2.24.1' +PACKAGE_STRING='at-spi2-atk 2.24.1' PACKAGE_BUGREPORT='[email protected]' PACKAGE_URL='' @@ -1362,7 +1362,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures at-spi2-atk 2.24.0 to adapt to many kinds of systems. +\`configure' configures at-spi2-atk 2.24.1 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1432,7 +1432,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of at-spi2-atk 2.24.0:";; + short | recursive ) echo "Configuration of at-spi2-atk 2.24.1:";; esac cat <<\_ACEOF @@ -1563,7 +1563,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -at-spi2-atk configure 2.24.0 +at-spi2-atk configure 2.24.1 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -1841,7 +1841,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by at-spi2-atk $as_me 2.24.0, which was +It was created by at-spi2-atk $as_me 2.24.1, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2724,7 +2724,7 @@ # Define the identity of the package. PACKAGE='at-spi2-atk' - VERSION='2.24.0' + VERSION='2.24.1' cat >>confdefs.h <<_ACEOF @@ -13108,7 +13108,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by at-spi2-atk $as_me 2.24.0, which was +This file was extended by at-spi2-atk $as_me 2.24.1, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -13174,7 +13174,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -at-spi2-atk config.status 2.24.0 +at-spi2-atk config.status 2.24.1 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-atk-2.24.0/configure.ac new/at-spi2-atk-2.24.1/configure.ac --- old/at-spi2-atk-2.24.0/configure.ac 2017-03-20 23:44:50.000000000 +0100 +++ new/at-spi2-atk-2.24.1/configure.ac 2017-05-09 00:29:06.000000000 +0200 @@ -1,4 +1,4 @@ -AC_INIT([at-spi2-atk], [2.24.0], [[email protected]]) +AC_INIT([at-spi2-atk], [2.24.1], [[email protected]]) AC_CONFIG_AUX_DIR(config) AT_SPI_ATK_MAJOR_VERSION=0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-atk-2.24.0/tests/atk_test_table_cell.c new/at-spi2-atk-2.24.1/tests/atk_test_table_cell.c --- old/at-spi2-atk-2.24.0/tests/atk_test_table_cell.c 2017-03-17 22:27:09.000000000 +0100 +++ new/at-spi2-atk-2.24.1/tests/atk_test_table_cell.c 2017-04-25 00:43:15.000000000 +0200 @@ -140,6 +140,28 @@ } static void +atk_test_table_cell_get_position (gpointer fixture, gconstpointer user_data) +{ + AtspiAccessible *_obj = get_root_obj (DATA_FILE); + g_assert (_obj); + AtspiAccessible *child = atspi_accessible_get_child_at_index (_obj, 0, NULL); + g_assert (child); + + AtspiAccessible *cell = atspi_accessible_get_child_at_index (child, 9, NULL); + AtspiTableCell *obj = atspi_accessible_get_table_cell (cell); + g_assert (cell); + + gint row = 10; + gint column = 10; + + atspi_table_cell_get_position (obj, &row, &column, NULL); + + /* TODO: not a very good test for the app to return (-1, -1) */ + g_assert_cmpint (row, ==, -1); + g_assert_cmpint (column, ==, -1); +} + +static void atk_test_table_cell_get_table (gpointer fixture, gconstpointer user_data) { AtspiAccessible *_obj = get_root_obj (DATA_FILE); @@ -181,6 +203,8 @@ */ g_test_add_vtable (ATK_TEST_PATH_TABLE_CELL "/atk_test_table_cell_get_row_column_span", 0, NULL, NULL, atk_test_table_cell_get_row_column_span, teardown_table_cell_test); + g_test_add_vtable (ATK_TEST_PATH_TABLE_CELL "/atk_test_table_cell_get_position", + 0, NULL, NULL, atk_test_table_cell_get_position, teardown_table_cell_test); g_test_add_vtable (ATK_TEST_PATH_TABLE_CELL "/atk_test_table_cell_get_table", 0, NULL, NULL, atk_test_table_cell_get_table, teardown_table_cell_test); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/at-spi2-atk-2.24.0/tests/dummyatk/my-atk-table-cell.c new/at-spi2-atk-2.24.1/tests/dummyatk/my-atk-table-cell.c --- old/at-spi2-atk-2.24.0/tests/dummyatk/my-atk-table-cell.c 2015-11-19 02:32:22.000000000 +0100 +++ new/at-spi2-atk-2.24.1/tests/dummyatk/my-atk-table-cell.c 2017-04-25 00:43:15.000000000 +0200 @@ -134,7 +134,7 @@ *row = self->xy[0]; *column = self->xy[1]; - return FALSE; + return TRUE; } static GPtrArray *
