Hello community, here is the log from the commit of package gnome-software for openSUSE:Factory checked in at 2017-05-31 12:13:14 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-software (Old) and /work/SRC/openSUSE:Factory/.gnome-software.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-software" Wed May 31 12:13:14 2017 rev:43 rq:496389 version:3.24.3 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-software/gnome-software.changes 2017-04-29 10:51:21.582575376 +0200 +++ /work/SRC/openSUSE:Factory/.gnome-software.new/gnome-software.changes 2017-05-31 12:13:15.563307393 +0200 @@ -1,0 +2,38 @@ +Mon May 15 10:49:05 UTC 2017 - zai...@opensuse.org + +- Update to version 3.24.3: + + Fix a common crash when installing flatpakrepo files. + + Show the headerbar in toolbar-mode when running in Unity. + + Updated translations. + +------------------------------------------------------------------- +Wed May 10 19:29:39 UTC 2017 - zai...@opensuse.org + +- Update to version 3.24.2: + + Use the unique id of an AsApp when creating a GsApp in + gs-appstream. + + Prevent potential abuse of an app list in the plugin-loader. + + trivial: Add one more dep to the example spec file. + + Fix popular-overrides. + + Add the complete flatpak source as a keyword. + + Load the application keywords after the origin keywords have + been added. + + trivial: + - Use the correct type when removing applications. + - Correctly clear custom widget CSS if the metadata key is + cleared. + - Update the feature tile widget if the app name or summary + changes. + - Prevent critical warning when trying to parse an invalid + URI. + - Update more tile widgets if the app name or summary change. + + Fix destdir!=srcdir when running the flatpak tests. + + Fix callback for gs_plugin_loader_url_to_app_async, fixing + small memory leak. + + shell-extensions: Use static URI to fetch extensions data. + + Fix building the external-appstream plugin. + + Do not show the origin comment in the details page. + + Do not abort if a page does not handle the reload vfunc. + + Updated translations. + +------------------------------------------------------------------- Old: ---- gnome-software-3.24.1.tar.xz New: ---- gnome-software-3.24.3.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-software.spec ++++++ --- /var/tmp/diff_new_pack.3Y81qE/_old 2017-05-31 12:13:16.255209727 +0200 +++ /var/tmp/diff_new_pack.3Y81qE/_new 2017-05-31 12:13:16.259209163 +0200 @@ -17,7 +17,7 @@ Name: gnome-software -Version: 3.24.1 +Version: 3.24.3 Release: 0 %define gs_plugin_api 11 Summary: GNOME Software Store ++++++ gnome-software-3.24.1.tar.xz -> gnome-software-3.24.3.tar.xz ++++++ ++++ 1894 lines of diff (skipped) ++++ retrying with extended exclude list diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/NEWS new/gnome-software-3.24.3/NEWS --- old/gnome-software-3.24.1/NEWS 2017-04-10 15:56:26.000000000 +0200 +++ new/gnome-software-3.24.3/NEWS 2017-05-15 11:57:50.000000000 +0200 @@ -1,3 +1,25 @@ +Version 3.24.3 +~~~~~~~~~~~~~~ +Released: 2017-05-15 + +This is an stable release with the following bug fixes: + * Fix a common crash when installing flatpakrepo files + * Show the headerbar in toolbar-mode when running in Unity + +This release also updates translations. + +Version 3.24.2 +~~~~~~~~~~~~~~ +Released: 2017-05-08 + +This is an stable release with the following bug fixes: + * Add the complete flatpak source as a keyword + * Do not show the origin comment in the details page + * Fix popular-apps when using the GSettings key + * Fix crash when metadata is reloaded + +This release also updates translations. + Version 3.24.1 ~~~~~~~~~~~~~~ Released: 2017-04-10 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/config.h new/gnome-software-3.24.3/config.h --- old/gnome-software-3.24.1/config.h 2017-04-10 15:25:45.000000000 +0200 +++ new/gnome-software-3.24.3/config.h 2017-05-14 19:52:00.000000000 +0200 @@ -69,7 +69,7 @@ #define HAVE_SHELL_EXTENSIONS 1 /* Build Snap support */ -#define HAVE_SNAP 1 +/* #undef HAVE_SNAP */ /* Define to 1 if you have the <stdint.h> header file. */ #define HAVE_STDINT_H 1 @@ -111,7 +111,7 @@ #define PACKAGE_NAME "gnome-software" /* Define to the full name and version of this package. */ -#define PACKAGE_STRING "gnome-software 3.24.1" +#define PACKAGE_STRING "gnome-software 3.24.3" /* Define to the one symbol short name of this package. */ #define PACKAGE_TARNAME "gnome-software" @@ -120,10 +120,10 @@ #define PACKAGE_URL "" /* Define to the version of this package. */ -#define PACKAGE_VERSION "3.24.1" +#define PACKAGE_VERSION "3.24.3" /* Define to 1 if you have the ANSI C header files. */ #define STDC_HEADERS 1 /* Version number of package */ -#define VERSION "3.24.1" +#define VERSION "3.24.3" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/configure.ac new/gnome-software-3.24.3/configure.ac --- old/gnome-software-3.24.1/configure.ac 2017-03-20 21:54:14.000000000 +0100 +++ new/gnome-software-3.24.3/configure.ac 2017-05-08 17:29:03.000000000 +0200 @@ -1,7 +1,7 @@ # Copyright (C) 2010-2015 Richard Hughes <rich...@hughsie.com> AC_PREREQ(2.63) -AC_INIT([gnome-software],[3.24.1],[http://bugzilla.gnome.org/enter_bug.cgi?product=gnome-software]) +AC_INIT([gnome-software],[3.24.3],[http://bugzilla.gnome.org/enter_bug.cgi?product=gnome-software]) AC_CONFIG_SRCDIR(src) AM_INIT_AUTOMAKE([1.11 no-dist-gzip dist-xz tar-ustar serial-tests foreign]) AC_CONFIG_HEADERS([config.h]) @@ -502,6 +502,7 @@ plugins/fedora-distro-upgrades/Makefile plugins/fedora-tagger-usage/Makefile plugins/flatpak/Makefile +plugins/flatpak/tests/Makefile plugins/fwupd/Makefile plugins/limba/Makefile plugins/modalias/Makefile diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/data/appdata/org.gnome.Software.appdata.xml.in new/gnome-software-3.24.3/data/appdata/org.gnome.Software.appdata.xml.in --- old/gnome-software-3.24.1/data/appdata/org.gnome.Software.appdata.xml.in 2017-04-10 15:53:54.000000000 +0200 +++ new/gnome-software-3.24.3/data/appdata/org.gnome.Software.appdata.xml.in 2017-05-15 11:56:23.000000000 +0200 @@ -46,6 +46,33 @@ Validate with `appstream-util validate *.appdata.xml` --> <releases> + <release date="2017-05-15" version="3.24.3"> + <description> + <p> + This is an stable release with the following bug fixes: + </p> + <ul> + <li>Fix a common crash when installing flatpakrepo files</li> + <li>Show the headerbar in toolbar-mode when running in Unity</li> + <li>Ensure we show the banner when upgrades are available</li> + </ul> + <p>This release also updates translations.</p> + </description> + </release> + <release date="2017-05-08" version="3.24.2"> + <description> + <p> + This is an stable release with the following bug fixes: + </p> + <ul> + <li>Add the complete flatpak source as a keyword</li> + <li>Do not show the origin comment in the details page</li> + <li>Fix popular-apps when using the GSettings key</li> + <li>Fix crash when metadata is reloaded</li> + </ul> + <p>This release also updates translations.</p> + </description> + </release> <release date="2017-04-10" version="3.24.1"> <description> <p> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/lib/gs-app-list.c new/gnome-software-3.24.3/lib/gs-app-list.c --- old/gnome-software-3.24.1/lib/gs-app-list.c 2017-03-20 21:32:16.000000000 +0100 +++ new/gnome-software-3.24.3/lib/gs-app-list.c 2017-05-08 14:14:00.000000000 +0200 @@ -157,7 +157,7 @@ void gs_app_list_remove (GsAppList *list, GsApp *app) { - AsApp *app_tmp; + GsApp *app_tmp; const gchar *unique_id; g_autoptr(GMutexLocker) locker = g_mutex_locker_new (&list->mutex); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/lib/gs-app.c new/gnome-software-3.24.3/lib/gs-app.c --- old/gnome-software-3.24.1/lib/gs-app.c 2017-04-10 15:36:14.000000000 +0200 +++ new/gnome-software-3.24.3/lib/gs-app.c 2017-05-14 19:50:47.000000000 +0200 @@ -403,13 +403,16 @@ gs_app_get_kudos_percentage (app)); if (app->name != NULL) gs_app_kv_lpad (str, "name", app->name); - gs_app_kv_printf (str, "pixbuf", "%p", app->pixbuf); + if (app->pixbuf != NULL) + gs_app_kv_printf (str, "pixbuf", "%p", app->pixbuf); for (i = 0; i < app->icons->len; i++) { AsIcon *icon = g_ptr_array_index (app->icons, i); gs_app_kv_lpad (str, "icon-kind", as_icon_kind_to_string (as_icon_get_kind (icon))); - gs_app_kv_printf (str, "icon-pixbuf", "%p", - as_icon_get_pixbuf (icon)); + if (as_icon_get_pixbuf (icon) != NULL) { + gs_app_kv_printf (str, "icon-pixbuf", "%p", + as_icon_get_pixbuf (icon)); + } if (as_icon_get_name (icon) != NULL) gs_app_kv_lpad (str, "icon-name", as_icon_get_name (icon)); @@ -1142,7 +1145,8 @@ if (quality <= app->name_quality) return; app->name_quality = quality; - _g_set_str (&app->name, name); + if (_g_set_str (&app->name, name)) + g_object_notify (G_OBJECT (app), "name"); } /** @@ -1848,7 +1852,8 @@ if (quality <= app->summary_quality) return; app->summary_quality = quality; - _g_set_str (&app->summary, summary); + if (_g_set_str (&app->summary, summary)) + g_object_notify (G_OBJECT (app), "summary"); } /** diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/lib/gs-plugin-loader.c new/gnome-software-3.24.3/lib/gs-plugin-loader.c --- old/gnome-software-3.24.1/lib/gs-plugin-loader.c 2017-04-10 15:33:55.000000000 +0200 +++ new/gnome-software-3.24.3/lib/gs-plugin-loader.c 2017-05-08 14:18:45.000000000 +0200 @@ -700,6 +700,7 @@ for (i = 0; i < priv->plugins->len; i++) { g_autoptr(AsProfileTask) ptask = NULL; GsPlugin *plugin = g_ptr_array_index (priv->plugins, i); + g_autoptr(GsAppList) app_list = NULL; /* run the batched plugin symbol then the per-app plugin */ job->function_name = "gs_plugin_refine"; @@ -707,8 +708,14 @@ cancellable, error)) { return FALSE; } - for (j = 0; j < gs_app_list_length (list); j++) { - app = gs_app_list_index (list, j); + + /* use a copy of the list for the loop because a function called + * on the plugin may affect the list which can lead to problems + * (e.g. inserting an app in the list on every call results in + * an infinite loop) */ + app_list = gs_app_list_copy (list); + for (j = 0; j < gs_app_list_length (app_list); j++) { + app = gs_app_list_index (app_list, j); if (!gs_app_has_quirk (app, AS_APP_QUIRK_MATCH_ANY_PREFIX)) { job->function_name = "gs_plugin_refine_app"; } else { @@ -1715,6 +1722,15 @@ gs_app_add_quirk (app, AS_APP_QUIRK_MATCH_ANY_PREFIX); gs_app_list_add (job->list, app); } + + /* prepare refine job */ + job->action = GS_PLUGIN_ACTION_REFINE; + job->function_name = "gs_plugin_refine"; + job->failure_flags = GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS; + if (!gs_plugin_loader_run_refine (job, job->list, cancellable, &error)) { + g_task_return_error (task, error); + return; + } } else { /* do things that would block */ job->function_name = "gs_plugin_add_popular"; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/lib/gs-plugin.c new/gnome-software-3.24.3/lib/gs-plugin.c --- old/gnome-software-3.24.1/lib/gs-plugin.c 2017-03-20 21:32:16.000000000 +0100 +++ new/gnome-software-3.24.3/lib/gs-plugin.c 2017-05-08 14:12:13.000000000 +0200 @@ -1262,6 +1262,13 @@ /* remote */ g_debug ("downloading %s to %s from plugin %s", uri, filename, priv->name); msg = soup_message_new (SOUP_METHOD_GET, uri); + if (msg == NULL) { + g_set_error (error, + GS_PLUGIN_ERROR, + GS_PLUGIN_ERROR_DOWNLOAD_FAILED, + "failed to parse URI %s", uri); + return FALSE; + } if (app != NULL) { helper.plugin = plugin; helper.app = app; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/plugins/core/gs-appstream.c new/gnome-software-3.24.3/plugins/core/gs-appstream.c --- old/gnome-software-3.24.1/plugins/core/gs-appstream.c 2017-04-10 15:39:54.000000000 +0200 +++ new/gnome-software-3.24.3/plugins/core/gs-appstream.c 2017-05-08 14:19:12.000000000 +0200 @@ -33,7 +33,7 @@ const gchar *unique_id = as_app_get_unique_id (item); GsApp *app = gs_plugin_cache_lookup (plugin, unique_id); if (app == NULL) { - app = gs_app_new (as_app_get_id (item)); + app = gs_app_new_from_unique_id (unique_id); gs_app_set_metadata (app, "GnomeSoftware::Creator", gs_plugin_get_name (plugin)); if (!gs_appstream_refine_app (plugin, app, item, error)) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/plugins/core/gs-plugin-appstream.c new/gnome-software-3.24.3/plugins/core/gs-plugin-appstream.c --- old/gnome-software-3.24.1/plugins/core/gs-plugin-appstream.c 2017-03-20 21:32:16.000000000 +0100 +++ new/gnome-software-3.24.3/plugins/core/gs-plugin-appstream.c 2017-05-08 14:15:22.000000000 +0200 @@ -302,9 +302,6 @@ G_CALLBACK (gs_plugin_appstream_store_changed_cb), plugin); - /* ensure the token cache */ - as_store_load_search_cache (priv->store); - /* add search terms for apps not in the main source */ origins = gs_plugin_appstream_get_origins_hash (items); for (i = 0; i < items->len; i++) { @@ -320,6 +317,9 @@ } } + /* ensure the token cache */ + as_store_load_search_cache (priv->store); + /* rely on the store keeping itself updated */ return TRUE; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/plugins/dummy/gs-plugin-dummy.c new/gnome-software-3.24.3/plugins/dummy/gs-plugin-dummy.c --- old/gnome-software-3.24.1/plugins/dummy/gs-plugin-dummy.c 2017-04-10 15:40:13.000000000 +0200 +++ new/gnome-software-3.24.3/plugins/dummy/gs-plugin-dummy.c 2017-05-14 19:50:14.000000000 +0200 @@ -65,8 +65,10 @@ gs_plugin_add_flags (plugin, GS_PLUGIN_FLAGS_GLOBAL_CACHE); /* toggle this */ - priv->allow_updates_id = g_timeout_add_seconds (10, - gs_plugin_dummy_allow_updates_cb, plugin); + if (g_getenv ("GS_SELF_TEST_TOGGLE_ALLOW_UPDATES") != NULL) { + priv->allow_updates_id = g_timeout_add_seconds (10, + gs_plugin_dummy_allow_updates_cb, plugin); + } /* set up a dummy authentication provider */ priv->auth = gs_auth_new (gs_plugin_get_name (plugin)); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/plugins/external-appstream/Makefile.am new/gnome-software-3.24.3/plugins/external-appstream/Makefile.am --- old/gnome-software-3.24.1/plugins/external-appstream/Makefile.am 2017-03-20 21:32:16.000000000 +0100 +++ new/gnome-software-3.24.3/plugins/external-appstream/Makefile.am 2017-05-08 14:10:13.000000000 +0200 @@ -1,5 +1,8 @@ AM_CPPFLAGS = \ - -DG_LOG_DOMAIN=\"GsPluginExternalAppstream\" + -DG_LOG_DOMAIN=\"GsPluginExternalAppstream\" \ + -DLIBEXECDIR=\"$(libexecdir)\" \ + -DLOCALEDIR=\""$(localedir)"\" \ + -DLOCALSTATEDIR=\""$(localstatedir)"\" plugindir = $(GS_PLUGIN_DIR) plugin_LTLIBRARIES = libgs_plugin_external-appstream.la @@ -12,7 +15,7 @@ libexec_PROGRAMS = gnome-software-install-appstream gnome_software_install_appstream_SOURCES = gs-install-appstream.c gnome_software_install_appstream_LDADD = $(GLIB_LIBS) $(APPSTREAM_LIBS) -gnome_software_install_appstream_CFLAGS = $(WARN_CFLAGS) +gnome_software_install_appstream_CFLAGS = $(APPSTREAM_CFLAGS) $(PIE_CFLAGS) $(WARN_CFLAGS) gnome_software_install_appstream_LDFLAGS = $(PIE_LDFLAGS) $(RELRO_LDFLAGS) -include $(top_srcdir)/git.mk diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/plugins/flatpak/Makefile.am new/gnome-software-3.24.3/plugins/flatpak/Makefile.am --- old/gnome-software-3.24.1/plugins/flatpak/Makefile.am 2017-03-20 21:32:16.000000000 +0100 +++ new/gnome-software-3.24.3/plugins/flatpak/Makefile.am 2017-05-08 14:10:13.000000000 +0200 @@ -1,3 +1,5 @@ +SUBDIRS = tests + AM_CPPFLAGS = \ -DG_LOG_DOMAIN=\"GsPluginFlatpak\" \ -DSYSCONFDIR=\""$(sysconfdir)"\" \ @@ -35,13 +37,6 @@ gs_self_test_LDADD = $(top_builddir)/lib/libgnomesoftware.a $(GS_PRIVATE_LIBS) gs_self_test_CFLAGS = $(GS_PRIVATE_CFLAGS) TESTS = gs-self-test - -tests/app-with-runtime/repo: tests/app-with-runtime - $(AM_V_GEN) cd "$(srcdir)/tests" && ./build.py && cd - - -BUILT_SOURCES = \ - tests/app-with-runtime/repo - endif -include $(top_srcdir)/git.mk diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/plugins/flatpak/gs-appstream.c new/gnome-software-3.24.3/plugins/flatpak/gs-appstream.c --- old/gnome-software-3.24.1/plugins/flatpak/gs-appstream.c 2017-04-10 15:39:54.000000000 +0200 +++ new/gnome-software-3.24.3/plugins/flatpak/gs-appstream.c 2017-05-08 14:19:12.000000000 +0200 @@ -33,7 +33,7 @@ const gchar *unique_id = as_app_get_unique_id (item); GsApp *app = gs_plugin_cache_lookup (plugin, unique_id); if (app == NULL) { - app = gs_app_new (as_app_get_id (item)); + app = gs_app_new_from_unique_id (unique_id); gs_app_set_metadata (app, "GnomeSoftware::Creator", gs_plugin_get_name (plugin)); if (!gs_appstream_refine_app (plugin, app, item, error)) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/plugins/flatpak/gs-flatpak.c new/gnome-software-3.24.3/plugins/flatpak/gs-flatpak.c --- old/gnome-software-3.24.1/plugins/flatpak/gs-flatpak.c 2017-04-10 15:39:54.000000000 +0200 +++ new/gnome-software-3.24.3/plugins/flatpak/gs-flatpak.c 2017-05-14 19:49:40.000000000 +0200 @@ -248,6 +248,16 @@ return FALSE; } + /* add the origin as a keyword */ + apps = as_store_get_apps (store); + for (i = 0; i < apps->len; i++) { + AsApp *app = g_ptr_array_index (apps, i); + g_debug ("adding keyword '%s' to %s", + flatpak_remote_get_name (xremote), + as_app_get_id (app)); + as_app_add_keyword (app, NULL, flatpak_remote_get_name (xremote)); + } + /* ensure the token cache */ as_store_load_search_cache (store); @@ -265,7 +275,6 @@ default_branch = flatpak_remote_get_default_branch (xremote); /* get all the apps and fix them up */ - apps = as_store_get_apps (store); app_filtered = g_ptr_array_new (); for (i = 0; i < apps->len; i++) { AsApp *app = g_ptr_array_index (apps, i); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/plugins/flatpak/tests/Makefile.am new/gnome-software-3.24.3/plugins/flatpak/tests/Makefile.am --- old/gnome-software-3.24.1/plugins/flatpak/tests/Makefile.am 1970-01-01 01:00:00.000000000 +0100 +++ new/gnome-software-3.24.3/plugins/flatpak/tests/Makefile.am 2017-05-08 14:10:13.000000000 +0200 @@ -0,0 +1,26 @@ +if ENABLE_TESTS + +app-with-runtime/repo/config: $(srcdir)/flatpakrepos.tar.gz + $(AM_V_GEN) tar -xf $(srcdir)/flatpakrepos.tar.gz + +flatpakrepos.tar.gz: + $(AM_V_GEN) tar -czf $(srcdir)flatpakrepos.tar.gz \ + app-missing-runtime/repo/ \ + app-update/repo/ \ + app-with-runtime/repo/ \ + only-runtime/repo/ + +BUILT_SOURCES = \ + app-with-runtime/repo/config + +DISTCLEANFILES = \ + app-missing-runtime/repo \ + app-update/repo \ + app-with-runtime/repo \ + only-runtime/repo + +endif + +EXTRA_DIST = flatpakrepos.tar.gz + +-include $(top_srcdir)/git.mk Binary files old/gnome-software-3.24.1/plugins/flatpak/tests/flatpakrepos.tar.gz and new/gnome-software-3.24.3/plugins/flatpak/tests/flatpakrepos.tar.gz differ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/plugins/shell-extensions/gs-plugin-shell-extensions.c new/gnome-software-3.24.3/plugins/shell-extensions/gs-plugin-shell-extensions.c --- old/gnome-software-3.24.1/plugins/shell-extensions/gs-plugin-shell-extensions.c 2017-03-20 21:32:16.000000000 +0100 +++ new/gnome-software-3.24.3/plugins/shell-extensions/gs-plugin-shell-extensions.c 2017-05-08 14:10:13.000000000 +0200 @@ -655,11 +655,8 @@ } /* create the GET data */ - uri = g_strdup_printf ("%s/extension-query/" - "?shell_version=%s" - "&page=1&n_per_page=1000", - SHELL_EXTENSIONS_API_URI, - priv->shell_version); + uri = g_strdup_printf ("%s/static/extensions.json", + SHELL_EXTENSIONS_API_URI); data = gs_plugin_download_data (plugin, dummy, uri, cancellable, error); if (data == NULL) { gs_utils_error_add_unique_id (error, priv->cached_origin); Binary files old/gnome-software-3.24.1/po/hr.gmo and new/gnome-software-3.24.3/po/hr.gmo differ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/po/hr.po new/gnome-software-3.24.3/po/hr.po --- old/gnome-software-3.24.1/po/hr.po 2017-04-10 15:24:47.000000000 +0200 +++ new/gnome-software-3.24.3/po/hr.po 2017-05-02 09:34:44.000000000 +0200 @@ -9,7 +9,7 @@ "Report-Msgid-Bugs-To: https://bugzilla.gnome.org/enter_bug.cgi?product=gnome-"; "software&keywords=I18N+L10N&component=General\n" "POT-Creation-Date: 2017-04-07 02:07+0000\n" -"PO-Revision-Date: 2017-04-07 23:06+0200\n" +"PO-Revision-Date: 2017-04-11 12:09+0200\n" "Last-Translator: gogo <trebeln...@gmail.com>\n" "Language-Team: Croatian <h...@li.org>\n" "Language: hr\n" @@ -3465,7 +3465,7 @@ #. TRANSLATORS: this is the menu spec main category for Reference #: plugins/core/gs-desktop-common.c:336 msgid "Reference" -msgstr "" +msgstr "Preporuke" #. TRANSLATORS: this is the menu spec main category for Utilities #: plugins/core/gs-desktop-common.c:339 Binary files old/gnome-software-3.24.1/po/sk.gmo and new/gnome-software-3.24.3/po/sk.gmo differ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/po/sk.po new/gnome-software-3.24.3/po/sk.po --- old/gnome-software-3.24.1/po/sk.po 2017-04-10 15:24:47.000000000 +0200 +++ new/gnome-software-3.24.3/po/sk.po 2017-05-02 09:34:44.000000000 +0200 @@ -8,8 +8,8 @@ "Project-Id-Version: gnome-software master\n" "Report-Msgid-Bugs-To: https://bugzilla.gnome.org/enter_bug.cgi?product=gnome-"; "software&keywords=I18N+L10N&component=General\n" -"POT-Creation-Date: 2017-03-17 16:41+0000\n" -"PO-Revision-Date: 2017-03-23 17:49+0100\n" +"POT-Creation-Date: 2017-04-07 02:07+0000\n" +"PO-Revision-Date: 2017-04-17 10:10+0200\n" "Last-Translator: Dušan Kazik <prescot...@gmail.com>\n" "Language-Team: slovenčina <>\n" "Language: sk\n" @@ -17,7 +17,7 @@ "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" "Plural-Forms: nplurals=3; plural=(n==1) ? 1 : (n>=2 && n<=4) ? 2 : 0;\n" -"X-Generator: Poedit 1.8.11\n" +"X-Generator: Poedit 2.0.1\n" #: data/appdata/org.gnome.Software.appdata.xml.in:7 msgid "GNOME Software" @@ -69,7 +69,7 @@ msgid "The update details" msgstr "Podrobnosti o aktualizácii" -#: data/appdata/org.gnome.Software.appdata.xml.in:717 +#: data/appdata/org.gnome.Software.appdata.xml.in:722 msgid "The GNOME Project" msgstr "Projekt GNOME" @@ -1766,13 +1766,13 @@ #. TRANSLATORS: initial start #: src/gs-loading-page.c:62 msgid "Software catalog is being downloaded" -msgstr "Katalóg softvéru sa preberá" +msgstr "Prebieha preberanie katalógu softvéru" # title #. TRANSLATORS: initial start #: src/gs-loading-page.c:67 msgid "Software catalog is being loaded" -msgstr "Katalóg softvéru sa načítava" +msgstr "Prebieha načítavanie katalógu softvéru" #: src/gs-loading-page.ui:7 msgid "Loading page" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/src/gs-common.c new/gnome-software-3.24.3/src/gs-common.c --- old/gnome-software-3.24.1/src/gs-common.c 2017-03-20 21:32:17.000000000 +0100 +++ new/gnome-software-3.24.3/src/gs-common.c 2017-05-08 14:12:35.000000000 +0200 @@ -401,8 +401,10 @@ /* invalid */ css = gs_app_get_metadata_item (app, metadata_css); - if (css == NULL) + if (css == NULL) { + gs_utils_widget_set_css_simple (widget, css); return; + } /* replace any key colors */ css_str = g_string_new (css); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/src/gs-details-page.c new/gnome-software-3.24.3/src/gs-details-page.c --- old/gnome-software-3.24.1/src/gs-details-page.c 2017-04-10 15:35:57.000000000 +0200 +++ new/gnome-software-3.24.3/src/gs-details-page.c 2017-05-08 14:10:13.000000000 +0200 @@ -895,9 +895,7 @@ } /* set the origin */ - tmp = gs_app_get_origin_ui (self->app); - if (tmp == NULL) - tmp = gs_app_get_origin_hostname (self->app); + tmp = gs_app_get_origin_hostname (self->app); if (tmp == NULL) tmp = gs_app_get_origin (self->app); if (tmp == NULL || tmp[0] == '\0') { @@ -1448,13 +1446,8 @@ } static void -gs_details_page_file_to_app_cb (GObject *source, - GAsyncResult *res, - gpointer user_data) +set_app (GsDetailsPage *self, GsApp *app) { - GsPluginLoader *plugin_loader = GS_PLUGIN_LOADER (source); - GsDetailsPage *self = GS_DETAILS_PAGE (user_data); - g_autoptr(GError) error = NULL; g_autofree gchar *tmp = NULL; /* disconnect the old handlers */ @@ -1464,12 +1457,8 @@ } /* save app */ - g_set_object (&self->app, - gs_plugin_loader_file_to_app_finish (plugin_loader, - res, - &error)); + g_set_object (&self->app, app); if (self->app == NULL) { - g_warning ("failed to convert to GsApp: %s", error->message); /* switch away from the details view that failed to load */ gs_shell_set_mode (self->shell, GS_SHELL_MODE_OVERVIEW); return; @@ -1505,6 +1494,42 @@ gs_details_page_app_refine2 (self); } +static void +gs_details_page_file_to_app_cb (GObject *source, + GAsyncResult *res, + gpointer user_data) +{ + GsPluginLoader *plugin_loader = GS_PLUGIN_LOADER (source); + GsDetailsPage *self = GS_DETAILS_PAGE (user_data); + g_autoptr(GsApp) app = NULL; + g_autoptr(GError) error = NULL; + + app = gs_plugin_loader_file_to_app_finish (plugin_loader, + res, + &error); + if (app == NULL) + g_warning ("failed to convert file to GsApp: %s", error->message); + set_app (self, app); +} + +static void +gs_details_page_url_to_app_cb (GObject *source, + GAsyncResult *res, + gpointer user_data) +{ + GsPluginLoader *plugin_loader = GS_PLUGIN_LOADER (source); + GsDetailsPage *self = GS_DETAILS_PAGE (user_data); + g_autoptr(GsApp) app = NULL; + g_autoptr(GError) error = NULL; + + app = gs_plugin_loader_url_to_app_finish (plugin_loader, + res, + &error); + if (app == NULL) + g_warning ("failed to convert URL to GsApp: %s", error->message); + set_app (self, app); +} + void gs_details_page_set_local_file (GsDetailsPage *self, GFile *file) { @@ -1516,7 +1541,7 @@ GS_PLUGIN_REFINE_FLAGS_REQUIRE_SIZE | GS_PLUGIN_REFINE_FLAGS_REQUIRE_VERSION | GS_PLUGIN_REFINE_FLAGS_REQUIRE_HISTORY | - GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_UI | + GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_HOSTNAME | GS_PLUGIN_REFINE_FLAGS_REQUIRE_MENU_PATH | GS_PLUGIN_REFINE_FLAGS_REQUIRE_URL | GS_PLUGIN_REFINE_FLAGS_REQUIRE_SETUP_ACTION | @@ -1551,7 +1576,7 @@ GS_PLUGIN_REFINE_FLAGS_REQUIRE_PERMISSIONS, GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS, self->cancellable, - gs_details_page_file_to_app_cb, + gs_details_page_url_to_app_cb, self); } @@ -1566,7 +1591,7 @@ GS_PLUGIN_REFINE_FLAGS_REQUIRE_VERSION | GS_PLUGIN_REFINE_FLAGS_REQUIRE_HISTORY | GS_PLUGIN_REFINE_FLAGS_REQUIRE_SETUP_ACTION | - GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_UI | + GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_HOSTNAME | GS_PLUGIN_REFINE_FLAGS_REQUIRE_MENU_PATH | GS_PLUGIN_REFINE_FLAGS_REQUIRE_URL | GS_PLUGIN_REFINE_FLAGS_REQUIRE_SETUP_ACTION | diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/src/gs-feature-tile.c new/gnome-software-3.24.3/src/gs-feature-tile.c --- old/gnome-software-3.24.1/src/gs-feature-tile.c 2017-03-20 21:32:17.000000000 +0100 +++ new/gnome-software-3.24.3/src/gs-feature-tile.c 2017-05-08 14:12:26.000000000 +0200 @@ -53,6 +53,14 @@ AtkObject *accessible; g_autofree gchar *name = NULL; + /* update text */ + gtk_label_set_label (GTK_LABEL (tile->title), gs_app_get_name (tile->app)); + gtk_label_set_label (GTK_LABEL (tile->subtitle), gs_app_get_summary (tile->app)); + + /* perhaps set custom css */ + gs_utils_widget_set_css_app (tile->app, GTK_WIDGET (tile), + "GnomeSoftware::FeatureTile-css"); + accessible = gtk_widget_get_accessible (GTK_WIDGET (tile)); switch (gs_app_get_state (tile->app)) { @@ -94,25 +102,22 @@ g_return_if_fail (GS_IS_APP (app) || app == NULL); - if (tile->app) + if (tile->app != NULL) g_signal_handlers_disconnect_by_func (tile->app, app_state_changed, tile); g_set_object (&tile->app, app); - if (!app) + if (app == NULL) return; gtk_stack_set_visible_child_name (GTK_STACK (tile->stack), "content"); g_signal_connect (tile->app, "notify::state", G_CALLBACK (app_state_changed), tile); + g_signal_connect (tile->app, "notify::name", + G_CALLBACK (app_state_changed), tile); + g_signal_connect (tile->app, "notify::summary", + G_CALLBACK (app_state_changed), tile); app_state_changed (tile->app, NULL, tile); - - gtk_label_set_label (GTK_LABEL (tile->title), gs_app_get_name (app)); - gtk_label_set_label (GTK_LABEL (tile->subtitle), gs_app_get_summary (app)); - - /* perhaps set custom css */ - gs_utils_widget_set_css_app (app, GTK_WIDGET (tile), - "GnomeSoftware::FeatureTile-css"); } static void diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/src/gs-page.c new/gnome-software-3.24.3/src/gs-page.c --- old/gnome-software-3.24.1/src/gs-page.c 2017-03-20 21:32:17.000000000 +0100 +++ new/gnome-software-3.24.3/src/gs-page.c 2017-05-02 09:34:46.000000000 +0200 @@ -646,8 +646,8 @@ GsPageClass *klass; g_return_if_fail (GS_IS_PAGE (page)); klass = GS_PAGE_GET_CLASS (page); - g_assert (klass->reload != NULL); - klass->reload (page); + if (klass->reload != NULL) + klass->reload (page); } gboolean diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/src/gs-popular-tile.c new/gnome-software-3.24.3/src/gs-popular-tile.c --- old/gnome-software-3.24.1/src/gs-popular-tile.c 2017-03-20 21:32:17.000000000 +0100 +++ new/gnome-software-3.24.3/src/gs-popular-tile.c 2017-05-08 14:12:09.000000000 +0200 @@ -118,6 +118,10 @@ g_signal_connect (tile->app, "notify::state", G_CALLBACK (app_state_changed), tile); + g_signal_connect (tile->app, "notify::name", + G_CALLBACK (app_state_changed), tile); + g_signal_connect (tile->app, "notify::summary", + G_CALLBACK (app_state_changed), tile); app_state_changed (tile->app, NULL, tile); /* perhaps set custom css */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/src/gs-shell.c new/gnome-software-3.24.3/src/gs-shell.c --- old/gnome-software-3.24.1/src/gs-shell.c 2017-03-20 21:32:17.000000000 +0100 +++ new/gnome-software-3.24.3/src/gs-shell.c 2017-05-14 19:49:40.000000000 +0200 @@ -1617,6 +1617,7 @@ { GsShellPrivate *priv = gs_shell_get_instance_private (shell); GtkWidget *widget; + GtkStyleContext *style_context; GsPage *page; g_return_if_fail (GS_IS_SHELL (shell)); @@ -1644,6 +1645,9 @@ /* fix up the header bar */ widget = GTK_WIDGET (gtk_builder_get_object (priv->builder, "header")); if (gs_utils_is_current_desktop ("Unity")) { + style_context = gtk_widget_get_style_context (widget); + gtk_style_context_remove_class (style_context, GTK_STYLE_CLASS_TITLEBAR); + gtk_style_context_add_class (style_context, GTK_STYLE_CLASS_PRIMARY_TOOLBAR); gtk_header_bar_set_decoration_layout (GTK_HEADER_BAR (widget), ""); } else { g_object_ref (widget); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/src/gs-summary-tile.c new/gnome-software-3.24.3/src/gs-summary-tile.c --- old/gnome-software-3.24.1/src/gs-summary-tile.c 2017-03-20 21:32:17.000000000 +0100 +++ new/gnome-software-3.24.3/src/gs-summary-tile.c 2017-05-08 14:12:09.000000000 +0200 @@ -129,6 +129,10 @@ g_signal_connect (tile->app, "notify::state", G_CALLBACK (app_state_changed), tile); + g_signal_connect (tile->app, "notify::name", + G_CALLBACK (app_state_changed), tile); + g_signal_connect (tile->app, "notify::summary", + G_CALLBACK (app_state_changed), tile); app_state_changed (tile->app, NULL, tile); pixbuf = gs_app_get_pixbuf (app); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/gnome-software-3.24.1/src/gs-updates-page.c new/gnome-software-3.24.3/src/gs-updates-page.c --- old/gnome-software-3.24.1/src/gs-updates-page.c 2017-04-10 15:36:48.000000000 +0200 +++ new/gnome-software-3.24.3/src/gs-updates-page.c 2017-05-14 19:51:14.000000000 +0200 @@ -545,11 +545,13 @@ } else if (gs_app_list_length (list) == 0) { g_debug ("updates-shell: no upgrades to show"); gs_updates_page_clear_flag (self, GS_UPDATES_PAGE_FLAG_HAS_UPGRADES); + gtk_widget_set_visible (self->upgrade_banner, FALSE); } else { GsApp *app = gs_app_list_index (list, 0); g_debug ("got upgrade %s", gs_app_get_id (app)); gs_upgrade_banner_set_app (GS_UPGRADE_BANNER (self->upgrade_banner), app); gs_updates_page_set_flag (self, GS_UPDATES_PAGE_FLAG_HAS_UPGRADES); + gtk_widget_set_visible (self->upgrade_banner, TRUE); } /* only when both set */
