Hello community,
here is the log from the commit of package yast2-kdump for openSUSE:Factory
checked in at 2017-06-22 10:35:35
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-kdump (Old)
and /work/SRC/openSUSE:Factory/.yast2-kdump.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-kdump"
Thu Jun 22 10:35:35 2017 rev:82 rq:505099 version:3.2.5
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-kdump/yast2-kdump.changes 2017-06-05
18:49:32.092045045 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-kdump.new/yast2-kdump.changes
2017-06-22 10:35:36.742060583 +0200
@@ -1,0 +2,9 @@
+Tue Jun 20 12:19:21 UTC 2017 - gso...@suse.com
+
+- The alloc_mem parameter is verified to be in accordance with
+ documentation (bsc#1045098).
+- Pop-up is suppressed from command line when the user enables or
+ disables kdump (bsc#1045103).
+- 3.2.5
+
+-------------------------------------------------------------------
Old:
----
yast2-kdump-3.2.4.tar.bz2
New:
----
yast2-kdump-3.2.5.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-kdump.spec ++++++
--- /var/tmp/diff_new_pack.CZGrM8/_old 2017-06-22 10:35:37.381970379 +0200
+++ /var/tmp/diff_new_pack.CZGrM8/_new 2017-06-22 10:35:37.389969251 +0200
@@ -17,7 +17,7 @@
Name: yast2-kdump
-Version: 3.2.4
+Version: 3.2.5
Release: 0
Summary: Configuration of kdump
License: GPL-2.0
++++++ yast2-kdump-3.2.4.tar.bz2 -> yast2-kdump-3.2.5.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-kdump-3.2.4/package/yast2-kdump.changes
new/yast2-kdump-3.2.5/package/yast2-kdump.changes
--- old/yast2-kdump-3.2.4/package/yast2-kdump.changes 2017-06-02
16:29:19.757793732 +0200
+++ new/yast2-kdump-3.2.5/package/yast2-kdump.changes 2017-06-20
16:35:47.736649735 +0200
@@ -1,4 +1,13 @@
-------------------------------------------------------------------
+Tue Jun 20 12:19:21 UTC 2017 - gso...@suse.com
+
+- The alloc_mem parameter is verified to be in accordance with
+ documentation (bsc#1045098).
+- Pop-up is suppressed from command line when the user enables or
+ disables kdump (bsc#1045103).
+- 3.2.5
+
+-------------------------------------------------------------------
Fri Jun 2 13:44:40 UTC 2017 - gso...@suse.com
- Added allocate memory high in commandline (FATE#320016)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-kdump-3.2.4/package/yast2-kdump.spec
new/yast2-kdump-3.2.5/package/yast2-kdump.spec
--- old/yast2-kdump-3.2.4/package/yast2-kdump.spec 2017-06-02
16:29:19.757793732 +0200
+++ new/yast2-kdump-3.2.5/package/yast2-kdump.spec 2017-06-20
16:35:47.736649735 +0200
@@ -17,7 +17,7 @@
Name: yast2-kdump
-Version: 3.2.4
+Version: 3.2.5
Release: 0
Summary: Configuration of kdump
License: GPL-2.0
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-kdump-3.2.4/src/clients/kdump.rb
new/yast2-kdump-3.2.5/src/clients/kdump.rb
--- old/yast2-kdump-3.2.4/src/clients/kdump.rb 2017-06-02 16:29:19.757793732
+0200
+++ new/yast2-kdump-3.2.5/src/clients/kdump.rb 2017-06-20 16:35:47.736649735
+0200
@@ -734,6 +734,8 @@
end
+ # Only numbers are allowed as allow_mem_high and allow_mem_low values
+ ALLOC_MEM_REGEXP = /\D/
def cmdKdumpStartup(options)
options = deep_copy(options)
@@ -742,6 +744,11 @@
Kdump.add_crashkernel_param = true
alloc_mem_low, alloc_mem_high = options["alloc_mem"].split(',')
Kdump.allocated_memory = { low: alloc_mem_low, high: alloc_mem_high }
+ unless alloc_mem_low =~ ALLOC_MEM_REGEXP &&
+ (alloc_mem_high.nil? || alloc_mem_high =~ ALLOC_MEM_REGEXP)
+ CommandLine.Error(_("Invalid allocation memory parameter"))
+ return false
+ end
#TRANSLATORS: CommandLine printed text
if Kdump.crashkernel_list_ranges
CommandLine.Print(
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-kdump-3.2.4/src/modules/Kdump.rb
new/yast2-kdump-3.2.5/src/modules/Kdump.rb
--- old/yast2-kdump-3.2.4/src/modules/Kdump.rb 2017-06-02 16:29:19.765793732
+0200
+++ new/yast2-kdump-3.2.5/src/modules/Kdump.rb 2017-06-20 16:35:47.760649735
+0200
@@ -531,7 +531,7 @@
Service.Stop(KDUMP_SERVICE_NAME) if Service.active?(KDUMP_SERVICE_NAME)
end
- if reboot_needed && Mode.normal
+ if reboot_needed && Mode.normal && !Mode.commandline
Popup.Message(_("To apply changes a reboot is necessary."))
end
