Hello community, here is the log from the commit of package yast2 for openSUSE:Factory checked in at 2017-07-11 08:23:49 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2 (Old) and /work/SRC/openSUSE:Factory/.yast2.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2" Tue Jul 11 08:23:49 2017 rev:406 rq:509120 version:3.3.0 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2/yast2.changes 2017-07-02 13:32:35.318353535 +0200 +++ /work/SRC/openSUSE:Factory/.yast2.new/yast2.changes 2017-07-11 08:23:51.324287791 +0200 @@ -1,0 +2,7 @@ +Mon Jul 10 08:09:15 UTC 2017 - [email protected] + +- Fix omitting button in CWM::Dialog and make API consistent with + CWM.show (boo#1039901) +- 3.3.0 + +------------------------------------------------------------------- Old: ---- yast2-3.2.40.tar.bz2 New: ---- yast2-3.3.0.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2.spec ++++++ --- /var/tmp/diff_new_pack.1QL23Z/_old 2017-07-11 08:23:51.936201488 +0200 +++ /var/tmp/diff_new_pack.1QL23Z/_new 2017-07-11 08:23:51.936201488 +0200 @@ -17,7 +17,7 @@ Name: yast2 -Version: 3.2.40 +Version: 3.3.0 Release: 0 Summary: YaST2 - Main Package License: GPL-2.0 ++++++ yast2-3.2.40.tar.bz2 -> yast2-3.3.0.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-3.2.40/library/cwm/src/lib/cwm/dialog.rb new/yast2-3.3.0/library/cwm/src/lib/cwm/dialog.rb --- old/yast2-3.2.40/library/cwm/src/lib/cwm/dialog.rb 2017-06-29 10:29:38.862757928 +0200 +++ new/yast2-3.3.0/library/cwm/src/lib/cwm/dialog.rb 2017-07-10 11:22:16.620954640 +0200 @@ -1,6 +1,8 @@ require "yast" +require "abstract_method" Yast.import "CWM" +Yast.import "Wizard" module CWM # An OOP API and the pieces missing from {Yast::CWMClass#show Yast::CWM.show}: @@ -43,24 +45,24 @@ end # The :back button - # @return [String,true,nil] button label, - # `true` to use the default label, or `nil` to omit the button + # @return [String, nil] button label, + # `nil` to use the default label, `""` to omit the button def back_button - true + nil end # The :abort button - # @return [String,true,nil] button label, - # `true` to use the default label, or `nil` to omit the button + # @return [String, nil] button label, + # `nil` to use the default label, `""` to omit the button def abort_button - true + nil end # The :next button - # @return [String,true,nil] button label, - # `true` to use the default label, or `nil` to omit the button + # @return [String, nil] button label, + # `nil` to use the default label, `""` to omit the button def next_button - true + nil end # @return [Array<Symbol>] @@ -86,19 +88,11 @@ Yast::CWM.show( contents, caption: title, - back_button: replace_true(back_button, Yast::Label.BackButton), - abort_button: replace_true(abort_button, Yast::Label.AbortButton), - next_button: replace_true(next_button, Yast::Label.NextButton), + back_button: back_button, + abort_button: abort_button, + next_button: next_button, skip_store_for: skip_store_for ) end - - def replace_true(value, replacement) - if value == true - replacement - else - value - end - end end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-3.2.40/library/cwm/src/lib/cwm/rspec.rb new/yast2-3.3.0/library/cwm/src/lib/cwm/rspec.rb --- old/yast2-3.2.40/library/cwm/src/lib/cwm/rspec.rb 2017-06-29 10:29:38.866757928 +0200 +++ new/yast2-3.3.0/library/cwm/src/lib/cwm/rspec.rb 2017-07-10 11:22:16.620954640 +0200 @@ -137,20 +137,20 @@ end describe "#back_button" do - it "produces a String or true or nil" do - expect(subject.back_button).to be_a(String).or be(true).or be_nil + it "produces a String or nil" do + expect(subject.back_button).to be_a(String).or be_nil end end describe "#abort_button" do - it "produces a String or true or nil" do - expect(subject.abort_button).to be_a(String).or be(true).or be_nil + it "produces a String or nil" do + expect(subject.abort_button).to be_a(String).or be_nil end end describe "#next_button" do - it "produces a String or true or nil" do - expect(subject.next_button).to be_a(String).or be(true).or be_nil + it "produces a String or nil" do + expect(subject.next_button).to be_a(String).or be_nil end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-3.2.40/library/cwm/src/modules/CWM.rb new/yast2-3.3.0/library/cwm/src/modules/CWM.rb --- old/yast2-3.2.40/library/cwm/src/modules/CWM.rb 2017-06-29 10:29:38.866757928 +0200 +++ new/yast2-3.3.0/library/cwm/src/modules/CWM.rb 2017-07-10 11:22:16.640954640 +0200 @@ -932,9 +932,12 @@ # Display the dialog and run its event loop using new widget API # @param [::CWM::WidgetTerm] contents is UI term including instances of {CWM::AbstractWidget} # @param [String] caption of dialog - # @param [String] back_button label for dialog back button - # @param [String] next_button label for dialog next button - # @param [String] abort_button label for dialog abort button + # @param [String, nil] back_button label for dialog back button, + # `nil` to use the default label, `""` to omit the button + # @param [String, nil] next_button label for dialog next button, + # `nil` to use the default label, `""` to omit the button + # @param [String, nil] abort_button label for dialog abort button, + # `nil` to use the default label, `""` to omit the button # @param [Array] skip_store_for list of events for which the value of the widget will not be stored. # Useful mainly when some widget returns an event that should not trigger the storing, # like a reset button or a redrawing. It will skip also validation, because it is not needed diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-3.2.40/library/cwm/test/dialog_test.rb new/yast2-3.3.0/library/cwm/test/dialog_test.rb --- old/yast2-3.2.40/library/cwm/test/dialog_test.rb 2017-06-29 10:29:38.910757928 +0200 +++ new/yast2-3.3.0/library/cwm/test/dialog_test.rb 2017-07-10 11:22:16.696954640 +0200 @@ -33,16 +33,4 @@ expect(subject.class.run).to eq(:launch) end end - - describe "#replace_true" do - it "replaces true" do - expect(subject.send(:replace_true, true, :new)).to eq :new - end - - it "does not replace others" do - expect(subject.send(:replace_true, nil, :new)).to eq nil - expect(subject.send(:replace_true, false, :new)).to eq false - expect(subject.send(:replace_true, :old, :new)).to eq :old - end - end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-3.2.40/package/yast2.changes new/yast2-3.3.0/package/yast2.changes --- old/yast2-3.2.40/package/yast2.changes 2017-06-29 10:29:39.958757928 +0200 +++ new/yast2-3.3.0/package/yast2.changes 2017-07-10 11:22:17.520954640 +0200 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Mon Jul 10 08:09:15 UTC 2017 - [email protected] + +- Fix omitting button in CWM::Dialog and make API consistent with + CWM.show (boo#1039901) +- 3.3.0 + +------------------------------------------------------------------- Fri Jun 23 07:26:03 UTC 2017 - [email protected] - Support for the new Expert Partitioner (boo#1039901): diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-3.2.40/package/yast2.spec new/yast2-3.3.0/package/yast2.spec --- old/yast2-3.2.40/package/yast2.spec 2017-06-29 10:29:39.958757928 +0200 +++ new/yast2-3.3.0/package/yast2.spec 2017-07-10 11:22:17.520954640 +0200 @@ -17,7 +17,7 @@ Name: yast2 -Version: 3.2.40 +Version: 3.3.0 Release: 0 Summary: YaST2 - Main Package License: GPL-2.0
