Hello community,
here is the log from the commit of package gstreamer-plugins-ugly for
openSUSE:Factory checked in at 2017-09-04 12:17:15
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/gstreamer-plugins-ugly (Old)
and /work/SRC/openSUSE:Factory/.gstreamer-plugins-ugly.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gstreamer-plugins-ugly"
Mon Sep 4 12:17:15 2017 rev:42 rq:519754 version:1.12.2
Changes:
--------
---
/work/SRC/openSUSE:Factory/gstreamer-plugins-ugly/gstreamer-plugins-ugly.changes
2017-07-17 09:03:50.869711591 +0200
+++
/work/SRC/openSUSE:Factory/.gstreamer-plugins-ugly.new/gstreamer-plugins-ugly.changes
2017-09-04 12:17:19.367787143 +0200
@@ -1,0 +2,34 @@
+Fri Aug 25 19:04:04 UTC 2017 - [email protected]
+
+- Add gst-ugly-fix-caps-and-memory-leaks.patch:
+ + x264enc: fix caps leak (bgo#784982).
+ + mpg123audiodec: fix caps leak (bgo#784982).
+ + dvdreadsrc: Fix string memory leak (bgo#785388).
+- Run spec-cleaner, modernize spec, add pkgconfig BuildRequires,
+ update make and makeinstall macros.
+- Replace glib2-devel, gstreamer-devel and
+ gstreamer-plugins-base-devel with pkgconfig(glib-2.0),
+ pkgconfig(gmodule-no-export-2.0), pkgconfig(gstreamer-1.0) and
+ pkgconfig(gstreamer-plugins-base-1.0) BuildRequires, align with
+ what configure looks for.
+- Drop conditional valgrind-devel BuildRequires, this type of
+ debugging is probably not done by users of binary packages.
+
+-------------------------------------------------------------------
+Thu Aug 24 19:31:39 UTC 2017 - [email protected]
+
+- Move libmp3lame-devel and pkgconfig(twolame) BuildRequires from
+ conditional BUILD_ORIG section to normal build, these
+ dependencies are now available in openSUSE.
+
+-------------------------------------------------------------------
+Thu Jul 20 10:18:07 UTC 2017 - [email protected]
+
+- Drop conditional ENABLE_MPG123 and ENABLE_A52DEC defines and
+ hence pkgconfig(libmpg123) and liba52-devel BuildRequires from
+ BUILDORIG/orig-addon. libmpg123 and a52dec are now available in
+ all supported versions of openSUSE.
+- Drop obsolete automake BuildRequires, we do not carry any
+ patches.
+
+-------------------------------------------------------------------
New:
----
gst-ugly-fix-caps-and-memory-leaks.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ gstreamer-plugins-ugly.spec ++++++
--- /var/tmp/diff_new_pack.MyqQ5x/_old 2017-09-04 12:17:20.307655017 +0200
+++ /var/tmp/diff_new_pack.MyqQ5x/_new 2017-09-04 12:17:20.307655017 +0200
@@ -22,13 +22,6 @@
# Use rpmbuild -D 'BUILD_ORIG 1' to build original code.
# Use rpmbuild -D 'BUILD_ORIG 1' -D 'BUILD_ORIG_ADDON 1' to build patched
build plus original as addon.
%define _experimental 0
-%if 0%{?suse_version} > 1320
-%define ENABLE_MPG123 1
-%define ENABLE_A52DEC 1
-%else
-%define ENABLE_MPG123 0
-%define ENABLE_A52DEC 0
-%endif
Name: gstreamer-plugins-ugly
Version: 1.12.2
@@ -39,37 +32,27 @@
Url: http://gstreamer.freedesktop.org/
Source:
http://gstreamer.freedesktop.org/src/gst-plugins-ugly/%{_name}-%{version}.tar.xz
Source99: baselibs.conf
-BuildRequires: automake
+# PATCH-FIX-UPSTREAM gst-ugly-fix-caps-and-memory-leaks.patch bgo#784982
bgo#785388 [email protected] -- Fix caps and memory leaks
+Patch0: gst-ugly-fix-caps-and-memory-leaks.patch
BuildRequires: gcc-c++
-BuildRequires: glib2-devel >= 2.40.0
-BuildRequires: gstreamer-devel >= 1.12.0
-BuildRequires: gstreamer-plugins-base-devel >= 1.12.0
BuildRequires: gtk-doc >= 1.12
+BuildRequires: liba52-devel
BuildRequires: libcdio-devel >= 0.76
BuildRequires: libdvdread-devel
+BuildRequires: libmp3lame-devel
BuildRequires: orc >= 0.4.16
+BuildRequires: pkgconfig
BuildRequires: python-base
-%ifarch %ix86 ppc x86_64
-BuildRequires: valgrind-devel
-%endif
-%if 0%{?ENABLE_MPG123}
+BuildRequires: pkgconfig(glib-2.0) >= 2.40.0
+BuildRequires: pkgconfig(gmodule-no-export-2.0)
+BuildRequires: pkgconfig(gstreamer-1.0) >= 1.12.0
+BuildRequires: pkgconfig(gstreamer-plugins-base-1.0) >= 1.12.0
BuildRequires: pkgconfig(libmpg123) >= 1.3
-%endif
-%if 0%{?ENABLE_A52DEC}
-BuildRequires: liba52-devel
-%endif
+BuildRequires: pkgconfig(twolame) >= 0.3.10
%if 0%{?BUILD_ORIG}
-BuildRequires: libmp3lame-devel
BuildRequires: pkgconfig(libmpeg2) >= 0.5.1
BuildRequires: pkgconfig(opencore-amrwb) >= 0.1.3
-BuildRequires: pkgconfig(twolame) >= 0.3.10
BuildRequires: pkgconfig(x264) >= 0.120
-%if ! 0%{?ENABLE_MPG123}
-BuildRequires: pkgconfig(libmpg123) >= 1.3
-%endif
-%if ! 0%{?ENABLE_A52DEC}
-BuildRequires: liba52-devel
-%endif
%endif
# Get minimum gstreamer and gstreamer-plugins-base required versions from
configure.ac
%define gstreamer_plugins_ugly_req %(xzgrep --text "^GST.*_REQ" %{S:0} | sort
-u | sed 's/GST_REQ=/gstreamer >= /;s/GSTPB_REQ=/gstreamer-plugins-base >= /' |
tr '\\n' ' ')
@@ -87,7 +70,6 @@
%else
Provides: patched_subset
%endif
-BuildRoot: %{_tmppath}/%{name}-%{version}-build
%description
GStreamer is a streaming media framework based on graphs of filters
@@ -141,11 +123,13 @@
installing new plug-ins.
%lang_package
+
%prep
%setup -q -n %{_name}-%{version}
+%patch0 -p1
%build
-%configure\
+%configure \
%if ! 0%{?BUILD_ORIG}
--with-package-name='openSUSE gstreamer-plugins-ugly package' \
--disable-asfdemux \
@@ -155,29 +139,28 @@
%if 0%{?_experimental}
--enable-experimental \
%endif
- --disable-static
-make %{?_smp_mflags}
+ --disable-static \
+ %{nil}
+%make_build
%install
-%makeinstall
-rm %{buildroot}%{_libdir}/gstreamer-%{gst_branch}/*.la
+%make_install
+find %{buildroot} -type f -name "*.la" -delete -print
%find_lang %{_name}-%{gst_branch}
%files
-%defattr(-, root, root)
-%doc COPYING
-%if 0%{?ENABLE_A52DEC}
+%license COPYING
%{_libdir}/gstreamer-%{gst_branch}/libgsta52dec.so
-%endif
%{_libdir}/gstreamer-%{gst_branch}/libgstcdio.so
%{_libdir}/gstreamer-%{gst_branch}/libgstdvdlpcmdec.so
%{_libdir}/gstreamer-%{gst_branch}/libgstdvdread.so
%{_libdir}/gstreamer-%{gst_branch}/libgstdvdsub.so
-%if 0%{?ENABLE_MPG123}
+%{_libdir}/gstreamer-%{gst_branch}/libgstlame.so
%{_libdir}/gstreamer-%{gst_branch}/libgstmpg123.so
-%endif
%{_libdir}/gstreamer-%{gst_branch}/libgstrealmedia.so
+%{_libdir}/gstreamer-%{gst_branch}/libgsttwolame.so
%{_libdir}/gstreamer-%{gst_branch}/libgstxingmux.so
+
%if 0%{?_experimental}
# Place experimental plugins here.
%endif
@@ -186,20 +169,11 @@
%if 0%{?BUILD_ORIG_ADDON}
%files orig-addon
-%defattr(-, root, root)
-%endif
-%if ! 0%{?ENABLE_A52DEC}
-%{_libdir}/gstreamer-%{gst_branch}/libgsta52dec.so
%endif
%{_libdir}/gstreamer-%{gst_branch}/libgstamrnb.so
%{_libdir}/gstreamer-%{gst_branch}/libgstamrwbdec.so
%{_libdir}/gstreamer-%{gst_branch}/libgstasf.so
-%{_libdir}/gstreamer-%{gst_branch}/libgstlame.so
%{_libdir}/gstreamer-%{gst_branch}/libgstmpeg2dec.so
-%if ! 0%{?ENABLE_MPG123}
-%{_libdir}/gstreamer-%{gst_branch}/libgstmpg123.so
-%endif
-%{_libdir}/gstreamer-%{gst_branch}/libgsttwolame.so
%{_libdir}/gstreamer-%{gst_branch}/libgstx264.so
%{_datadir}/gstreamer-%{gst_branch}/presets/GstAmrnbEnc.prs
%{_datadir}/gstreamer-%{gst_branch}/presets/GstX264Enc.prs
@@ -208,7 +182,6 @@
%files lang -f %{_name}-%{gst_branch}.lang
%files doc
-%defattr(-, root, root)
%doc AUTHORS NEWS README RELEASE REQUIREMENTS
%{_datadir}/gtk-doc/html/gst-plugins-ugly-plugins-%{gst_branch}
++++++ gst-ugly-fix-caps-and-memory-leaks.patch ++++++
>From b93b55cc62e5e5d99afb2642fe55e108827569b7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= <[email protected]>
Date: Sat, 15 Jul 2017 14:59:42 +0100
Subject: x264enc: fix caps leak
Move creation of supported sink pads into class_init function
which is also the only place where they're used. Unref the
caps when no longer needed, the pad template will take its
own ref.
https://bugzilla.gnome.org/show_bug.cgi?id=784982
diff --git a/ext/x264/gstx264enc.c b/ext/x264/gstx264enc.c
index 49d99f1..4287cf9 100644
--- a/ext/x264/gstx264enc.c
+++ b/ext/x264/gstx264enc.c
@@ -140,7 +140,6 @@ struct _GstX264EncVTable
static GstX264EncVTable default_vtable;
static GstX264EncVTable *vtable_8bit = NULL, *vtable_10bit = NULL;
-static GstCaps *supported_sinkcaps = NULL;
#define LOAD_SYMBOL(name) G_STMT_START { \
if (!g_module_symbol (module, #name, (gpointer *) &vtable->name)) { \
@@ -324,14 +323,6 @@ load_x264_libraries (void)
if (!vtable_8bit && !vtable_10bit)
return FALSE;
- supported_sinkcaps = gst_caps_new_simple ("video/x-raw",
- "framerate", GST_TYPE_FRACTION_RANGE, 0, 1, G_MAXINT, 1,
- "width", GST_TYPE_INT_RANGE, 16, G_MAXINT,
- "height", GST_TYPE_INT_RANGE, 16, G_MAXINT, NULL);
-
- gst_x264_enc_add_x264_chroma_format (gst_caps_get_structure
- (supported_sinkcaps, 0), TRUE, TRUE, TRUE);
-
return TRUE;
}
@@ -874,6 +865,7 @@ gst_x264_enc_class_init (GstX264EncClass * klass)
GstVideoEncoderClass *gstencoder_class;
const gchar *partitions = NULL;
GstPadTemplate *sink_templ;
+ GstCaps *supported_sinkcaps;
x264enc_defaults = g_string_new ("");
@@ -1134,9 +1126,19 @@ gst_x264_enc_class_init (GstX264EncClass * klass)
"Josef Zlomek <[email protected]>, "
"Mark Nauwelaerts <[email protected]>");
+ supported_sinkcaps = gst_caps_new_simple ("video/x-raw",
+ "framerate", GST_TYPE_FRACTION_RANGE, 0, 1, G_MAXINT, 1,
+ "width", GST_TYPE_INT_RANGE, 16, G_MAXINT,
+ "height", GST_TYPE_INT_RANGE, 16, G_MAXINT, NULL);
+
+ gst_x264_enc_add_x264_chroma_format (gst_caps_get_structure
+ (supported_sinkcaps, 0), TRUE, TRUE, TRUE);
+
sink_templ = gst_pad_template_new ("sink",
GST_PAD_SINK, GST_PAD_ALWAYS, supported_sinkcaps);
+ gst_caps_unref (supported_sinkcaps);
+
gst_element_class_add_pad_template (element_class, sink_templ);
gst_element_class_add_static_pad_template (element_class, &src_factory);
}
--
cgit v0.10.2
>From f0fb1135c676e90cf8036ad2ef4bb56bf9f5348a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= <[email protected]>
Date: Sat, 15 Jul 2017 14:57:49 +0100
Subject: mpg123audiodec: fix caps leak
The pad template takes its own ref, so we should unref the caps.
https://bugzilla.gnome.org/show_bug.cgi?id=784982
diff --git a/ext/mpg123/gstmpg123audiodec.c b/ext/mpg123/gstmpg123audiodec.c
index cfd017e..fa6743c 100644
--- a/ext/mpg123/gstmpg123audiodec.c
+++ b/ext/mpg123/gstmpg123audiodec.c
@@ -167,6 +167,7 @@ gst_mpg123_audio_dec_class_init (GstMpg123AudioDecClass *
klass)
src_template_caps = gst_caps_from_string (s->str);
src_template = gst_pad_template_new ("src", GST_PAD_SRC, GST_PAD_ALWAYS,
src_template_caps);
+ gst_caps_unref (src_template_caps);
g_string_free (s, TRUE);
}
--
cgit v0.10.2
>From f0a224a90871fd07d1aaf3589482654a548dc388 Mon Sep 17 00:00:00 2001
From: Satya Prakash Gupta <[email protected]>
Date: Tue, 25 Jul 2017 13:36:17 +0530
Subject: dvdreadsrc: Fix string memory leak
https://bugzilla.gnome.org/show_bug.cgi?id=785388
diff --git a/ext/dvdread/dvdreadsrc.c b/ext/dvdread/dvdreadsrc.c
index 234f251..18e9f70 100644
--- a/ext/dvdread/dvdreadsrc.c
+++ b/ext/dvdread/dvdreadsrc.c
@@ -559,6 +559,7 @@ gst_dvd_read_src_goto_title (GstDvdReadSrc * src, gint
title, gint angle)
lang_code[0] = (u->lang_code >> 8) & 0xff;
lang_code[1] = u->lang_code & 0xff;
gst_structure_set (s, t, G_TYPE_STRING, lang_code, NULL);
+ g_free (t);
t = g_strdup_printf ("subpicture-%d-stream", i);
gst_structure_set (s, t, G_TYPE_INT, (int) sid, NULL);
g_free (t);
--
cgit v0.10.2
