Hello community,
here is the log from the commit of package rubygem-actionpack-5_1 for
openSUSE:Factory checked in at 2017-09-13 22:34:11
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/rubygem-actionpack-5_1 (Old)
and /work/SRC/openSUSE:Factory/.rubygem-actionpack-5_1.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "rubygem-actionpack-5_1"
Wed Sep 13 22:34:11 2017 rev:2 rq:523491 version:5.1.4
Changes:
--------
---
/work/SRC/openSUSE:Factory/rubygem-actionpack-5_1/rubygem-actionpack-5_1.changes
2017-09-04 12:38:59.101036442 +0200
+++
/work/SRC/openSUSE:Factory/.rubygem-actionpack-5_1.new/rubygem-actionpack-5_1.changes
2017-09-13 22:35:27.056395642 +0200
@@ -1,0 +2,6 @@
+Fri Sep 8 13:37:12 UTC 2017 - [email protected]
+
+- Update to version 5.1.4
+ see installed CHANGELOG.md
+
+-------------------------------------------------------------------
Old:
----
actionpack-5.1.3.gem
New:
----
actionpack-5.1.4.gem
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ rubygem-actionpack-5_1.spec ++++++
--- /var/tmp/diff_new_pack.SQZNy3/_old 2017-09-13 22:35:27.712303291 +0200
+++ /var/tmp/diff_new_pack.SQZNy3/_new 2017-09-13 22:35:27.712303291 +0200
@@ -24,7 +24,7 @@
#
Name: rubygem-actionpack-5_1
-Version: 5.1.3
+Version: 5.1.4
Release: 0
%define mod_name actionpack
%define mod_full_name %{mod_name}-%{version}
++++++ actionpack-5.1.3.gem -> actionpack-5.1.4.gem ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/CHANGELOG.md new/CHANGELOG.md
--- old/CHANGELOG.md 2017-08-03 21:13:04.000000000 +0200
+++ new/CHANGELOG.md 2017-09-08 02:49:01.000000000 +0200
@@ -1,3 +1,16 @@
+## Rails 5.1.4 (September 07, 2017) ##
+
+* Make `take_failed_screenshot` work within engine.
+
+ Fixes #30405.
+
+ *Yuji Yaginuma*
+
+## Rails 5.1.4.rc1 (August 24, 2017) ##
+
+* No changes.
+
+
## Rails 5.1.3 (August 03, 2017) ##
* No changes.
Binary files old/checksums.yaml.gz and new/checksums.yaml.gz differ
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_controller/railtie.rb
new/lib/action_controller/railtie.rb
--- old/lib/action_controller/railtie.rb 2017-08-03 21:13:04.000000000
+0200
+++ new/lib/action_controller/railtie.rb 2017-09-08 02:49:02.000000000
+0200
@@ -22,17 +22,19 @@
initializer "action_controller.parameters_config" do |app|
options = app.config.action_controller
- if options.delete(:raise_on_unfiltered_parameters)
- ActiveSupport::Deprecation.warn("raise_on_unfiltered_parameters is
deprecated and has no effect in Rails 5.1.")
- end
+ ActiveSupport.on_load(:action_controller, run_once: true) do
+ if options.delete(:raise_on_unfiltered_parameters)
+ ActiveSupport::Deprecation.warn("raise_on_unfiltered_parameters is
deprecated and has no effect in Rails 5.1.")
+ end
- ActionController::Parameters.permit_all_parameters =
options.delete(:permit_all_parameters) { false }
- if app.config.action_controller[:always_permitted_parameters]
- ActionController::Parameters.always_permitted_parameters =
- app.config.action_controller.delete(:always_permitted_parameters)
- end
- ActionController::Parameters.action_on_unpermitted_parameters =
options.delete(:action_on_unpermitted_parameters) do
- (Rails.env.test? || Rails.env.development?) ? :log : false
+ ActionController::Parameters.permit_all_parameters =
options.delete(:permit_all_parameters) { false }
+ if app.config.action_controller[:always_permitted_parameters]
+ ActionController::Parameters.always_permitted_parameters =
+ app.config.action_controller.delete(:always_permitted_parameters)
+ end
+ ActionController::Parameters.action_on_unpermitted_parameters =
options.delete(:action_on_unpermitted_parameters) do
+ (Rails.env.test? || Rails.env.development?) ? :log : false
+ end
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_dispatch/http/parameters.rb
new/lib/action_dispatch/http/parameters.rb
--- old/lib/action_dispatch/http/parameters.rb 2017-08-03 21:13:04.000000000
+0200
+++ new/lib/action_dispatch/http/parameters.rb 2017-09-08 02:49:02.000000000
+0200
@@ -55,7 +55,7 @@
query_parameters.dup
end
params.merge!(path_parameters)
- params = set_binary_encoding(params)
+ params = set_binary_encoding(params, params[:controller],
params[:action])
set_header("action_dispatch.request.parameters", params)
params
end
@@ -64,6 +64,7 @@
def path_parameters=(parameters) #:nodoc:
delete_header("action_dispatch.request.parameters")
+ parameters = set_binary_encoding(parameters, parameters[:controller],
parameters[:action])
# If any of the path parameters has an invalid encoding then
# raise since it's likely to trigger errors further on.
Request::Utils.check_param_encoding(parameters)
@@ -83,9 +84,10 @@
private
- def set_binary_encoding(params)
- action = params[:action]
- if binary_params_for?(action)
+ def set_binary_encoding(params, controller, action)
+ return params unless controller && controller.valid_encoding?
+
+ if binary_params_for?(controller, action)
ActionDispatch::Request::Utils.each_param_value(params) do |param|
param.force_encoding ::Encoding::ASCII_8BIT
end
@@ -93,8 +95,8 @@
params
end
- def binary_params_for?(action)
- controller_class.binary_params_for?(action)
+ def binary_params_for?(controller, action)
+ controller_class_for(controller).binary_params_for?(action)
rescue NameError
false
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_dispatch/http/request.rb
new/lib/action_dispatch/http/request.rb
--- old/lib/action_dispatch/http/request.rb 2017-08-03 21:13:04.000000000
+0200
+++ new/lib/action_dispatch/http/request.rb 2017-09-08 02:49:02.000000000
+0200
@@ -74,10 +74,13 @@
def controller_class
params = path_parameters
+ params[:action] ||= "index"
+ controller_class_for(params[:controller])
+ end
- if params.key?(:controller)
- controller_param = params[:controller].underscore
- params[:action] ||= "index"
+ def controller_class_for(name)
+ if name
+ controller_param = name.underscore
const_name = "#{controller_param.camelize}Controller"
ActiveSupport::Dependencies.constantize(const_name)
else
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_dispatch/journey/router/utils.rb
new/lib/action_dispatch/journey/router/utils.rb
--- old/lib/action_dispatch/journey/router/utils.rb 2017-08-03
21:13:04.000000000 +0200
+++ new/lib/action_dispatch/journey/router/utils.rb 2017-09-08
02:49:02.000000000 +0200
@@ -13,11 +13,13 @@
# normalize_path("") # => "/"
# normalize_path("/%ab") # => "/%AB"
def self.normalize_path(path)
+ encoding = path.encoding
path = "/#{path}"
path.squeeze!("/".freeze)
path.sub!(%r{/+\Z}, "".freeze)
path.gsub!(/(%[a-f0-9]{2})/) { $1.upcase }
path = "/" if path == "".freeze
+ path.force_encoding(encoding)
path
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_dispatch/journey/router.rb
new/lib/action_dispatch/journey/router.rb
--- old/lib/action_dispatch/journey/router.rb 2017-08-03 21:13:04.000000000
+0200
+++ new/lib/action_dispatch/journey/router.rb 2017-09-08 02:49:02.000000000
+0200
@@ -41,6 +41,10 @@
req.path_info = "/" + req.path_info unless
req.path_info.start_with? "/"
end
+ parameters = route.defaults.merge parameters.transform_values { |val|
+ val.dup.force_encoding(::Encoding::UTF_8)
+ }
+
req.path_parameters = set_params.merge parameters
status, headers, body = route.app.serve(req)
@@ -65,6 +69,7 @@
rails_req.path_info = match.post_match.sub(/^([^\/])/, '/\1')
end
+ parameters = route.defaults.merge parameters
yield(route, parameters)
end
end
@@ -117,7 +122,7 @@
routes.map! { |r|
match_data = r.path.match(req.path_info)
- path_parameters = r.defaults.dup
+ path_parameters = {}
match_data.names.zip(match_data.captures) { |name, val|
path_parameters[name.to_sym] = Utils.unescape_uri(val) if val
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_dispatch/system_testing/server.rb
new/lib/action_dispatch/system_testing/server.rb
--- old/lib/action_dispatch/system_testing/server.rb 2017-08-03
21:13:04.000000000 +0200
+++ new/lib/action_dispatch/system_testing/server.rb 2017-09-08
02:49:02.000000000 +0200
@@ -3,6 +3,12 @@
module ActionDispatch
module SystemTesting
class Server # :nodoc:
+ class << self
+ attr_accessor :silence_puma
+ end
+
+ self.silence_puma = false
+
def run
register
setup
@@ -11,7 +17,12 @@
private
def register
Capybara.register_server :rails_puma do |app, port, host|
- Rack::Handler::Puma.run(app, Port: port, Threads: "0:1")
+ Rack::Handler::Puma.run(
+ app,
+ Port: port,
+ Threads: "0:1",
+ Silent: self.class.silence_puma
+ )
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb
new/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb
--- old/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb
2017-08-03 21:13:04.000000000 +0200
+++ new/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb
2017-09-08 02:49:02.000000000 +0200
@@ -42,11 +42,15 @@
end
def image_path
- "tmp/screenshots/#{image_name}.png"
+ @image_path ||=
absolute_image_path.relative_path_from(Pathname.pwd).to_s
+ end
+
+ def absolute_image_path
+ Rails.root.join("tmp/screenshots/#{image_name}.png")
end
def save_image
- page.save_screenshot(Rails.root.join(image_path))
+ page.save_screenshot(absolute_image_path)
end
def output_type
@@ -67,10 +71,10 @@
case output_type
when "artifact"
- message << "\e]1338;url=artifact://#{image_path}\a\n"
+ message << "\e]1338;url=artifact://#{absolute_image_path}\a\n"
when "inline"
- name = inline_base64(File.basename(image_path))
- image = inline_base64(File.read(image_path))
+ name = inline_base64(File.basename(absolute_image_path))
+ image = inline_base64(File.read(absolute_image_path))
message <<
"\e]1337;File=name=#{name};height=400px;inline=1:#{image}\a\n"
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_pack/gem_version.rb
new/lib/action_pack/gem_version.rb
--- old/lib/action_pack/gem_version.rb 2017-08-03 21:13:04.000000000 +0200
+++ new/lib/action_pack/gem_version.rb 2017-09-08 02:49:02.000000000 +0200
@@ -7,7 +7,7 @@
module VERSION
MAJOR = 5
MINOR = 1
- TINY = 3
+ TINY = 4
PRE = nil
STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/metadata new/metadata
--- old/metadata 2017-08-03 21:13:04.000000000 +0200
+++ new/metadata 2017-09-08 02:49:01.000000000 +0200
@@ -1,14 +1,14 @@
--- !ruby/object:Gem::Specification
name: actionpack
version: !ruby/object:Gem::Version
- version: 5.1.3
+ version: 5.1.4
platform: ruby
authors:
- David Heinemeier Hansson
autorequire:
bindir: bin
cert_chain: []
-date: 2017-08-03 00:00:00.000000000 Z
+date: 2017-09-08 00:00:00.000000000 Z
dependencies:
- !ruby/object:Gem::Dependency
name: activesupport
@@ -16,14 +16,14 @@
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 5.1.3
+ version: 5.1.4
type: :runtime
prerelease: false
version_requirements: !ruby/object:Gem::Requirement
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 5.1.3
+ version: 5.1.4
- !ruby/object:Gem::Dependency
name: rack
requirement: !ruby/object:Gem::Requirement
@@ -42,14 +42,14 @@
name: rack-test
requirement: !ruby/object:Gem::Requirement
requirements:
- - - "~>"
+ - - ">="
- !ruby/object:Gem::Version
version: 0.6.3
type: :runtime
prerelease: false
version_requirements: !ruby/object:Gem::Requirement
requirements:
- - - "~>"
+ - - ">="
- !ruby/object:Gem::Version
version: 0.6.3
- !ruby/object:Gem::Dependency
@@ -92,28 +92,28 @@
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 5.1.3
+ version: 5.1.4
type: :runtime
prerelease: false
version_requirements: !ruby/object:Gem::Requirement
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 5.1.3
+ version: 5.1.4
- !ruby/object:Gem::Dependency
name: activemodel
requirement: !ruby/object:Gem::Requirement
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 5.1.3
+ version: 5.1.4
type: :development
prerelease: false
version_requirements: !ruby/object:Gem::Requirement
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 5.1.3
+ version: 5.1.4
description: Web apps on Rails. Simple, battle-tested conventions for building
and
testing MVC web applications. Works with any Rack-compatible server.
email: [email protected]
@@ -304,7 +304,7 @@
requirements:
- none
rubyforge_project:
-rubygems_version: 2.6.12
+rubygems_version: 2.6.13
signing_key:
specification_version: 4
summary: Web-flow and rendering framework putting the VC in MVC (part of
Rails).
