Hello community,
here is the log from the commit of package rubygem-actionpack-4_2 for
openSUSE:Factory checked in at 2017-09-26 21:13:06
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/rubygem-actionpack-4_2 (Old)
and /work/SRC/openSUSE:Factory/.rubygem-actionpack-4_2.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "rubygem-actionpack-4_2"
Tue Sep 26 21:13:06 2017 rev:12 rq:514918 version:4.2.9
Changes:
--------
---
/work/SRC/openSUSE:Factory/rubygem-actionpack-4_2/rubygem-actionpack-4_2.changes
2017-03-21 22:50:36.497798339 +0100
+++
/work/SRC/openSUSE:Factory/.rubygem-actionpack-4_2.new/rubygem-actionpack-4_2.changes
2017-09-26 21:13:26.310697176 +0200
@@ -1,0 +2,34 @@
+Thu Aug 3 18:58:34 UTC 2017 - [email protected]
+
+- updated to version 4.2.9
+ see installed CHANGELOG.md
+
+ ## Rails 4.2.9 (June 26, 2017) ##
+
+ * Use more specific check for :format in route path
+
+ The current check for whether to add an optional format to the path is
very lax
+ and will match things like `:format_id` where there are nested
resources, e.g:
+
+ ``` ruby
+ resources :formats do
+ resources :items
+ end
+ ```
+
+ Fix this by using a more restrictive regex pattern that looks for the
patterns
+ `(.:format)`, `.:format` or `/` at the end of the path. Note that we
need to
+ allow for multiple closing parenthesis since the route may be of this
form:
+
+ ``` ruby
+ get "/books(/:action(.:format))", controller: "books"
+ ```
+
+ This probably isn't what's intended since it means that the default
index action
+ route doesn't support a format but we have a test for it so we need to
allow it.
+
+ Fixes #28517.
+
+ *Andrew White*
+
+-------------------------------------------------------------------
Old:
----
actionpack-4.2.8.gem
New:
----
actionpack-4.2.9.gem
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ rubygem-actionpack-4_2.spec ++++++
--- /var/tmp/diff_new_pack.dDquLt/_old 2017-09-26 21:13:26.934609443 +0200
+++ /var/tmp/diff_new_pack.dDquLt/_new 2017-09-26 21:13:26.938608880 +0200
@@ -24,7 +24,7 @@
#
Name: rubygem-actionpack-4_2
-Version: 4.2.8
+Version: 4.2.9
Release: 0
%define mod_name actionpack
%define mod_full_name %{mod_name}-%{version}
++++++ actionpack-4.2.8.gem -> actionpack-4.2.9.gem ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/CHANGELOG.md new/CHANGELOG.md
--- old/CHANGELOG.md 2017-02-21 17:07:01.000000000 +0100
+++ new/CHANGELOG.md 2017-06-26 23:29:05.000000000 +0200
@@ -1,3 +1,32 @@
+## Rails 4.2.9 (June 26, 2017) ##
+
+* Use more specific check for :format in route path
+
+ The current check for whether to add an optional format to the path is
very lax
+ and will match things like `:format_id` where there are nested resources,
e.g:
+
+ ``` ruby
+ resources :formats do
+ resources :items
+ end
+ ```
+
+ Fix this by using a more restrictive regex pattern that looks for the
patterns
+ `(.:format)`, `.:format` or `/` at the end of the path. Note that we need
to
+ allow for multiple closing parenthesis since the route may be of this form:
+
+ ``` ruby
+ get "/books(/:action(.:format))", controller: "books"
+ ```
+
+ This probably isn't what's intended since it means that the default index
action
+ route doesn't support a format but we have a test for it so we need to
allow it.
+
+ Fixes #28517.
+
+ *Andrew White*
+
+
## Rails 4.2.8 (February 21, 2017) ##
* No changes.
Binary files old/checksums.yaml.gz and new/checksums.yaml.gz differ
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_dispatch/journey/router/utils.rb
new/lib/action_dispatch/journey/router/utils.rb
--- old/lib/action_dispatch/journey/router/utils.rb 2017-02-21
17:07:01.000000000 +0100
+++ new/lib/action_dispatch/journey/router/utils.rb 2017-06-26
23:29:05.000000000 +0200
@@ -13,11 +13,13 @@
# normalize_path("") # => "/"
# normalize_path("/%ab") # => "/%AB"
def self.normalize_path(path)
+ encoding = path.encoding
path = "/#{path}"
path.squeeze!('/')
path.sub!(%r{/+\Z}, '')
path.gsub!(/(%[a-f0-9]{2})/) { $1.upcase }
- path = '/' if path == ''
+ path = "/" if path == "".freeze
+ path.force_encoding(encoding)
path
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_dispatch/routing/mapper.rb
new/lib/action_dispatch/routing/mapper.rb
--- old/lib/action_dispatch/routing/mapper.rb 2017-02-21 17:07:01.000000000
+0100
+++ new/lib/action_dispatch/routing/mapper.rb 2017-06-26 23:29:05.000000000
+0200
@@ -60,6 +60,7 @@
class Mapping #:nodoc:
ANCHOR_CHARACTERS_REGEX = %r{\A(\\A|\^)|(\\Z|\\z|\$)\Z}
+ OPTIONAL_FORMAT_REGEX = %r{(?:\(\.:format\)+|\.:format|/)\Z}
attr_reader :requirements, :conditions, :defaults
attr_reader :to, :default_controller, :default_action, :as, :anchor
@@ -144,7 +145,7 @@
end
def optional_format?(path, format)
- format != false && !path.include?(':format') &&
!path.end_with?('/')
+ format != false && path !~ OPTIONAL_FORMAT_REGEX
end
def normalize_options!(options, formatted, path_params, path_ast,
modyoule)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_pack/gem_version.rb
new/lib/action_pack/gem_version.rb
--- old/lib/action_pack/gem_version.rb 2017-02-21 17:07:01.000000000 +0100
+++ new/lib/action_pack/gem_version.rb 2017-06-26 23:29:05.000000000 +0200
@@ -7,7 +7,7 @@
module VERSION
MAJOR = 4
MINOR = 2
- TINY = 8
+ TINY = 9
PRE = nil
STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/metadata new/metadata
--- old/metadata 2017-02-21 17:07:01.000000000 +0100
+++ new/metadata 2017-06-26 23:29:05.000000000 +0200
@@ -1,14 +1,14 @@
--- !ruby/object:Gem::Specification
name: actionpack
version: !ruby/object:Gem::Version
- version: 4.2.8
+ version: 4.2.9
platform: ruby
authors:
- David Heinemeier Hansson
autorequire:
bindir: bin
cert_chain: []
-date: 2017-02-21 00:00:00.000000000 Z
+date: 2017-06-26 00:00:00.000000000 Z
dependencies:
- !ruby/object:Gem::Dependency
name: activesupport
@@ -16,14 +16,14 @@
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 4.2.8
+ version: 4.2.9
type: :runtime
prerelease: false
version_requirements: !ruby/object:Gem::Requirement
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 4.2.8
+ version: 4.2.9
- !ruby/object:Gem::Dependency
name: rack
requirement: !ruby/object:Gem::Requirement
@@ -98,28 +98,28 @@
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 4.2.8
+ version: 4.2.9
type: :runtime
prerelease: false
version_requirements: !ruby/object:Gem::Requirement
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 4.2.8
+ version: 4.2.9
- !ruby/object:Gem::Dependency
name: activemodel
requirement: !ruby/object:Gem::Requirement
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 4.2.8
+ version: 4.2.9
type: :development
prerelease: false
version_requirements: !ruby/object:Gem::Requirement
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 4.2.8
+ version: 4.2.9
description: Web apps on Rails. Simple, battle-tested conventions for building
and
testing MVC web applications. Works with any Rack-compatible server.
email: [email protected]
@@ -300,7 +300,7 @@
requirements:
- none
rubyforge_project:
-rubygems_version: 2.6.10
+rubygems_version: 2.6.12
signing_key:
specification_version: 4
summary: Web-flow and rendering framework putting the VC in MVC (part of
Rails).
