Hello community, here is the log from the commit of package gtk3 for openSUSE:Factory checked in at 2017-10-20 16:12:44 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gtk3 (Old) and /work/SRC/openSUSE:Factory/.gtk3.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gtk3" Fri Oct 20 16:12:44 2017 rev:118 rq:533693 version:3.22.24 Changes: -------- --- /work/SRC/openSUSE:Factory/gtk3/gtk3.changes 2017-10-06 11:01:09.814092221 +0200 +++ /work/SRC/openSUSE:Factory/.gtk3.new/gtk3.changes 2017-10-20 16:12:45.996426473 +0200 @@ -1,0 +2,9 @@ +Mon Oct 11 04:18:16 UTC 2017 - [email protected] + +- Add gtk3-restore-filechooser-click-behavior.patch: The + clicking behavior introduced by commit#fb0a13b has confused many + users in the past 2 years. By reverting the commit, the patch + makes the primary button clicking behave as consistent as most + users has been used to (bgo#758065 bsc#1057471). + +------------------------------------------------------------------- New: ---- gtk3-restore-filechooser-click-behavior.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gtk3.spec ++++++ --- /var/tmp/diff_new_pack.MyggIo/_old 2017-10-20 16:12:47.276366682 +0200 +++ /var/tmp/diff_new_pack.MyggIo/_new 2017-10-20 16:12:47.276366682 +0200 @@ -46,6 +46,8 @@ Patch1: gtk3-path-local.patch # PATCH-FIX-UPSTREAM gtk3-silence-log-spew-blank-cursors.patch bgo#775217 [email protected] -- wayland: Don't spew warnings for blank cursors Patch2: gtk3-silence-log-spew-blank-cursors.patch +# PATCH-FIX-OPENSUSE gtk3-restore-filechooser-click-behavior.patch bgo#758065 bsc#1057471 [email protected] -- revert upstream commit#fb0a13b to restore the single click behavior +Patch3: gtk3-restore-filechooser-click-behavior.patch BuildRequires: cups-devel >= 1.2 BuildRequires: docbook-xsl-stylesheets BuildRequires: fdupes @@ -366,6 +368,7 @@ # Patch disabled, needs rebase. #patch1 -p0 %patch2 -p1 +%patch3 -p1 %build # Disabled since patch 1 is in need of rebase ++++++ gtk3-restore-filechooser-click-behavior.patch ++++++ Index: gtk+-3.22.24/gtk/gtkfilechooserwidget.c =================================================================== --- gtk+-3.22.24.orig/gtk/gtkfilechooserwidget.c +++ gtk+-3.22.24/gtk/gtkfilechooserwidget.c @@ -77,7 +77,6 @@ #include "gtkseparator.h" #include "gtkmodelbutton.h" #include "gtkgesturelongpress.h" -#include "gtkdebug.h" #include <cairo-gobject.h> @@ -2379,25 +2378,6 @@ list_popup_menu_cb (GtkWidget return TRUE; } -static void -get_selection_modifiers (GtkWidget *widget, - GdkEventButton *event, - gboolean *modify, - gboolean *extend) -{ - GdkModifierType mask; - - *modify = FALSE; - *extend = FALSE; - - mask = gtk_widget_get_modifier_mask (widget, GDK_MODIFIER_INTENT_MODIFY_SELECTION); - if ((event->state & mask) == mask) - *modify = TRUE; - mask = gtk_widget_get_modifier_mask (widget, GDK_MODIFIER_INTENT_EXTEND_SELECTION); - if ((event->state & mask) == mask) - *extend = TRUE; -} - /* Callback used when a button is pressed on the file list. We trap button 3 to * bring up a popup menu. */ @@ -2408,40 +2388,10 @@ list_button_press_event_cb (GtkWidget { GtkFileChooserWidgetPrivate *priv = impl->priv; static gboolean in_press = FALSE; - GtkTreePath *path; - GtkTreeViewColumn *column; - GdkDevice *device; - gboolean modify, extend, is_touchscreen; if (in_press) return FALSE; - device = gdk_event_get_source_device ((GdkEvent *) event); - is_touchscreen = gtk_simulate_touchscreen () || - gdk_device_get_source (device) == GDK_SOURCE_TOUCHSCREEN; - - get_selection_modifiers (widget, event, &modify, &extend); - if (!is_touchscreen && - !modify && !extend && - event->type == GDK_BUTTON_PRESS && - event->button == GDK_BUTTON_PRIMARY && - gtk_tree_view_get_path_at_pos (GTK_TREE_VIEW (priv->browse_files_tree_view), - event->x, event->y, - &path, &column, NULL, NULL)) - { - GtkTreeSelection *selection; - - selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->browse_files_tree_view)); - if (gtk_tree_selection_path_is_selected (selection, path)) - { - list_row_activated (GTK_TREE_VIEW (priv->browse_files_tree_view), path, column, impl); - gtk_tree_path_free (path); - return TRUE; - } - - gtk_tree_path_free (path); - } - if (!gdk_event_triggers_context_menu ((GdkEvent *) event)) return FALSE;
