Hello community, here is the log from the commit of package gnome-shell for openSUSE:Factory checked in at 2017-10-21 20:16:59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-shell (Old) and /work/SRC/openSUSE:Factory/.gnome-shell.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-shell" Sat Oct 21 20:16:59 2017 rev:142 rq:535495 version:3.26.1 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-shell/gnome-shell.changes 2017-10-20 16:13:16.507001178 +0200 +++ /work/SRC/openSUSE:Factory/.gnome-shell.new/gnome-shell.changes 2017-10-21 20:17:00.936374904 +0200 @@ -1,0 +2,7 @@ +Thu Oct 19 21:57:31 UTC 2017 - [email protected] + +- Add + gnome-shell-unset-primary-and-bottom-monitor-when-headless.patch: + fixes a crash when the monitor is turned off (bgo#788607). + +------------------------------------------------------------------- New: ---- gnome-shell-unset-primary-and-bottom-monitor-when-headless.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-shell.spec ++++++ --- /var/tmp/diff_new_pack.N0731m/_old 2017-10-21 20:17:02.220314781 +0200 +++ /var/tmp/diff_new_pack.N0731m/_new 2017-10-21 20:17:02.260312908 +0200 @@ -41,6 +41,8 @@ Patch3: gnome-shell-Avoid-loginDialog-grab-focus-when-locked.patch # PATCH-FIX-UPSTREAM gnome-shell-osk-dont-popup-when-not-needed.patch bgo#788188 [email protected] -- Stop the on-screen keyboard from showing up when touchscreen use doesn't activate a text field; patch taken from upstream bug report Patch4: gnome-shell-osk-dont-popup-when-not-needed.patch +# PATCH-FIX-UPSTREAM gnome-shell-unset-primary-and-bottom-monitor-when-headless.patch bgo#788607 [email protected] -- unset primary and button monitor when headless; fixes a crash. +Patch5: gnome-shell-unset-primary-and-bottom-monitor-when-headless.patch ## NOTE: Keep SLE only patches at bottom (starting on 1000). # PATCH-FEATURE-SLE gnome-shell-gdm-login-applet.patch fate#314545 [email protected] -- Add an applet on login UI to display suse icon, product name, hostname. @@ -190,6 +192,7 @@ %patch2 -p1 %patch3 -p1 %patch4 -p1 +%patch5 -p1 %if !0%{?is_opensuse} %patch1001 -p1 ++++++ gnome-shell-unset-primary-and-bottom-monitor-when-headless.patch ++++++ >From 5f8a5114833d7d31d4bd64affbd323bb7252c3d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20=C3=85dahl?= <[email protected]> Date: Fri, 6 Oct 2017 20:26:24 -0400 Subject: [PATCH] layout: Unset primary and bottom monitor when headless We were handling being initially headless by only setting the primary and bottom monitor if there was any primary monitor, then checking the primary monitor reference before making calls assuming there was any monitors. What we didn't do was unset the primary and bottom monitor when going headless, meaning that temporarly disconnecting a monitor while having windows open caused an assert to be triggered due to various code paths taking the path assuming there are valid monitors. Unsetting both the primary and bottom monitor when going headless avoids the code paths in the same way as they were avoided when starting headless. https://bugzilla.gnome.org/show_bug.cgi?id=788607 --- js/ui/layout.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/js/ui/layout.js b/js/ui/layout.js index 304c2a152..2f1894775 100644 --- a/js/ui/layout.js +++ b/js/ui/layout.js @@ -351,6 +351,9 @@ var LayoutManager = new Lang.Class({ this._loadBackground(); this._pendingLoadBackground = false; } + } else { + this.primaryMonitor = null; + this.bottomMonitor = null; } }, -- 2.14.2
