Hello community, here is the log from the commit of package lensfun for openSUSE:Factory checked in at 2017-10-25 17:45:37 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/lensfun (Old) and /work/SRC/openSUSE:Factory/.lensfun.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "lensfun" Wed Oct 25 17:45:37 2017 rev:44 rq:536408 version:0.3.2 Changes: -------- --- /work/SRC/openSUSE:Factory/lensfun/lensfun.changes 2017-07-25 11:39:21.385151860 +0200 +++ /work/SRC/openSUSE:Factory/.lensfun.new/lensfun.changes 2017-10-25 17:45:38.892689873 +0200 @@ -1,0 +2,6 @@ +Tue Oct 24 13:39:30 UTC 2017 - [email protected] + +- Add lensfun_fix_memory_leak.patch to add a virtual destructor to + avoid a memory leaks. + +------------------------------------------------------------------- New: ---- lensfun_fix_memory_leak.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ lensfun.spec ++++++ --- /var/tmp/diff_new_pack.n3572u/_old 2017-10-25 17:45:39.604656458 +0200 +++ /var/tmp/diff_new_pack.n3572u/_new 2017-10-25 17:45:39.608656271 +0200 @@ -31,6 +31,8 @@ Patch1: lensfun-test-database.patch # PATCH-FIX-UPSTREAM 0060-Various-CMake-patches-from-the-mailing-list.patch Patch2: 0060-Various-CMake-patches-from-the-mailing-list.patch +# PATCH-FIX-UPSTREAM lensfun_fix_memory_leak.patch +Patch3: lensfun_fix_memory_leak.patch BuildRequires: cmake BuildRequires: doxygen BuildRequires: fdupes @@ -132,6 +134,7 @@ %patch0 -p1 %patch1 -p1 %patch2 -p1 +%patch3 -p1 echo 'HTML_TIMESTAMP=NO' >> docs/doxyfile.in.cmake # fix python shebangs sed -i \ ++++++ lensfun_fix_memory_leak.patch ++++++ commit 3226f7589f476b291e8baad2fcf3593db6f14cf9 Author: Sebastian Kraft <[email protected]> AuthorDate: Sat Jul 22 19:34:34 2017 +0200 Commit: Sebastian Kraft <[email protected]> CommitDate: Sat Jul 22 19:34:34 2017 +0200 Add a virtual destructor to lfCallbackData to avoid memory leak in derived classes --- include/lensfun/lensfun.h.in | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/lensfun/lensfun.h.in b/include/lensfun/lensfun.h.in index ee9cf41..ec87b3c 100644 --- a/include/lensfun/lensfun.h.in +++ b/include/lensfun/lensfun.h.in @@ -1909,18 +1909,22 @@ typedef void (*lfModifyColorFunc) (void *data, float x, float y, typedef void (*lfModifyCoordFunc) (void *data, float *iocoord, int count); // @cond - +#ifdef __cplusplus + /// Common ancestor for lfCoordCallbackData and lfColorCallbackData struct lfCallbackData { int priority; void *data; size_t data_size; + + virtual ~lfCallbackData() {}; }; // A test point in the autoscale algorithm typedef struct { float angle, dist; } lfPoint; +#endif // @endcond /**
