Hello community, here is the log from the commit of package karchive for openSUSE:Factory checked in at 2017-11-16 14:35:41 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/karchive (Old) and /work/SRC/openSUSE:Factory/.karchive.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "karchive" Thu Nov 16 14:35:41 2017 rev:47 rq:541636 version:5.40.0 Changes: -------- --- /work/SRC/openSUSE:Factory/karchive/karchive.changes 2017-10-27 13:54:06.436530811 +0200 +++ /work/SRC/openSUSE:Factory/.karchive.new/karchive.changes 2017-11-16 14:36:30.752464231 +0100 @@ -1,0 +2,11 @@ +Mon Nov 13 07:01:13 CET 2017 - [email protected] + +- Update to 5.40.0 + * New feature release + * For more details please see: + * https://www.kde.org/announcements/kde-frameworks-5.40.0.php +- Changes since 5.39.0: + * Fix potential mem leak. Fix logic + * Fix some cppcheck warning + +------------------------------------------------------------------- Old: ---- karchive-5.39.0.tar.xz New: ---- karchive-5.40.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ karchive.spec ++++++ --- /var/tmp/diff_new_pack.t41xtB/_old 2017-11-16 14:36:31.464438421 +0100 +++ /var/tmp/diff_new_pack.t41xtB/_new 2017-11-16 14:36:31.468438276 +0100 @@ -17,13 +17,13 @@ %define lname libKF5Archive5 -%define _tar_path 5.39 +%define _tar_path 5.40 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) %{!?_kf5_bugfix_version: %global _kf5_bugfix_version %(echo %{_kf5_version} | awk -F. '{print $1"."$2}')} Name: karchive -Version: 5.39.0 +Version: 5.40.0 Release: 0 BuildRequires: cmake >= 3.0 BuildRequires: extra-cmake-modules >= %{_kf5_bugfix_version} ++++++ karchive-5.39.0.tar.xz -> karchive-5.40.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/karchive-5.39.0/CMakeLists.txt new/karchive-5.40.0/CMakeLists.txt --- old/karchive-5.39.0/CMakeLists.txt 2017-10-07 13:08:10.000000000 +0200 +++ new/karchive-5.40.0/CMakeLists.txt 2017-11-04 22:37:30.000000000 +0100 @@ -1,10 +1,10 @@ cmake_minimum_required(VERSION 3.0) -set(KF5_VERSION "5.39.0") # handled by release scripts +set(KF5_VERSION "5.40.0") # handled by release scripts project(KArchive VERSION ${KF5_VERSION}) include(FeatureSummary) -find_package(ECM 5.39.0 NO_MODULE) +find_package(ECM 5.40.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules";) feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/karchive-5.39.0/src/k7zip.cpp new/karchive-5.40.0/src/k7zip.cpp --- old/karchive-5.39.0/src/k7zip.cpp 2017-10-07 13:08:10.000000000 +0200 +++ new/karchive-5.40.0/src/k7zip.cpp 2017-11-04 22:37:30.000000000 +0100 @@ -871,9 +871,8 @@ packSizes.append(readNumber()); } - int type; for (;;) { - type = readByte(); + int type = readByte(); if (type == kEnd) { break; } @@ -1730,9 +1729,7 @@ unpackSizes.append(symLink.size()); } fileInfos.append(fileInfo); - } - - if (entry->isDirectory()) { + } else if (entry->isDirectory()) { fileInfo->attributes = FILE_ATTRIBUTE_DIRECTORY; fileInfo->attributes |= FILE_ATTRIBUTE_UNIX_EXTENSION + ((entry->permissions() & 0xFFFF) << 16); fileInfo->isDir = true; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/karchive-5.39.0/src/ktar.cpp new/karchive-5.40.0/src/ktar.cpp --- old/karchive-5.39.0/src/ktar.cpp 2017-10-07 13:08:10.000000000 +0200 +++ new/karchive-5.40.0/src/ktar.cpp 2017-11-04 22:37:30.000000000 +0100 @@ -501,6 +501,8 @@ Q_ASSERT(isdir); if (isdir) { setRootDir(static_cast<KArchiveDirectory *>(e)); + } else { + delete e; } } else { rootDir()->addEntry(e); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/karchive-5.39.0/src/kzip.cpp new/karchive-5.40.0/src/kzip.cpp --- old/karchive-5.39.0/src/kzip.cpp 2017-10-07 13:08:10.000000000 +0200 +++ new/karchive-5.40.0/src/kzip.cpp 2017-11-04 22:37:30.000000000 +0100 @@ -450,8 +450,6 @@ // KArchive::open() opened the underlying device already. quint64 offset = 0; // holds offset, where we read - int n; - // contains information gathered from the local file headers QHash<QByteArray, ParseFileInfo> pfi_map; @@ -463,7 +461,7 @@ for (;;) { // repeat until 'end of entries' signature is reached //qCDebug(KArchiveLog) << "loop starts"; //qCDebug(KArchiveLog) << "dev->pos() now : " << dev->pos(); - n = dev->read(buffer, 4); + int n = dev->read(buffer, 4); if (n < 4) { setErrorString(tr("Invalid ZIP file. Unexpected end of file. (Error code: %1)").arg(1));
