Hello community, here is the log from the commit of package gnome-photos for openSUSE:Factory checked in at 2017-12-06 08:50:47 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-photos (Old) and /work/SRC/openSUSE:Factory/.gnome-photos.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-photos" Wed Dec 6 08:50:47 2017 rev:37 rq:548513 version:3.26.2 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-photos/gnome-photos.changes 2017-11-10 14:44:09.768792692 +0100 +++ /work/SRC/openSUSE:Factory/.gnome-photos.new/gnome-photos.changes 2017-12-06 08:50:50.777991702 +0100 @@ -1,0 +2,17 @@ +Thu Nov 23 22:06:01 UTC 2017 - [email protected] + +- Add upstream stable commits: + + Add gnome-photos-properties-dialog-dont-leak.patch: + properties-dialog: Don't leak the error. + + Add gnome-photos-main-toolbar-dont-leak.patch: main-toolbar: + Don't leak the preview's GMenu. + + Add gnome-photos-nb-translations.patch: Add updated Norwegian + bokmål translation. +- Run spec-cleaner, modernize spec, use autosetup and make_build + macros. +- Drop hicolor-icon-theme BuildRequires: No longer needed. +- Replace update-desktop-files with desktop-file-utils + BuildRequires and no longer pass suse_update_desktop_file macro: + Align more closely with what upstream expects. + +------------------------------------------------------------------- New: ---- gnome-photos-main-toolbar-dont-leak.patch gnome-photos-nb-translations.patch gnome-photos-properties-dialog-dont-leak.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-photos.spec ++++++ --- /var/tmp/diff_new_pack.iUBzMZ/_old 2017-12-06 08:50:51.281973251 +0100 +++ /var/tmp/diff_new_pack.iUBzMZ/_new 2017-12-06 08:50:51.285973105 +0100 @@ -23,15 +23,23 @@ License: GPL-3.0+ Group: Productivity/Graphics/Viewers Url: https://wiki.gnome.org/Design/Apps/Photos -Source: https://download.gnome.org/sources/gnome-photos/3.26/%{name}-%{version}.tar.xz -# Technically seen, glib2-tools would require this, but it introduces a loop there. So explictly require here + +Source0: https://download.gnome.org/sources/gnome-photos/3.26/%{name}-%{version}.tar.xz +# PATCH-FIX-UPSTREAM gnome-photos-properties-dialog-dont-leak.patch [email protected] -- properties-dialog: Don't leak the error +Patch0: gnome-photos-properties-dialog-dont-leak.patch +# PATCH-FIX-UPSTREAM gnome-photos-main-toolbar-dont-leak.patch [email protected] -- main-toolbar: Don't leak the preview's GMenu +Patch1: gnome-photos-main-toolbar-dont-leak.patch +# PATCH-FIX-UPSTREAM gnome-photos-nb-translations.patch [email protected] -- Add updated Norwegian bokmål translation +Patch2: gnome-photos-nb-translations.patch + +BuildRequires: desktop-file-utils BuildRequires: fdupes +# Technically seen, glib2-tools would require this, but it introduces a loop there. So explictly require here BuildRequires: gdk-pixbuf-loader-rsvg -BuildRequires: hicolor-icon-theme BuildRequires: itstool BuildRequires: libjpeg-devel BuildRequires: libtool -BuildRequires: update-desktop-files +BuildRequires: pkgconfig BuildRequires: yelp-tools BuildRequires: pkgconfig(babl) BuildRequires: pkgconfig(cairo) >= 1.14.0 @@ -61,7 +69,6 @@ Requires: tracker # If we want to be able to send photos to a remote DLNA renderer, we require the dbus service for it Recommends: dbus(dleyna-renderer-service) -BuildRoot: %{_tmppath}/%{name}-%{version}-build %description Photos, like Documents, Music and Videos, is one of the core GNOME @@ -82,22 +89,24 @@ %lang_package + %prep -%setup -q +%autosetup -p1 %build %configure -make %{?_smp_mflags} +%make_build %install %make_install + rm %{buildroot}%{_datadir}/doc/%{name}/{ARTISTS,AUTHORS,ChangeLog,COPYING,NEWS,README} -%suse_update_desktop_file org.gnome.Photos %find_lang %{name} %{?no_lang_C} %fdupes %{buildroot}%{_datadir} %files -%doc ChangeLog README COPYING +%license COPYING +%doc ChangeLog README %{_bindir}/%{name} %{_datadir}/icons/hicolor/*/apps/org.gnome.Photos* %dir %{_datadir}/appdata @@ -109,7 +118,7 @@ %{_libexecdir}/gnome-photos-thumbnailer %files -n gnome-shell-search-provider-gnome-photos -# Own dirs so we don't have to depend on gnome-shell -- should probably be split into own package. +# Own dirs so we don't have to depend on gnome-shell. %dir %{_datadir}/gnome-shell %dir %{_datadir}/gnome-shell/search-providers %{_datadir}/gnome-shell/search-providers/org.gnome.Photos.search-provider.ini ++++++ gnome-photos-main-toolbar-dont-leak.patch ++++++ >From 58afe6a3cafb7a2eeb7c6e08a6b83d684edc44e7 Mon Sep 17 00:00:00 2001 From: Debarshi Ray <[email protected]> Date: Mon, 6 Nov 2017 17:36:02 +0100 Subject: main-toolbar: Don't leak the preview's GMenu --- src/photos-main-toolbar.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/photos-main-toolbar.c b/src/photos-main-toolbar.c index a1135db..1c65535 100644 --- a/src/photos-main-toolbar.c +++ b/src/photos-main-toolbar.c @@ -506,7 +506,7 @@ photos_main_toolbar_populate_for_overview (PhotosMainToolbar *self) static void photos_main_toolbar_populate_for_preview (PhotosMainToolbar *self) { - GMenu *preview_menu; + GMenu *preview_menu = NULL; GtkWidget *back_button; GtkWidget *edit_button; GtkWidget *image; @@ -565,6 +565,8 @@ photos_main_toolbar_populate_for_preview (PhotosMainToolbar *self) G_CALLBACK (photos_main_toolbar_item_active_changed), self, G_CONNECT_SWAPPED); + + g_object_unref (preview_menu); } -- cgit v0.12 ++++++ gnome-photos-nb-translations.patch ++++++ ++++ 1147 lines (skipped) ++++++ gnome-photos-properties-dialog-dont-leak.patch ++++++ >From 0cdca1a6ba6d8d3c5b24125e861d2c5d9aec53fc Mon Sep 17 00:00:00 2001 From: Debarshi Ray <[email protected]> Date: Mon, 6 Nov 2017 16:02:43 +0100 Subject: properties-dialog: Don't leak the error --- src/photos-properties-dialog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/photos-properties-dialog.c b/src/photos-properties-dialog.c index 22129b4..04a6bb9 100644 --- a/src/photos-properties-dialog.c +++ b/src/photos-properties-dialog.c @@ -232,6 +232,7 @@ photos_properties_dialog_location_query_executed (GObject *source_object, GAsync if (error != NULL) { g_warning ("Unable to query latitude and longitude: %s", error->message); + g_error_free (error); goto out; } -- cgit v0.12
