Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2017-12-13 11:58:49 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virt-manager" Wed Dec 13 11:58:49 2017 rev:163 rq:556304 version:1.4.3 Changes: -------- --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2017-12-08 13:02:11.707268513 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new/virt-manager.changes 2017-12-13 11:58:52.355218175 +0100 @@ -1,0 +2,7 @@ +Mon Dec 11 14:50:59 MST 2017 - [email protected] + +- bsc#1071825 - AttributeError: 'NoneType' object has no attribute + 'change_run_text' + virtman-register-delete-event-for-details-dialog.patch + +------------------------------------------------------------------- @@ -1178,0 +1186,6 @@ +- Fix GUI failure to display addition of a second disk + Dropped virtman-device-flags.patch + +------------------------------------------------------------------- +Wed Jul 9 09:50:14 MDT 2014 - [email protected] + @@ -1543,0 +1557,13 @@ + +------------------------------------------------------------------- +Fri Mar 14 11:33:09 MDT 2014 - [email protected] + +- For Xen always have the arch expander expanded. +- For Xen and KVM default to Network install if host was installed + from the network +- Default to a bridge with an actual inet address if available + virtinst-modify-gui-defaults.patch +- We are not supporting PV ISO installs with virt-install. + Drop the following patches + virtinst-allow-pv-iso-install.patch + virtman-allow-pv-iso-install.patch New: ---- virtman-register-delete-event-for-details-dialog.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ virt-manager.spec ++++++ --- /var/tmp/diff_new_pack.z949Qv/_old 2017-12-13 11:58:54.643107728 +0100 +++ /var/tmp/diff_new_pack.z949Qv/_new 2017-12-13 11:58:54.647107535 +0100 @@ -126,6 +126,7 @@ Patch207: 0002-virtinst-python3-avoid-comparison-of-None-and-int.patch Patch208: 0003-virtinst-python3-avoid-using-long-type.patch Patch209: 0004-virtinst-python3-use-binary-mode-for-kernel.patch +Patch210: virtman-register-delete-event-for-details-dialog.patch BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -297,6 +298,7 @@ %patch207 -p1 %patch208 -p1 %patch209 -p1 +%patch210 -p1 %build %if %{qemu_user} ++++++ virtman-register-delete-event-for-details-dialog.patch ++++++ References: bsc#1071825 Running under python3 the delete-event as defined in details.ui and connected in details.py does not get called when the top right (x) button on the dialog is clicked. It appears that even though this code is unchanged and works on python2, it is not recognized as a top level dialog on python3 and therefore we explicitly need to set the connection event. Not getting the event to cleanup leaves us in a bad state for when the details dialog is reopened. Index: virt-manager-1.4.3/virtManager/details.py =================================================================== --- virt-manager-1.4.3.orig/virtManager/details.py +++ virt-manager-1.4.3/virtManager/details.py @@ -596,6 +596,9 @@ class vmmDetails(vmmGObjectUI): self.console.details_auth_login), }) + # Make sure the delete event is properly registered for the details dialog + self.topwin.connect("delete-event", self._window_delete_event) + # Deliberately keep all this after signal connection self.vm.connect("state-changed", self.refresh_vm_state) self.vm.connect("resources-sampled", self.refresh_resources)
