Hello community,
here is the log from the commit of package libKF5NetworkManagerQt for
openSUSE:Factory checked in at 2018-01-09 14:45:29
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/libKF5NetworkManagerQt (Old)
and /work/SRC/openSUSE:Factory/.libKF5NetworkManagerQt.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libKF5NetworkManagerQt"
Tue Jan 9 14:45:29 2018 rev:45 rq:559477 version:5.41.0
Changes:
--------
---
/work/SRC/openSUSE:Factory/libKF5NetworkManagerQt/libKF5NetworkManagerQt.changes
2017-11-16 14:41:52.492797697 +0100
+++
/work/SRC/openSUSE:Factory/.libKF5NetworkManagerQt.new/libKF5NetworkManagerQt.changes
2018-01-09 14:45:32.093346299 +0100
@@ -1,0 +2,11 @@
+Sun Dec 17 09:43:49 CET 2017 - [email protected]
+
+- Update to 5.41.0
+ * New feature release
+ * For more details please see:
+ * https://www.kde.org/announcements/kde-frameworks-5.41.0.php
+- Changes since 5.40.0:
+ * Remove redundant map look-ups
+ * Don't do unnecessary QString allocations to convert parts of it into
strings
+
+-------------------------------------------------------------------
Old:
----
networkmanager-qt-5.40.0.tar.xz
New:
----
networkmanager-qt-5.41.0.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ libKF5NetworkManagerQt.spec ++++++
--- /var/tmp/diff_new_pack.cbbAB7/_old 2018-01-09 14:45:33.621274652 +0100
+++ /var/tmp/diff_new_pack.cbbAB7/_new 2018-01-09 14:45:33.625274465 +0100
@@ -17,13 +17,13 @@
%define soversion 6
-%define _tar_path 5.40
+%define _tar_path 5.41
# Full KF5 version (e.g. 5.33.0)
%{!?_kf5_version: %global _kf5_version %{version}}
# Last major and minor KF5 version (e.g. 5.33)
%{!?_kf5_bugfix_version: %global _kf5_bugfix_version %(echo %{_kf5_version} |
awk -F. '{print $1"."$2}')}
Name: libKF5NetworkManagerQt
-Version: 5.40.0
+Version: 5.41.0
Release: 0
Summary: A Qt wrapper for NetworkManager DBus API
License: LGPL-2.1 or LGPL-3.0
++++++ networkmanager-qt-5.40.0.tar.xz -> networkmanager-qt-5.41.0.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/networkmanager-qt-5.40.0/CMakeLists.txt
new/networkmanager-qt-5.41.0/CMakeLists.txt
--- old/networkmanager-qt-5.40.0/CMakeLists.txt 2017-11-04 22:50:19.000000000
+0100
+++ new/networkmanager-qt-5.41.0/CMakeLists.txt 2017-12-02 11:21:47.000000000
+0100
@@ -1,10 +1,10 @@
cmake_minimum_required(VERSION 3.0)
-set(KF5_VERSION "5.40.0") # handled by release scripts
+set(KF5_VERSION "5.41.0") # handled by release scripts
project(NetworkManagerQt VERSION ${KF5_VERSION})
include(FeatureSummary)
-find_package(ECM 5.40.0 NO_MODULE)
+find_package(ECM 5.41.0 NO_MODULE)
set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake
Modules." URL
"https://projects.kde.org/projects/kdesupport/extra-cmake-modules")
feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND
FATAL_ON_MISSING_REQUIRED_PACKAGES)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/networkmanager-qt-5.40.0/src/manager.cpp
new/networkmanager-qt-5.41.0/src/manager.cpp
--- old/networkmanager-qt-5.40.0/src/manager.cpp 2017-11-04
22:50:19.000000000 +0100
+++ new/networkmanager-qt-5.41.0/src/manager.cpp 2017-12-02
11:21:47.000000000 +0100
@@ -180,7 +180,7 @@
propertiesChanged(initialProperties);
}
- QTimer::singleShot(0, [this] { qobject_cast<SettingsPrivate
*>(settingsNotifier())->init(); });
+ QTimer::singleShot(0, [] { qobject_cast<SettingsPrivate
*>(settingsNotifier())->init(); });
if (iface.isValid()) {
QList <QDBusObjectPath> devices = iface.devices();
@@ -207,7 +207,7 @@
{
int x, y, z;
- QStringList sl = version.split('.');
+ const auto sl = version.splitRef('.');
if (sl.size() > 2) {
x = sl[0].toInt();
@@ -277,9 +277,10 @@
NetworkManager::Device::Ptr
NetworkManager::NetworkManagerPrivate::findRegisteredNetworkInterface(const
QString &uni)
{
NetworkManager::Device::Ptr networkInterface;
- if (networkInterfaceMap.contains(uni)) {
- if (networkInterfaceMap.value(uni)) {
- networkInterface = networkInterfaceMap.value(uni);
+ auto it = networkInterfaceMap.constFind(uni);
+ if (it != networkInterfaceMap.constEnd()) {
+ if (*it) {
+ networkInterface = *it;
} else {
networkInterface = createNetworkInterface(uni);
networkInterfaceMap[uni] = networkInterface;
@@ -292,9 +293,10 @@
{
NetworkManager::ActiveConnection::Ptr activeConnection;
if (!uni.isEmpty() && uni != QLatin1String("/")) {
- const bool contains = m_activeConnections.contains(uni);
- if (contains && m_activeConnections.value(uni)) {
- activeConnection = m_activeConnections.value(uni);
+ const auto it = m_activeConnections.constFind(uni);
+ const bool contains = it != m_activeConnections.constEnd();
+ if (contains && *it) {
+ activeConnection = *it;
} else {
activeConnection = NetworkManager::ActiveConnection::Ptr(new
NetworkManager::VpnConnection(uni), &QObject::deleteLater);
if (activeConnection->connection()) {