Hello community,
here is the log from the commit of package yast2-installation for
openSUSE:Factory checked in at 2018-01-28 00:38:28
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-installation (Old)
and /work/SRC/openSUSE:Factory/.yast2-installation.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-installation"
Sun Jan 28 00:38:28 2018 rev:392 rq:569878 version:4.0.26
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-installation/yast2-installation.changes
2018-01-17 21:43:13.921552512 +0100
+++
/work/SRC/openSUSE:Factory/.yast2-installation.new/yast2-installation.changes
2018-01-28 00:38:29.740117365 +0100
@@ -1,0 +2,30 @@
+Fri Jan 26 11:19:05 UTC 2018 - [email protected]
+
+- Start performing real installation with as much memory as
+ possible (bsc#1076768)
+- 4.0.26
+
+-------------------------------------------------------------------
+Mon Jan 22 17:25:35 UTC 2018 - [email protected]
+
+- Read the root_subvolume_read_only setting from its new location
+ (moved by libstorage-ng) in the control file (boo#1077047).
+- 4.0.25
+
+-------------------------------------------------------------------
+Fri Jan 19 14:27:55 UTC 2018 - [email protected]
+
+- save keyboard settings before console settings (bsc#1076798)
+- 4.0.24
+
+-------------------------------------------------------------------
+Thu Jan 18 12:48:55 UTC 2018 - [email protected]
+
+- Update YaST2-Firstboot.service: Depreciate plymouth --wait, add
+ conflict to plymouth start service.
+- Update YaST2-Second-Stage.service: Depreciate plymouth deactivate
+ command and add conflict to plymouth start service. For that will
+ block TTY device activation(bsc#1042554).
+- 4.0.23
+
+-------------------------------------------------------------------
Old:
----
yast2-installation-4.0.22.tar.bz2
New:
----
yast2-installation-4.0.26.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-installation.spec ++++++
--- /var/tmp/diff_new_pack.2LoEi1/_old 2018-01-28 00:38:30.368088110 +0100
+++ /var/tmp/diff_new_pack.2LoEi1/_new 2018-01-28 00:38:30.372087924 +0100
@@ -17,7 +17,7 @@
Name: yast2-installation
-Version: 4.0.22
+Version: 4.0.26
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
++++++ YaST2-Firstboot.service ++++++
--- /var/tmp/diff_new_pack.2LoEi1/_old 2018-01-28 00:38:30.420085688 +0100
+++ /var/tmp/diff_new_pack.2LoEi1/_new 2018-01-28 00:38:30.420085688 +0100
@@ -1,6 +1,7 @@
[Unit]
Description=YaST2 Firstboot
After=apparmor.service local-fs.target plymouth-start.service
YaST2-Second-Stage.service
+Conflicts=plymouth-start.service
[email protected] [email protected]
[email protected] [email protected]
Before=display-manager.service
ConditionPathExists=/var/lib/YaST2/reconfig_system
@@ -9,7 +10,6 @@
Type=oneshot
Environment=TERM=linux
ExecStartPre=-/usr/bin/plymouth quit
-ExecStartPre=-/usr/bin/plymouth --wait
ExecStart=/usr/lib/YaST2/startup/YaST2.Firstboot
ExecStartPost=/usr/bin/rm -f /var/lib/YaST2/reconfig_system
ExecStartPost=/usr/bin/systemctl restart systemd-vconsole-setup.service
++++++ YaST2-Second-Stage.service ++++++
--- /var/tmp/diff_new_pack.2LoEi1/_old 2018-01-28 00:38:30.444084570 +0100
+++ /var/tmp/diff_new_pack.2LoEi1/_new 2018-01-28 00:38:30.444084570 +0100
@@ -3,6 +3,7 @@
# If xinetd is enabled, make sure it's already running so we can stop it during
# initialization of the VNC server
After=apparmor.service local-fs.target plymouth-start.service
+Conflicts=plymouth-start.service
[email protected] [email protected]
[email protected] [email protected]
Before=display-manager.service
ConditionPathExists=/var/lib/YaST2/runme_at_boot
@@ -15,13 +16,7 @@
# and envvar extensions are still loaded, /etc/sysconfig/proxy values are still
# used correctly (see bnc#866692 and bnc#866692 for details).
Environment=TERM=linux PX_MODULE_PATH=""
-# Workaround of bug in plymouth --> using deactivate option
-# in second boot stage in order to start ncurses yast correctly
-# (bnc#886488)
-# If the system starts in multi-user mode plymouth will be quit while
-# installation in order to ensure that installation will be finished on
-# console 1 and the login prompt. (bnc#903682,889757,897956)
-ExecStartPre=-/bin/sh -c 'if [ -x /usr/bin/plymouth ] ; then if [
`/usr/bin/systemctl get-default` = "multi-user.target" ];then /usr/bin/plymouth
quit; else /usr/bin/plymouth deactivate --hide-splash; fi; fi'
+ExecStartPre=-/usr/bin/plymouth quit
ExecStart=/usr/lib/YaST2/startup/YaST2.Second-Stage
RemainAfterExit=yes
TimeoutSec=0
++++++ yast2-installation-4.0.22.tar.bz2 -> yast2-installation-4.0.26.tar.bz2
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-installation-4.0.22/doc/control-file.md
new/yast2-installation-4.0.26/doc/control-file.md
--- old/yast2-installation-4.0.22/doc/control-file.md 2018-01-10
17:42:08.000000000 +0100
+++ new/yast2-installation-4.0.26/doc/control-file.md 2018-01-26
15:08:01.000000000 +0100
@@ -538,33 +538,6 @@
</software>
```
-- *only\_update\_selected*
-
- One can update (only update packages already installed) or upgrade
- (also install new packages with new functionality). For example,
- SLES should do "update", not "upgrade" by default
-
-- *only\_update\_selected\_reverse\_list*
-
- Inverts the *only\_update\_selected* for products defined as list of
- regular expressions matching installed product name (SuSE-release).
-
-```xml
- <!--
- Only update packages but install new packages
- when upgrading any SUSE Linux or openSUSE
- -->
- <software>
- <only_update_selected config:type="boolean">true</only_update_selected>
- <only_update_selected_reverse_list config:type="list">
- <regexp_item>^SUSE Linux [0-9].*</regexp_item>
- <regexp_item>^openSUSE [0-9].*</regexp_item>
- </only_update_selected_reverse_list>
- </software>
-```
-
-The other option defines how product upgrading in general is defined.
-
- *products\_supported\_for\_upgrade*
List of known products supported for upgrade (SuSE-release). Old
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-4.0.22/package/YaST2-Firstboot.service
new/yast2-installation-4.0.26/package/YaST2-Firstboot.service
--- old/yast2-installation-4.0.22/package/YaST2-Firstboot.service
2018-01-10 17:42:08.000000000 +0100
+++ new/yast2-installation-4.0.26/package/YaST2-Firstboot.service
2018-01-26 15:08:01.000000000 +0100
@@ -1,6 +1,7 @@
[Unit]
Description=YaST2 Firstboot
After=apparmor.service local-fs.target plymouth-start.service
YaST2-Second-Stage.service
+Conflicts=plymouth-start.service
[email protected] [email protected]
[email protected] [email protected]
Before=display-manager.service
ConditionPathExists=/var/lib/YaST2/reconfig_system
@@ -9,7 +10,6 @@
Type=oneshot
Environment=TERM=linux
ExecStartPre=-/usr/bin/plymouth quit
-ExecStartPre=-/usr/bin/plymouth --wait
ExecStart=/usr/lib/YaST2/startup/YaST2.Firstboot
ExecStartPost=/usr/bin/rm -f /var/lib/YaST2/reconfig_system
ExecStartPost=/usr/bin/systemctl restart systemd-vconsole-setup.service
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-4.0.22/package/YaST2-Second-Stage.service
new/yast2-installation-4.0.26/package/YaST2-Second-Stage.service
--- old/yast2-installation-4.0.22/package/YaST2-Second-Stage.service
2018-01-10 17:42:08.000000000 +0100
+++ new/yast2-installation-4.0.26/package/YaST2-Second-Stage.service
2018-01-26 15:08:01.000000000 +0100
@@ -3,6 +3,7 @@
# If xinetd is enabled, make sure it's already running so we can stop it during
# initialization of the VNC server
After=apparmor.service local-fs.target plymouth-start.service
+Conflicts=plymouth-start.service
[email protected] [email protected]
[email protected] [email protected]
Before=display-manager.service
ConditionPathExists=/var/lib/YaST2/runme_at_boot
@@ -15,13 +16,7 @@
# and envvar extensions are still loaded, /etc/sysconfig/proxy values are still
# used correctly (see bnc#866692 and bnc#866692 for details).
Environment=TERM=linux PX_MODULE_PATH=""
-# Workaround of bug in plymouth --> using deactivate option
-# in second boot stage in order to start ncurses yast correctly
-# (bnc#886488)
-# If the system starts in multi-user mode plymouth will be quit while
-# installation in order to ensure that installation will be finished on
-# console 1 and the login prompt. (bnc#903682,889757,897956)
-ExecStartPre=-/bin/sh -c 'if [ -x /usr/bin/plymouth ] ; then if [
`/usr/bin/systemctl get-default` = "multi-user.target" ];then /usr/bin/plymouth
quit; else /usr/bin/plymouth deactivate --hide-splash; fi; fi'
+ExecStartPre=-/usr/bin/plymouth quit
ExecStart=/usr/lib/YaST2/startup/YaST2.Second-Stage
RemainAfterExit=yes
TimeoutSec=0
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-4.0.22/package/yast2-installation.changes
new/yast2-installation-4.0.26/package/yast2-installation.changes
--- old/yast2-installation-4.0.22/package/yast2-installation.changes
2018-01-10 17:42:08.000000000 +0100
+++ new/yast2-installation-4.0.26/package/yast2-installation.changes
2018-01-26 15:08:01.000000000 +0100
@@ -1,8 +1,38 @@
-------------------------------------------------------------------
+Fri Jan 26 11:19:05 UTC 2018 - [email protected]
+
+- Start performing real installation with as much memory as
+ possible (bsc#1076768)
+- 4.0.26
+
+-------------------------------------------------------------------
+Mon Jan 22 17:25:35 UTC 2018 - [email protected]
+
+- Read the root_subvolume_read_only setting from its new location
+ (moved by libstorage-ng) in the control file (boo#1077047).
+- 4.0.25
+
+-------------------------------------------------------------------
+Fri Jan 19 14:27:55 UTC 2018 - [email protected]
+
+- save keyboard settings before console settings (bsc#1076798)
+- 4.0.24
+
+-------------------------------------------------------------------
+Thu Jan 18 12:48:55 UTC 2018 - [email protected]
+
+- Update YaST2-Firstboot.service: Depreciate plymouth --wait, add
+ conflict to plymouth start service.
+- Update YaST2-Second-Stage.service: Depreciate plymouth deactivate
+ command and add conflict to plymouth start service. For that will
+ block TTY device activation(bsc#1042554).
+- 4.0.23
+
+-------------------------------------------------------------------
Wed Jan 10 14:32:39 UTC 2018 - [email protected]
- Fix initialization to copy the profile to /tmp/profile again
- (bsc#1075334)
+ (bsc#1075334)
- 4.0.22
-------------------------------------------------------------------
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-4.0.22/package/yast2-installation.spec
new/yast2-installation-4.0.26/package/yast2-installation.spec
--- old/yast2-installation-4.0.22/package/yast2-installation.spec
2018-01-10 17:42:08.000000000 +0100
+++ new/yast2-installation-4.0.26/package/yast2-installation.spec
2018-01-26 15:08:01.000000000 +0100
@@ -16,7 +16,7 @@
#
Name: yast2-installation
-Version: 4.0.22
+Version: 4.0.26
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-4.0.22/src/lib/installation/clients/inst_prepareprogress.rb
new/yast2-installation-4.0.26/src/lib/installation/clients/inst_prepareprogress.rb
---
old/yast2-installation-4.0.22/src/lib/installation/clients/inst_prepareprogress.rb
2018-01-10 17:42:08.000000000 +0100
+++
new/yast2-installation-4.0.26/src/lib/installation/clients/inst_prepareprogress.rb
2018-01-26 15:08:01.000000000 +0100
@@ -167,6 +167,13 @@
Builtins.y2milestone("END of inst_prepareprogress.ycp")
+ Builtins.y2milestone("Cleaning memory.")
+ Builtins.y2milestone("Memory
before:\n#{File.read("/proc/#{Process.pid}/status")}")
+ # clean as much memory as possible before doing real installation,
because some packages
+ # can have memory demanding scripts
+ GC.start
+ Builtins.y2milestone("Memory
after:\n#{File.read("/proc/#{Process.pid}/status")}")
+
@ret_val
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-4.0.22/src/lib/installation/clients/save_config_finish.rb
new/yast2-installation-4.0.26/src/lib/installation/clients/save_config_finish.rb
---
old/yast2-installation-4.0.22/src/lib/installation/clients/save_config_finish.rb
2018-01-10 17:42:08.000000000 +0100
+++
new/yast2-installation-4.0.26/src/lib/installation/clients/save_config_finish.rb
2018-01-26 15:08:01.000000000 +0100
@@ -138,6 +138,14 @@
end
Progress.NextStep
+ # save keyboard settings (via systemd-firstboot) before setting console
+ # otherwise they are not written (bsc#1076798)
+ if !minimal_inst
+ # progress step title
+ Progress.Title(_("Saving keyboard configuration..."))
+ Keyboard.Save
+ Progress.NextStep
+ end
if !Mode.update && !minimal_inst
# progress step title
Progress.Title(_("Saving language..."))
@@ -162,12 +170,6 @@
"second_stage_language" => @lang
)
end
- if !minimal_inst
- # progress step title
- Progress.Title(_("Saving keyboard configuration..."))
- Keyboard.Save
- Progress.NextStep
- end
# progress step title
Progress.Title(_("Saving product information..."))
ProductFeatures.Save
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-4.0.22/src/lib/installation/clients/umount_finish.rb
new/yast2-installation-4.0.26/src/lib/installation/clients/umount_finish.rb
--- old/yast2-installation-4.0.22/src/lib/installation/clients/umount_finish.rb
2018-01-10 17:42:08.000000000 +0100
+++ new/yast2-installation-4.0.26/src/lib/installation/clients/umount_finish.rb
2018-01-26 15:08:01.000000000 +0100
@@ -410,7 +410,13 @@
# should be set to read-only.
#
def root_subvol_read_only_configured?
- ProductFeatures.GetBooleanFeature("partitioning",
"root_subvolume_read_only")
+ # FIXME: this whole method should rely on Y2Storage::ProposalSettings.
+ # But right now there is no #root_subvolume_read_only method there
+
+ partitioning = ProductFeatures.GetSection("partitioning")
+ proposal = partitioning.nil? ? nil : partitioning["proposal"]
+ return false if proposal.nil?
+ proposal["root_subvolume_read_only"] == true
end
# Change /etc/fstab on the target to mount the root subvolume read-only.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-installation-4.0.22/test/lib/clients/umount_finish_test.rb
new/yast2-installation-4.0.26/test/lib/clients/umount_finish_test.rb
--- old/yast2-installation-4.0.22/test/lib/clients/umount_finish_test.rb
1970-01-01 01:00:00.000000000 +0100
+++ new/yast2-installation-4.0.26/test/lib/clients/umount_finish_test.rb
2018-01-26 15:08:01.000000000 +0100
@@ -0,0 +1,101 @@
+#!/usr/bin/env rspec
+
+require_relative "../../test_helper"
+require "installation/clients/umount_finish"
+
+Yast.import "ProductFeatures"
+
+describe Yast::UmountFinishClient do
+ subject(:client) { described_class.new }
+
+ describe "root_subvol_read_only_configured?" do
+ before do
+ Yast::ProductFeatures.Import(features)
+ end
+
+ after do
+ # Reset the product features to its default values after
+ # fiddling with then
+ Yast::ProductFeatures.Import({})
+ end
+
+ context "if there is no /partitioning section in the product features" do
+ let(:features) { {} }
+
+ it "returns false" do
+ expect(client.root_subvol_read_only_configured?).to eq false
+ end
+ end
+
+ context "if there is no /partitioning/proposal section in the product
features" do
+ let(:features) { { "partitioning" => {} } }
+
+ it "returns false" do
+ expect(client.root_subvol_read_only_configured?).to eq false
+ end
+ end
+
+ context "if root_subvolume_read_only is not set in /partitioning/proposal"
do
+ let(:features) do
+ { "partitioning" => { "proposal" => {} } }
+ end
+
+ it "returns false" do
+ expect(client.root_subvol_read_only_configured?).to eq false
+ end
+ end
+
+ context "if root_subvolume_read_only is set directly in the /partitioning
section" do
+ let(:features) do
+ { "partitioning" => { "root_subvolume_read_only" => true } }
+ end
+
+ it "returns false" do
+ expect(client.root_subvol_read_only_configured?).to eq false
+ end
+ end
+
+ context "if root_subvolume_read_only is set to true in the
/partitioning/proposal section" do
+ let(:features) do
+ {
+ "partitioning" => {
+ "proposal" => { "root_subvolume_read_only" => true }
+ }
+ }
+ end
+
+ it "returns true" do
+ expect(client.root_subvol_read_only_configured?).to eq true
+ end
+ end
+
+ context "if root_subvolume_read_only is set to false in
/partitioning/proposal section" do
+ let(:features) do
+ {
+ "partitioning" => {
+ "proposal" => { "root_subvolume_read_only" => false }
+ }
+ }
+ end
+
+ it "returns false" do
+ expect(client.root_subvol_read_only_configured?).to eq false
+ end
+ end
+
+ # Validation should protect us from this, but is not always checked
+ context "if root_subvolume_read_only has a non boolean value in
/partitioning/proposal section" do
+ let(:features) do
+ {
+ "partitioning" => {
+ "proposal" => { "root_subvolume_read_only" => "not so sure" }
+ }
+ }
+ end
+
+ it "returns false" do
+ expect(client.root_subvol_read_only_configured?).to eq false
+ end
+ end
+ end
+end
