Hello community, here is the log from the commit of package yast2-iscsi-lio-server for openSUSE:Factory checked in at 2018-01-31 19:53:22 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-iscsi-lio-server (Old) and /work/SRC/openSUSE:Factory/.yast2-iscsi-lio-server.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-iscsi-lio-server" Wed Jan 31 19:53:22 2018 rev:22 rq:571286 version:4.0.2 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-iscsi-lio-server/yast2-iscsi-lio-server.changes 2018-01-30 15:44:41.277808620 +0100 +++ /work/SRC/openSUSE:Factory/.yast2-iscsi-lio-server.new/yast2-iscsi-lio-server.changes 2018-01-31 19:53:53.231909328 +0100 @@ -1,0 +2,11 @@ +Tue Jan 30 13:50:53 UTC 2018 - ls...@suse.com + +- fate#323460, fate#319238 +- Add firewalld read / write +- Rename required backend package to python3-targetcli-fb +- Add message when failed to install python3-targetcli-fb +- Remove message which shown when user set userid = mutual_userid + Not leak this message since kernel keep slience. +-4.0.2 + +------------------------------------------------------------------- Old: ---- yast2-iscsi-lio-server-4.0.1.tar.bz2 New: ---- yast2-iscsi-lio-server-4.0.2.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-iscsi-lio-server.spec ++++++ --- /var/tmp/diff_new_pack.D6DWAn/_old 2018-01-31 19:53:55.399808510 +0100 +++ /var/tmp/diff_new_pack.D6DWAn/_new 2018-01-31 19:53:55.407808137 +0100 @@ -17,7 +17,7 @@ Name: yast2-iscsi-lio-server -Version: 4.0.1 +Version: 4.0.2 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-iscsi-lio-server-4.0.1.tar.bz2 -> yast2-iscsi-lio-server-4.0.2.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-lio-server-4.0.1/package/yast2-iscsi-lio-server.changes new/yast2-iscsi-lio-server-4.0.2/package/yast2-iscsi-lio-server.changes --- old/yast2-iscsi-lio-server-4.0.1/package/yast2-iscsi-lio-server.changes 2018-01-30 08:45:53.000000000 +0100 +++ new/yast2-iscsi-lio-server-4.0.2/package/yast2-iscsi-lio-server.changes 2018-01-31 09:09:55.000000000 +0100 @@ -1,4 +1,15 @@ ------------------------------------------------------------------- +Tue Jan 30 13:50:53 UTC 2018 - ls...@suse.com + +- fate#323460, fate#319238 +- Add firewalld read / write +- Rename required backend package to python3-targetcli-fb +- Add message when failed to install python3-targetcli-fb +- Remove message which shown when user set userid = mutual_userid + Not leak this message since kernel keep slience. +-4.0.2 + +------------------------------------------------------------------- Fri Jan 26 11:52:12 UTC 2018 - knut.anders...@suse.com - Replace SuSEFirewall2 by firewalld (fate#323460) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-lio-server-4.0.1/package/yast2-iscsi-lio-server.spec new/yast2-iscsi-lio-server-4.0.2/package/yast2-iscsi-lio-server.spec --- old/yast2-iscsi-lio-server-4.0.1/package/yast2-iscsi-lio-server.spec 2018-01-30 08:45:53.000000000 +0100 +++ new/yast2-iscsi-lio-server-4.0.2/package/yast2-iscsi-lio-server.spec 2018-01-31 09:09:55.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-iscsi-lio-server -Version: 4.0.1 +Version: 4.0.2 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-lio-server-4.0.1/src/clients/iscsi-lio-server.rb new/yast2-iscsi-lio-server-4.0.2/src/clients/iscsi-lio-server.rb --- old/yast2-iscsi-lio-server-4.0.1/src/clients/iscsi-lio-server.rb 2018-01-30 08:45:53.000000000 +0100 +++ new/yast2-iscsi-lio-server-4.0.2/src/clients/iscsi-lio-server.rb 2018-01-31 09:09:55.000000000 +0100 @@ -5,6 +5,7 @@ require "ui/service_status" require "yast" require "yast2/execute" +require "y2firewall/firewalld" Yast.import "CWM" Yast.import "CWMTab" @@ -29,7 +30,7 @@ end def installed_packages - if !PackageSystem.PackageInstalled("targetcli-fb") + if !PackageSystem.PackageInstalled("python3-targetcli-fb") confirm = Popup.AnyQuestionRichText( "", _("Yast iscsi-lio-server can't run without installing targetcli-fb package. Do you want to install?"), @@ -41,22 +42,28 @@ ) if confirm - PackageSystem.DoInstall(["targetcli-fb"]) - if PackageSystem.PackageInstalled("targetcli-fb") - true + PackageSystem.DoInstall(["python3-targetcli-fb"]) + if PackageSystem.PackageInstalled("python3-targetcli-fb") + return true else + err_msg = _("Failed to install targetcli-fb and related packages.") + Yast::Popup.Error(err_msg) false end end - false else true end end + def firewalld + Y2Firewall::Firewalld.instance + end + def run textdomain "iscsi-lio-server" msg = "" + firewalld.read global_tab = GlobalTab.new targets_tab = TargetsTab.new service_tab = ServiceTab.new @@ -66,6 +73,7 @@ ret = CWM.show(contents, caption: _("Yast iSCSI Targets"),next_button: _("Finish")) Yast::Wizard.CloseDialog if ret == :next + firewalld.write status = $discovery_auth.fetch_status userid = $discovery_auth.fetch_userid password = $discovery_auth.fetch_password @@ -88,11 +96,6 @@ p1 += ("mutual_password=" + mutual_password) end p1 += " enable=1" - if userid == mutual_userid - msg = _("It seems that Authentication by Initiators and Authentication by Targets using a same username") - msg += _("This may cause a CHAP negotiation error, an authenticaiton failure.") - Yast::Popup.Error(msg) - end else p1 = "iscsi/ set discovery_auth enable = 0" end @@ -125,4 +128,4 @@ $global_data.execute_init_commands $discovery_auth = DiscoveryAuth.new iscsi_target_server.run -end \ No newline at end of file +end