Hello community, here is the log from the commit of package yast2-ntp-client for openSUSE:Factory checked in at 2018-02-02 22:19:24 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-ntp-client (Old) and /work/SRC/openSUSE:Factory/.yast2-ntp-client.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-ntp-client" Fri Feb 2 22:19:24 2018 rev:101 rq:572102 version:4.0.7 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-ntp-client/yast2-ntp-client.changes 2018-01-17 21:42:35.847334681 +0100 +++ /work/SRC/openSUSE:Factory/.yast2-ntp-client.new/yast2-ntp-client.changes 2018-02-02 22:19:24.853909070 +0100 @@ -1,0 +2,8 @@ +Fri Feb 2 16:38:55 UTC 2018 - [email protected] + +- set properly range for sync interval (bsc#1079117) +- Mention proper configuration file when write failed (bsc#1079120) +- validate pool address (bsc#1079120) +- 4.0.7 + +------------------------------------------------------------------- Old: ---- yast2-ntp-client-4.0.6.tar.bz2 New: ---- yast2-ntp-client-4.0.7.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-ntp-client.spec ++++++ --- /var/tmp/diff_new_pack.u7BfV8/_old 2018-02-02 22:19:25.365885168 +0100 +++ /var/tmp/diff_new_pack.u7BfV8/_new 2018-02-02 22:19:25.369884981 +0100 @@ -1,7 +1,7 @@ # # spec file for package yast2-ntp-client # -# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: yast2-ntp-client -Version: 4.0.6 +Version: 4.0.7 Release: 0 Summary: YaST2 - NTP Client Configuration License: GPL-2.0+ ++++++ yast2-ntp-client-4.0.6.tar.bz2 -> yast2-ntp-client-4.0.7.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ntp-client-4.0.6/package/yast2-ntp-client.changes new/yast2-ntp-client-4.0.7/package/yast2-ntp-client.changes --- old/yast2-ntp-client-4.0.6/package/yast2-ntp-client.changes 2017-12-13 16:20:23.000000000 +0100 +++ new/yast2-ntp-client-4.0.7/package/yast2-ntp-client.changes 2018-02-02 18:24:58.000000000 +0100 @@ -1,4 +1,12 @@ ------------------------------------------------------------------- +Fri Feb 2 16:38:55 UTC 2018 - [email protected] + +- set properly range for sync interval (bsc#1079117) +- Mention proper configuration file when write failed (bsc#1079120) +- validate pool address (bsc#1079120) +- 4.0.7 + +------------------------------------------------------------------- Wed Dec 13 14:40:48 UTC 2017 - [email protected] - Do minimal modification to default chrony.conf in autoyast diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ntp-client-4.0.6/package/yast2-ntp-client.spec new/yast2-ntp-client-4.0.7/package/yast2-ntp-client.spec --- old/yast2-ntp-client-4.0.6/package/yast2-ntp-client.spec 2017-12-13 16:20:23.000000000 +0100 +++ new/yast2-ntp-client-4.0.7/package/yast2-ntp-client.spec 2018-02-02 18:24:58.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-ntp-client -Version: 4.0.6 +Version: 4.0.7 Release: 0 Summary: YaST2 - NTP Client Configuration License: GPL-2.0+ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ntp-client-4.0.6/src/clients/ntp-client_proposal.rb new/yast2-ntp-client-4.0.7/src/clients/ntp-client_proposal.rb --- old/yast2-ntp-client-4.0.6/src/clients/ntp-client_proposal.rb 2017-12-13 16:20:23.000000000 +0100 +++ new/yast2-ntp-client-4.0.7/src/clients/ntp-client_proposal.rb 2018-02-02 18:24:58.000000000 +0100 @@ -183,7 +183,7 @@ end if NtpClient.config_has_been_read || NtpClient.ntp_selected - Builtins.y2milestone("ntp_items will be filled from /etc/ntp.conf") + Builtins.y2milestone("ntp_items will be filled from /etc/chrony.conf") # grr, GUNS means all of them are used and here we just pick one ntp_items = Builtins.maplist(NtpClient.GetUsedNtpServers) do |server| Item(Id(server), server) @@ -193,7 +193,7 @@ end if ntp_items == [] Builtins.y2milestone( - "Nothing found in /etc/ntp.conf, proposing current timezone-based NTP server list" + "Nothing found in /etc/chrony.conf, proposing current timezone-based NTP server list" ) time_zone_country = Timezone.GetCountryForTimezone(Timezone.timezone) ntp_items = NtpClient.GetNtpServersByCountry(time_zone_country, true) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ntp-client-4.0.6/src/lib/y2ntp_client/widgets/main_widgets.rb new/yast2-ntp-client-4.0.7/src/lib/y2ntp_client/widgets/main_widgets.rb --- old/yast2-ntp-client-4.0.6/src/lib/y2ntp_client/widgets/main_widgets.rb 2017-12-13 16:20:23.000000000 +0100 +++ new/yast2-ntp-client-4.0.7/src/lib/y2ntp_client/widgets/main_widgets.rb 2018-02-02 18:24:58.000000000 +0100 @@ -147,10 +147,14 @@ _("Synchronization &Interval in Minutes") end - def minimal + def minimum 1 end + def maximum + 59 + end + def init self.value = Yast::NtpClient.sync_interval end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ntp-client-4.0.6/src/lib/y2ntp_client/widgets/pool_widgets.rb new/yast2-ntp-client-4.0.7/src/lib/y2ntp_client/widgets/pool_widgets.rb --- old/yast2-ntp-client-4.0.6/src/lib/y2ntp_client/widgets/pool_widgets.rb 2017-12-13 16:20:23.000000000 +0100 +++ new/yast2-ntp-client-4.0.7/src/lib/y2ntp_client/widgets/pool_widgets.rb 2018-02-02 18:24:58.000000000 +0100 @@ -2,7 +2,9 @@ require "cwm/widget" +Yast.import "Address" Yast.import "NtpClient" +Yast.import "Popup" module Y2NtpClient module Widgets @@ -24,8 +26,11 @@ end def validate - # TODO: validate address and also that it is not yet used - true + return true if Yast::Address.Check(value) + + msg = _("Invalid pool address.") + Yast::Popup.Error(msg) + false end def store diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-ntp-client-4.0.6/src/modules/NtpClient.rb new/yast2-ntp-client-4.0.7/src/modules/NtpClient.rb --- old/yast2-ntp-client-4.0.6/src/modules/NtpClient.rb 2017-12-13 16:20:23.000000000 +0100 +++ new/yast2-ntp-client-4.0.7/src/modules/NtpClient.rb 2018-02-02 18:24:58.000000000 +0100 @@ -345,7 +345,7 @@ # write settings return false if !go_next - Report.Error(Message.CannotWriteSettingsTo("/etc/ntp.conf")) if !write_ntp_conf + Report.Error(Message.CannotWriteSettingsTo("/etc/chrony.conf")) if !write_ntp_conf write_and_update_policy @@ -385,6 +385,11 @@ @run_service = false @synchronize_time = true @sync_interval = sync.to_i + # if wrong number is passed log it and use default + if !(1..59).cover?(@sync_interval) + log.error "Invalid interval in sync interval #{@sync_interval}" + @sync_interval = DEFAULT_SYNC_INTERVAL + end when /manual/ @run_service = false @synchronize_time = false
