Hello community,

here is the log from the commit of package yast2-isns for openSUSE:Factory 
checked in at 2018-02-02 22:23:32
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-isns (Old)
 and      /work/SRC/openSUSE:Factory/.yast2-isns.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-isns"

Fri Feb  2 22:23:32 2018 rev:33 rq:572034 version:4.0.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-isns/yast2-isns.changes    2016-06-07 
23:50:09.000000000 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-isns.new/yast2-isns.changes       
2018-02-02 22:23:39.670013129 +0100
@@ -1,0 +2,6 @@
+Fri Feb  2 08:24:23 UTC 2018 - knut.anders...@suse.com
+
+- Replace SuSEFirewall2 by firewalld (fate#323460)
+- 4.0.0
+
+-------------------------------------------------------------------

Old:
----
  yast2-isns-3.1.7.tar.bz2

New:
----
  yast2-isns-4.0.0.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-isns.spec ++++++
--- /var/tmp/diff_new_pack.85GcUE/_old  2018-02-02 22:23:40.269985122 +0100
+++ /var/tmp/diff_new_pack.85GcUE/_new  2018-02-02 22:23:40.273984935 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package yast2-isns
 #
-# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -17,14 +17,14 @@
 
 
 Name:           yast2-isns
-Version:        3.1.7
+Version:        4.0.0
 Release:        0
 
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 Source0:        %{name}-%{version}.tar.bz2
 
-# Wizard::SetDesktopTitleAndIcon
-Requires:       yast2 >= 2.21.22
+# SuSEFirewall2 replaced by firewalld (fate#323460)
+Requires:       yast2 >= 4.0.39
 BuildRequires:  perl-XML-Writer
 BuildRequires:  update-desktop-files
 BuildRequires:  yast2

++++++ yast2-isns-3.1.7.tar.bz2 -> yast2-isns-4.0.0.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-isns-3.1.7/.travis.yml 
new/yast2-isns-4.0.0/.travis.yml
--- old/yast2-isns-3.1.7/.travis.yml    2016-06-07 10:54:03.989980484 +0200
+++ new/yast2-isns-4.0.0/.travis.yml    2018-02-02 15:02:55.000000000 +0100
@@ -1,16 +1,11 @@
-language: cpp
-compiler:
-    - gcc
+sudo: required
+language: bash
+services:
+  - docker
+
 before_install:
-    # disable rvm, use system Ruby
-    - rvm reset
-    - wget 
https://raw.githubusercontent.com/yast/yast-devtools/master/travis-tools/travis_setup.sh
-    - sh ./travis_setup.sh -p "rake yast2-devtools yast2-testsuite yast2" -g 
"yast-rake gettext"
+  - docker build -t yast-isns-image .
 script:
-    - rake check:syntax
-    - rake check:pot
-    - make -f Makefile.cvs
-    - make
-    - sudo make install
-    - make check
-
+  # the "yast-travis-ruby" script is included in the base yastdevel/ruby image
+  # see https://github.com/yast/docker-yast-ruby/blob/master/yast-travis-ruby
+  - docker run -it -e TRAVIS=1 -e TRAVIS_JOB_ID="$TRAVIS_JOB_ID" 
yast-isns-image yast-travis-ruby
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-isns-3.1.7/CONTRIBUTING.md 
new/yast2-isns-4.0.0/CONTRIBUTING.md
--- old/yast2-isns-3.1.7/CONTRIBUTING.md        2016-06-07 10:54:04.001980484 
+0200
+++ new/yast2-isns-4.0.0/CONTRIBUTING.md        2018-02-02 15:02:55.000000000 
+0100
@@ -3,7 +3,7 @@
 
 YaST is an open source project and as such it welcomes all kinds of
 contributions. If you decide to contribute, please follow these guidelines to
-ensure the process is effective and pleasant both for you and YaST maintainers.
+ensure the process is effective and pleasant both for you and the YaST 
maintainers.
 
 There are two main forms of contribution: reporting bugs and performing code
 changes.
@@ -17,13 +17,11 @@
 
registration](https://secure-www.novell.com/selfreg/jsp/createSimpleAccount.jsp)
 if you don't have an account yet.)
 
-If you find a problem, please report it either using
-[Bugzilla](https://bugzilla.suse.com/) or GitHub issues. We can't guarantee
-that every bug will be fixed, but we'll try.
-
 When creating a bug report, please follow our [bug reporting
 guidelines](http://en.opensuse.org/openSUSE:Report_a_YaST_bug).
 
+We can't guarantee that every bug will be fixed, but we'll try.
+
 Code Changes
 ------------
 
@@ -44,15 +42,22 @@
      to the [Ruby style
      guide](https://github.com/SUSE/style-guides/blob/master/Ruby.md).
 
-  4. Make sure your change didn't break anything by building the RPM package
+  4. Update the package version (in `packages/*.spec`, usually by
+     `rake version:bump`) and add a new entry to the `package/*.changes` file
+     (by `osc vc package`).  
+     For bigger changes or changes which need longer discussion it is advised 
to
+     add this as a separate last commit so it can be easily updated when 
another
+     change is merged in the meantime.
+
+  5. Make sure your change didn't break anything by building the RPM package
      (`rake osc:build`). The build process includes running the full testsuite.
 
-  5. Publish the branch and create a pull request.
+  6. Publish the branch and create a pull request.
 
-  6. YaST developers will review your change and possibly point out issues.
+  7. YaST developers will review your change and possibly point out issues.
      Adapt the code under their guidance until they are all resolved.
 
-  7. Finally, the pull request will get merged or rejected.
+  8. Finally, the pull request will get merged or rejected.
 
 See also [GitHub's guide on
 contributing](https://help.github.com/articles/fork-a-repo).
@@ -60,9 +65,6 @@
 If you want to do multiple unrelated changes, use separate branches and pull
 requests.
 
-Do not change the `VERSION` and `*.changes` files as this could lead to
-conflicts.
-
 ### Commits
 
 Each commit in the pull request should do only one thing, which is clearly
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-isns-3.1.7/Dockerfile 
new/yast2-isns-4.0.0/Dockerfile
--- old/yast2-isns-3.1.7/Dockerfile     1970-01-01 01:00:00.000000000 +0100
+++ new/yast2-isns-4.0.0/Dockerfile     2018-02-02 15:02:55.000000000 +0100
@@ -0,0 +1,3 @@
+FROM yastdevel/ruby
+COPY . /usr/src/app
+
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-isns-3.1.7/package/yast2-isns.changes 
new/yast2-isns-4.0.0/package/yast2-isns.changes
--- old/yast2-isns-3.1.7/package/yast2-isns.changes     2016-06-07 
10:54:04.057980484 +0200
+++ new/yast2-isns-4.0.0/package/yast2-isns.changes     2018-02-02 
15:02:55.000000000 +0100
@@ -1,4 +1,10 @@
 -------------------------------------------------------------------
+Fri Feb  2 08:24:23 UTC 2018 - knut.anders...@suse.com
+
+- Replace SuSEFirewall2 by firewalld (fate#323460)
+- 4.0.0
+
+-------------------------------------------------------------------
 Tue Jun  7 08:14:04 UTC 2016 - igonzalezs...@suse.com
 
 - Stop generating autodocs (fate#320356)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-isns-3.1.7/package/yast2-isns.spec 
new/yast2-isns-4.0.0/package/yast2-isns.spec
--- old/yast2-isns-3.1.7/package/yast2-isns.spec        2016-06-07 
10:54:04.057980484 +0200
+++ new/yast2-isns-4.0.0/package/yast2-isns.spec        2018-02-02 
15:02:55.000000000 +0100
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-isns
-Version:        3.1.7
+Version:        4.0.0
 Release:        0
 License:       GPL-2.0
 Group:         System/YaST
@@ -25,8 +25,8 @@
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 Source0:        %{name}-%{version}.tar.bz2
 
-# Wizard::SetDesktopTitleAndIcon
-Requires:      yast2 >= 2.21.22
+# SuSEFirewall2 replaced by firewalld (fate#323460)
+Requires:       yast2 >= 4.0.39
 BuildRequires:  perl-XML-Writer update-desktop-files yast2 yast2-testsuite
 BuildRequires:  yast2-devtools >= 3.1.10
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-isns-3.1.7/src/include/isns/dialogs.rb 
new/yast2-isns-4.0.0/src/include/isns/dialogs.rb
--- old/yast2-isns-3.1.7/src/include/isns/dialogs.rb    2016-06-07 
10:54:04.097980484 +0200
+++ new/yast2-isns-4.0.0/src/include/isns/dialogs.rb    2018-02-02 
15:02:55.000000000 +0100
@@ -94,7 +94,7 @@
           }
         ),
         "firewall"            => 
CWMFirewallInterfaces.CreateOpenFirewallWidget(
-          { "services" => ["service:isns"], "display_details" => true }
+          { "services" => ["isns"], "display_details" => true }
         ),
         "iscsi_nodes_display" => {
           "widget"        => :custom,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-isns-3.1.7/src/modules/IsnsServer.rb 
new/yast2-isns-4.0.0/src/modules/IsnsServer.rb
--- old/yast2-isns-3.1.7/src/modules/IsnsServer.rb      2016-06-07 
10:54:04.169980484 +0200
+++ new/yast2-isns-4.0.0/src/modules/IsnsServer.rb      2018-02-02 
15:02:55.000000000 +0100
@@ -10,6 +10,7 @@
 # Representation of the configuration of iscsi-server.
 # Input and output routines.
 require "yast"
+require "y2firewall/firewalld"
 
 module Yast
   class IsnsServerClass < Module
@@ -23,7 +24,6 @@
       Yast.import "Service"
       Yast.import "Package"
       Yast.import "Popup"
-      Yast.import "SuSEFirewall"
       Yast.import "Confirm"
       Yast.import "Mode"
       Yast.import "String"
@@ -37,7 +37,6 @@
       @modified = false
       @configured = false
 
-
       @proposal_valid = false
 
       # Write only, used during autoinstallation.
@@ -286,7 +285,7 @@
       return false if !getServiceStatus
 
       # detect devices
-      SuSEFirewall.Read
+      Y2Firewall::Firewalld.instance.read
 
       @modified = false
       @configured = true
@@ -299,7 +298,7 @@
       # IsnsServer write dialog caption
       caption = _("Saving isns Configuration")
 
-      SuSEFirewall.Write
+      Y2Firewall::Firewalld.instance.write
 
       # set isns initscript status
       return false if !setServiceStatus


Reply via email to