Hello community, here is the log from the commit of package rubygem-devise for openSUSE:Factory checked in at 2018-02-12 10:14:44 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/rubygem-devise (Old) and /work/SRC/openSUSE:Factory/.rubygem-devise.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "rubygem-devise" Mon Feb 12 10:14:44 2018 rev:3 rq:574942 version:4.4.1 Changes: -------- --- /work/SRC/openSUSE:Factory/rubygem-devise/rubygem-devise.changes 2018-01-17 21:58:46.793895872 +0100 +++ /work/SRC/openSUSE:Factory/.rubygem-devise.new/rubygem-devise.changes 2018-02-12 10:15:00.429954574 +0100 @@ -1,0 +2,13 @@ +Thu Feb 8 07:46:54 UTC 2018 - [email protected] + +- updated to version 4.4.1 + see installed CHANGELOG.md + + ### 4.4.1 - 2018-01-23 + + * bug fixes + * Ensure Gemspec is loaded as utf-8. (by @segiddins) + * Fix `ActiveRecord` check on `Confirmable`. (by @tegon) + * Fix `signed_in?` docs without running auth hooks. by (@machty) + +------------------------------------------------------------------- @@ -20,0 +34,26 @@ + +------------------------------------------------------------------- +Tue Jan 9 07:26:30 UTC 2018 - [email protected] + +- updated to version 4.4.0 + see installed CHANGELOG.md + + ### Unreleased + + ### 4.4.0 - 2017-12-29 + + * enhancements + * Add `frozen_string_literal` pragma comment to all Ruby files. (by @pat) + * Use `set_flash_method!` instead of `set_flash_method` in `Devise::OmniauthCallbacksController#failure`. (by @saichander17) + * Clarify how `store_location_for` modifies URIs. (by @olivierlacan) + * Move `failed_attempts` increment into its own function. by (@mobilutz) + * Add `autocomplete="email"` to email fields. by (@MikeRogers0) + * Add the ability to change the default migrations path introduced in Rails 5.0.3. (by @alexhifer) + * Delete unnecessary condition for helper method. (by @davydovanton) + * Support `id: :uuid` option for migrations. (by @filip373) + + * bug fixes + * Fix syntax for MRI 2.5.0. (by @pat) + * Validations were being ignored on singup in the `Trackable#update_tracked_fields!` method. (by @AshleyFoster) + * Do not modify options for `#serializable_hash`. (by @guigs) + * Email confirmations were being sent on sign in/sign out for application using `mongoid` and `mongoid-paperclip` gems. This is because previously we were checking if a model is from Active Record by checking if the method `after_commit` was defined - since `mongoid` doesn' have one - but `mongoid-paperclip` gem does define one, which cause this issue. (by @fjg) Old: ---- devise-4.4.0.gem New: ---- devise-4.4.1.gem ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rubygem-devise.spec ++++++ --- /var/tmp/diff_new_pack.ACVfC4/_old 2018-02-12 10:15:01.313922719 +0100 +++ /var/tmp/diff_new_pack.ACVfC4/_new 2018-02-12 10:15:01.313922719 +0100 @@ -1,7 +1,7 @@ # # spec file for package rubygem-devise # -# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -24,7 +24,7 @@ # Name: rubygem-devise -Version: 4.4.0 +Version: 4.4.1 Release: 0 %define mod_name devise %define mod_full_name %{mod_name}-%{version} @@ -33,7 +33,7 @@ BuildRequires: %{rubygem gem2rpm} BuildRequires: ruby-macros >= 5 Url: https://github.com/plataformatec/devise -Source: http://rubygems.org/gems/%{mod_full_name}.gem +Source: https://rubygems.org/gems/%{mod_full_name}.gem Source1: gem2rpm.yml Summary: Flexible authentication solution for Rails with Warden License: MIT ++++++ devise-4.4.0.gem -> devise-4.4.1.gem ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/CHANGELOG.md new/CHANGELOG.md --- old/CHANGELOG.md 2017-12-29 20:32:56.000000000 +0100 +++ new/CHANGELOG.md 2018-01-23 19:11:17.000000000 +0100 @@ -1,5 +1,12 @@ ### Unreleased +### 4.4.1 - 2018-01-23 + +* bug fixes + * Ensure Gemspec is loaded as utf-8. (by @segiddins) + * Fix `ActiveRecord` check on `Confirmable`. (by @tegon) + * Fix `signed_in?` docs without running auth hooks. by (@machty) + ### 4.4.0 - 2017-12-29 * enhancements diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Gemfile.lock new/Gemfile.lock --- old/Gemfile.lock 2017-12-29 20:32:56.000000000 +0100 +++ new/Gemfile.lock 2018-01-23 19:11:17.000000000 +0100 @@ -10,7 +10,7 @@ PATH remote: . specs: - devise (4.4.0) + devise (4.4.1) bcrypt (~> 3.0) orm_adapter (~> 0.1) railties (>= 4.1.0, < 5.2) @@ -190,4 +190,4 @@ webrat (= 0.7.3) BUNDLED WITH - 1.15.3 + 1.16.0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/README.md new/README.md --- old/README.md 2017-12-29 20:32:56.000000000 +0100 +++ new/README.md 2018-01-23 19:11:17.000000000 +0100 @@ -674,6 +674,6 @@ ## License -MIT License. Copyright 2009-2017 Plataformatec. http://plataformatec.com.br +MIT License. Copyright 2009-2018 Plataformatec. http://plataformatec.com.br You are not granted rights or licenses to the trademarks of Plataformatec, including without limitation the Devise name or logo. Binary files old/checksums.yaml.gz and new/checksums.yaml.gz differ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/devise.gemspec new/devise.gemspec --- old/devise.gemspec 2017-12-29 20:32:56.000000000 +0100 +++ new/devise.gemspec 2018-01-23 19:11:17.000000000 +0100 @@ -1,6 +1,6 @@ +# -*- encoding: utf-8 -*- # frozen_string_literal: true -# -*- encoding: utf-8 -*- $:.push File.expand_path("../lib", __FILE__) require "devise/version" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gemfiles/Gemfile.rails-4.1-stable.lock new/gemfiles/Gemfile.rails-4.1-stable.lock --- old/gemfiles/Gemfile.rails-4.1-stable.lock 2017-12-29 20:32:56.000000000 +0100 +++ new/gemfiles/Gemfile.rails-4.1-stable.lock 2018-01-23 19:11:17.000000000 +0100 @@ -21,7 +21,7 @@ PATH remote: .. specs: - devise (4.4.0) + devise (4.4.1) bcrypt (~> 3.0) orm_adapter (~> 0.1) railties (>= 4.1.0, < 5.2) @@ -168,4 +168,4 @@ webrat (= 0.7.3) BUNDLED WITH - 1.15.3 + 1.16.0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gemfiles/Gemfile.rails-4.2-stable.lock new/gemfiles/Gemfile.rails-4.2-stable.lock --- old/gemfiles/Gemfile.rails-4.2-stable.lock 2017-12-29 20:32:56.000000000 +0100 +++ new/gemfiles/Gemfile.rails-4.2-stable.lock 2018-01-23 19:11:17.000000000 +0100 @@ -57,7 +57,7 @@ PATH remote: .. specs: - devise (4.4.0) + devise (4.4.1) bcrypt (~> 3.0) orm_adapter (~> 0.1) railties (>= 4.1.0, < 5.2) @@ -189,4 +189,4 @@ webrat (= 0.7.3) BUNDLED WITH - 1.15.3 + 1.16.0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gemfiles/Gemfile.rails-5.0-stable.lock new/gemfiles/Gemfile.rails-5.0-stable.lock --- old/gemfiles/Gemfile.rails-5.0-stable.lock 2017-12-29 20:32:56.000000000 +0100 +++ new/gemfiles/Gemfile.rails-5.0-stable.lock 2018-01-23 19:11:17.000000000 +0100 @@ -10,7 +10,7 @@ PATH remote: .. specs: - devise (4.4.0) + devise (4.4.1) bcrypt (~> 3.0) orm_adapter (~> 0.1) railties (>= 4.1.0, < 5.2) @@ -189,4 +189,4 @@ webrat (= 0.7.3) BUNDLED WITH - 1.15.3 + 1.16.0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/devise/controllers/sign_in_out.rb new/lib/devise/controllers/sign_in_out.rb --- old/lib/devise/controllers/sign_in_out.rb 2017-12-29 20:32:56.000000000 +0100 +++ new/lib/devise/controllers/sign_in_out.rb 2018-01-23 19:11:17.000000000 +0100 @@ -6,7 +6,10 @@ # Included by default in all controllers. module SignInOut # Return true if the given scope is signed in session. If no scope given, return - # true if any scope is signed in. Does not run authentication hooks. + # true if any scope is signed in. This will run authentication hooks, which may + # cause exceptions to be thrown from this method; if you simply want to check + # if a scope has already previously been authenticated without running + # authentication hooks, you can directly call `warden.authenticated?(scope: scope)` def signed_in?(scope=nil) [scope || Devise.mappings.keys].flatten.any? do |_scope| warden.authenticate?(scope: _scope) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/devise/models/confirmable.rb new/lib/devise/models/confirmable.rb --- old/lib/devise/models/confirmable.rb 2017-12-29 20:32:56.000000000 +0100 +++ new/lib/devise/models/confirmable.rb 2018-01-23 19:11:17.000000000 +0100 @@ -48,7 +48,7 @@ included do before_create :generate_confirmation_token, if: :confirmation_required? after_create :skip_reconfirmation_in_callback!, if: :send_confirmation_notification? - if defined?(ActiveRecord) && self.is_a?(ActiveRecord::Base) # ActiveRecord + if defined?(ActiveRecord) && self < ActiveRecord::Base # ActiveRecord after_commit :send_on_create_confirmation_instructions, on: :create, if: :send_confirmation_notification? after_commit :send_reconfirmation_instructions, on: :update, if: :reconfirmation_required? else # Mongoid diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lib/devise/version.rb new/lib/devise/version.rb --- old/lib/devise/version.rb 2017-12-29 20:32:56.000000000 +0100 +++ new/lib/devise/version.rb 2018-01-23 19:11:17.000000000 +0100 @@ -1,5 +1,5 @@ # frozen_string_literal: true module Devise - VERSION = "4.4.0".freeze + VERSION = "4.4.1".freeze end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/metadata new/metadata --- old/metadata 2017-12-29 20:32:56.000000000 +0100 +++ new/metadata 2018-01-23 19:11:17.000000000 +0100 @@ -1,7 +1,7 @@ --- !ruby/object:Gem::Specification name: devise version: !ruby/object:Gem::Version - version: 4.4.0 + version: 4.4.1 platform: ruby authors: - José Valim @@ -9,7 +9,7 @@ autorequire: bindir: bin cert_chain: [] -date: 2017-12-29 00:00:00.000000000 Z +date: 2018-01-23 00:00:00.000000000 Z dependencies: - !ruby/object:Gem::Dependency name: warden @@ -379,7 +379,7 @@ version: '0' requirements: [] rubyforge_project: -rubygems_version: 2.6.8 +rubygems_version: 2.6.13 signing_key: specification_version: 4 summary: Flexible authentication solution for Rails with Warden diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/test/models/confirmable_test.rb new/test/models/confirmable_test.rb --- old/test/models/confirmable_test.rb 2017-12-29 20:32:56.000000000 +0100 +++ new/test/models/confirmable_test.rb 2018-01-23 19:11:17.000000000 +0100 @@ -8,6 +8,17 @@ setup_mailer end + test 'should set callbacks to send the mail' do + if DEVISE_ORM == :active_record + defined_callbacks = User._commit_callbacks.map(&:filter) + assert_includes defined_callbacks, :send_on_create_confirmation_instructions + assert_includes defined_callbacks, :send_reconfirmation_instructions + elsif DEVISE_ORM == :mongoid + assert_includes User._create_callbacks.map(&:filter), :send_on_create_confirmation_instructions + assert_includes User._update_callbacks.map(&:filter), :send_reconfirmation_instructions + end + end + test 'should generate confirmation token after creating a record' do assert_nil new_user.confirmation_token assert_not_nil create_user.confirmation_token
