Hello community,
here is the log from the commit of package yast2-bootloader for
openSUSE:Factory checked in at 2018-02-13 10:23:57
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-bootloader (Old)
and /work/SRC/openSUSE:Factory/.yast2-bootloader.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-bootloader"
Tue Feb 13 10:23:57 2018 rev:253 rq:575819 version:4.0.17
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-bootloader/yast2-bootloader.changes
2018-02-12 10:07:10.958873505 +0100
+++ /work/SRC/openSUSE:Factory/.yast2-bootloader.new/yast2-bootloader.changes
2018-02-13 10:23:58.796818173 +0100
@@ -1,0 +2,7 @@
+Mon Feb 12 15:14:28 UTC 2018 - jreidin...@suse.com
+
+- Detect properly that unknown device is used in bootloader
+ configuration (bsc#1078713)
+- 4.0.17
+
+-------------------------------------------------------------------
Old:
----
yast2-bootloader-4.0.16.tar.bz2
New:
----
yast2-bootloader-4.0.17.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-bootloader.spec ++++++
--- /var/tmp/diff_new_pack.5uMbvL/_old 2018-02-13 10:24:00.172768599 +0100
+++ /var/tmp/diff_new_pack.5uMbvL/_new 2018-02-13 10:24:00.176768455 +0100
@@ -17,7 +17,7 @@
Name: yast2-bootloader
-Version: 4.0.16
+Version: 4.0.17
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
++++++ yast2-bootloader-4.0.16.tar.bz2 -> yast2-bootloader-4.0.17.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-bootloader-4.0.16/package/yast2-bootloader.changes
new/yast2-bootloader-4.0.17/package/yast2-bootloader.changes
--- old/yast2-bootloader-4.0.16/package/yast2-bootloader.changes
2018-02-09 15:16:26.000000000 +0100
+++ new/yast2-bootloader-4.0.17/package/yast2-bootloader.changes
2018-02-12 16:32:57.000000000 +0100
@@ -1,4 +1,11 @@
-------------------------------------------------------------------
+Mon Feb 12 15:14:28 UTC 2018 - jreidin...@suse.com
+
+- Detect properly that unknown device is used in bootloader
+ configuration (bsc#1078713)
+- 4.0.17
+
+-------------------------------------------------------------------
Fri Feb 9 13:39:03 UTC 2018 - jlo...@suse.com
- Adapt to new MountPoint API (part of fate#318196).
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-bootloader-4.0.16/package/yast2-bootloader.spec
new/yast2-bootloader-4.0.17/package/yast2-bootloader.spec
--- old/yast2-bootloader-4.0.16/package/yast2-bootloader.spec 2018-02-09
15:16:26.000000000 +0100
+++ new/yast2-bootloader-4.0.17/package/yast2-bootloader.spec 2018-02-12
16:32:57.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-bootloader
-Version: 4.0.16
+Version: 4.0.17
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-bootloader-4.0.16/src/modules/BootStorage.rb
new/yast2-bootloader-4.0.17/src/modules/BootStorage.rb
--- old/yast2-bootloader-4.0.16/src/modules/BootStorage.rb 2018-02-09
15:16:26.000000000 +0100
+++ new/yast2-bootloader-4.0.17/src/modules/BootStorage.rb 2018-02-12
16:32:57.000000000 +0100
@@ -133,7 +133,7 @@
# @return [Array<Y2Storage::Device>] list of suitable devices
def stage1_devices_for_name(dev_name)
device = staging.find_by_any_name(dev_name)
- raise "unknown device #{dev_name}" unless device
+ raise ::Bootloader::BrokenConfiguration, "unknown device #{dev_name}"
unless device
if device.is?(:partition) || device.is?(:filesystem)
stage1_partitions_for(device)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-bootloader-4.0.16/test/boot_storage_test.rb
new/yast2-bootloader-4.0.17/test/boot_storage_test.rb
--- old/yast2-bootloader-4.0.16/test/boot_storage_test.rb 2018-02-09
15:16:26.000000000 +0100
+++ new/yast2-bootloader-4.0.17/test/boot_storage_test.rb 2018-02-12
16:32:57.000000000 +0100
@@ -52,4 +52,15 @@
expect(subject.extended_for_logical(partition)).to eq
find_device("/dev/sda2")
end
end
+
+ describe ".stage1_devices_for_name" do
+ it "raises BrokenConfiguration exception if gets unknown name" do
+ # mock staging graph as graph does not return proper value when run as
non-root
+ allow(subject.staging).to receive(:find_by_any_name).and_return(nil)
+
+ expect { subject.stage1_devices_for_name("/dev/non-existing") }.to(
+ raise_error(::Bootloader::BrokenConfiguration)
+ )
+ end
+ end
end
