Hello community,

here is the log from the commit of package NetworkManager for openSUSE:Factory 
checked in at 2018-02-14 09:20:32
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/NetworkManager (Old)
 and      /work/SRC/openSUSE:Factory/.NetworkManager.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "NetworkManager"

Wed Feb 14 09:20:32 2018 rev:178 rq:575535 version:1.10.4

Changes:
--------
--- /work/SRC/openSUSE:Factory/NetworkManager/NetworkManager.changes    
2018-02-03 15:36:02.815462874 +0100
+++ /work/SRC/openSUSE:Factory/.NetworkManager.new/NetworkManager.changes       
2018-02-14 09:20:35.819453030 +0100
@@ -1,0 +2,18 @@
+Mon Feb  5 11:29:58 UTC 2018 - dims...@opensuse.org
+
+- Update to version 1.10.4:
+  + Load jansson at runtime. This solves a clash with json-glib
+    that caused a gnome-control-center crash, but also gets rid of
+    a hard dependency.
+  + Correct nmcli exit values after receiving a signal.
+  + Fix libnm secret agent asynchronous initialization.
+  + Add a default route for a modem even if it didn't sent a
+    gateway.
+  + Improve communication of DAD failures.
+  + Remember device default metrics across daemon restarts.
+  + Various bug fixes including possible crashes.
+  + Updated translations.
++ Add NetworkManager-1.10.4-buildfixes.patch: Fix OVS compile
+  errors (bgo#793183).
+
+-------------------------------------------------------------------

Old:
----
  NetworkManager-1.10.2.tar.xz

New:
----
  NetworkManager-1.10.4-buildfixes.patch
  NetworkManager-1.10.4.tar.xz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ NetworkManager.spec ++++++
--- /var/tmp/diff_new_pack.oxH9JB/_old  2018-02-14 09:20:36.639423310 +0100
+++ /var/tmp/diff_new_pack.oxH9JB/_new  2018-02-14 09:20:36.639423310 +0100
@@ -23,7 +23,7 @@
 %define _udevdir %(pkg-config --variable udevdir udev)
 
 Name:           NetworkManager
-Version:        1.10.2
+Version:        1.10.4
 Release:        0
 Summary:        Network Link Manager and User Applications
 License:        GPL-2.0+
@@ -46,6 +46,8 @@
 Patch3:         networkmanager-obs-net.patch
 # PATCH-FIX-OPENSUSE nm-dont-overwrite-resolv-conf.patch bsc#1021665, 
bsc#960153 sck...@suse.com -- NetworkManager spawns netconfig to update DNS 
settings, and terminates netconfig after 1s. But 1s isn't quite long enough for 
netconfig to complete the task. Adjust it to 0 seconds(don't send SIGKILL) to 
avoid NM overwriting /etc/resolv.conf.
 Patch4:         nm-dont-overwrite-resolv-conf.patch
+# PATCH-FIx-UPSTREAM NetworkManager-1.10.4-buildfixes.patch bgo#793183 
dims...@opensuse.org -- Fix OVS compile errors
+Patch5:         NetworkManager-1.10.4-buildfixes.patch
 
 BuildRequires:  dnsmasq
 BuildRequires:  fdupes
@@ -238,6 +240,7 @@
 %patch2 -p1
 %patch3 -p1
 %patch4 -p1
+%patch5 -p1
 
 %build
 NOCONFIGURE=1 ./autogen.sh

++++++ NetworkManager-1.10.4-buildfixes.patch ++++++
>From 640673f75ba4bcc40989b3bf1c03738b562ea2fc Mon Sep 17 00:00:00 2001
From: Thomas Haller <thal...@redhat.com>
Date: Sun, 28 Jan 2018 08:51:25 +0100
Subject: [PATCH 2/3] build: fix configure check for CC support of _Generic()
 and __auto_type

autotools' AC_LANG_PROGRAM() generates a main() function which triggers
a compiler warning (for which we fail with -WError).

    conftest.c:92:1: error: function declaration isn't a prototype 
[-Werror=strict-prototypes]
     main ()
     ^~~~
    cc1: all warnings being treated as errors

Fixes: 557d83bf2ddf832828a9b85ffffcad0b7d88272a
(cherry picked from commit a43bf33888a639671bb7b7c7d37f416f1ef8dd79)
---
 configure.ac | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index e263738f5..ab2ded77b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1224,16 +1224,16 @@ fi
 AC_SUBST(SANITIZERS, [$sanitizers])
 
 AC_MSG_CHECKING([CC support C11 _Generic()])
-AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[int foo(void); int foo() { int a = 0; int 
b = _Generic (a, int: 4); return b + a; }]],
-                                   [[foo();]])],
+AC_COMPILE_IFELSE([AC_LANG_SOURCE([[int foo(void); int foo() { int a = 0; int 
b = _Generic (a, int: 4); return b + a; }]],
+                                  [[foo();]])],
                   [cc_support_generic=1],
                   [cc_support_generic=0])
 AC_MSG_RESULT($cc_support_generic)
 AC_DEFINE_UNQUOTED(_NM_CC_SUPPORT_GENERIC, $cc_support_generic, [Define 
whether the compiler supports C11 _Generic()])
 
 AC_MSG_CHECKING([CC support gcc __auto_type])
-AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[int foo(void); int foo() { int a = 0; 
__auto_type b = a; return b + a; }]],
-                                   [[foo();]])],
+AC_COMPILE_IFELSE([AC_LANG_SOURCE([[int foo(void); int foo() { int a = 0; 
__auto_type b = a; return b + a; }]],
+                                  [[foo();]])],
                   [cc_support_auto_type=1],
                   [cc_support_auto_type=0])
 AC_MSG_RESULT($cc_support_auto_type)
-- 
2.15.1

>From 5159c34ea8923bf0c17fd31e183c5803b72b97f3 Mon Sep 17 00:00:00 2001
From: Thomas Haller <thal...@redhat.com>
Date: Mon, 5 Feb 2018 13:10:24 +0100
Subject: [PATCH 3/3] ovs: fix compiler error for passing NMDevice pointer to
 NM_DEVICE_OVS_INTERFACE_GET_PRIVATE()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

NM_DEVICE_OVS_INTERFACE_GET_PRIVATE() is implemented via the _NM_GET_PRIVATE()
macro. This macro uses C11's _Generic() to provide additional compiler checks
when casting from an incompatible pointer type.

As such,

  NMDevice *device = ...;
  NMDeviceOvsInterfacePrivate *priv;

  priv = NM_DEVICE_OVS_INTERFACE_GET_PRIVATE (device);

causes a compilation error:

    error: ‘_Generic’ selector of type ‘NMDevice * {aka struct _NMDevice *}’ is 
not compatible with any association

One workaround would be to cast the pointer first:

  priv = NM_DEVICE_OVS_INTERFACE_GET_PRIVATE ((NMDeviceOvsInterface *) device);

A better fix is to mark NMDevice as a compatible pointer in _NM_GET_PRIVATE(),
which this patch does.

Previously, this went unnoticed, because due to bug "a43bf3388 build: fix 
configure
check for CC support of _Generic() and __auto_type", we failed to detect support
for _Generic() when compiling with -Werror. That essentially disables this 
check,
and NM_DEVICE_OVS_INTERFACE_GET_PRIVATE() would do a direct cast.

A workaround for this build failure might be to build with -Werror, which 
accidentally
results in not using _Generic().

https://bugzilla.gnome.org/show_bug.cgi?id=793183

Fixes: 8ad310f8e3cb0157cfa5fa8ff10f313555cf8e3c
(cherry picked from commit 782578122c6cb23bdbee0b01eddceee1b967a673)
---
 src/devices/ovs/nm-device-ovs-interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/devices/ovs/nm-device-ovs-interface.c 
b/src/devices/ovs/nm-device-ovs-interface.c
index e746a3fd2..ce32c2dd7 100644
--- a/src/devices/ovs/nm-device-ovs-interface.c
+++ b/src/devices/ovs/nm-device-ovs-interface.c
@@ -50,7 +50,7 @@ struct _NMDeviceOvsInterfaceClass {
 
 G_DEFINE_TYPE (NMDeviceOvsInterface, nm_device_ovs_interface, NM_TYPE_DEVICE)
 
-#define NM_DEVICE_OVS_INTERFACE_GET_PRIVATE(self) _NM_GET_PRIVATE (self, 
NMDeviceOvsInterface, NM_IS_DEVICE_OVS_INTERFACE)
+#define NM_DEVICE_OVS_INTERFACE_GET_PRIVATE(self) _NM_GET_PRIVATE (self, 
NMDeviceOvsInterface, NM_IS_DEVICE_OVS_INTERFACE, NMDevice)
 
 /*****************************************************************************/
 
-- 
2.15.1

++++++ NetworkManager-1.10.2.tar.xz -> NetworkManager-1.10.4.tar.xz ++++++
++++ 72442 lines of diff (skipped)


Reply via email to