Hello community,

here is the log from the commit of package tcmu-runner for openSUSE:Factory 
checked in at 2018-02-14 09:45:57
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/tcmu-runner (Old)
 and      /work/SRC/openSUSE:Factory/.tcmu-runner.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "tcmu-runner"

Wed Feb 14 09:45:57 2018 rev:6 rq:575856 version:1.3.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/tcmu-runner/tcmu-runner.changes  2017-10-31 
15:44:42.112247511 +0100
+++ /work/SRC/openSUSE:Factory/.tcmu-runner.new/tcmu-runner.changes     
2018-02-14 09:46:15.419546779 +0100
@@ -1,0 +2,22 @@
+Fri Feb  9 17:28:47 UTC 2018 - dd...@suse.com
+
+- Update to version 1.3.0; (fate#322524)
+  + Improved Ceph RBD integration
+  + Support XCOPY copy-offload commands
+  + Support COMPARE_AND_WRITE, with Ceph OSD request mapping
+  + Asynchronous I/O improvements and bug fixes
+- Remove a number of downstream patches now carried upstream:
+  + glfs-discard-glfs_check_config
+  + 
fixed-local-dos-when-unregisterhandler-was-called-for-a-not-existing-handler
+  + 
only-allow-dynamic-unregisterhandler-for-external-handlers-thereby-fixing-dos
+  + fixed-a-number-of-memory-leaks-with-deregistering-of-dbus-handlers
+  + removed-all-check_config-callback-implementations-to-avoid-security-issues
+  + tcmu-runner-add-local-target_core_user-h
+- Remove development packages (bsc#1080619)
+  + API discontinued upstream
+- Add fix for -Werror-return-type failures:
+  + api-avoid-compiler-Werror-return-type-failures.patch
+- Add fix for library versioning:
+  + build-drop-versionless-libtcmu.so-symlink.patch
+
+-------------------------------------------------------------------

Old:
----
  fixed-a-number-of-memory-leaks-with-deregistering-of-dbus-handlers
  fixed-local-dos-when-unregisterhandler-was-called-for-a-not-existing-handler
  glfs-discard-glfs_check_config
  only-allow-dynamic-unregisterhandler-for-external-handlers-thereby-fixing-dos
  removed-all-check_config-callback-implementations-to-avoid-security-issues
  tcmu-runner-1.2.0.tar.gz
  tcmu-runner-add-local-target_core_user-h

New:
----
  api-avoid-compiler-Werror-return-type-failures.patch
  build-drop-versionless-libtcmu.so-symlink.patch
  tcmu-runner-1.3.0.tar.gz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ tcmu-runner.spec ++++++
--- /var/tmp/diff_new_pack.QQqkWW/_old  2018-02-14 09:46:16.931491680 +0100
+++ /var/tmp/diff_new_pack.QQqkWW/_new  2018-02-14 09:46:16.939491388 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package tcmu-runner
 #
-# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -27,7 +27,7 @@
 %endif
 
 Name:           tcmu-runner
-Version:        1.2.0
+Version:        1.3.0
 Release:        0
 Summary:        A userspace daemon that handles the LIO TCM-User backstore
 License:        Apache-2.0
@@ -35,14 +35,10 @@
 Url:            https://github.com/agrover/%{name}
 Source:         %{name}-%{version}.tar.gz
 Patch1:         %{name}-handler_file-add-libtcmu.patch
-Patch2:         glfs-discard-glfs_check_config
-Patch3:         
fixed-local-dos-when-unregisterhandler-was-called-for-a-not-existing-handler
-Patch4:         
only-allow-dynamic-unregisterhandler-for-external-handlers-thereby-fixing-dos
-Patch5:         
fixed-a-number-of-memory-leaks-with-deregistering-of-dbus-handlers
-Patch6:         
removed-all-check_config-callback-implementations-to-avoid-security-issues
 Patch7:         %{name}-remove-handler-path-install-prefix.patch
-Patch8:         %{name}-add-local-target_core_user-h
 Patch9:         %{name}-remove-uio-include-for-iovec.patch
+Patch10:        api-avoid-compiler-Werror-return-type-failures.patch
+Patch11:        build-drop-versionless-libtcmu.so-symlink.patch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 BuildRequires:  cmake
 BuildRequires:  glib2-devel
@@ -80,30 +76,13 @@
 authors can write code just to handle the SCSI commands as desired,
 and can also link with whatever userspace libraries they like.
 
-%package -n libtcmu1
+%package -n libtcmu2
 Summary:        Runtime libraries for tcmu-runner
 Group:          System/Libraries
 
-%description -n libtcmu1
+%description -n libtcmu2
 This package contains the runtime libraries for tcmu-runner.
 
-%package -n libtcmu-devel
-Summary:        Runtime library development files for tcmu-runner
-Group:          Development/Libraries/C and C++
-Requires:       libtcmu1 = %{version}
-
-%description -n libtcmu-devel
-This package contains the runtime library development files for
-tcmu-runner.
-
-%package devel
-Summary:        Development files for tcmu-runner
-Group:          Development/Libraries/C and C++
-Requires:       tcmu-runner = %{version}
-
-%description devel
-These are the development files for tcmu-runner.
-
 %if 0%{?build_handler_glusterfs}
 %package handler-glusterfs
 Summary:        GlusterFS handler for tcmu-runner
@@ -131,16 +110,12 @@
 %prep
 %setup
 %patch1 -p1
-%patch2 -p1
-%patch3 -p1
-%patch4 -p1
-%patch5 -p1
-%patch6 -p1
 %patch7 -p1
-%patch8 -p1
 %if 0%{?suse_version} >= 1330
 %patch9 -p1
 %endif
+%patch10 -p1
+%patch11 -p1
 
 %build
 CMAKE_OPTIONS="\
@@ -179,9 +154,9 @@
 %preun
 %{service_del_preun tcmu-runner.service}
 
-%post -n libtcmu1 -p /sbin/ldconfig
+%post -n libtcmu2 -p /sbin/ldconfig
 
-%postun -n libtcmu1 -p /sbin/ldconfig
+%postun -n libtcmu2 -p /sbin/ldconfig
 
 %files
 %defattr(-,root,root)
@@ -199,21 +174,12 @@
 %{_unitdir}/tcmu-runner.service
 %doc %{_mandir}/man8/tcmu-runner.8%{ext_man}
 
-%files -n libtcmu1
+%files -n libtcmu2
 %defattr(-,root,root)
-%{_libdir}/libtcmu.so.1
+%{_libdir}/libtcmu.so.2
 %dir %{_sysconfdir}/tcmu
 %config(noreplace) %{_sysconfdir}/tcmu/tcmu.conf
 
-%files -n libtcmu-devel
-%defattr(-,root,root)
-%{_includedir}/libtcmu*.h
-%{_libdir}/libtcmu.so
-
-%files devel
-%defattr(-,root,root)
-%{_includedir}/tcmu-runner.h
-
 %if 0%{?build_handler_glusterfs}
 %files handler-glusterfs
 %{_libdir}/tcmu-runner/handler_glfs.so

++++++ api-avoid-compiler-Werror-return-type-failures.patch ++++++
>From d5ea2b1b11f638650caed8dae6203bf253ab5bcf Mon Sep 17 00:00:00 2001
From: David Disseldorp <dd...@suse.de>
Date: Mon, 12 Feb 2018 14:08:44 +0100
Subject: [PATCH] api: avoid compiler -Werror=return-type failures

Seen with gcc-7-2.9:
/usr/bin/cc -Dtcmu_EXPORTS -I/usr/include/libnl3 -I/usr/include/gio-unix-2.0 
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include 
-I/home/abuild/rpmbuild/BUILD/tcmu-runner-1.3.0/ccan  -fmessage-length=0 
-grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong 
-funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -g 
-DNDEBUG -Werror -Wall -Wdeclaration-after-statement -std=c99 -O2 -g -DNDEBUG 
-fPIC   -o CMakeFiles/tcmu.dir/api.c.o   -c 
/home/abuild/rpmbuild/BUILD/tcmu-runner-1.3.0/api.c
[   15s] /home/abuild/rpmbuild/BUILD/tcmu-runner-1.3.0/api.c: In function 
'tcmu_get_lba':
[   15s] /home/abuild/rpmbuild/BUILD/tcmu-runner-1.3.0/api.c:87:1: error: 
control reaches end of non-void function [-Werror=return-type]
...

Signed-off-by: David Disseldorp <dd...@suse.de>
---
 api.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/api.c b/api.c
index 78a073e..98a35e1 100644
--- a/api.c
+++ b/api.c
@@ -83,6 +83,7 @@ uint64_t tcmu_get_lba(uint8_t *cdb)
                return be64toh(*((u_int64_t *)&cdb[2]));
        default:
                assert_perror(EINVAL);
+               return 0;       /* not reached */
        }
 }
 
@@ -99,6 +100,7 @@ uint32_t tcmu_get_xfer_length(uint8_t *cdb)
                return be32toh(*((u_int32_t *)&cdb[10]));
        default:
                assert_perror(EINVAL);
+               return 0;       /* not reached */
        }
 }
 
-- 
2.13.6

++++++ build-drop-versionless-libtcmu.so-symlink.patch ++++++
>From 8727a386dd05603f3d3619f18f3b06bf57679749 Mon Sep 17 00:00:00 2001
From: David Disseldorp <dd...@suse.de>
Date: Mon, 12 Feb 2018 14:47:56 +0100
Subject: [PATCH] build: drop versionless libtcmu.so symlink

Following a00cb71 ("libtcmu: do not install headers and drop libtcmu
stable API"), it no longer makes sense to install a versionless symlink
for libtcmu.so.2.
Dropping this allows for libtcmu1 and libtcmu2 to be installed alongside
each other.

Signed-off-by: David Disseldorp <dd...@suse.de>
---
 CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index b5b65c3..2076d68 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -60,7 +60,7 @@ target_link_libraries(tcmu
   ${LIBNL_GENL_LIB}
   ${GLIB_LIBRARIES}
   )
-install(TARGETS tcmu LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR})
+install(TARGETS tcmu LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} NAMELINK_SKIP)
 
 # Stuff for building the static library
 add_library(tcmu_static
-- 
2.13.6

++++++ tcmu-runner-1.2.0.tar.gz -> tcmu-runner-1.3.0.tar.gz ++++++
++++ 18669 lines of diff (skipped)

++++++ tcmu-runner-remove-uio-include-for-iovec.patch ++++++
--- /var/tmp/diff_new_pack.QQqkWW/_old  2018-02-14 09:46:17.199481914 +0100
+++ /var/tmp/diff_new_pack.QQqkWW/_new  2018-02-14 09:46:17.203481768 +0100
@@ -9,20 +9,22 @@
 
 Signed-off-by: Lee Duncan <ldun...@suse.com>
 --- 
-diff -aurp tcmu-runner-1.2.0.orig/consumer.c tcmu-runner-1.2.0/consumer.c
---- tcmu-runner-1.2.0.orig/consumer.c  2017-10-25 11:18:25.805340765 -0700
-+++ tcmu-runner-1.2.0/consumer.c       2017-10-25 14:38:56.456122857 -0700
-@@ -32,6 +32,7 @@
- #include <unistd.h>
+Index: tcmu-runner-1.3.0/consumer.c
+===================================================================
+--- tcmu-runner-1.3.0.orig/consumer.c
++++ tcmu-runner-1.3.0/consumer.c
+@@ -34,6 +34,7 @@
  #include <sys/mman.h>
+ #include <signal.h>
  #include <poll.h>
 +#include <sys/uio.h>
  
  #include <stdint.h>
  #include <scsi/scsi.h>
-diff -aurp tcmu-runner-1.2.0.orig/target_core_user_local.h 
tcmu-runner-1.2.0/target_core_user_local.h
---- tcmu-runner-1.2.0.orig/target_core_user_local.h    2017-10-25 
11:18:25.805340765 -0700
-+++ tcmu-runner-1.2.0/target_core_user_local.h 2017-10-25 14:39:48.618507387 
-0700
+Index: tcmu-runner-1.3.0/target_core_user_local.h
+===================================================================
+--- tcmu-runner-1.3.0.orig/target_core_user_local.h
++++ tcmu-runner-1.3.0/target_core_user_local.h
 @@ -4,7 +4,6 @@
  /* This header will be used by application too */
  


Reply via email to