Hello community,
here is the log from the commit of package perl-Perl-Critic-Freenode for
openSUSE:Factory checked in at 2018-02-16 21:45:29
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-Perl-Critic-Freenode (Old)
and /work/SRC/openSUSE:Factory/.perl-Perl-Critic-Freenode.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Perl-Critic-Freenode"
Fri Feb 16 21:45:29 2018 rev:5 rq:577182 version:0.025
Changes:
--------
---
/work/SRC/openSUSE:Factory/perl-Perl-Critic-Freenode/perl-Perl-Critic-Freenode.changes
2017-10-10 11:43:36.557832363 +0200
+++
/work/SRC/openSUSE:Factory/.perl-Perl-Critic-Freenode.new/perl-Perl-Critic-Freenode.changes
2018-02-16 21:45:29.189325858 +0100
@@ -1,0 +2,11 @@
+Mon Feb 12 12:16:03 UTC 2018 - [email protected]
+
+- updated to 0.025
+ see /usr/share/doc/packages/perl-Perl-Critic-Freenode/Changes
+
+ 0.025 2018-02-11 01:31:58 EST
+ - Fix DeprecatedFeatures to recognize correctly-parsed postderef in PPI
1.237+
+ - Avoid warning from running PackageMatchesFilename policy on a document
without a filename (willt #29)
+ - Fix another false positive in DollarAB policy
+
+-------------------------------------------------------------------
Old:
----
Perl-Critic-Freenode-0.024.tar.gz
New:
----
Perl-Critic-Freenode-0.025.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ perl-Perl-Critic-Freenode.spec ++++++
--- /var/tmp/diff_new_pack.Wtf7kD/_old 2018-02-16 21:45:29.865301479 +0100
+++ /var/tmp/diff_new_pack.Wtf7kD/_new 2018-02-16 21:45:29.869301335 +0100
@@ -1,7 +1,7 @@
#
# spec file for package perl-Perl-Critic-Freenode
#
-# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
Name: perl-Perl-Critic-Freenode
-Version: 0.024
+Version: 0.025
Release: 0
%define cpan_name Perl-Critic-Freenode
Summary: Perl::Critic policies inspired by #perl on
++++++ Perl-Critic-Freenode-0.024.tar.gz -> Perl-Critic-Freenode-0.025.tar.gz
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.024/Build.PL
new/Perl-Critic-Freenode-0.025/Build.PL
--- old/Perl-Critic-Freenode-0.024/Build.PL 2017-08-17 04:39:55.000000000
+0200
+++ new/Perl-Critic-Freenode-0.025/Build.PL 2018-02-11 07:32:01.000000000
+0100
@@ -84,7 +84,7 @@
"Dan Book <dbook\@cpan.org>"
],
"dist_name" => "Perl-Critic-Freenode",
- "dist_version" => "0.024",
+ "dist_version" => "0.025",
"license" => "artistic_2",
"module_name" => "Perl::Critic::Freenode",
"recursive_test_files" => 1,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.024/Changes
new/Perl-Critic-Freenode-0.025/Changes
--- old/Perl-Critic-Freenode-0.024/Changes 2017-08-17 04:39:55.000000000
+0200
+++ new/Perl-Critic-Freenode-0.025/Changes 2018-02-11 07:32:01.000000000
+0100
@@ -1,3 +1,8 @@
+0.025 2018-02-11 01:31:58 EST
+ - Fix DeprecatedFeatures to recognize correctly-parsed postderef in PPI
1.237+
+ - Avoid warning from running PackageMatchesFilename policy on a document
without a filename (willt #29)
+ - Fix another false positive in DollarAB policy
+
0.024 2017-08-16 22:39:53 EDT
- Make PackageMatchesFilename more robust against infinite loops
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.024/META.json
new/Perl-Critic-Freenode-0.025/META.json
--- old/Perl-Critic-Freenode-0.024/META.json 2017-08-17 04:39:55.000000000
+0200
+++ new/Perl-Critic-Freenode-0.025/META.json 2018-02-11 07:32:01.000000000
+0100
@@ -68,99 +68,99 @@
"provides" : {
"Perl::Critic::Freenode" : {
"file" : "lib/Perl/Critic/Freenode.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Freenode::Utils" : {
"file" : "lib/Perl/Critic/Freenode/Utils.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::AmpersandSubCalls" : {
"file" : "lib/Perl/Critic/Policy/Freenode/AmpersandSubCalls.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::ArrayAssignAref" : {
"file" : "lib/Perl/Critic/Policy/Freenode/ArrayAssignAref.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::BarewordFilehandles" : {
"file" : "lib/Perl/Critic/Policy/Freenode/BarewordFilehandles.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::ConditionalDeclarations" : {
"file" : "lib/Perl/Critic/Policy/Freenode/ConditionalDeclarations.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::ConditionalImplicitReturn" : {
"file" :
"lib/Perl/Critic/Policy/Freenode/ConditionalImplicitReturn.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::DeprecatedFeatures" : {
"file" : "lib/Perl/Critic/Policy/Freenode/DeprecatedFeatures.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::DiscouragedModules" : {
"file" : "lib/Perl/Critic/Policy/Freenode/DiscouragedModules.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::DollarAB" : {
"file" : "lib/Perl/Critic/Policy/Freenode/DollarAB.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::Each" : {
"file" : "lib/Perl/Critic/Policy/Freenode/Each.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::EmptyReturn" : {
"file" : "lib/Perl/Critic/Policy/Freenode/EmptyReturn.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::IndirectObjectNotation" : {
"file" : "lib/Perl/Critic/Policy/Freenode/IndirectObjectNotation.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::ModPerl" : {
"file" : "lib/Perl/Critic/Policy/Freenode/ModPerl.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::OpenArgs" : {
"file" : "lib/Perl/Critic/Policy/Freenode/OpenArgs.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::OverloadOptions" : {
"file" : "lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::POSIXImports" : {
"file" : "lib/Perl/Critic/Policy/Freenode/POSIXImports.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::PackageMatchesFilename" : {
"file" : "lib/Perl/Critic/Policy/Freenode/PackageMatchesFilename.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::Prototypes" : {
"file" : "lib/Perl/Critic/Policy/Freenode/Prototypes.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::StrictWarnings" : {
"file" : "lib/Perl/Critic/Policy/Freenode/StrictWarnings.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::Threads" : {
"file" : "lib/Perl/Critic/Policy/Freenode/Threads.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::Wantarray" : {
"file" : "lib/Perl/Critic/Policy/Freenode/Wantarray.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::WarningsSwitch" : {
"file" : "lib/Perl/Critic/Policy/Freenode/WarningsSwitch.pm",
- "version" : "0.024"
+ "version" : "0.025"
},
"Perl::Critic::Policy::Freenode::WhileDiamondDefaultAssignment" : {
"file" :
"lib/Perl/Critic/Policy/Freenode/WhileDiamondDefaultAssignment.pm",
- "version" : "0.024"
+ "version" : "0.025"
}
},
"release_status" : "stable",
@@ -176,10 +176,10 @@
},
"x_IRC" : "irc://chat.freenode.net/#perl"
},
- "version" : "0.024",
+ "version" : "0.025",
"x_Dist_Zilla" : {
"perl" : {
- "version" : "5.026000"
+ "version" : "5.026001"
},
"plugins" : [
{
@@ -243,7 +243,7 @@
"class" : "Dist::Zilla::Plugin::Git::Contributors",
"config" : {
"Dist::Zilla::Plugin::Git::Contributors" : {
- "git_version" : "2.9.4",
+ "git_version" : "2.14.3",
"include_authors" : 0,
"include_releaser" : 1,
"order_by" : "name",
@@ -251,7 +251,7 @@
}
},
"name" : "@Author::DBOOK/Git::Contributors",
- "version" : "0.030"
+ "version" : "0.032"
},
{
"class" : "Dist::Zilla::Plugin::MetaNoIndex",
@@ -266,7 +266,7 @@
{
"class" : "Dist::Zilla::Plugin::CheckChangesHasContent",
"name" : "@Author::DBOOK/CheckChangesHasContent",
- "version" : "0.010"
+ "version" : "0.011"
},
{
"class" : "Dist::Zilla::Plugin::Git::Check",
@@ -284,12 +284,12 @@
"changelog" : "Changes"
},
"Dist::Zilla::Role::Git::Repo" : {
- "git_version" : "2.9.4",
+ "git_version" : "2.14.3",
"repo_root" : "."
}
},
"name" : "@Author::DBOOK/Git::Check",
- "version" : "2.042"
+ "version" : "2.043"
},
{
"class" : "Dist::Zilla::Plugin::RewriteVersion",
@@ -305,7 +305,7 @@
}
},
"name" : "@Author::DBOOK/RewriteVersion",
- "version" : "0.015"
+ "version" : "0.017"
},
{
"class" : "Dist::Zilla::Plugin::NextRelease",
@@ -353,7 +353,7 @@
"changelog" : "Changes"
},
"Dist::Zilla::Role::Git::Repo" : {
- "git_version" : "2.9.4",
+ "git_version" : "2.14.3",
"repo_root" : "."
},
"Dist::Zilla::Role::Git::StringFormatter" : {
@@ -361,7 +361,7 @@
}
},
"name" : "@Author::DBOOK/Git::Commit",
- "version" : "2.042"
+ "version" : "2.043"
},
{
"class" : "Dist::Zilla::Plugin::Git::Tag",
@@ -370,12 +370,12 @@
"branch" : null,
"changelog" : "Changes",
"signed" : 0,
- "tag" : "v0.024",
+ "tag" : "v0.025",
"tag_format" : "v%v",
"tag_message" : "v%v"
},
"Dist::Zilla::Role::Git::Repo" : {
- "git_version" : "2.9.4",
+ "git_version" : "2.14.3",
"repo_root" : "."
},
"Dist::Zilla::Role::Git::StringFormatter" : {
@@ -383,7 +383,7 @@
}
},
"name" : "@Author::DBOOK/Git::Tag",
- "version" : "2.042"
+ "version" : "2.043"
},
{
"class" : "Dist::Zilla::Plugin::BumpVersionAfterRelease",
@@ -398,7 +398,7 @@
}
},
"name" : "@Author::DBOOK/BumpVersionAfterRelease",
- "version" : "0.015"
+ "version" : "0.017"
},
{
"class" : "Dist::Zilla::Plugin::Git::Commit",
@@ -418,7 +418,7 @@
"changelog" : "Changes"
},
"Dist::Zilla::Role::Git::Repo" : {
- "git_version" : "2.9.4",
+ "git_version" : "2.14.3",
"repo_root" : "."
},
"Dist::Zilla::Role::Git::StringFormatter" : {
@@ -426,7 +426,7 @@
}
},
"name" : "@Author::DBOOK/Commit_Version_Bump",
- "version" : "2.042"
+ "version" : "2.043"
},
{
"class" : "Dist::Zilla::Plugin::Git::Push",
@@ -438,12 +438,12 @@
"remotes_must_exist" : 1
},
"Dist::Zilla::Role::Git::Repo" : {
- "git_version" : "2.9.4",
+ "git_version" : "2.14.3",
"repo_root" : "."
}
},
"name" : "@Author::DBOOK/Git::Push",
- "version" : "2.042"
+ "version" : "2.043"
},
{
"class" : "Dist::Zilla::Plugin::PodSyntaxTests",
@@ -480,7 +480,7 @@
}
},
"name" : "@Author::DBOOK/Git::GatherDir",
- "version" : "2.042"
+ "version" : "2.043"
},
{
"class" : "Dist::Zilla::Plugin::Regenerate::AfterReleasers",
@@ -685,8 +685,9 @@
"x_contributors" : [
"Dan Book <[email protected]>",
"Dan Book <[email protected]>",
- "Graham Knop <[email protected]>"
+ "Graham Knop <[email protected]>",
+ "William Taylor <[email protected]>"
],
- "x_serialization_backend" : "Cpanel::JSON::XS version 3.0237"
+ "x_serialization_backend" : "Cpanel::JSON::XS version 4.01"
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.024/META.yml
new/Perl-Critic-Freenode-0.025/META.yml
--- old/Perl-Critic-Freenode-0.024/META.yml 2017-08-17 04:39:55.000000000
+0200
+++ new/Perl-Critic-Freenode-0.025/META.yml 2018-02-11 07:32:01.000000000
+0100
@@ -26,76 +26,76 @@
provides:
Perl::Critic::Freenode:
file: lib/Perl/Critic/Freenode.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Freenode::Utils:
file: lib/Perl/Critic/Freenode/Utils.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::AmpersandSubCalls:
file: lib/Perl/Critic/Policy/Freenode/AmpersandSubCalls.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::ArrayAssignAref:
file: lib/Perl/Critic/Policy/Freenode/ArrayAssignAref.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::BarewordFilehandles:
file: lib/Perl/Critic/Policy/Freenode/BarewordFilehandles.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::ConditionalDeclarations:
file: lib/Perl/Critic/Policy/Freenode/ConditionalDeclarations.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::ConditionalImplicitReturn:
file: lib/Perl/Critic/Policy/Freenode/ConditionalImplicitReturn.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::DeprecatedFeatures:
file: lib/Perl/Critic/Policy/Freenode/DeprecatedFeatures.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::DiscouragedModules:
file: lib/Perl/Critic/Policy/Freenode/DiscouragedModules.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::DollarAB:
file: lib/Perl/Critic/Policy/Freenode/DollarAB.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::Each:
file: lib/Perl/Critic/Policy/Freenode/Each.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::EmptyReturn:
file: lib/Perl/Critic/Policy/Freenode/EmptyReturn.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::IndirectObjectNotation:
file: lib/Perl/Critic/Policy/Freenode/IndirectObjectNotation.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::ModPerl:
file: lib/Perl/Critic/Policy/Freenode/ModPerl.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::OpenArgs:
file: lib/Perl/Critic/Policy/Freenode/OpenArgs.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::OverloadOptions:
file: lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::POSIXImports:
file: lib/Perl/Critic/Policy/Freenode/POSIXImports.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::PackageMatchesFilename:
file: lib/Perl/Critic/Policy/Freenode/PackageMatchesFilename.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::Prototypes:
file: lib/Perl/Critic/Policy/Freenode/Prototypes.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::StrictWarnings:
file: lib/Perl/Critic/Policy/Freenode/StrictWarnings.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::Threads:
file: lib/Perl/Critic/Policy/Freenode/Threads.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::Wantarray:
file: lib/Perl/Critic/Policy/Freenode/Wantarray.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::WarningsSwitch:
file: lib/Perl/Critic/Policy/Freenode/WarningsSwitch.pm
- version: '0.024'
+ version: '0.025'
Perl::Critic::Policy::Freenode::WhileDiamondDefaultAssignment:
file: lib/Perl/Critic/Policy/Freenode/WhileDiamondDefaultAssignment.pm
- version: '0.024'
+ version: '0.025'
requires:
Carp: '0'
Exporter: '0'
@@ -115,10 +115,10 @@
bugtracker: https://github.com/Grinnz/Perl-Critic-Freenode/issues
homepage: https://github.com/Grinnz/Perl-Critic-Freenode
repository: https://github.com/Grinnz/Perl-Critic-Freenode.git
-version: '0.024'
+version: '0.025'
x_Dist_Zilla:
perl:
- version: '5.026000'
+ version: '5.026001'
plugins:
-
class: Dist::Zilla::Plugin::GithubMeta
@@ -167,13 +167,13 @@
class: Dist::Zilla::Plugin::Git::Contributors
config:
Dist::Zilla::Plugin::Git::Contributors:
- git_version: 2.9.4
+ git_version: 2.14.3
include_authors: 0
include_releaser: 1
order_by: name
paths: []
name: '@Author::DBOOK/Git::Contributors'
- version: '0.030'
+ version: '0.032'
-
class: Dist::Zilla::Plugin::MetaNoIndex
name: '@Author::DBOOK/MetaNoIndex'
@@ -185,7 +185,7 @@
-
class: Dist::Zilla::Plugin::CheckChangesHasContent
name: '@Author::DBOOK/CheckChangesHasContent'
- version: '0.010'
+ version: '0.011'
-
class: Dist::Zilla::Plugin::Git::Check
config:
@@ -199,10 +199,10 @@
allow_dirty_match: []
changelog: Changes
Dist::Zilla::Role::Git::Repo:
- git_version: 2.9.4
+ git_version: 2.14.3
repo_root: .
name: '@Author::DBOOK/Git::Check'
- version: '2.042'
+ version: '2.043'
-
class: Dist::Zilla::Plugin::RewriteVersion
config:
@@ -214,7 +214,7 @@
global: 0
skip_version_provider: 0
name: '@Author::DBOOK/RewriteVersion'
- version: '0.015'
+ version: '0.017'
-
class: Dist::Zilla::Plugin::NextRelease
name: '@Author::DBOOK/NextRelease'
@@ -252,12 +252,12 @@
allow_dirty_match: []
changelog: Changes
Dist::Zilla::Role::Git::Repo:
- git_version: 2.9.4
+ git_version: 2.14.3
repo_root: .
Dist::Zilla::Role::Git::StringFormatter:
time_zone: local
name: '@Author::DBOOK/Git::Commit'
- version: '2.042'
+ version: '2.043'
-
class: Dist::Zilla::Plugin::Git::Tag
config:
@@ -265,16 +265,16 @@
branch: ~
changelog: Changes
signed: 0
- tag: v0.024
+ tag: v0.025
tag_format: v%v
tag_message: v%v
Dist::Zilla::Role::Git::Repo:
- git_version: 2.9.4
+ git_version: 2.14.3
repo_root: .
Dist::Zilla::Role::Git::StringFormatter:
time_zone: local
name: '@Author::DBOOK/Git::Tag'
- version: '2.042'
+ version: '2.043'
-
class: Dist::Zilla::Plugin::BumpVersionAfterRelease
config:
@@ -285,7 +285,7 @@
global: 0
munge_makefile_pl: 0
name: '@Author::DBOOK/BumpVersionAfterRelease'
- version: '0.015'
+ version: '0.017'
-
class: Dist::Zilla::Plugin::Git::Commit
config:
@@ -300,12 +300,12 @@
- (?^:^(?:lib|script|bin)/)
changelog: Changes
Dist::Zilla::Role::Git::Repo:
- git_version: 2.9.4
+ git_version: 2.14.3
repo_root: .
Dist::Zilla::Role::Git::StringFormatter:
time_zone: local
name: '@Author::DBOOK/Commit_Version_Bump'
- version: '2.042'
+ version: '2.043'
-
class: Dist::Zilla::Plugin::Git::Push
config:
@@ -314,10 +314,10 @@
- origin
remotes_must_exist: 1
Dist::Zilla::Role::Git::Repo:
- git_version: 2.9.4
+ git_version: 2.14.3
repo_root: .
name: '@Author::DBOOK/Git::Push'
- version: '2.042'
+ version: '2.043'
-
class: Dist::Zilla::Plugin::PodSyntaxTests
name: '@Author::DBOOK/PodSyntaxTests'
@@ -347,7 +347,7 @@
Dist::Zilla::Plugin::Git::GatherDir:
include_untracked: 0
name: '@Author::DBOOK/Git::GatherDir'
- version: '2.042'
+ version: '2.043'
-
class: Dist::Zilla::Plugin::Regenerate::AfterReleasers
config:
@@ -502,4 +502,5 @@
- 'Dan Book <[email protected]>'
- 'Dan Book <[email protected]>'
- 'Graham Knop <[email protected]>'
+ - 'William Taylor <[email protected]>'
x_serialization_backend: 'YAML::Tiny version 1.70'
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.024/README
new/Perl-Critic-Freenode-0.025/README
--- old/Perl-Critic-Freenode-0.024/README 2017-08-17 04:39:55.000000000
+0200
+++ new/Perl-Critic-Freenode-0.025/README 2018-02-11 07:32:01.000000000
+0100
@@ -137,6 +137,8 @@
Matt S Trout (mst)
+ William Taylor (willt)
+
COPYRIGHT AND LICENSE
Copyright 2015, Dan Book.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.024/dist.ini
new/Perl-Critic-Freenode-0.025/dist.ini
--- old/Perl-Critic-Freenode-0.024/dist.ini 2017-08-17 04:39:55.000000000
+0200
+++ new/Perl-Critic-Freenode-0.025/dist.ini 2018-02-11 07:32:01.000000000
+0100
@@ -9,3 +9,4 @@
installer = ModuleBuildTiny::Fallback
irc = irc://chat.freenode.net/#perl
pod_tests = syntax
+Test::ReportPrereqs.include[] = PPI
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Freenode/Utils.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Freenode/Utils.pm
--- old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Freenode/Utils.pm
2017-08-17 04:39:55.000000000 +0200
+++ new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Freenode/Utils.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Exporter 'import';
use Scalar::Util 'blessed';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
our @EXPORT_OK = qw(is_empty_return is_structural_block);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Freenode.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Freenode.pm
--- old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Freenode.pm 2017-08-17
04:39:55.000000000 +0200
+++ new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Freenode.pm 2018-02-11
07:32:01.000000000 +0100
@@ -3,7 +3,7 @@
use strict;
use warnings;
-our $VERSION = '0.024';
+our $VERSION = '0.025';
1;
@@ -151,6 +151,8 @@
=item Matt S Trout (mst)
+=item William Taylor (willt)
+
=back
=head1 COPYRIGHT AND LICENSE
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/AmpersandSubCalls.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/AmpersandSubCalls.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/AmpersandSubCalls.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/AmpersandSubCalls.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy::Subroutines::ProhibitAmpersandSigils';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
sub default_severity { $SEVERITY_HIGH }
sub default_themes { 'freenode' }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/ArrayAssignAref.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/ArrayAssignAref.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/ArrayAssignAref.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/ArrayAssignAref.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent
'Perl::Critic::Policy::ValuesAndExpressions::ProhibitArrayAssignAref';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
sub default_severity { $SEVERITY_MEDIUM }
sub default_themes { 'freenode' }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/BarewordFilehandles.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/BarewordFilehandles.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/BarewordFilehandles.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/BarewordFilehandles.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'Using bareword filehandles';
use constant EXPL => 'Bareword filehandles are a legacy feature, creating the
filehandles as package variables. Use lexical, scoped filehandles instead (open
my $fh, ...).';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/ConditionalDeclarations.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/ConditionalDeclarations.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/ConditionalDeclarations.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/ConditionalDeclarations.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
sub default_severity { $SEVERITY_HIGH }
sub default_themes { 'freenode' }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/ConditionalImplicitReturn.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/ConditionalImplicitReturn.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/ConditionalImplicitReturn.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/ConditionalImplicitReturn.pm
2018-02-11 07:32:01.000000000 +0100
@@ -9,7 +9,7 @@
use List::Util 'any';
use Perl::Critic::Freenode::Utils qw(is_empty_return is_structural_block);
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'Subroutine may implicitly return a conditional
statement';
use constant EXPL => 'When the last statement in a subroutine is a
conditional, the return value may unexpectedly be the evaluated condition.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/DeprecatedFeatures.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/DeprecatedFeatures.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/DeprecatedFeatures.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/DeprecatedFeatures.pm
2018-02-11 07:32:01.000000000 +0100
@@ -8,7 +8,7 @@
use Perl::Critic::Violation;
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
sub supported_parameters { () }
sub default_severity { $SEVERITY_HIGH }
@@ -161,12 +161,13 @@
$next = $next->schild(0) if
$next->isa('PPI::Structure::List');
$next = $next->schild(0) if $next and
$next->isa('PPI::Statement::Expression');
if ($next and $next->isa('PPI::Token::Symbol')
and $next->raw_type eq '$') {
- # try to detect postderef, very hacky;
PPI does not understand postderef yet
+ # try to detect postderef, hacky for
PPI that doesn't understand postderef yet
my $is_postderef;
until (!$next or
($next->isa('PPI::Token::Structure') and $next eq ';')
or
($next->isa('PPI::Token::Operator') and $next eq ',')) {
$next = $next->snext_sibling;
- if ($next and
$next->isa('PPI::Token::Magic') and ($next eq '@*' or $next eq '%*')) {
+ # this can just look for
PPI::Token::Cast in PPI 1.237+
+ if ($next and
($next->isa('PPI::Token::Magic') or $next->isa('PPI::Token::Cast')) and ($next
eq '@*' or $next eq '%*')) {
$is_postderef = 1;
last;
} elsif ($next and
$next->isa('PPI::Token::Operator') and $next eq '*') {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/DiscouragedModules.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/DiscouragedModules.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/DiscouragedModules.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/DiscouragedModules.pm
2018-02-11 07:32:01.000000000 +0100
@@ -7,7 +7,7 @@
use Perl::Critic::Violation;
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
sub supported_parameters { () }
sub default_severity { $SEVERITY_HIGH }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/DollarAB.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/DollarAB.pm
--- old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/DollarAB.pm
2017-08-17 04:39:55.000000000 +0200
+++ new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/DollarAB.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'Using $a or $b outside sort()';
use constant EXPL => '$a and $b are special package variables for use in
sort() and related functions. Declaring them as lexicals like "my $a" may break
sort(). Use different variable names.';
@@ -25,44 +25,32 @@
sub default_themes { 'freenode' }
sub applies_to { 'PPI::Token::Symbol' }
-my %sorters = (
- sort => 1,
- reduce => 1,
- pairgrep => 1,
- pairfirst => 1,
- pairmap => 1,
- pairwise => 1,
-);
+my @sorters = qw(sort reduce pairgrep pairfirst pairmap pairwise);
sub violates {
my ($self, $elem) = @_;
return () unless $elem->symbol eq '$a' or $elem->symbol eq '$b';
+
+ my %sorters_hash = map { ($_ => 1) } @sorters, keys
%{$self->{_extra_pair_functions}};
+ my $found = $self->_find_sorter($elem, \%sorters_hash);
- $sorters{$_} = 1 foreach keys %{$self->{_extra_pair_functions}};
-
- my $name = $self->_find_sorter($elem);
- return $self->violation(DESC, EXPL, $elem) unless exists
$sorters{$name};
+ return $self->violation(DESC, EXPL, $elem) unless $found;
return ();
}
sub _find_sorter {
- my ($self, $elem) = @_;
+ my ($self, $elem, $sorters) = @_;
- my $outer = $elem;
+ my $outer = $elem->parent;
$outer = $outer->parent until !$outer or
$outer->isa('PPI::Structure::Block');
- return '' unless $outer and $outer->isa('PPI::Structure::Block');
+ return '' unless $outer;
# Find function or method call (assumes block/sub is first argument)
my $function = $outer->previous_token;
$function = $function->previous_token until !$function
- or ($function->isa('PPI::Token::Word')
- and (is_method_call $function or is_function_call
$function or is_hash_key $function));
- return $self->_find_sorter($outer) unless $function and
$function->isa('PPI::Token::Word')
- and (is_method_call $function or is_function_call $function or
is_hash_key $function);
-
- my $name = $function;
- $name =~ s/.+:://;
- return $name;
+ or ($function->isa('PPI::Token::Word') and $function =~
m/([^:]+)\z/ and exists $sorters->{$1});
+ return $self->_find_sorter($outer) unless $function;
+ return $function;
}
1;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/Each.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/Each.pm
--- old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/Each.pm
2017-08-17 04:39:55.000000000 +0200
+++ new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/Each.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'each() called';
use constant EXPL => 'The each function may cause undefined behavior when
operating on the hash while iterating. Use a foreach loop over the hash\'s keys
or values instead.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/EmptyReturn.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/EmptyReturn.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/EmptyReturn.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/EmptyReturn.pm
2018-02-11 07:32:01.000000000 +0100
@@ -9,7 +9,7 @@
use List::Util 'any';
use Perl::Critic::Freenode::Utils qw(is_empty_return is_structural_block);
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'return called with no arguments';
use constant EXPL => 'return with no arguments may return either undef or an
empty list depending on context. This can be surprising for the same reason as
other context-sensitive returns. Return undef or the empty list explicitly.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/IndirectObjectNotation.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/IndirectObjectNotation.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/IndirectObjectNotation.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/IndirectObjectNotation.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy::Objects::ProhibitIndirectSyntax';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
sub default_severity { $SEVERITY_HIGHEST }
sub default_themes { 'freenode' }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/ModPerl.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/ModPerl.pm
--- old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/ModPerl.pm
2017-08-17 04:39:55.000000000 +0200
+++ new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/ModPerl.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'Using mod_perl';
use constant EXPL => 'mod_perl is not designed for writing Perl web
applications. Try a Plack-based framework (Web::Simple, Dancer2, Catalyst) or
Mojolicious for a modern approach.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/OpenArgs.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/OpenArgs.pm
--- old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/OpenArgs.pm
2017-08-17 04:39:55.000000000 +0200
+++ new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/OpenArgs.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'open() called with less than 3 arguments';
use constant EXPL => 'The one- and two-argument forms of open() parse
functionality from the filename, use the three-argument form instead.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/OverloadOptions.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'Using overload.pm without a boolean overload or
fallback';
use constant EXPL => 'When using overload.pm to define overloads for an object
class, always define an overload on "bool" explicitly and set the fallback
option. This prevents objects from autogenerating a potentially surprising
boolean overload, and causes operators for which overloads can\'t be
autogenerated to act on the object as they normally would.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/POSIXImports.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/POSIXImports.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/POSIXImports.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/POSIXImports.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'Using POSIX.pm without an explicit import list';
use constant EXPL => 'Using the POSIX module without specifying an import list
results in importing hundreds of symbols. Import the functions or constants you
want explicitly, or prevent the import with ().';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/PackageMatchesFilename.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/PackageMatchesFilename.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/PackageMatchesFilename.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/PackageMatchesFilename.pm
2018-02-11 07:32:01.000000000 +0100
@@ -7,7 +7,7 @@
use Path::Tiny 'path';
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'No package matching the module filename';
use constant EXPL => 'A Perl module file is expected to contain a matching
package name, so it can be used after loading it from the filesystem. A module
file that doesn\'t contain a matching package name usually indicates an error.';
@@ -18,7 +18,7 @@
sub violates {
my ($self, $elem, $doc) = @_;
- return () unless $doc->is_module and $doc->filename =~ m/\.pm\z/;
+ return () unless $doc->is_module and $doc->filename and $doc->filename
=~ m/\.pm\z/;
my $packages = $elem->find('PPI::Statement::Package') || [];
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/Prototypes.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/Prototypes.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/Prototypes.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/Prototypes.pm
2018-02-11 07:32:01.000000000 +0100
@@ -8,7 +8,7 @@
use List::Util 'any';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'Using function prototypes';
use constant EXPL => 'Function prototypes (sub foo ($@) { ... }) will usually
not do what you want. Omit the prototype, or use signatures instead.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/StrictWarnings.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/StrictWarnings.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/StrictWarnings.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/StrictWarnings.pm
2018-02-11 07:32:01.000000000 +0100
@@ -8,7 +8,7 @@
use parent 'Perl::Critic::Policy';
use version;
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'Missing strict or warnings';
use constant EXPL => 'The strict and warnings pragmas are important to avoid
common pitfalls and deprecated/experimental functionality. Make sure each
script or module contains "use strict; use warnings;" or a module that does
this for you.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/Threads.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/Threads.pm
--- old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/Threads.pm
2017-08-17 04:39:55.000000000 +0200
+++ new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/Threads.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'Using interpreter threads';
use constant EXPL => 'Interpreter threads are discouraged, they are not
lightweight and fast as other threads may be. Try an event loop, forks.pm, or
Parallel::Prefork.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/Wantarray.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/Wantarray.pm
--- old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/Wantarray.pm
2017-08-17 04:39:55.000000000 +0200
+++ new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/Wantarray.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'wantarray() called';
use constant EXPL => 'Context-sensitive functions lead to unexpected errors or
vulnerabilities. Functions should explicitly return either a list or a scalar
value.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/WarningsSwitch.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/WarningsSwitch.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/WarningsSwitch.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/WarningsSwitch.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => 'Using -w switch';
use constant EXPL => 'Don\'t use -w (or -W), it\'s too eager. use warnings;
instead.';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/WhileDiamondDefaultAssignment.pm
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/WhileDiamondDefaultAssignment.pm
---
old/Perl-Critic-Freenode-0.024/lib/Perl/Critic/Policy/Freenode/WhileDiamondDefaultAssignment.pm
2017-08-17 04:39:55.000000000 +0200
+++
new/Perl-Critic-Freenode-0.025/lib/Perl/Critic/Policy/Freenode/WhileDiamondDefaultAssignment.pm
2018-02-11 07:32:01.000000000 +0100
@@ -6,7 +6,7 @@
use Perl::Critic::Utils qw(:severities :classification :ppi);
use parent 'Perl::Critic::Policy';
-our $VERSION = '0.024';
+our $VERSION = '0.025';
use constant DESC => '<>/<<>>/readline/readdir/each result not explicitly
assigned in while condition';
use constant EXPL => 'When used alone in a while condition, the <>/<<>>
operator, readline, readdir, and each functions assign their result to $_, but
do not localize it. Assign the result to an explicit lexical variable instead
(my $line = <...>, my $dir = readdir ...)';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.024/t/00-report-prereqs.t
new/Perl-Critic-Freenode-0.025/t/00-report-prereqs.t
--- old/Perl-Critic-Freenode-0.024/t/00-report-prereqs.t 2017-08-17
04:39:55.000000000 +0200
+++ new/Perl-Critic-Freenode-0.025/t/00-report-prereqs.t 2018-02-11
07:32:01.000000000 +0100
@@ -60,7 +60,7 @@
}
my @include = qw(
-
+ PPI
);
my @exclude = qw(
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/Perl-Critic-Freenode-0.024/t/Freenode/DollarAB.run
new/Perl-Critic-Freenode-0.025/t/Freenode/DollarAB.run
--- old/Perl-Critic-Freenode-0.024/t/Freenode/DollarAB.run 2017-08-17
04:39:55.000000000 +0200
+++ new/Perl-Critic-Freenode-0.025/t/Freenode/DollarAB.run 2018-02-11
07:32:01.000000000 +0100
@@ -35,6 +35,7 @@
## cut
sort { @{$a} <=> @{$b} } ();
+sort { scalar(@{$a->{ids}}) <=> scalar(@{$b->{ids}}) } ();
## name InnerBlock
## failures 0
