Hello community, here is the log from the commit of package tig for openSUSE:Factory checked in at 2018-02-19 13:01:33 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/tig (Old) and /work/SRC/openSUSE:Factory/.tig.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "tig" Mon Feb 19 13:01:33 2018 rev:42 rq:577718 version:2.3.3 Changes: -------- --- /work/SRC/openSUSE:Factory/tig/tig.changes 2018-01-13 21:45:34.935851302 +0100 +++ /work/SRC/openSUSE:Factory/.tig.new/tig.changes 2018-02-19 13:02:12.255401816 +0100 @@ -1,0 +2,9 @@ +Sun Feb 18 03:42:48 UTC 2018 - avin...@opensuse.org + +- tig 2.3.3: + * Fix 100% CPU when closing terminal window before quitting tig + by catching SIGHUP. + * Change refs_tags type to size_t. + * Revert "Handle \n like \r (#758)" from 2.3.1 + +------------------------------------------------------------------- Old: ---- tig-2.3.2.tar.gz New: ---- tig-2.3.3.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ tig.spec ++++++ --- /var/tmp/diff_new_pack.Kxvn7u/_old 2018-02-19 13:02:13.655351327 +0100 +++ /var/tmp/diff_new_pack.Kxvn7u/_new 2018-02-19 13:02:13.655351327 +0100 @@ -1,7 +1,7 @@ # # spec file for package tig # -# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: tig -Version: 2.3.2 +Version: 2.3.3 Release: 0 Summary: An ncurses-based text-mode interface for git License: GPL-2.0+ ++++++ tig-2.3.2.tar.gz -> tig-2.3.3.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/INSTALL.adoc new/tig-2.3.3/INSTALL.adoc --- old/tig-2.3.2/INSTALL.adoc 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/INSTALL.adoc 2018-01-31 02:13:24.000000000 +0100 @@ -6,8 +6,8 @@ repository http://github.com/jonas/tig[git://github.com/jonas/tig.git]. The latest version is: -https://github.com/jonas/tig/releases/download/tig-2.3.2/tig-2.3.2.tar.gz[tig-2.3.2] -https://github.com/jonas/tig/releases/download/tig-2.3.2/tig-2.3.2.tar.gz.md5[(md5)] +https://github.com/jonas/tig/releases/download/tig-2.3.3/tig-2.3.3.tar.gz[tig-2.3.3] +https://github.com/jonas/tig/releases/download/tig-2.3.3/tig-2.3.3.tar.gz.md5[(md5)] *Note:* Do not use the tar.gz file for version 2.0 because it will fail to compile due to issue https://github.com/jonas/tig/pull/283[#283] and diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/INSTALL.html new/tig-2.3.3/INSTALL.html --- old/tig-2.3.2/INSTALL.html 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/INSTALL.html 2018-01-31 02:13:24.000000000 +0100 @@ -742,8 +742,8 @@ <div class="paragraph"><p>Download a tarball from <a href="https://github.com/jonas/tig/releases">https://github.com/jonas/tig/releases</a> or clone the Tig repository <a href="http://github.com/jonas/tig">git://github.com/jonas/tig.git</a>.</p></div> <div class="paragraph"><p>The latest version is: -<a href="https://github.com/jonas/tig/releases/download/tig-2.3.2/tig-2.3.2.tar.gz">tig-2.3.2</a> -<a href="https://github.com/jonas/tig/releases/download/tig-2.3.2/tig-2.3.2.tar.gz.md5">(md5)</a></p></div> +<a href="https://github.com/jonas/tig/releases/download/tig-2.3.3/tig-2.3.3.tar.gz">tig-2.3.3</a> +<a href="https://github.com/jonas/tig/releases/download/tig-2.3.3/tig-2.3.3.tar.gz.md5">(md5)</a></p></div> <div class="paragraph"><p><strong>Note:</strong> Do not use the tar.gz file for version 2.0 because it will fail to compile due to issue <a href="https://github.com/jonas/tig/pull/283">#283</a> and <a href="https://github.com/jonas/tig/issues/337">#337</a></p></div> @@ -1008,7 +1008,7 @@ <div id="footer"> <div id="footer-text"> Last updated - 2017-12-18 16:59:00 EST + 2018-01-30 20:13:03 EST </div> </div> </body> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/Makefile new/tig-2.3.3/Makefile --- old/tig-2.3.2/Makefile 2017-12-18 22:59:26.000000000 +0100 +++ new/tig-2.3.3/Makefile 2018-01-31 02:13:28.000000000 +0100 @@ -2,7 +2,7 @@ # The last tagged version. Can be overridden either by the version from # git or from the value of the DIST_VERSION environment variable. -VERSION = 2.3.2 +VERSION = 2.3.3 all: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/NEWS.adoc new/tig-2.3.3/NEWS.adoc --- old/tig-2.3.2/NEWS.adoc 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/NEWS.adoc 2018-01-31 02:13:24.000000000 +0100 @@ -1,6 +1,15 @@ Release notes ============= +tig-2.3.3 +--------- + +Bug fixes: + + - Revert "Handle \n like \r (#758)". (GH #769) + - Fix GH #164 by catching SIGHUP. + - Change `refs_tags` type to `size_t`. + tig-2.3.2 --------- diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/NEWS.html new/tig-2.3.3/NEWS.html --- old/tig-2.3.2/NEWS.html 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/NEWS.html 2018-01-31 02:13:24.000000000 +0100 @@ -738,6 +738,29 @@ </div> <div id="content"> <div class="sect1"> +<h2 id="_tig_2_3_3">tig-2.3.3</h2> +<div class="sectionbody"> +<div class="paragraph"><p>Bug fixes:</p></div> +<div class="ulist"><ul> +<li> +<p> +Revert "Handle \n like \r (#758)". (GH #769) +</p> +</li> +<li> +<p> +Fix GH #164 by catching SIGHUP. +</p> +</li> +<li> +<p> +Change <code>refs_tags</code> type to <code>size_t</code>. +</p> +</li> +</ul></div> +</div> +</div> +<div class="sect1"> <h2 id="_tig_2_3_2">tig-2.3.2</h2> <div class="sectionbody"> <div class="paragraph"><p>Bug fixes:</p></div> @@ -3875,7 +3898,7 @@ <div id="footer"> <div id="footer-text"> Last updated - 2017-12-18 16:59:00 EST + 2018-01-30 20:13:03 EST </div> </div> </body> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/README.adoc new/tig-2.3.3/README.adoc --- old/tig-2.3.2/README.adoc 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/README.adoc 2018-01-31 02:13:24.000000000 +0100 @@ -28,7 +28,7 @@ https://github.com/jonas/tig/issues[issue tracker] or by mail to either the Git mailing list or directly to the maintainer. Ensure that the word "tig" is in the subject. For other Tig related questions please use -Stack Overflow: http://stackoverflow.com/questions/tagged/tig[]. +Stack Overflow: https://stackoverflow.com/questions/tagged/tig[]. Installation and News --------------------- diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/README.html new/tig-2.3.3/README.html --- old/tig-2.3.2/README.html 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/README.html 2018-01-31 02:13:24.000000000 +0100 @@ -63,7 +63,7 @@ <a href="https://github.com/jonas/tig/issues">issue tracker</a> or by mail to either the Git mailing list or directly to the maintainer. Ensure that the word "tig" is in the subject. For other Tig related questions please use -Stack Overflow: <a href="http://stackoverflow.com/questions/tagged/tig">http://stackoverflow.com/questions/tagged/tig</a>.</p></div> +Stack Overflow: <a href="https://stackoverflow.com/questions/tagged/tig">https://stackoverflow.com/questions/tagged/tig</a>.</p></div> </div> </div> <div class="sect1"> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/doc/tig.1 new/tig-2.3.3/doc/tig.1 --- old/tig-2.3.2/doc/tig.1 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/doc/tig.1 2018-01-31 02:13:24.000000000 +0100 @@ -2,12 +2,12 @@ .\" Title: tig .\" Author: [FIXME: author] [see http://docbook.sf.net/el/author] .\" Generator: DocBook XSL Stylesheets v1.78.0 <http://docbook.sf.net/> -.\" Date: 12/18/2017 +.\" Date: 01/30/2018 .\" Manual: Tig Manual -.\" Source: Tig 2.3.2 +.\" Source: Tig 2.3.3 .\" Language: English .\" -.TH "TIG" "1" "12/18/2017" "Tig 2\&.3\&.2" "Tig Manual" +.TH "TIG" "1" "01/30/2018" "Tig 2\&.3\&.3" "Tig Manual" .\" ----------------------------------------------------------------- .\" * Define some portability stuff .\" ----------------------------------------------------------------- diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/doc/tigmanual.7 new/tig-2.3.3/doc/tigmanual.7 --- old/tig-2.3.2/doc/tigmanual.7 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/doc/tigmanual.7 2018-01-31 02:13:24.000000000 +0100 @@ -2,12 +2,12 @@ .\" Title: tigmanual .\" Author: [FIXME: author] [see http://docbook.sf.net/el/author] .\" Generator: DocBook XSL Stylesheets v1.78.0 <http://docbook.sf.net/> -.\" Date: 12/18/2017 +.\" Date: 01/30/2018 .\" Manual: Tig Manual -.\" Source: Tig 2.3.2 +.\" Source: Tig 2.3.3 .\" Language: English .\" -.TH "TIGMANUAL" "7" "12/18/2017" "Tig 2\&.3\&.2" "Tig Manual" +.TH "TIGMANUAL" "7" "01/30/2018" "Tig 2\&.3\&.3" "Tig Manual" .\" ----------------------------------------------------------------- .\" * Define some portability stuff .\" ----------------------------------------------------------------- diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/doc/tigrc.5 new/tig-2.3.3/doc/tigrc.5 --- old/tig-2.3.2/doc/tigrc.5 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/doc/tigrc.5 2018-01-31 02:13:24.000000000 +0100 @@ -2,12 +2,12 @@ .\" Title: tigrc .\" Author: [FIXME: author] [see http://docbook.sf.net/el/author] .\" Generator: DocBook XSL Stylesheets v1.78.0 <http://docbook.sf.net/> -.\" Date: 12/18/2017 +.\" Date: 01/30/2018 .\" Manual: Tig Manual -.\" Source: Tig 2.3.2 +.\" Source: Tig 2.3.3 .\" Language: English .\" -.TH "TIGRC" "5" "12/18/2017" "Tig 2\&.3\&.2" "Tig Manual" +.TH "TIGRC" "5" "01/30/2018" "Tig 2\&.3\&.3" "Tig Manual" .\" ----------------------------------------------------------------- .\" * Define some portability stuff .\" ----------------------------------------------------------------- diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/src/display.c new/tig-2.3.3/src/display.c --- old/tig-2.3.2/src/display.c 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/src/display.c 2018-01-31 02:13:24.000000000 +0100 @@ -748,40 +748,6 @@ return is_loading; } -/* - * Under normal circumstanecs this will do nothing, however, if the TTY - * is "corrupted" such as when running `nohup tig` and closing the - * terminal, then this will detect if the event loop starts doing a busy - * loop. - * - * This is a hack, and ideally it would be better to detect if the TTY - * is no longer in a good state, howver, testing suggest that the TTY fd - * is valid and ncurses does not seem to expose a way to check validity. - */ -static void -detect_busy_loop(int loops_per_check, int max_loops_per_second) -{ - static size_t busy_loops = 0; - static time_t busy_loop_time = 0; - - busy_loops++; - - if ((busy_loops % loops_per_check) == 0) { - time_t now = time(NULL); - time_t diff = now - busy_loop_time; - - if (diff > 0) { - size_t loops_per_second = busy_loops / diff; - - if (loops_per_second > max_loops_per_second) - die("Busy loop detected"); - - busy_loops = 0; - busy_loop_time = now; - } - } -} - int get_input(int prompt_position, struct key *key) { @@ -844,9 +810,6 @@ /* wgetch() with nodelay() enabled returns ERR when * there's no input. */ if (key_value == ERR) { - // Only check busy loop if no views are updating. - if (delay != 0) - detect_busy_loop(1000, 5000); } else if (key_value == KEY_RESIZE) { int height, width; @@ -868,9 +831,6 @@ input_mode = false; if (key_value == erasechar()) key_value = KEY_BACKSPACE; - /* Handle \n just like \r */ - else if (key_value == '\n') - key_value = KEY_RETURN; /* * Ctrl-<key> values are represented using a 0x1F diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/src/refdb.c new/tig-2.3.3/src/refdb.c --- old/tig-2.3.2/src/refdb.c 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/src/refdb.c 2018-01-31 02:13:24.000000000 +0100 @@ -21,7 +21,7 @@ #include "tig/refdb.h" static struct ref *refs_head = NULL; -static bool refs_tags; +static size_t refs_tags; DEFINE_STRING_MAP(refs_by_name, struct ref *, name, 32) DEFINE_STRING_MAP(refs_by_id, struct ref *, id, 16) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/src/tig.c new/tig-2.3.3/src/tig.c --- old/tig-2.3.2/src/tig.c 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/src/tig.c 2018-01-31 02:13:24.000000000 +0100 @@ -664,6 +664,15 @@ } #endif +void +sighup_handler(int sig) +{ + if (die_callback) + die_callback(); + + exit(EXIT_SUCCESS); +} + struct key_combo { enum request request; struct keymap *keymap; @@ -725,6 +734,9 @@ if (signal(SIGPIPE, SIG_IGN) == SIG_ERR) die("Failed to setup signal handler"); + if (signal(SIGHUP, sighup_handler) == SIG_ERR) + die("Failed to setup signal handler"); + #ifdef DEBUG if (signal(SIGSEGV, sigsegv_handler) == SIG_ERR) die("Failed to setup signal handler"); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/tig.spec new/tig-2.3.3/tig.spec --- old/tig-2.3.2/tig.spec 2017-12-18 22:59:26.000000000 +0100 +++ new/tig-2.3.3/tig.spec 2018-01-31 02:13:28.000000000 +0100 @@ -3,7 +3,7 @@ Summary: Tig: text-mode interface for git Name: tig -Version: 2.3.2 +Version: 2.3.3 Release: 0%{?dist} License: GPL Group: Development/Tools diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/tig-2.3.2/tools/aspell.dict new/tig-2.3.3/tools/aspell.dict --- old/tig-2.3.2/tools/aspell.dict 2017-12-18 22:59:21.000000000 +0100 +++ new/tig-2.3.3/tools/aspell.dict 2018-01-31 02:13:24.000000000 +0100 @@ -227,8 +227,8 @@ substring PID tz -DocBook docbook +DocBook submodule strndup startup