Hello community, here is the log from the commit of package yast2 for openSUSE:Factory checked in at 2018-03-04 11:49:50 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2 (Old) and /work/SRC/openSUSE:Factory/.yast2.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2" Sun Mar 4 11:49:50 2018 rev:420 rq:580958 version:4.0.56 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2/yast2.changes 2018-02-24 16:36:15.792178938 +0100 +++ /work/SRC/openSUSE:Factory/.yast2.new/yast2.changes 2018-03-04 11:49:58.743827332 +0100 @@ -1,0 +2,15 @@ +Wed Feb 28 13:03:21 UTC 2018 - [email protected] + +- Fixed a typo and the list item marker in the firewall widget + (bsc#1083058). +- 4.0.55 + +------------------------------------------------------------------- +Tue Feb 27 15:19:25 CET 2018 - [email protected] + +- NIS configuration fails while executing firewall-offline-cmd. + Fix: Ensure that the firewalld configuration is read before + writing. (bnc#1082827) +- 4.0.55 + +------------------------------------------------------------------- Old: ---- yast2-4.0.54.tar.bz2 New: ---- yast2-4.0.56.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2.spec ++++++ --- /var/tmp/diff_new_pack.NtuVZr/_old 2018-03-04 11:49:59.375804438 +0100 +++ /var/tmp/diff_new_pack.NtuVZr/_new 2018-03-04 11:49:59.379804293 +0100 @@ -17,7 +17,7 @@ Name: yast2 -Version: 4.0.54 +Version: 4.0.56 Release: 0 Summary: YaST2 - Main Package License: GPL-2.0 ++++++ yast2-4.0.54.tar.bz2 -> yast2-4.0.56.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.0.54/library/cwm/examples/replace_point_with_nested_custom.rb new/yast2-4.0.56/library/cwm/examples/replace_point_with_nested_custom.rb --- old/yast2-4.0.54/library/cwm/examples/replace_point_with_nested_custom.rb 2018-02-23 12:11:35.000000000 +0100 +++ new/yast2-4.0.56/library/cwm/examples/replace_point_with_nested_custom.rb 2018-02-28 14:20:36.000000000 +0100 @@ -82,6 +82,7 @@ class GenerateButton < CWM::PushButton def initialize(lucky_number_widget) @lucky_number_widget = lucky_number_widget + textdomain "example" end def label diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.0.54/library/cwm/examples/replace_point_with_nested_replace_point.rb new/yast2-4.0.56/library/cwm/examples/replace_point_with_nested_replace_point.rb --- old/yast2-4.0.54/library/cwm/examples/replace_point_with_nested_replace_point.rb 2018-02-23 12:11:35.000000000 +0100 +++ new/yast2-4.0.56/library/cwm/examples/replace_point_with_nested_replace_point.rb 2018-02-28 14:20:36.000000000 +0100 @@ -72,6 +72,7 @@ def initialize @minimum = 0 @maximum = 1000 + textdomain "example" end def label @@ -86,6 +87,7 @@ class GenerateButton < CWM::PushButton def initialize(lucky_number_widget) @lucky_number_widget = lucky_number_widget + textdomain "example" end def label diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.0.54/library/network/src/lib/y2firewall/firewalld.rb new/yast2-4.0.56/library/network/src/lib/y2firewall/firewalld.rb --- old/yast2-4.0.54/library/network/src/lib/y2firewall/firewalld.rb 2018-02-23 12:11:35.000000000 +0100 +++ new/yast2-4.0.56/library/network/src/lib/y2firewall/firewalld.rb 2018-02-28 14:20:36.000000000 +0100 @@ -142,6 +142,7 @@ # Apply the changes to the modified zones and sets the logging option def write_only return false unless installed? + read unless read? zones.each { |z| z.apply_changes! if z.modified? } api.log_denied_packets = log_denied_packets if log_denied_packets != api.log_denied_packets api.default_zone = default_zone if default_zone != api.default_zone diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.0.54/library/network/src/modules/CWMFirewallInterfaces.rb new/yast2-4.0.56/library/network/src/modules/CWMFirewallInterfaces.rb --- old/yast2-4.0.54/library/network/src/modules/CWMFirewallInterfaces.rb 2018-02-23 12:11:35.000000000 +0100 +++ new/yast2-4.0.56/library/network/src/modules/CWMFirewallInterfaces.rb 2018-02-28 14:20:36.000000000 +0100 @@ -1055,9 +1055,13 @@ services_list = services.map do |service| if !firewalld.api.service_supported?(service) - HBox(HSpacing(2), Left(Label(_("* %{service} (Not available)") % { service: service }))) + # TRANSLATORS: do not modify '%{service}', it will be replaced with service name. + # TRANSLATORS: item in a list, '-' is used as marker. Feel free to change it + HBox(HSpacing(2), Left(Label(_("- %{service} (Not available)") % { service: service }))) else - HBox(HSpacing(2), Left(Label(_("* %{service}") % { service: service }))) + # TRANSLATORS: do not modify '%{service}', it will be replaced with service name. + # TRANSLATORS: item in a list, '-' is used as marker. Feel free to change it + HBox(HSpacing(2), Left(Label(_("- %{service}") % { service: service }))) end end @@ -1067,7 +1071,7 @@ VBox( Left(Label(_("Some firewalld services are not available:"))), *services_list, - Left(Label(_("You need to defined them to be able to configure the firewall."))) + Left(Label(_("These services must be defined in order to configure the firewall."))) ) ) ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.0.54/library/network/test/y2firewall/firewalld_test.rb new/yast2-4.0.56/library/network/test/y2firewall/firewalld_test.rb --- old/yast2-4.0.54/library/network/test/y2firewall/firewalld_test.rb 2018-02-23 12:11:35.000000000 +0100 +++ new/yast2-4.0.56/library/network/test/y2firewall/firewalld_test.rb 2018-02-28 14:20:36.000000000 +0100 @@ -202,7 +202,7 @@ let(:api) do instance_double(Y2Firewall::Firewalld::Api, - log_denied_packets: false, + log_denied_packets: "off", default_zone: "dmz", list_all_zones: zones_definition, zones: known_zones) @@ -228,7 +228,7 @@ it "initializes global options with the current firewalld config" do firewalld.read - expect(firewalld.log_denied_packets).to eq(false) + expect(firewalld.log_denied_packets).to eq("off") expect(firewalld.default_zone).to eq("dmz") end end @@ -251,7 +251,7 @@ describe "#modified?" do let(:api) do - instance_double(Y2Firewall::Firewalld::Api, log_denied_packets: true, default_zone: "public") + instance_double(Y2Firewall::Firewalld::Api, log_denied_packets: "off", default_zone: "public") end let(:modified_zone) { false } @@ -262,7 +262,7 @@ allow(zone).to receive(:modified?).and_return(modified_zone) end firewalld.zones = empty_zones - firewalld.log_denied_packets = true + firewalld.log_denied_packets = "all" end context "when some of the attributes have been modified since read" do @@ -275,6 +275,7 @@ context "when no attribute has been modifiede since read" do it "returns false" do firewalld.default_zone = "public" + firewalld.log_denied_packets = "off" expect(firewalld.modified?).to eq(false) end end @@ -286,6 +287,7 @@ end before do + allow(firewalld).to receive("read?").and_return(true) firewalld.zones = empty_zones allow(firewalld).to receive("api").and_return api empty_zones.each do |zone| @@ -296,12 +298,19 @@ allow(api).to receive(:log_denied_packets=) end + it "enforces a read of the configuration if not read before" do + allow(firewalld).to receive("read?").and_return(false) + expect(firewalld).to receive("read") + + firewalld.write_only + end + it "applies in firewalld all the changes done in the object since read" do - firewalld.log_denied_packets = false + firewalld.log_denied_packets = "off" firewalld.default_zone = "drop" expect(api).to receive(:default_zone=).with("drop") - expect(api).to receive(:log_denied_packets=).with(false) + expect(api).to receive(:log_denied_packets=).with("off") firewalld.write_only end @@ -357,7 +366,7 @@ let(:api) do instance_double(Y2Firewall::Firewalld::Api, - log_denied_packets: true, + log_denied_packets: "all", default_zone: "work", list_all_zones: zones_definition, zones: known_zones) @@ -378,7 +387,7 @@ expect(config).to be_a(Hash) expect(config["enable_firewall"]).to eq(false) expect(config["start_firewall"]).to eq(true) - expect(config["log_denied_packets"]).to eq(true) + expect(config["log_denied_packets"]).to eq("all") expect(config["default_zone"]).to eq("work") expect(external["interfaces"]).to eq(["eth0"]) expect(external["ports"]).to eq(["5901/tcp", "5901/udp"]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.0.54/package/yast2.changes new/yast2-4.0.56/package/yast2.changes --- old/yast2-4.0.54/package/yast2.changes 2018-02-23 12:11:35.000000000 +0100 +++ new/yast2-4.0.56/package/yast2.changes 2018-02-28 14:20:36.000000000 +0100 @@ -1,4 +1,19 @@ ------------------------------------------------------------------- +Wed Feb 28 13:03:21 UTC 2018 - [email protected] + +- Fixed a typo and the list item marker in the firewall widget + (bsc#1083058). +- 4.0.55 + +------------------------------------------------------------------- +Tue Feb 27 15:19:25 CET 2018 - [email protected] + +- NIS configuration fails while executing firewall-offline-cmd. + Fix: Ensure that the firewalld configuration is read before + writing. (bnc#1082827) +- 4.0.55 + +------------------------------------------------------------------- Fri Feb 23 10:50:59 UTC 2018 - [email protected] - Added missing textdomain to firewalld zone class for translations diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.0.54/package/yast2.spec new/yast2-4.0.56/package/yast2.spec --- old/yast2-4.0.54/package/yast2.spec 2018-02-23 12:11:35.000000000 +0100 +++ new/yast2-4.0.56/package/yast2.spec 2018-02-28 14:20:36.000000000 +0100 @@ -16,7 +16,7 @@ # Name: yast2 -Version: 4.0.54 +Version: 4.0.56 Release: 0 Summary: YaST2 - Main Package License: GPL-2.0
