Hello community,
here is the log from the commit of package yast2-registration for
openSUSE:Factory checked in at 2018-03-14 19:34:24
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-registration (Old)
and /work/SRC/openSUSE:Factory/.yast2-registration.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-registration"
Wed Mar 14 19:34:24 2018 rev:13 rq:586383 version:4.0.24
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-registration/yast2-registration.changes
2018-03-07 10:29:34.777511949 +0100
+++
/work/SRC/openSUSE:Factory/.yast2-registration.new/yast2-registration.changes
2018-03-14 19:34:25.959016261 +0100
@@ -1,0 +2,7 @@
+Tue Mar 13 09:37:14 UTC 2018 - [email protected]
+
+- Prevent crashing when no product was defined in the profile
+ (bsc#1084820)
+- 4.0.24
+
+-------------------------------------------------------------------
Old:
----
yast2-registration-4.0.23.tar.bz2
New:
----
yast2-registration-4.0.24.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-registration.spec ++++++
--- /var/tmp/diff_new_pack.YyfKHC/_old 2018-03-14 19:34:27.042977763 +0100
+++ /var/tmp/diff_new_pack.YyfKHC/_new 2018-03-14 19:34:27.054977337 +0100
@@ -17,7 +17,7 @@
Name: yast2-registration
-Version: 4.0.23
+Version: 4.0.24
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
++++++ yast2-registration-4.0.23.tar.bz2 -> yast2-registration-4.0.24.tar.bz2
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-registration-4.0.23/package/yast2-registration.changes
new/yast2-registration-4.0.24/package/yast2-registration.changes
--- old/yast2-registration-4.0.23/package/yast2-registration.changes
2018-03-05 12:46:35.000000000 +0100
+++ new/yast2-registration-4.0.24/package/yast2-registration.changes
2018-03-13 14:04:41.000000000 +0100
@@ -1,4 +1,11 @@
-------------------------------------------------------------------
+Tue Mar 13 09:37:14 UTC 2018 - [email protected]
+
+- Prevent crashing when no product was defined in the profile
+ (bsc#1084820)
+- 4.0.24
+
+-------------------------------------------------------------------
Mon Mar 5 10:14:28 UTC 2018 - [email protected]
- Display additional error details when refreshing a service fails
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-registration-4.0.23/package/yast2-registration.spec
new/yast2-registration-4.0.24/package/yast2-registration.spec
--- old/yast2-registration-4.0.23/package/yast2-registration.spec
2018-03-05 12:46:35.000000000 +0100
+++ new/yast2-registration-4.0.24/package/yast2-registration.spec
2018-03-13 14:04:41.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-registration
-Version: 4.0.23
+Version: 4.0.24
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-registration-4.0.23/src/lib/registration/registration.rb
new/yast2-registration-4.0.24/src/lib/registration/registration.rb
--- old/yast2-registration-4.0.23/src/lib/registration/registration.rb
2018-03-05 12:46:35.000000000 +0100
+++ new/yast2-registration-4.0.24/src/lib/registration/registration.rb
2018-03-13 14:04:41.000000000 +0100
@@ -191,6 +191,7 @@
# @see SUSE::Connect::Yast.list_installer_updates
def get_updates_list
product = SwMgmt.base_product_to_register
+ return [] unless product
id = Yast::ProductFeatures.GetStringFeature("globals", "self_update_id")
if !id.empty?
log.info "Using self update id from control file #{id.inspect}"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-registration-4.0.23/src/lib/registration/sw_mgmt.rb
new/yast2-registration-4.0.24/src/lib/registration/sw_mgmt.rb
--- old/yast2-registration-4.0.23/src/lib/registration/sw_mgmt.rb
2018-03-05 12:46:35.000000000 +0100
+++ new/yast2-registration-4.0.24/src/lib/registration/sw_mgmt.rb
2018-03-13 14:04:41.000000000 +0100
@@ -162,6 +162,7 @@
Yast.import "AutoinstFunctions"
# note: AutoinstFunctions.selected_product should never be nil when
# AY let it pass here
+ return false unless AutoinstFunctions.selected_product
p["name"] == AutoinstFunctions.selected_product.name
elsif Stage.initial && !Mode.update
# during installation the ["type"] value is not valid yet yet
@@ -238,6 +239,8 @@
# use FAKE_BASE_PRODUCT just for debugging
base_product = ENV["FAKE_BASE_PRODUCT"] ? FAKE_BASE_PRODUCT :
find_base_product
+ return unless base_product
+
# filter out not needed data
product_info = {
"name" => base_product["name"],
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-registration-4.0.23/test/registration_spec.rb
new/yast2-registration-4.0.24/test/registration_spec.rb
--- old/yast2-registration-4.0.23/test/registration_spec.rb 2018-03-05
12:46:35.000000000 +0100
+++ new/yast2-registration-4.0.24/test/registration_spec.rb 2018-03-13
14:04:41.000000000 +0100
@@ -229,6 +229,11 @@
.and_return(updates)
expect(subject.get_updates_list).to eq(updates)
end
+
+ it "returns an empty list if no base product is selected" do
+ allow(Registration::SwMgmt).to
receive(:base_product_to_register).and_return(nil)
+ expect(subject.get_updates_list).to eq([])
+ end
end
describe "#synchronize_products" do
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-registration-4.0.23/test/sw_mgmt_spec.rb
new/yast2-registration-4.0.24/test/sw_mgmt_spec.rb
--- old/yast2-registration-4.0.23/test/sw_mgmt_spec.rb 2018-03-05
12:46:35.000000000 +0100
+++ new/yast2-registration-4.0.24/test/sw_mgmt_spec.rb 2018-03-13
14:04:41.000000000 +0100
@@ -106,6 +106,12 @@
end
describe ".base_product_to_register" do
+ it "returns nil if not able to find a product" do
+ expect(subject).to receive(:find_base_product).and_return(nil)
+
+ expect(subject.base_product_to_register).to eq(nil)
+ end
+
it "returns base product base version and release_type" do
expect(subject).to(receive(:find_base_product)
.and_return("name" => "SLES", "arch" => "x86_64",
