Hello community, here is the log from the commit of package gtg for openSUSE:Factory checked in at 2018-03-22 12:04:12 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gtg (Old) and /work/SRC/openSUSE:Factory/.gtg.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gtg" Thu Mar 22 12:04:12 2018 rev:28 rq:589157 version:0.3.1 Changes: -------- --- /work/SRC/openSUSE:Factory/gtg/gtg.changes 2015-05-18 22:31:44.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.gtg.new/gtg.changes 2018-03-22 12:10:09.474832731 +0100 @@ -1,0 +2,7 @@ +Sun Mar 18 23:36:55 UTC 2018 - [email protected] + +- Add gtg-fix-pynotify-crash.patch and python-notify Requires to + fix a crashing due to the lack of installed python-notify + (lp#1264846). + +------------------------------------------------------------------- New: ---- gtg-fix-pynotify-crash.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gtg.spec ++++++ --- /var/tmp/diff_new_pack.oRX8he/_old 2018-03-22 12:10:11.358765205 +0100 +++ /var/tmp/diff_new_pack.oRX8he/_new 2018-03-22 12:10:11.366764918 +0100 @@ -25,6 +25,8 @@ Url: http://gtgnome.net/ Source0: http://launchpad.net/gtg/trunk/%{version}/+download/%{name}-%{version}.tar.gz Source1: gtg.appdata.xml +# PATCH-FIX-UPSTREAM gtg-fix-pynotify-crash.patch [email protected] -- Fix crashing due to the lack of python-notify installation (lp#1264846). +Patch0: gtg-fix-pynotify-crash.patch BuildRequires: dbus-1 # dbus-1 is only required for file ownerships BuildRequires: fdupes @@ -37,6 +39,7 @@ Requires: python-gtk Requires: python-liblarch >= 2.1 Requires: python-liblarch_gtk >= 2.1 +Requires: python-notify Requires: python-xdg Recommends: %{name}-lang BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -55,6 +58,7 @@ %lang_package %prep %setup -q +%patch0 -p1 %build %{__python} setup.py build ++++++ gtg-fix-pynotify-crash.patch ++++++ Fix for lp#1264846 -- A function was registered with atexit which executed pynotify.uninit() without checking whether the user had pynotify installed or not. Since pynotify.init() was called everytime a notification had to be sent, I've added uninit() in the same function. Index: b/GTG/plugins/bugzilla/notification.py =================================================================== --- a/GTG/plugins/bugzilla/notification.py +++ b/GTG/plugins/bugzilla/notification.py @@ -4,7 +4,6 @@ Notification is used to show messages to GTG users. ''' -import atexit import subprocess __all__ = ("send_notification", ) @@ -24,6 +23,7 @@ def _notify_via_pynotify(title, message) # Keep quiet here when notification service is not avialable currently # sometime. For example, if user is using LXDE, no notifyd by default. pass + pynotify.uninit() def _notify_via_notify_send(title, message): @@ -57,8 +57,3 @@ def send_notification(title, message): if _notify_handler is not None: _notify_handler(title, message) - - [email protected] -def uinit_pynotify(): - pynotify.uninit()
