Hello community, here is the log from the commit of package autofs for openSUSE:Factory checked in at 2018-05-23 16:04:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/autofs (Old) and /work/SRC/openSUSE:Factory/.autofs.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "autofs" Wed May 23 16:04:53 2018 rev:117 rq:608997 version:5.1.3 Changes: -------- --- /work/SRC/openSUSE:Factory/autofs/autofs.changes 2018-03-12 12:10:55.137190962 +0100 +++ /work/SRC/openSUSE:Factory/.autofs.new/autofs.changes 2018-05-23 16:04:56.343130796 +0200 @@ -1,0 +2,6 @@ +Wed May 16 00:55:57 UTC 2018 - [email protected] + +- 0003-autofs-5.1.4-fix-fd-leak-in-rpc_do_create_client.patch + Fix filedescriptor leak (bsc#1093436) + +------------------------------------------------------------------- New: ---- 0003-autofs-5.1.4-fix-fd-leak-in-rpc_do_create_client.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ autofs.spec ++++++ --- /var/tmp/diff_new_pack.ZX8r0C/_old 2018-05-23 16:04:57.463089766 +0200 +++ /var/tmp/diff_new_pack.ZX8r0C/_new 2018-05-23 16:04:57.467089620 +0200 @@ -105,6 +105,7 @@ Patch108: autofs-5-1-3-check-map-instances-for-staleness-on-map-update.patch Patch109: 0001-use_hostname_for_mounts-shouldn-t-prevent-selection-.patch Patch110: 0002-Fix-monotonic_elapsed.patch +Patch111: 0003-autofs-5.1.4-fix-fd-leak-in-rpc_do_create_client.patch Requires(pre): %fillup_prereq Requires(pre): aaa_base %if %{with_systemd} @@ -136,6 +137,7 @@ %patch108 -p1 %patch109 -p1 %patch110 -p1 +%patch111 -p1 %build autoreconf -fiv ++++++ 0003-autofs-5.1.4-fix-fd-leak-in-rpc_do_create_client.patch ++++++ >From 3fd936200694c7b323b1721bf2b08f1d48c868c8 Mon Sep 17 00:00:00 2001 From: Ian Kent <[email protected]> Date: Fri, 11 May 2018 16:38:37 +0800 Subject: [PATCH] autofs-5.1.4 - fix fd leak in rpc_do_create_client() Commit 94f87e203a (fix create_client() RPC client handling) fixed possible use of an invalid RPC client handle but the change neglected to account of a check in rpc_do_create_client() that would open a new file descriptor without checking if the passed if descriptor was already opened. Signed-off-by: Ian Kent <[email protected]> --- CHANGELOG | 1 + lib/rpc_subs.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) --- a/CHANGELOG +++ b/CHANGELOG @@ -180,6 +180,7 @@ - link daemon with pthread library (Debian patch). - manpage corrections (Debian patch). - fix manpages hyphenation (Debian patch). +- fix fd leak in rpc_do_create_client(). 04/06/2014 autofs-5.1.0 ======================= --- a/lib/rpc_subs.c +++ b/lib/rpc_subs.c @@ -182,7 +182,7 @@ static int rpc_do_create_client(struct s in4_laddr.sin_addr.s_addr = htonl(INADDR_ANY); slen = sizeof(struct sockaddr_in); - if (!info->client) { + if (!info->client && *fd == RPC_ANYSOCK) { struct sockaddr *laddr; *fd = open_sock(addr->sa_family, type, proto); @@ -295,7 +295,7 @@ static int rpc_do_create_client(struct s * it would bind to a reserved port, which has been shown to * exhaust the reserved port range in some situations. */ - if (!info->client) { + if (!info->client && *fd == RPC_ANYSOCK) { *fd = open_sock(addr->sa_family, type, proto); if (*fd < 0) { ret = -errno;
